63974 2011-07-05 21:25:41 -0700 DFG JIT virtual call implementation is inefficient 2011-07-05 23:36:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 fpizlo webkit-unassigned webkit.review.bot oldest_to_newest 432613 0 fpizlo 2011-07-05 21:25:41 -0700 When making a virtual call, only one check is necessary to see if the function needs to be compiled. Currently, the code does two checks (first, if it's a host, and second, if it needs to be compiled). The old JIT folded both checks into a query on the number of parameters (which would be negative if the function was neither a host function nor was compiled). The DFG JIT should have the same optimization. 432617 1 99790 fpizlo 2011-07-05 21:52:09 -0700 Created attachment 99790 the patch 432640 2 99790 webkit.review.bot 2011-07-05 23:35:56 -0700 Comment on attachment 99790 the patch Clearing flags on attachment: 99790 Committed r90437: <http://trac.webkit.org/changeset/90437> 432641 3 webkit.review.bot 2011-07-05 23:36:00 -0700 All reviewed patches have been landed. Closing bug. 99790 2011-07-05 21:52:09 -0700 2011-07-05 23:35:56 -0700 the patch fastercall_patch_1.diff text/plain 6888 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTA0MzQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTEtMDctMDUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgSklUIHZpcnR1YWwgY2FsbCBpbXBsZW1lbnRhdGlvbiBpcyBpbmVmZmljaWVudC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzOTc0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHT3BlcmF0 aW9ucy5jcHA6CisgICAgICAgICogcnVudGltZS9FeGVjdXRhYmxlLmg6CisgICAgICAgIChKU0M6 OkV4ZWN1dGFibGVCYXNlOjpnZW5lcmF0ZWRKSVRDb2RlRm9yQ2FsbFdpdGhBcml0eUNoZWNrKToK KyAgICAgICAgKEpTQzo6RXhlY3V0YWJsZUJhc2U6OmdlbmVyYXRlZEpJVENvZGVGb3JDb25zdHJ1 Y3RXaXRoQXJpdHlDaGVjayk6CisgICAgICAgIChKU0M6OkV4ZWN1dGFibGVCYXNlOjpnZW5lcmF0 ZWRKSVRDb2RlV2l0aEFyaXR5Q2hlY2tGb3IpOgorICAgICAgICAoSlNDOjpFeGVjdXRhYmxlQmFz ZTo6aGFzSklUQ29kZUZvckNhbGwpOgorICAgICAgICAoSlNDOjpFeGVjdXRhYmxlQmFzZTo6aGFz SklUQ29kZUZvckNvbnN0cnVjdCk6CisgICAgICAgIChKU0M6OkV4ZWN1dGFibGVCYXNlOjpoYXNK SVRDb2RlRm9yKToKKyAgICAgICAgKiBydW50aW1lL0pTRnVuY3Rpb24uaDoKKyAgICAgICAgKEpT Qzo6SlNGdW5jdGlvbjo6c2NvcGVVbmNoZWNrZWQpOgorCiAyMDExLTA3LTA1ICBPbGl2ZXIgSHVu dCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgRm9yY2UgaW5saW5pbmcgb2Ygc2ltcGxl IGZ1bmN0aW9ucyB0aGF0IHNob3cgdXAgYXMgbm90IGJlaW5nIGlubGluZWQKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcAkocmV2aXNpb24gOTA0MjQp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC00ODgsMjIgKzQ4OCwyMSBAQCB2b2lkKiBvcGVyYXRpb25WaXJ0dWFsQ2FsbChF eGVjU3RhdGUqIGV4CiAgICAgSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhID0gJmV4ZWMtPmdsb2Jh bERhdGEoKTsKICAgICBKU1ZhbHVlIGNhbGxlZUFzVmFsdWUgPSBleGVjQ2FsbGVlLT5jYWxsZWVB c1ZhbHVlKCk7CiAgICAgSlNDZWxsKiBjYWxsZWVBc0Z1bmN0aW9uQ2VsbCA9IGdldEpTRnVuY3Rp b24oKmdsb2JhbERhdGEsIGNhbGxlZUFzVmFsdWUpOwotICAgIGlmICghY2FsbGVlQXNGdW5jdGlv bkNlbGwpCisgICAgaWYgKFVOTElLRUxZKCFjYWxsZWVBc0Z1bmN0aW9uQ2VsbCkpCiAgICAgICAg IHJldHVybiBoYW5kbGVIb3N0Q2FsbChleGVjQ2FsbGVlLCBjYWxsZWVBc1ZhbHVlKTsKICAgICAK ICAgICBKU0Z1bmN0aW9uKiBmdW5jdGlvbiA9IGFzRnVuY3Rpb24oY2FsbGVlQXNGdW5jdGlvbkNl bGwpOwogICAgIEV4ZWN1dGFibGVCYXNlKiBleGVjdXRhYmxlID0gZnVuY3Rpb24tPmV4ZWN1dGFi bGUoKTsKLSAgICBpZiAoZXhlY3V0YWJsZS0+aXNIb3N0RnVuY3Rpb24oKSkKLSAgICAgICAgcmV0 dXJuIGV4ZWN1dGFibGUtPmdlbmVyYXRlZEpJVENvZGVGb3JDYWxsKCkuYWRkcmVzc0ZvckNhbGwo KS5leGVjdXRhYmxlQWRkcmVzcygpOwotCi0gICAgRnVuY3Rpb25FeGVjdXRhYmxlKiBmdW5jdGlv bkV4ZWN1dGFibGUgPSBzdGF0aWNfY2FzdDxGdW5jdGlvbkV4ZWN1dGFibGUqPihleGVjdXRhYmxl KTsKLSAgICBKU09iamVjdCogZXJyb3IgPSBmdW5jdGlvbkV4ZWN1dGFibGUtPmNvbXBpbGVGb3JD YWxsKGV4ZWMsIGZ1bmN0aW9uLT5zY29wZSgpKTsKLSAgICBpZiAoZXJyb3IpIHsKLSAgICAgICAg ZXhlYy0+Z2xvYmFsRGF0YSgpLmV4Y2VwdGlvbiA9IGVycm9yOwotICAgICAgICByZXR1cm4gMDsK KyAgICBpZiAoVU5MSUtFTFkoIWV4ZWN1dGFibGUtPmhhc0pJVENvZGVGb3JDYWxsKCkpKSB7Cisg ICAgICAgIEZ1bmN0aW9uRXhlY3V0YWJsZSogZnVuY3Rpb25FeGVjdXRhYmxlID0gc3RhdGljX2Nh c3Q8RnVuY3Rpb25FeGVjdXRhYmxlKj4oZXhlY3V0YWJsZSk7CisgICAgICAgIEpTT2JqZWN0KiBl cnJvciA9IGZ1bmN0aW9uRXhlY3V0YWJsZS0+Y29tcGlsZUZvckNhbGwoZXhlYywgZnVuY3Rpb24t PnNjb3BlKCkpOworICAgICAgICBpZiAoZXJyb3IpIHsKKyAgICAgICAgICAgIGV4ZWMtPmdsb2Jh bERhdGEoKS5leGNlcHRpb24gPSBlcnJvcjsKKyAgICAgICAgICAgIHJldHVybiAwOworICAgICAg ICB9CiAgICAgfQotICAgIGV4ZWNDYWxsZWUtPnNldFNjb3BlQ2hhaW4oZnVuY3Rpb24tPnNjb3Bl KCkpOwotICAgIHJldHVybiBmdW5jdGlvbkV4ZWN1dGFibGUtPmdlbmVyYXRlZEpJVENvZGVGb3JD YWxsV2l0aEFyaXR5Q2hlY2soKS5leGVjdXRhYmxlQWRkcmVzcygpOworICAgIGV4ZWNDYWxsZWUt PnNldFNjb3BlQ2hhaW4oZnVuY3Rpb24tPnNjb3BlVW5jaGVja2VkKCkpOworICAgIHJldHVybiBl eGVjdXRhYmxlLT5nZW5lcmF0ZWRKSVRDb2RlRm9yQ2FsbFdpdGhBcml0eUNoZWNrKCkuZXhlY3V0 YWJsZUFkZHJlc3MoKTsKIH0KIAogRW5jb2RlZEpTVmFsdWUgb3BlcmF0aW9uSW5zdGFuY2VPZihF eGVjU3RhdGUqIGV4ZWMsIEVuY29kZWRKU1ZhbHVlIGVuY29kZWRWYWx1ZSwgRW5jb2RlZEpTVmFs dWUgZW5jb2RlZEJhc2UsIEVuY29kZWRKU1ZhbHVlIGVuY29kZWRQcm90b3R5cGUpCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGVjdXRhYmxlLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5oCShyZXZpc2lvbiA5MDQy NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTAyLDYgKzEwMiw0NiBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAg IHJldHVybiBnZW5lcmF0ZWRKSVRDb2RlRm9yQ29uc3RydWN0KCk7CiAgICAgICAgIH0KIAorICAg ICAgICBNYWNyb0Fzc2VtYmxlckNvZGVQdHIgZ2VuZXJhdGVkSklUQ29kZUZvckNhbGxXaXRoQXJp dHlDaGVjaygpCisgICAgICAgIHsKKyAgICAgICAgICAgIEFTU0VSVChtX2ppdENvZGVGb3JDYWxs KTsKKyAgICAgICAgICAgIEFTU0VSVChtX2ppdENvZGVGb3JDYWxsV2l0aEFyaXR5Q2hlY2spOwor ICAgICAgICAgICAgcmV0dXJuIG1faml0Q29kZUZvckNhbGxXaXRoQXJpdHlDaGVjazsKKyAgICAg ICAgfQorCisgICAgICAgIE1hY3JvQXNzZW1ibGVyQ29kZVB0ciBnZW5lcmF0ZWRKSVRDb2RlRm9y Q29uc3RydWN0V2l0aEFyaXR5Q2hlY2soKQorICAgICAgICB7CisgICAgICAgICAgICBBU1NFUlQo bV9qaXRDb2RlRm9yQ29uc3RydWN0KTsKKyAgICAgICAgICAgIEFTU0VSVChtX2ppdENvZGVGb3JD b25zdHJ1Y3RXaXRoQXJpdHlDaGVjayk7CisgICAgICAgICAgICByZXR1cm4gbV9qaXRDb2RlRm9y Q29uc3RydWN0V2l0aEFyaXR5Q2hlY2s7CisgICAgICAgIH0KKyAgICAgICAgCisgICAgICAgIE1h Y3JvQXNzZW1ibGVyQ29kZVB0ciBnZW5lcmF0ZWRKSVRDb2RlV2l0aEFyaXR5Q2hlY2tGb3IoQ29k ZVNwZWNpYWxpemF0aW9uS2luZCBraW5kKQorICAgICAgICB7CisgICAgICAgICAgICBpZiAoa2lu ZCA9PSBDb2RlRm9yQ2FsbCkKKyAgICAgICAgICAgICAgICByZXR1cm4gZ2VuZXJhdGVkSklUQ29k ZUZvckNhbGxXaXRoQXJpdHlDaGVjaygpOworICAgICAgICAgICAgQVNTRVJUKGtpbmQgPT0gQ29k ZUZvckNvbnN0cnVjdCk7CisgICAgICAgICAgICByZXR1cm4gZ2VuZXJhdGVkSklUQ29kZUZvckNv bnN0cnVjdFdpdGhBcml0eUNoZWNrKCk7CisgICAgICAgIH0KKyAgICAgICAgCisgICAgICAgIGJv b2wgaGFzSklUQ29kZUZvckNhbGwoKSBjb25zdAorICAgICAgICB7CisgICAgICAgICAgICByZXR1 cm4gbV9udW1QYXJhbWV0ZXJzRm9yQ2FsbCA+PSAwOworICAgICAgICB9CisgICAgICAgIAorICAg ICAgICBib29sIGhhc0pJVENvZGVGb3JDb25zdHJ1Y3QoKSBjb25zdAorICAgICAgICB7CisgICAg ICAgICAgICByZXR1cm4gbV9udW1QYXJhbWV0ZXJzRm9yQ29uc3RydWN0ID49IDA7CisgICAgICAg IH0KKyAgICAgICAgCisgICAgICAgIGJvb2wgaGFzSklUQ29kZUZvcihDb2RlU3BlY2lhbGl6YXRp b25LaW5kIGtpbmQpIGNvbnN0CisgICAgICAgIHsKKyAgICAgICAgICAgIGlmIChraW5kID09IENv ZGVGb3JDYWxsKQorICAgICAgICAgICAgICAgIHJldHVybiBoYXNKSVRDb2RlRm9yQ2FsbCgpOwor ICAgICAgICAgICAgQVNTRVJUKGtpbmQgPT0gQ29kZUZvckNvbnN0cnVjdCk7CisgICAgICAgICAg ICByZXR1cm4gaGFzSklUQ29kZUZvckNvbnN0cnVjdCgpOworICAgICAgICB9CisKICAgICAgICAg dm9pZCBjbGVhckV4ZWN1dGFibGVDb2RlKCkKICAgICAgICAgewogICAgICAgICAgICAgbV9qaXRD b2RlRm9yQ2FsbC5jbGVhcigpOwpAQCAtNDU1LDMxICs0OTUsNiBAQCBuYW1lc3BhY2UgSlNDIHsK ICAgICAgICAgT3duUHRyPEZ1bmN0aW9uQ29kZUJsb2NrPiBtX2NvZGVCbG9ja0ZvckNvbnN0cnVj dDsKICAgICAgICAgSWRlbnRpZmllciBtX25hbWU7CiAgICAgICAgIFNoYXJlZFN5bWJvbFRhYmxl KiBtX3N5bWJvbFRhYmxlOwotCi0jaWYgRU5BQkxFKEpJVCkKLSAgICBwdWJsaWM6Ci0gICAgICAg IE1hY3JvQXNzZW1ibGVyQ29kZVB0ciBnZW5lcmF0ZWRKSVRDb2RlRm9yQ2FsbFdpdGhBcml0eUNo ZWNrKCkKLSAgICAgICAgewotICAgICAgICAgICAgQVNTRVJUKG1faml0Q29kZUZvckNhbGwpOwot ICAgICAgICAgICAgQVNTRVJUKG1faml0Q29kZUZvckNhbGxXaXRoQXJpdHlDaGVjayk7Ci0gICAg ICAgICAgICByZXR1cm4gbV9qaXRDb2RlRm9yQ2FsbFdpdGhBcml0eUNoZWNrOwotICAgICAgICB9 Ci0KLSAgICAgICAgTWFjcm9Bc3NlbWJsZXJDb2RlUHRyIGdlbmVyYXRlZEpJVENvZGVGb3JDb25z dHJ1Y3RXaXRoQXJpdHlDaGVjaygpCi0gICAgICAgIHsKLSAgICAgICAgICAgIEFTU0VSVChtX2pp dENvZGVGb3JDb25zdHJ1Y3QpOwotICAgICAgICAgICAgQVNTRVJUKG1faml0Q29kZUZvckNvbnN0 cnVjdFdpdGhBcml0eUNoZWNrKTsKLSAgICAgICAgICAgIHJldHVybiBtX2ppdENvZGVGb3JDb25z dHJ1Y3RXaXRoQXJpdHlDaGVjazsKLSAgICAgICAgfQotICAgICAgICAKLSAgICAgICAgTWFjcm9B c3NlbWJsZXJDb2RlUHRyIGdlbmVyYXRlZEpJVENvZGVXaXRoQXJpdHlDaGVja0ZvcihDb2RlU3Bl Y2lhbGl6YXRpb25LaW5kIGtpbmQpCi0gICAgICAgIHsKLSAgICAgICAgICAgIGlmIChraW5kID09 IENvZGVGb3JDYWxsKQotICAgICAgICAgICAgICAgIHJldHVybiBnZW5lcmF0ZWRKSVRDb2RlRm9y Q2FsbFdpdGhBcml0eUNoZWNrKCk7Ci0gICAgICAgICAgICBBU1NFUlQoa2luZCA9PSBDb2RlRm9y Q29uc3RydWN0KTsKLSAgICAgICAgICAgIHJldHVybiBnZW5lcmF0ZWRKSVRDb2RlRm9yQ29uc3Ry dWN0V2l0aEFyaXR5Q2hlY2soKTsKLSAgICAgICAgfQotI2VuZGlmCiAgICAgfTsKIAogICAgIGlu bGluZSBGdW5jdGlvbkV4ZWN1dGFibGUqIEpTRnVuY3Rpb246OmpzRXhlY3V0YWJsZSgpIGNvbnN0 CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0Z1bmN0aW9uLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNGdW5jdGlvbi5oCShyZXZp c2lvbiA5MDQyNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTRnVuY3Rpb24u aAkod29ya2luZyBjb3B5KQpAQCAtNjMsNiArNjMsMTUgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAg ICAgICAgICBBU1NFUlQoIWlzSG9zdEZ1bmN0aW9uTm9uSW5saW5lKCkpOwogICAgICAgICAgICAg cmV0dXJuIG1fc2NvcGVDaGFpbi5nZXQoKTsKICAgICAgICAgfQorICAgICAgICAvLyBUaGlzIG1l dGhvZCBtYXkgYmUgY2FsbGVkIGZvciBob3N0IGZ1bmN0aW5zLCBpbiB3aGljaCBjYXNlIGl0Cisg ICAgICAgIC8vIHdpbGwgcmV0dXJuIGFuIGFyYml0cmFyeSB2YWx1ZS4gVGhpcyBzaG91bGQgb25s eSBiZSB1c2VkIGZvcgorICAgICAgICAvLyBvcHRpbWl6ZWQgcGF0aHMgaW4gd2hpY2ggdGhlIHJl dHVybiB2YWx1ZSBkb2VzIG5vdCBtYXR0ZXIgZm9yCisgICAgICAgIC8vIGhvc3QgZnVuY3Rpb25z LCBhbmQgY2hlY2tpbmcgd2hldGhlciB0aGUgZnVuY3Rpb24gaXMgYSBob3N0CisgICAgICAgIC8v IGZ1bmN0aW9uIGlzIGRlZW1lZCB0b28gZXhwZW5zaXZlLgorICAgICAgICBTY29wZUNoYWluTm9k ZSogc2NvcGVVbmNoZWNrZWQoKQorICAgICAgICB7CisgICAgICAgICAgICByZXR1cm4gbV9zY29w ZUNoYWluLmdldCgpOworICAgICAgICB9CiAgICAgICAgIHZvaWQgc2V0U2NvcGUoSlNHbG9iYWxE YXRhJiBnbG9iYWxEYXRhLCBTY29wZUNoYWluTm9kZSogc2NvcGVDaGFpbikKICAgICAgICAgewog ICAgICAgICAgICAgQVNTRVJUKCFpc0hvc3RGdW5jdGlvbk5vbklubGluZSgpKTsK