63970 2011-07-05 20:31:39 -0700 new-run-webkit-tests doesn't understand --qt or --gtk 2011-10-27 17:21:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64491 1 webkit.review.bot webkit.review.bot abarth dpranke eric mrobinson ojan ossy oldest_to_newest 432587 0 webkit.review.bot 2011-07-05 20:31:39 -0700 new-run-webkit-tests doesn't understand --qt or --gtk Requested by eseidel2 on #webkit. 432588 1 eric 2011-07-05 20:36:33 -0700 I've committed a workaround in run-webkit-tests for now: http://trac.webkit.org/changeset/90431 489422 2 eric 2011-10-24 10:35:39 -0700 Moving this to the polish stage. This has not stopped Qt or Gtk from moving to NRWT. 491983 3 112760 eric 2011-10-27 14:53:47 -0700 Created attachment 112760 Patch 491985 4 eric 2011-10-27 14:54:11 -0700 Very easy. :) Clearly I need to spend some time cleaning up our options parsing code. 492003 5 112760 ojan 2011-10-27 15:09:36 -0700 Comment on attachment 112760 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112760&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:312 > optparse.make_option("--full-results-html", action="store_true", > default=False, > - help="Show all failures in results.html, rather than only " > - "regressions"), > + help="Show all failures in results.html, rather than only regressions"), Not related to this patch, but I *think* this is a misnomer now. I think all this does is that it decides whether we open the results.html page in cases where all the failures are expected (e.g. they're all listed in test_expectations). I guess what it should do is open the results.html page with the show expected failures checkbox checked. 492116 6 112760 webkit.review.bot 2011-10-27 17:21:25 -0700 Comment on attachment 112760 Patch Clearing flags on attachment: 112760 Committed r98665: <http://trac.webkit.org/changeset/98665> 492117 7 webkit.review.bot 2011-10-27 17:21:30 -0700 All reviewed patches have been landed. Closing bug. 112760 2011-10-27 14:53:47 -0700 2011-10-27 17:21:24 -0700 Patch bug-63970-20111027145346.patch text/plain 5900 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTg2MzkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiODgwYzZhMzJlZWE3ZTkxZWQ2NDRiODNmMjQ1NDg4NmVm ZDljYWFjLi40MzVkNzQzNDk2NTQ4NWM4Yzg3Y2E2MDM3ZTVmNTNmNDlhZDRkZDU5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTEtMTAtMjcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAg IG5ldy1ydW4td2Via2l0LXRlc3RzIGRvZXNuJ3QgdW5kZXJzdGFuZCAtLXF0IG9yIC0tZ3RrCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mzk3MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBzdXBwb3J0 IGZvciAtLXF0IGFuZCAtLWd0ayB0byBOUldULgorICAgICAgICBJIGFsc28gcmVtb3ZlZCBzb21l IGluY29ycmVjdCBjb21tZW50cyBpbiB0aGUgb3B0aW9uIHBhcnNpbmcKKyAgICAgICAgY29kZSAo b3B0aW9ucyB3aGljaCB3ZSBhbHJlYWR5IGltcGxlbWVudCwgYnV0IHNhaWQgd2UgZGlkbid0KQor ICAgICAgICBhcyB3ZWxsIGFzIG1vdmVkIC0tcGxhdGZvcm0gcGFyc2luZyBvdXQgb2YgdGhlICJy ZXN1bHRzX29wdGlvbnMiCisgICAgICAgIHNlY3Rpb24gaW50byB0aGUgdG9wIGNvbmZpZ3VyYXRp b24gc2VjdGlvbi4KKworICAgICAgICBOb3cgcnVuLXdlYmtpdC10ZXN0cyBubyBsb25nZXIgbmVl ZHMgTlJXVC1zcGVjaWZpYyBjb2RlIGZvciBwYXNzaW5nCisgICAgICAgIC0tcGxhdGZvcm09cXQs IGV0Yy4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0czoKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5OgorCisyMDEx LTEwLTI3ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKwogICAgICAgICBSRUdSRVNT SU9OIChOUldUKTogYnVpbGQud2Via2l0Lm9yZyBkb2Vzbid0IHNob3cgdGhlIHRvdGFsIG51bWJl ciBvZiBsZWFrcyBmb3VuZCBkdXJpbmcgYSB0ZXN0IHJ1biBvbiB0aGUgTGVha3MgYm90CiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjIyNwogCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1 bi13ZWJraXQtdGVzdHMKaW5kZXggMjBiYTIzYjk2MjdkZDhjN2JjYWQ5YjU5ZDU0NjJiMTBlOGU5 MWZkMy4uMDY4Y2E5YTI3N2UyYTJkNDgxMjMxNjg1OTEzYjU3MTA3ZDVjYWRjZCAxMDA3NTUKLS0t IGEvVG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVu LXdlYmtpdC10ZXN0cwpAQCAtODksMjQgKzg5LDE1IEBAIGlmICh1c2VOZXdSdW5XZWJLaXRUZXN0 cygpKSB7CiAgICAgaWYgKHJ1bm5pbmdPbkJ1aWxkQm90KCkpIHsKICAgICAgICAgcHVzaChAQVJH ViwgIi0tdmVyYm9zZSIpOwogICAgIH0KK30KIAotICAgICMgRklYTUU6IFdlIG5lZWQgYSBjbGVh bmVyIHdheSB0byBkbyAtLXBsYXRmb3JtIGhhbmRsaW5nLgotICAgICMgd2Via2l0ZGlycy5wbSBz dHJpcHMgLS1xdCBhbmQgLS1ndGsgZnJvbSBAQVJHViB3aGVuIHdlIGNhbGwgaXNRdC9pc0d0ay4K LSAgICAjIFVuZm9ydHVuYXRlbHkgbmV3LXJ1bi13ZWJraXQtdGVzdHMgd291bGRuJ3QgdW5kZXJz dGFuZCAtLXF0Ly0tZ3RrIGlmIHdlIHBhc3NlZCBpdCB0byBpdCBhbnl3YXksCi0gICAgIyBzbyB3 ZSBoYXZlIHRvIGNvbnZlcnQgaXQgdG8gLS1wbGF0Zm9ybT1QT1JUIGVxdWl2YWxlbnRzLgotICAg ICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzOTcwCi0gICAgaWYg KGlzUXQoKSkgewotICAgICAgICBwdXNoKEBBUkdWLCAiLS1wbGF0Zm9ybT1xdCIpOwotICAgIH0g ZWxzaWYgKGlzR3RrKCkpIHsKLSAgICAgICAgcHVzaChAQVJHViwgIi0tcGxhdGZvcm09Z3RrIik7 Ci0gICAgfQotfSBlbHNlIHsKLSAgICAjIFdlIGhhdmUgdG8gYWRkIGJhY2sgYW55IC0tUE9SVCBh cmd1bWVudHMgd2hpY2ggbWF5IGhhdmUgYmVlbiByZW1vdmVkIGJ5IGlzUG9ydCgpIGNoZWNrcyBh Ym92ZS4KLSAgICBpZiAoaXNRdCgpKSB7Ci0gICAgICAgIHB1c2goQEFSR1YsICItLXF0Iik7Ci0g ICAgfSBlbHNpZiAoaXNHdGsoKSkgewotICAgICAgICBwdXNoKEBBUkdWLCAiLS1ndGsiKTsKLSAg ICB9CisjIEZJWE1FOiBXZSBuZWVkIGEgY2xlYW5lciB3YXkgdG8gZG8gLS1wbGF0Zm9ybSBoYW5k bGluZy4KKyMgd2Via2l0ZGlycy5wbSBzdHJpcHMgLS1xdCBhbmQgLS1ndGsgZnJvbSBAQVJHViB3 aGVuIHdlIGNhbGwgaXNRdC9pc0d0ay4KKyMgV2UgaGF2ZSB0byBhZGQgYmFjayBhbnkgLS1QT1JU IGFyZ3VtZW50cyB3aGljaCBtYXkgaGF2ZSBiZWVuIHJlbW92ZWQgYnkgaXNQb3J0KCkgY2hlY2tz IGFib3ZlLgoraWYgKGlzUXQoKSkgeworICAgIHB1c2goQEFSR1YsICItLXF0Iik7Cit9IGVsc2lm IChpc0d0aygpKSB7CisgICAgcHVzaChAQVJHViwgIi0tZ3RrIik7CiB9CiAKIG15ICRoYXJuZXNz UGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUocmVsYXRpdmVTY3JpcHRzRGlyKCksICRoYXJuZXNz TmFtZSk7CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9y dW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCAzODYwOGI2ZTQ0Yzk2OWNkZmVkNTMwZjlkZGI3NWVk M2Y0ODE1ZjdmLi5jMDQzODY5ODFjYWQ2ZGE2MjY0MDBjYjc1NTBjYTgzYTIwY2UzNTNkIDEwMDc1 NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rl c3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJr aXRfdGVzdHMucHkKQEAgLTE4OSw2ICsxODksOSBAQCBkZWYgcGFyc2VfYXJncyhhcmdzPU5vbmUp OgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdD0nUmVsZWFzZScsIGRlc3Q9ImNv bmZpZ3VyYXRpb24iLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBoZWxwPSdTZXQgdGhl IGNvbmZpZ3VyYXRpb24gdG8gUmVsZWFzZScpLAogICAgICAgICAjIG9sZC1ydW4td2Via2l0LXRl c3RzIGFsc28gYWNjZXB0cyAtYywgLS1jb25maWd1cmF0aW9uIENPTkZJR1VSQVRJT04uCisgICAg ICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXBsYXRmb3JtIiwgaGVscD0iT3ZlcnJpZGUgcG9y dC9wbGF0Zm9ybSBiZWluZyB0ZXN0ZWQgKGkuZS4gY2hyb21pdW0tbWFjKSIpLAorICAgICAgICBv cHRwYXJzZS5tYWtlX29wdGlvbignLS1xdCcsIGFjdGlvbj0nc3RvcmVfY29uc3QnLCBjb25zdD0n cXQnLCBkZXN0PSJwbGF0Zm9ybSIsIGhlbHA9J0FsaWFzIGZvciAtLXBsYXRmb3JtPXF0JyksCisg ICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCctLWd0aycsIGFjdGlvbj0nc3RvcmVfY29uc3Qn LCBjb25zdD0nZ3RrJywgZGVzdD0icGxhdGZvcm0iLCBoZWxwPSdBbGlhcyBmb3IgLS1wbGF0Zm9y bT1ndGsnKSwKICAgICBdCiAKICAgICBwcmludF9vcHRpb25zID0gcHJpbnRpbmcucHJpbnRfb3B0 aW9ucygpCkBAIC0yNjMsOCArMjY2LDYgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25lKToKICAg ICBdCiAKICAgICByZXN1bHRzX29wdGlvbnMgPSBbCi0gICAgICAgICMgTkVFRCBmb3IgYm90czog LS11c2UtcmVtb3RlLWxpbmtzLXRvLXRlc3RzIExpbmsgdG8gdGVzdCBmaWxlcwotICAgICAgICAj IHdpdGhpbiB0aGUgU1ZOIHJlcG9zaXRvcnkgaW4gdGhlIHJlc3VsdHMuCiAgICAgICAgIG9wdHBh cnNlLm1ha2Vfb3B0aW9uKCItcCIsICItLXBpeGVsLXRlc3RzIiwgYWN0aW9uPSJzdG9yZV90cnVl IiwKICAgICAgICAgICAgIGRlc3Q9InBpeGVsX3Rlc3RzIiwgaGVscD0iRW5hYmxlIHBpeGVsLXRv LXBpeGVsIFBORyBjb21wYXJpc29ucyIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigi LS1uby1waXhlbC10ZXN0cyIsIGFjdGlvbj0ic3RvcmVfZmFsc2UiLApAQCAtMzA0LDIzICszMDUs MTMgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25lKToKICAgICAgICAgICAgICAgICAgImFyZSBk b25lIiksCiAgICAgICAgICMgRklYTUU6IFdlIHNob3VsZCBoYXZlIGEgaGVscGVyIGZ1bmN0aW9u IHRvIGRvIHRoaXMgc29ydCBvZgogICAgICAgICAjIGRlcHJlY3RhdGVkIG1hcHBpbmcgYW5kIGF1 dG9tYXRpY2FsbHkgbG9nLCBldGMuCi0gICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLW5v c2hvdy1yZXN1bHRzIiwgYWN0aW9uPSJzdG9yZV9mYWxzZSIsCi0gICAgICAgICAgICBkZXN0PSJz aG93X3Jlc3VsdHMiLAotICAgICAgICAgICAgaGVscD0iRGVwcmVjYXRlZCwgc2FtZSBhcyAtLW5v LXNob3ctcmVzdWx0cy4iKSwKLSAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tbm8tbGF1 bmNoLXNhZmFyaSIsIGFjdGlvbj0ic3RvcmVfZmFsc2UiLAotICAgICAgICAgICAgZGVzdD0ic2hv d19yZXN1bHRzIiwKLSAgICAgICAgICAgIGhlbHA9Im9sZC1ydW4td2Via2l0LXRlc3RzIGNvbXBh dCwgc2FtZSBhcyAtLW5vc2hvdy1yZXN1bHRzLiIpLAotICAgICAgICAjIG9sZC1ydW4td2Via2l0 LXRlc3RzOgotICAgICAgICAjIC0tW25vLV1sYXVuY2gtc2FmYXJpICAgIExhdW5jaCAob3IgZG8g bm90IGxhdW5jaCkgU2FmYXJpIHRvIGRpc3BsYXkKLSAgICAgICAgIyAgICAgICAgICAgICAgICAg ICAgICAgICB0ZXN0IHJlc3VsdHMgKGRlZmF1bHQ6IGxhdW5jaCkKKyAgICAgICAgb3B0cGFyc2Uu bWFrZV9vcHRpb24oIi0tbm9zaG93LXJlc3VsdHMiLCBhY3Rpb249InN0b3JlX2ZhbHNlIiwgZGVz dD0ic2hvd19yZXN1bHRzIiwgaGVscD0iRGVwcmVjYXRlZCwgc2FtZSBhcyAtLW5vLXNob3ctcmVz dWx0cy4iKSwKKyAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tbm8tbGF1bmNoLXNhZmFy aSIsIGFjdGlvbj0ic3RvcmVfZmFsc2UiLCBkZXN0PSJzaG93X3Jlc3VsdHMiLCBoZWxwPSJEZXBy ZWNhdGVkLCBzYW1lIGFzIC0tbm8tc2hvdy1yZXN1bHRzLiIpLAogICAgICAgICBvcHRwYXJzZS5t YWtlX29wdGlvbigiLS1mdWxsLXJlc3VsdHMtaHRtbCIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsCiAg ICAgICAgICAgICBkZWZhdWx0PUZhbHNlLAotICAgICAgICAgICAgaGVscD0iU2hvdyBhbGwgZmFp bHVyZXMgaW4gcmVzdWx0cy5odG1sLCByYXRoZXIgdGhhbiBvbmx5ICIKLSAgICAgICAgICAgICAg ICAgInJlZ3Jlc3Npb25zIiksCisgICAgICAgICAgICBoZWxwPSJTaG93IGFsbCBmYWlsdXJlcyBp biByZXN1bHRzLmh0bWwsIHJhdGhlciB0aGFuIG9ubHkgcmVncmVzc2lvbnMiKSwKICAgICAgICAg b3B0cGFyc2UubWFrZV9vcHRpb24oIi0tY2xvYmJlci1vbGQtcmVzdWx0cyIsIGFjdGlvbj0ic3Rv cmVfdHJ1ZSIsCiAgICAgICAgICAgICBkZWZhdWx0PUZhbHNlLCBoZWxwPSJDbG9iYmVycyB0ZXN0 IHJlc3VsdHMgZnJvbSBwcmV2aW91cyBydW5zLiIpLAotICAgICAgICBvcHRwYXJzZS5tYWtlX29w dGlvbigiLS1wbGF0Zm9ybSIsCi0gICAgICAgICAgICBoZWxwPSJPdmVycmlkZSB0aGUgcGxhdGZv cm0gZm9yIGV4cGVjdGVkIHJlc3VsdHMiKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24o Ii0tbm8tcmVjb3JkLXJlc3VsdHMiLCBhY3Rpb249InN0b3JlX2ZhbHNlIiwKICAgICAgICAgICAg IGRlZmF1bHQ9VHJ1ZSwgZGVzdD0icmVjb3JkX3Jlc3VsdHMiLAogICAgICAgICAgICAgaGVscD0i RG9uJ3QgcmVjb3JkIHRoZSByZXN1bHRzLiIpLAo=