63969 2011-07-05 20:02:50 -0700 Add first unit tests for garden-o-matic 2011-07-06 10:22:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dglazkov eric ojan tony oldest_to_newest 432577 0 abarth 2011-07-05 20:02:50 -0700 Add first unit tests for garden-o-matic 432579 1 99783 abarth 2011-07-05 20:03:37 -0700 Created attachment 99783 Patch 432580 2 99783 eric 2011-07-05 20:06:02 -0700 Comment on attachment 99783 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99783&action=review > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:2 > +<!DOCTYPE html> > +<html> Why not just run these as part of the layout tests? How are these goign to be run on the bots? 432581 3 abarth 2011-07-05 20:11:08 -0700 > Why not just run these as part of the layout tests? Are you saying that the code for garden-o-matic should be in the LayoutTest directory or that the LayoutTest directory should include scripts that reside in the Tools directory? Niether of those options is appealing. For the first one, garden-o-matic is a Tool, not a LayoutTests, so it should be in Tools directory. For the second one, we don't have any dependencies back from LayoutTests to Tools, and adding one would break at the downstream Chromium configuration and probably the downstream Apple configuration as well. > How are these goign to be run on the bots? Currently, they're not going to run on the bots. That sounds like a problem we should solve in the future if/when we have a problem keeping these tests green. 432582 4 99783 eric 2011-07-05 20:13:00 -0700 Comment on attachment 99783 Patch Tests which aren't run on the bots turn red. We've learned that lesson several times now. :) 432583 5 abarth 2011-07-05 20:15:29 -0700 Committed r90430: <http://trac.webkit.org/changeset/90430> 432863 6 tony 2011-07-06 10:22:30 -0700 FYI, the layout test results HTML file generated by NRWT are tested as part of the LayoutTests (in fast/harness/results.html). The test doesn't depend on Tools, but Tools does depend on it (NRWT copies results.html to the test output directory). 99783 2011-07-05 20:03:37 -0700 2011-07-05 20:13:00 -0700 Patch bug-63969-20110705200336.patch text/plain 5099 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkwNDI4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTcgQEAKKzIwMTEtMDctMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBBZGQgZmlyc3QgdW5pdCB0ZXN0cyBmb3IgZ2FyZGVuLW8tbWF0aWMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzOTY5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSd2ZSBhbHNvIHJlZm9ybWF0 ZWQgYmFzZS5qcyB0byBtYXRjaCBXZWJLaXQgc3R5bGUsIGFzIGRpc2N1c3NlZCBpbiB0aGUKKyAg ICAgICAgcHJldmlvdXMgYnVnLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3Nl cnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvYmFzZS5qczoKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9iYXNlX3VuaXR0ZXN0cy5q czogQWRkZWQuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9n YXJkZW5pbmdzZXJ2ZXIvcnVuLXVuaXR0ZXN0cy5odG1sOiBBZGRlZC4KKwogMjAxMS0wNy0wNSAg QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIGdhcmRlbi1vLW1hdGlj IHNob3VsZCB1bmRlcnN0YW5kIHdoaWNoIHRlc3RzIGhhdmUgdW5leHBlY3RlZCBmYWlsdXJlcwpJ bmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdz ZXJ2ZXIvYmFzZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv c2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9iYXNlLmpzCShyZXZpc2lvbiA5MDQyOCkKKysr IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVy L2Jhc2UuanMJKHdvcmtpbmcgY29weSkKQEAgLTEsMjcgKzEsMzQgQEAKIHZhciBiYXNlID0gYmFz ZSB8fCB7fTsKIAotKGZ1bmN0aW9uKCkgewotICBiYXNlLmpvaW5QYXRoID0gZnVuY3Rpb24ocGFy ZW50LCBjaGlsZCkgeworKGZ1bmN0aW9uKCl7CisKK2Jhc2Uuam9pblBhdGggPSBmdW5jdGlvbihw YXJlbnQsIGNoaWxkKQoreworICAgIGlmIChwYXJlbnQubGVuZ3RoID09IDApCisgICAgICAgIHJl dHVybiBjaGlsZDsKICAgICByZXR1cm4gcGFyZW50ICsgJy8nICsgY2hpbGQ7Ci0gIH0KK30KIAot ICBiYXNlLmZpbHRlclRyZWUgPSBmdW5jdGlvbih0cmVlLCBpc19sZWFmLCBwcmVkaWNhdGUpIHsK LSAgICB2YXIgZmlsdGVyZWRfdHJlZSA9IHt9OworYmFzZS5maWx0ZXJUcmVlID0gZnVuY3Rpb24o dHJlZSwgaXNMZWFmLCBwcmVkaWNhdGUpCit7CisgICAgdmFyIGZpbHRlcmVkVHJlZSA9IHt9Owog Ci0gICAgZnVuY3Rpb24gd2Fsa1N1YnRyZWUoc3VidHJlZSwgZGlyZWN0b3J5KSB7Ci0gICAgICBm b3IgKHZhciBjaGlsZF9uYW1lIGluIHN1YnRyZWUpIHsKLSAgICAgICAgdmFyIGNoaWxkID0gc3Vi dHJlZVtjaGlsZF9uYW1lXTsKLSAgICAgICAgdmFyIGNoaWxkX3BhdGggPSBiYXNlLmpvaW5QYXRo KGRpcmVjdG9yeSwgY2hpbGRfbmFtZSk7Ci0gICAgICAgIGlmIChpc19sZWFmKGNoaWxkKSkgewot ICAgICAgICAgIGlmIChwcmVkaWNhdGUoY2hpbGQpKQotICAgICAgICAgICAgZmlsdGVyZWRfdHJl ZVtjaGlsZF9wYXRoXSA9IGNoaWxkOwotICAgICAgICAgIGNvbnRpbnVlOworICAgIGZ1bmN0aW9u IHdhbGtTdWJ0cmVlKHN1YnRyZWUsIGRpcmVjdG9yeSkKKyAgICB7CisgICAgICAgIGZvciAodmFy IGNoaWxkTmFtZSBpbiBzdWJ0cmVlKSB7CisgICAgICAgICAgICB2YXIgY2hpbGQgPSBzdWJ0cmVl W2NoaWxkTmFtZV07CisgICAgICAgICAgICB2YXIgY2hpbGRQYXRoID0gYmFzZS5qb2luUGF0aChk aXJlY3RvcnksIGNoaWxkTmFtZSk7CisgICAgICAgICAgICBpZiAoaXNMZWFmKGNoaWxkKSkgewor ICAgICAgICAgICAgICAgIGlmIChwcmVkaWNhdGUoY2hpbGQpKQorICAgICAgICAgICAgICAgICAg ICBmaWx0ZXJlZFRyZWVbY2hpbGRQYXRoXSA9IGNoaWxkOworICAgICAgICAgICAgICAgIGNvbnRp bnVlOworICAgICAgICAgICAgfQorICAgICAgICAgICAgd2Fsa1N1YnRyZWUoY2hpbGQsIGNoaWxk UGF0aCk7CiAgICAgICAgIH0KLSAgICAgICAgd2Fsa1N1YnRyZWUoY2hpbGQsIGNoaWxkX3BhdGgp OwotICAgICAgfQogICAgIH0KIAogICAgIHdhbGtTdWJ0cmVlKHRyZWUsICcnKTsKLSAgICByZXR1 cm4gZmlsdGVyZWRfdHJlZTsKLSAgfQorICAgIHJldHVybiBmaWx0ZXJlZFRyZWU7Cit9CisKIH0p KCk7CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRl bmluZ3NlcnZlci9iYXNlX3VuaXR0ZXN0cy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9iYXNlX3VuaXR0ZXN0 cy5qcwkocmV2aXNpb24gMCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJz L2RhdGEvZ2FyZGVuaW5nc2VydmVyL2Jhc2VfdW5pdHRlc3RzLmpzCShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDU4IEBACittb2R1bGUoImJhc2UiKTsKKwordGVzdCgiam9pblBhdGgiLCAxLCBmdW5j dGlvbigpIHsKKyAgICB2YXIgdmFsdWUgPSBiYXNlLmpvaW5QYXRoKCJwYXRoL3RvIiwgInRlc3Qu aHRtbCIpOworICAgIGVxdWFscyh2YWx1ZSwgInBhdGgvdG8vdGVzdC5odG1sIik7Cit9KTsKKwor dGVzdCgiam9pblBhdGggd2l0aCBlbXB0eSBwYXJlbnQiLCAxLCBmdW5jdGlvbigpIHsKKyAgICB2 YXIgdmFsdWUgPSBiYXNlLmpvaW5QYXRoKCIiLCAidGVzdC5odG1sIik7CisgICAgZXF1YWxzKHZh bHVlLCAidGVzdC5odG1sIik7Cit9KTsKKwordGVzdCgiZmlsdGVyVHJlZSIsIDIsIGZ1bmN0aW9u KCkgeworICAgIHZhciB0cmVlID0geworICAgICAgICAncGF0aCc6IHsKKyAgICAgICAgICAgICd0 byc6IHsKKyAgICAgICAgICAgICAgICAndGVzdC5odG1sJzogeworICAgICAgICAgICAgICAgICAg ICAnYWN0dWFsJzogJ1BBU1MnLAorICAgICAgICAgICAgICAgICAgICAnZXhwZWN0ZWQnOiAnRkFJ TCcKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9LAorICAgICAgICAgICAgJ2Fub3Ro ZXIuaHRtbCc6IHsKKyAgICAgICAgICAgICAgICAnYWN0dWFsJzogJ1RFWFQnLAorICAgICAgICAg ICAgICAgICdleHBlY3RlZCc6ICdQQVNTJworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAg fQorCisgICAgZnVuY3Rpb24gaXNMZWFmKG5vZGUpCisgICAgeworICAgICAgICByZXR1cm4gISFu b2RlLmFjdHVhbDsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBhY3R1YWxJc1RleHQobm9kZSkKKyAg ICB7CisgICAgICAgIHJldHVybiBub2RlLmFjdHVhbCA9PSAnVEVYVCc7CisgICAgfQorCisgICAg dmFyIGFsbCA9IGJhc2UuZmlsdGVyVHJlZSh0cmVlLCBpc0xlYWYsIGZ1bmN0aW9uKCkgeyByZXR1 cm4gdHJ1ZSB9KTsKKyAgICBkZWVwRXF1YWwoYWxsLCB7CisgICAgICAgICdwYXRoL3RvL3Rlc3Qu aHRtbCc6IHsKKyAgICAgICAgICAgICdhY3R1YWwnOiAnUEFTUycsCisgICAgICAgICAgICAnZXhw ZWN0ZWQnOiAnRkFJTCcKKyAgICAgICAgfSwKKyAgICAgICAgJ3BhdGgvYW5vdGhlci5odG1sJzog eworICAgICAgICAgICAgJ2FjdHVhbCc6ICdURVhUJywKKyAgICAgICAgICAgICdleHBlY3RlZCc6 ICdQQVNTJworICAgICAgICB9CisgICAgfSk7CisKKyAgICB2YXIgdGV4dCA9IGJhc2UuZmlsdGVy VHJlZSh0cmVlLCBpc0xlYWYsIGFjdHVhbElzVGV4dCk7CisgICAgZGVlcEVxdWFsKHRleHQsIHsK KyAgICAgICAgJ3BhdGgvYW5vdGhlci5odG1sJzogeworICAgICAgICAgICAgJ2FjdHVhbCc6ICdU RVhUJywKKyAgICAgICAgICAgICdleHBlY3RlZCc6ICdQQVNTJworICAgICAgICB9CisgICAgfSk7 Cit9KTsKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2Fy ZGVuaW5nc2VydmVyL3J1bi11bml0dGVzdHMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9ydW4tdW5pdHRl c3RzLmh0bWwJKHJldmlzaW9uIDApCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2Vy dmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9ydW4tdW5pdHRlc3RzLmh0bWwJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMTYgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5r IHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vLi4vLi4vLi4vLi4vLi4vU291cmNlL1RoaXJk UGFydHkvcXVuaXQvcXVuaXQvcXVuaXQuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi8uLi8u Li8uLi8uLi9Tb3VyY2UvVGhpcmRQYXJ0eS9xdW5pdC9xdW5pdC9xdW5pdC5qcyI+PC9zY3JpcHQ+ Cis8L2hlYWQ+Cis8Ym9keT4KKzxoMSBpZD0icXVuaXQtaGVhZGVyIj5HYXJkZW5pbmcgU2VydmVy IEphdmFTY3JpcHQgVW5pdCBUZXN0czwvaDE+Cis8aDIgaWQ9InF1bml0LWJhbm5lciI+PC9oMj4K KzxkaXYgaWQ9InF1bml0LXRlc3RydW5uZXItdG9vbGJhciI+PC9kaXY+Cis8aDIgaWQ9InF1bml0 LXVzZXJBZ2VudCI+PC9oMj4KKzxvbCBpZD0icXVuaXQtdGVzdHMiPjwvb2w+Cis8c2NyaXB0IHNy Yz0iYmFzZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iYmFzZV91bml0dGVzdHMuanMiPjwv c2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=