63968 2011-07-05 19:21:36 -0700 Add comment to explain Vector usage in FontCache::purgeInactiveFontData 2019-05-02 16:25:16 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yuzo yuzo mitz perrymasterson1 thomasclein7 webkit.review.bot oldest_to_newest 432563 0 yuzo 2011-07-05 19:21:36 -0700 Vector<const SimpleFontData*, 20> fontDataToDelete is used to temporarily record which font data to delete but it is actually unnecessary. 432565 1 99782 yuzo 2011-07-05 19:25:36 -0700 Created attachment 99782 Patch 432568 2 99782 mitz 2011-07-05 19:30:49 -0700 Comment on attachment 99782 Patch Has anything changed since <http://trac.webkit.org/changeset/44011> that would make this safe? 432585 3 99784 yuzo 2011-07-05 20:26:33 -0700 Created attachment 99784 Patch 432586 4 yuzo 2011-07-05 20:28:07 -0700 Thank you for the review and sorry for the oversight. I believe it is worth a comment. Hence a new patch to add one. 434635 5 99784 webkit.review.bot 2011-07-10 18:38:25 -0700 Comment on attachment 99784 Patch Clearing flags on attachment: 99784 Committed r90700: <http://trac.webkit.org/changeset/90700> 434636 6 webkit.review.bot 2011-07-10 18:38:29 -0700 All reviewed patches have been landed. Closing bug. 99782 2011-07-05 19:25:36 -0700 2011-07-05 20:26:28 -0700 Patch bug-63968-20110705192535.patch text/plain 2201 yuzo U3VidmVyc2lvbiBSZXZpc2lvbjogOTA0MjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyZGI4OGI4ZjNiZDE2YmUy MGU0YzY5NGE3NDgyNDA2ZDMzY2RmZDc1Li5lY2EwN2E5NjNjMjQ2OWRhY2VkNzkyMjhlNzk4OTVh MTU5NDU2MGU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMDUgIFl1em8g RnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAgIEZpeCBmb3IgQnVnIDYzOTY4 IC0gUmVtb3ZlIHVubmVjZXNzYXJ5IFZlY3RvciB1c2FnZSBpbiBGb250Q2FjaGU6OnB1cmdlSW5h Y3RpdmVGb250RGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjM5NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGlzIGNoYW5nZXMgaW50ZXJuYWwgYmVoYXZpb3Ig b25seS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYWNoZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGb250Q2FjaGU6OnB1cmdlSW5hY3RpdmVGb250RGF0YSk6IFJlbW92ZSBm b250RGF0YVRvRGVsZXRlIHVzYWdlLgorCiAyMDExLTA3LTA1ICBIYW5zIFdlbm5ib3JnICA8aGFu c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XVtDaHJvbWl1bV0gUmVtb3ZlIHVzZSBvZiBP d25IYW5kbGUgZnJvbSBWOExvY2FsQ29udGV4dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0ZvbnRDYWNoZS5jcHAKaW5kZXggM2E0N2I3MmQ1ZTdlZGVlZDg2MjVjMTMwNTdl MTY2YjNhMmRkOWIwNi4uMmQ2ZTgzNTEyZjhiMmQ4YzZmOGRkY2NiNjg3NWRkNTk4MWJlYTgwNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuY3BwCkBA IC0zMzksMTMgKzMzOSwxMiBAQCB2b2lkIEZvbnRDYWNoZTo6cHVyZ2VJbmFjdGl2ZUZvbnREYXRh KGludCBjb3VudCkKIAogICAgIGlzUHVyZ2luZyA9IHRydWU7CiAKLSAgICBWZWN0b3I8Y29uc3Qg U2ltcGxlRm9udERhdGEqLCAyMD4gZm9udERhdGFUb0RlbGV0ZTsKICAgICBMaXN0SGFzaFNldDxj b25zdCBTaW1wbGVGb250RGF0YSo+OjppdGVyYXRvciBlbmQgPSBnSW5hY3RpdmVGb250RGF0YS0+ ZW5kKCk7CiAgICAgTGlzdEhhc2hTZXQ8Y29uc3QgU2ltcGxlRm9udERhdGEqPjo6aXRlcmF0b3Ig aXQgPSBnSW5hY3RpdmVGb250RGF0YS0+YmVnaW4oKTsKICAgICBmb3IgKGludCBpID0gMDsgaSA8 IGNvdW50ICYmIGl0ICE9IGVuZDsgKytpdCwgKytpKSB7CiAgICAgICAgIGNvbnN0IFNpbXBsZUZv bnREYXRhKiBmb250RGF0YSA9ICppdC5nZXQoKTsKICAgICAgICAgZ0ZvbnREYXRhQ2FjaGUtPnJl bW92ZShmb250RGF0YS0+cGxhdGZvcm1EYXRhKCkpOwotICAgICAgICBmb250RGF0YVRvRGVsZXRl LmFwcGVuZChmb250RGF0YSk7CisgICAgICAgIGRlbGV0ZSBmb250RGF0YTsKICAgICB9CiAKICAg ICBpZiAoaXQgPT0gZW5kKSB7CkBAIC0zNTYsMTAgKzM1NSw2IEBAIHZvaWQgRm9udENhY2hlOjpw dXJnZUluYWN0aXZlRm9udERhdGEoaW50IGNvdW50KQogICAgICAgICAgICAgZ0luYWN0aXZlRm9u dERhdGEtPnJlbW92ZShnSW5hY3RpdmVGb250RGF0YS0+YmVnaW4oKSk7CiAgICAgfQogCi0gICAg c2l6ZV90IGZvbnREYXRhVG9EZWxldGVDb3VudCA9IGZvbnREYXRhVG9EZWxldGUuc2l6ZSgpOwot ICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgZm9udERhdGFUb0RlbGV0ZUNvdW50OyArK2kpCi0g ICAgICAgIGRlbGV0ZSBmb250RGF0YVRvRGVsZXRlW2ldOwotCiAgICAgaWYgKGdGb250UGxhdGZv cm1EYXRhQ2FjaGUpIHsKICAgICAgICAgVmVjdG9yPEZvbnRQbGF0Zm9ybURhdGFDYWNoZUtleT4g a2V5c1RvUmVtb3ZlOwogICAgICAgICBrZXlzVG9SZW1vdmUucmVzZXJ2ZUluaXRpYWxDYXBhY2l0 eShnRm9udFBsYXRmb3JtRGF0YUNhY2hlLT5zaXplKCkpOwo= 99784 2011-07-05 20:26:33 -0700 2011-07-10 18:38:25 -0700 Patch bug-63968-20110705202632.patch text/plain 1610 yuzo U3VidmVyc2lvbiBSZXZpc2lvbjogOTA0MjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyZGI4OGI4ZjNiZDE2YmUy MGU0YzY5NGE3NDgyNDA2ZDMzY2RmZDc1Li4zOGI3YjRkZmI3ODdkZGNhMGY4YjBjOWU1MWMwODEz MWI0OTRlNWExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMDUgIFl1em8g RnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAgIEZpeCBmb3IgQnVnIDYzOTY4 IC0gQWRkIGNvbW1lbnQgdG8gZXhwbGFpbiBWZWN0b3IgdXNhZ2UgaW4gRm9udENhY2hlOjpwdXJn ZUluYWN0aXZlRm9udERhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTYzOTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhpcyBjaGFuZ2VzIGNvbW1lbnRzIG9ubHku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Rm9udENhY2hlOjpwdXJnZUluYWN0aXZlRm9udERhdGEpOiBBZGQgZXhwbGFuYXRp b24gd2h5IFNpbXBsZUZvbnREYXRhIGlzIG5vdCBkZWxldGVkIGluIHRoZSBpdGVyYXRpb24gbG9v cC4KKwogMjAxMS0wNy0wNSAgSGFucyBXZW5uYm9yZyAgPGhhbnNAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFtWOF1bQ2hyb21pdW1dIFJlbW92ZSB1c2Ugb2YgT3duSGFuZGxlIGZyb20gVjhMb2Nh bENvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zv bnRDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUu Y3BwCmluZGV4IDNhNDdiNzJkNWU3ZWRlZWQ4NjI1YzEzMDU3ZTE2NmIzYTJkZDliMDYuLmYxZWM5 ZWYzMWM1NTQ2ZDAyYzI3MzZiMmRmMWZjMGI3ZTEzYjM2MDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmNwcApAQCAtMzQ1LDYgKzM0NSw3IEBAIHZv aWQgRm9udENhY2hlOjpwdXJnZUluYWN0aXZlRm9udERhdGEoaW50IGNvdW50KQogICAgIGZvciAo aW50IGkgPSAwOyBpIDwgY291bnQgJiYgaXQgIT0gZW5kOyArK2l0LCArK2kpIHsKICAgICAgICAg Y29uc3QgU2ltcGxlRm9udERhdGEqIGZvbnREYXRhID0gKml0LmdldCgpOwogICAgICAgICBnRm9u dERhdGFDYWNoZS0+cmVtb3ZlKGZvbnREYXRhLT5wbGF0Zm9ybURhdGEoKSk7CisgICAgICAgIC8v IFdlIHNob3VsZCBub3QgZGVsZXRlIFNpbXBsZUZvbnREYXRhIGhlcmUgYmVjYXVzZSBkZWxldGlv biBjYW4gbW9kaWZ5IGdJbmFjdGl2ZUZvbnREYXRhLiBTZWUgaHR0cDovL3RyYWMud2Via2l0Lm9y Zy9jaGFuZ2VzZXQvNDQwMTEKICAgICAgICAgZm9udERhdGFUb0RlbGV0ZS5hcHBlbmQoZm9udERh dGEpOwogICAgIH0KIAo=