63965 2011-07-05 18:42:09 -0700 garden-o-matic should understand which tests have unexpected failures 2011-07-05 19:32:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth aroben dglazkov eric ojan webkit.review.bot oldest_to_newest 432531 0 abarth 2011-07-05 18:42:09 -0700 garden-o-matic should understand which tests have unexpected failures 432532 1 99771 abarth 2011-07-05 18:43:35 -0700 Created attachment 99771 Patch 432537 2 99771 eric 2011-07-05 18:44:48 -0700 Comment on attachment 99771 Patch I'm not a very good JS reviewer. You owe me some unit testing.... 432539 3 eric 2011-07-05 18:45:08 -0700 Why is our JS style 2-space indent? Does check-webkit-style enforce that? 432542 4 abarth 2011-07-05 18:45:40 -0700 > Why is our JS style 2-space indent? Does check-webkit-style enforce that? This style matches the code-review.js code. I don't think it's enforced by check-webkit-style. 432544 5 99771 ojan 2011-07-05 18:49:26 -0700 Comment on attachment 99771 Patch Seems fine to me. I'm not familiar with jquery grep, but I'll assume it does what you want. I'd just use "filter" on the array, but I know you luvs ur jquery. :) I should have commented on the previous patch as well, I don't like using a different style for our JS code than our C++/Python code. The benefits are not worth the context switching cost. I'd prefer if we did 4 space indent and open curly on a new line. 432546 6 ojan 2011-07-05 18:49:55 -0700 (In reply to comment #4) > > Why is our JS style 2-space indent? Does check-webkit-style enforce that? > > This style matches the code-review.js code. I don't think it's enforced by check-webkit-style. We should change that as well IMO. 432549 7 abarth 2011-07-05 18:52:48 -0700 > I should have commented on the previous patch as well, I don't like using a different style for our JS code than our C++/Python code. The benefits are not worth the context switching cost. I'd prefer if we did 4 space indent and open curly on a new line. Python style is a bad match for JavaScript because the JavaScript standard library doesn't match and that's odd. I'll change the style to match our C++ style (moving the curlies and camelCasing the variables, etc). 432570 8 99771 abarth 2011-07-05 19:32:17 -0700 Comment on attachment 99771 Patch Clearing flags on attachment: 99771 Committed r90428: <http://trac.webkit.org/changeset/90428> 432571 9 abarth 2011-07-05 19:32:21 -0700 All reviewed patches have been landed. Closing bug. 99771 2011-07-05 18:43:35 -0700 2011-07-05 19:32:17 -0700 Patch bug-63965-20110705184334.patch text/plain 5485 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTA0MTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkMjA0Yjk0MDMwN2FlNDFiMTZhNDI2ZDQ4YWQyOGNiZjk3 YzNlNjhhLi5iNWUzMThmNWJiY2IyMzQ1N2M0M2M3ZWVkZGNhZmI4ZGVhNmI0NjNlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTEtMDctMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAg ICBnYXJkZW4tby1tYXRpYyBzaG91bGQgdW5kZXJzdGFuZCB3aGljaCB0ZXN0cyBoYXZlIHVuZXhw ZWN0ZWQgZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYzOTY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ3VycmVudGx5LCB0aGlzIGNvZGUganVzdCBsb2dzIHRoZSBsaXN0IG9mIHVuZXhwZWN0 ZWQgZmFpbHVyZXMgdG8gdGhlCisgICAgICAgIGNvbnNvbGUuICBBIGZ1dHVyZSBwYXRjaCB3aWxs IGRvIHNvbWV0aGluZyB1c2VmdWwgd2l0aCB0aGlzCisgICAgICAgIGluZm9ybWF0aW9uLiAgQSB0 ZXN0aW5nIGhhcm5lc3Mgd2lsbCBhbHNvIGNvbWUgaW4gdGhlIG5leHQgcGF0Y2guCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9i YXNlLmpzOiBBZGRlZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9k YXRhL2dhcmRlbmluZ3NlcnZlci9pbmRleC5odG1sOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL3Jlc3VsdHMuanM6CisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5nc2VydmVyLnB5OgorCisy MDExLTA3LTA1ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAgZ2Fy ZGVuLW8tbWF0aWMgc2hvdWxkIGtub3cgaG93IHRvIGZldGNoIHRlc3QgcmVzdWx0cyBmcm9tIHRo ZSAoTlJXVCkgYm90cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjM5NTkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3Nl cnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvYmFzZS5qcyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL2Jhc2UuanMKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u ZTM5OTc4OWExYjk1ZGM2Y2VkYTVmMzcwYWUwNTFlODFjZDE5ZDZkNAotLS0gL2Rldi9udWxsCisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2Vy dmVyL2Jhc2UuanMKQEAgLTAsMCArMSwyNyBAQAordmFyIGJhc2UgPSBiYXNlIHx8IHt9OworCiso ZnVuY3Rpb24oKSB7CisgIGJhc2Uuam9pblBhdGggPSBmdW5jdGlvbihwYXJlbnQsIGNoaWxkKSB7 CisgICAgcmV0dXJuIHBhcmVudCArICcvJyArIGNoaWxkOworICB9CisKKyAgYmFzZS5maWx0ZXJU cmVlID0gZnVuY3Rpb24odHJlZSwgaXNfbGVhZiwgcHJlZGljYXRlKSB7CisgICAgdmFyIGZpbHRl cmVkX3RyZWUgPSB7fTsKKworICAgIGZ1bmN0aW9uIHdhbGtTdWJ0cmVlKHN1YnRyZWUsIGRpcmVj dG9yeSkgeworICAgICAgZm9yICh2YXIgY2hpbGRfbmFtZSBpbiBzdWJ0cmVlKSB7CisgICAgICAg IHZhciBjaGlsZCA9IHN1YnRyZWVbY2hpbGRfbmFtZV07CisgICAgICAgIHZhciBjaGlsZF9wYXRo ID0gYmFzZS5qb2luUGF0aChkaXJlY3RvcnksIGNoaWxkX25hbWUpOworICAgICAgICBpZiAoaXNf bGVhZihjaGlsZCkpIHsKKyAgICAgICAgICBpZiAocHJlZGljYXRlKGNoaWxkKSkKKyAgICAgICAg ICAgIGZpbHRlcmVkX3RyZWVbY2hpbGRfcGF0aF0gPSBjaGlsZDsKKyAgICAgICAgICBjb250aW51 ZTsKKyAgICAgICAgfQorICAgICAgICB3YWxrU3VidHJlZShjaGlsZCwgY2hpbGRfcGF0aCk7Cisg ICAgICB9CisgICAgfQorCisgICAgd2Fsa1N1YnRyZWUodHJlZSwgJycpOworICAgIHJldHVybiBm aWx0ZXJlZF90cmVlOworICB9Cit9KSgpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvaW5kZXguaHRtbCBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL2luZGV4 Lmh0bWwKaW5kZXggOTczZmQ0ODQ0ZDA5OTlhM2FjY2Q1Yjk4YTA5ODEzM2YxNzUzYjczZC4uNTBj MDEyNGYyODNlMDRhZWQzNDdkMWUwNzkzODMzNWNiMzE1MDZjZCAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvaW5kZXgu aHRtbAorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRl bmluZ3NlcnZlci9pbmRleC5odG1sCkBAIC0zNCw2ICszNCw3IEBAIGgxIHsKICAgPGxpPjxidXR0 b24gY2xhc3M9InF1aXQiPlF1aXQ8L2J1dHRvbj48L2xpPgogPC91bD4KIDxzY3JpcHQgc3JjPSJo dHRwczovL2FqYXguZ29vZ2xlYXBpcy5jb20vYWpheC9saWJzL2pxdWVyeS8xLjQuMi9qcXVlcnku bWluLmpzIj48L3NjcmlwdD4gCis8c2NyaXB0IHNyYz0iYmFzZS5qcyI+PC9zY3JpcHQ+CiA8c2Ny aXB0IHNyYz0ibWFpbi5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0IHNyYz0icmVzdWx0cy5qcyI+PC9z Y3JpcHQ+CiA8L2JvZHk+CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv c2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9yZXN1bHRzLmpzIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvcmVzdWx0cy5qcwppbmRl eCAwY2I5NzkyOWNlZjgzYmFmMDEyM2E3NTk1YjJiNzNlNmYwYWU2YjRhLi41NzQzMjBlODJlYTMx NTY4ZTQ0OTQzN2Y5MWI1ODVlMGRjMjUyMDE0IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9yZXN1bHRzLmpzCisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVy L3Jlc3VsdHMuanMKQEAgLTMsNiArMyw0NCBAQAogICB2YXIgVEVTVF9UWVBFID0gJ2xheW91dC10 ZXN0cyc7CiAgIHZhciBSRVNVTFRTX05BTUUgPSAnZnVsbF9yZXN1bHRzLmpzb24nOwogICB2YXIg TUFTVEVSX05BTUUgPSAnQ2hyb21pdW1XZWJraXQnOworICB2YXIgRkFJTElOR19SRVNVTFRTID0g WydUSU1FT1VUJywgJ1RFWFQnLCAnQ1JBU0gnLCAnSU1BR0UnLCdJTUFHRStURVhUJ107CisKKyAg ZnVuY3Rpb24gaXNGYWlsdXJlKHJlc3VsdCkgeworICAgIHJldHVybiBGQUlMSU5HX1JFU1VMVFMu aW5kZXhPZihyZXN1bHQpICE9IC0xOworICB9CisKKyAgZnVuY3Rpb24gYW55SXNGYWlsdXJlKHJl c3VsdHNfbGlzdCkgeworICAgIHJldHVybiAkLmdyZXAocmVzdWx0c19saXN0LCBpc0ZhaWx1cmUp Lmxlbmd0aCA+IDA7CisgIH0KKworICBmdW5jdGlvbiBhZGRJbXBsaWVkRXhwZWN0YXRpb25zKHJl c3VsdHNfbGlzdCkgeworICAgIGlmIChyZXN1bHRzX2xpc3QuaW5kZXhPZignRkFJTCcpID09IC0x KQorICAgICAgcmV0dXJuIHJlc3VsdHNfbGlzdDsKKyAgICByZXR1cm4gcmVzdWx0c19saXN0LmNv bmNhdChGQUlMSU5HX1JFU1VMVFMpOworICB9CisKKyAgZnVuY3Rpb24gdW5leHBlY3RlZFJlc3Vs dHMocmVzdWx0X25vZGUpIHsKKyAgICB2YXIgYWN0dWFsX3Jlc3VsdHMgPSByZXN1bHRfbm9kZS5h Y3R1YWwuc3BsaXQoJyAnKTsKKyAgICB2YXIgZXhwZWN0ZWRfcmVzdWx0cyA9IGFkZEltcGxpZWRF eHBlY3RhdGlvbnMocmVzdWx0X25vZGUuZXhwZWN0ZWQuc3BsaXQoJyAnKSkKKworICAgIHJldHVy biAkLmdyZXAoYWN0dWFsX3Jlc3VsdHMsIGZ1bmN0aW9uKHJlc3VsdCkgeworICAgICAgcmV0dXJu IGV4cGVjdGVkX3Jlc3VsdHMuaW5kZXhPZihyZXN1bHQpID09IC0xOworICAgIH0pOworICB9CisK KyAgZnVuY3Rpb24gaXNVbmV4cGVjdGVkRmFpbHVyZShyZXN1bHRfbm9kZSkgeworICAgIHJldHVy biBhbnlJc0ZhaWx1cmUodW5leHBlY3RlZFJlc3VsdHMocmVzdWx0X25vZGUpKTsKKyAgfQorCisg IGZ1bmN0aW9uIGlzUmVzdWx0Tm9kZShub2RlKSB7CisgICAgcmV0dXJuICEhbm9kZS5hY3R1YWw7 CisgIH0KKworICBmdW5jdGlvbiBsb2dVbmV4cGVjdGVkRmFpbHVyZXMocmVzdWx0c19qc29uKSB7 CisgICAgdW5leHBlY3RlZF9mYWlsdXJlcyA9IGJhc2UuZmlsdGVyVHJlZShyZXN1bHRzX2pzb24u dGVzdHMsIGlzUmVzdWx0Tm9kZSwgaXNVbmV4cGVjdGVkRmFpbHVyZSk7CisgICAgY29uc29sZS5s b2coJz09IFVuZXhwZWN0ZWQgRmFpbHVyZXMgPT0nKQorICAgIGNvbnNvbGUubG9nKHVuZXhwZWN0 ZWRfZmFpbHVyZXMpOworICB9CiAKICAgZnVuY3Rpb24gcmVzdWx0c1VSTChidWlsZGVyX25hbWUs IG5hbWUpIHsKICAgICByZXR1cm4gVEVTVF9SRVNVTFRTX1NFUlZFUiArICd0ZXN0ZmlsZScgKwpA QCAtMjAsOCArNTgsNSBAQAogICAgIH0pOwogICB9CiAKLSAgZmV0Y2hSZXN1bHRzKCdXZWJraXQg TGludXgnLCBmdW5jdGlvbihkYXRhKSB7Ci0gICAgY29uc29sZS5sb2coIj09IFJlc3VsdHMgPT0i KQotICAgIGNvbnNvbGUubG9nKGRhdGEpOwotICB9KTsKKyAgZmV0Y2hSZXN1bHRzKCdXZWJraXQg TGludXgnLCBsb2dVbmV4cGVjdGVkRmFpbHVyZXMpOwogfSkoKTsKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2dhcmRlbmluZ3NlcnZlci5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2dhcmRlbmluZ3NlcnZlci5weQppbmRleCBk ZjU4YWJlMDQzYTFmZWYzMzI1OWYwNjAzY2I5Y2E0Y2Q3MThlNjM4Li45ZGM3YmM3NDM3MzQ2YTQ4 MDYxY2ZkMWY1YjZjOWQxN2YwZWI3NzBiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvc2VydmVycy9nYXJkZW5pbmdzZXJ2ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5nc2VydmVyLnB5CkBAIC0zNyw2ICszNyw3IEBA IGNsYXNzIEdhcmRlbmluZ0hUVFBTZXJ2ZXIoQmFzZUhUVFBTZXJ2ZXIuSFRUUFNlcnZlcik6CiBj bGFzcyBHYXJkZW5pbmdIVFRQUmVxdWVzdEhhbmRsZXIoUmVmbGVjdGlvbkhhbmRsZXIpOgogICAg IFNUQVRJQ19GSUxFX05BTUVTID0gZnJvemVuc2V0KFsKICAgICAgICAgImluZGV4Lmh0bWwiLAor ICAgICAgICAiYmFzZS5qcyIsCiAgICAgICAgICJtYWluLmpzIiwKICAgICAgICAgInJlc3VsdHMu anMiLAogICAgIF0pCg==