63962 2011-07-05 17:48:45 -0700 Fix MIPS build due to readInt32 and readPointer 2011-07-09 13:09:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 fu webkit-unassigned paroga oldest_to_newest 432496 0 fu 2011-07-05 17:48:45 -0700 Hi, I will post a patch to fix readInt32 and readPointer for the MIPS build. Thanks! Regards, Chao-ying 432502 1 99768 fu 2011-07-05 17:54:39 -0700 Created attachment 99768 Fix MIPS readInt32 and readPointer Here is the patch. JavaScriptCore tests are ok. Thanks! 433738 2 100038 fu 2011-07-07 15:25:16 -0700 Created attachment 100038 Add MIPS rshift32 One more fix to add MIPS rshift32. Thanks! 434521 3 paroga 2011-07-09 13:07:18 -0700 Committed r90687: <http://trac.webkit.org/changeset/90687> 434522 4 100038 paroga 2011-07-09 13:09:33 -0700 Comment on attachment 100038 Add MIPS rshift32 Some hints for the future: Adding a revision where the build break occured helps to verify the patch and to see the relations between changes. Any interests in setting up a buildbot for MIPS? 99768 2011-07-05 17:54:39 -0700 2011-07-07 15:25:16 -0700 Fix MIPS readInt32 and readPointer mips20110705.diff text/plain 1439 fu SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTA0MjIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDctMDUgIENoYW8teWluZyBGdSAgPGZ1QG1pcHMuY29tPgorCisgICAgICAgIEZpeCBN SVBTIGJ1aWxkIGR1ZSB0byByZWFkSW50MzIgYW5kIHJlYWRQb2ludGVyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mzk2MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL01JUFNBc3NlbWJs ZXIuaDoKKyAgICAgICAgKEpTQzo6TUlQU0Fzc2VtYmxlcjo6cmVhZEludDMyKToKKyAgICAgICAg KEpTQzo6TUlQU0Fzc2VtYmxlcjo6cmVhZFBvaW50ZXIpOgorCiAyMDExLTA3LTA1ICBPbGl2ZXIg SHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgSW5pdGlhbGl6ZSBuZXcgTWFya1N0 YWNrIG1lbWJlcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NSVBTQXNz ZW1ibGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N SVBTQXNzZW1ibGVyLmgJKHJldmlzaW9uIDkwNDA3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NSVBTQXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTc1Myw3ICs3NTMs OCBAQCBwdWJsaWM6CiAgICAgICAgIGludDMyX3QgcmVzdWx0ID0gKCppbnNuICYgMHgwMDAwZmZm ZikgPDwgMTY7CiAgICAgICAgIGluc24rKzsKICAgICAgICAgQVNTRVJUKCgqaW5zbiAmIDB4ZmMw MDAwMDApID09IDB4MzQwMDAwMDApOyAvLyBvcmkKLSAgICAgICAgcmVzdWx0IHw9ICppbnNuICYg MHgwMDAwZmZmZgorICAgICAgICByZXN1bHQgfD0gKmluc24gJiAweDAwMDBmZmZmOworICAgICAg ICByZXR1cm4gcmVzdWx0OwogICAgIH0KICAgICAKICAgICBzdGF0aWMgdm9pZCByZXBhdGNoQ29t cGFjdCh2b2lkKiB3aGVyZSwgaW50MzJfdCB2YWx1ZSkKQEAgLTc2OCw3ICs3NjksNyBAQCBwdWJs aWM6CiAKICAgICBzdGF0aWMgdm9pZCogcmVhZFBvaW50ZXIodm9pZCogZnJvbSkKICAgICB7Ci0g ICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDx2b2lkKj4ocmVhZEludDMyKGZyb20pKTsKKyAgICAg ICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KHJlYWRJbnQzMihmcm9tKSk7CiAgICAg fQogCiBwcml2YXRlOgo= 100038 2011-07-07 15:25:16 -0700 2011-07-09 13:09:33 -0700 Add MIPS rshift32 mips20110707.diff text/plain 2169 fu SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTA1OTQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDctMDcgIENoYW8teWluZyBGdSAgPGZ1QG1pcHMuY29tPgorCisgICAgICAgIEZpeCBN SVBTIGJ1aWxkIGR1ZSB0byByZWFkSW50MzIgYW5kIHJlYWRQb2ludGVyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mzk2MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL01JUFNBc3NlbWJs ZXIuaDoKKyAgICAgICAgKEpTQzo6TUlQU0Fzc2VtYmxlcjo6cmVhZEludDMyKToKKyAgICAgICAg KEpTQzo6TUlQU0Fzc2VtYmxlcjo6cmVhZFBvaW50ZXIpOgorICAgICAgICAqIGFzc2VtYmxlci9N YWNyb0Fzc2VtYmxlck1JUFMuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjpy c2hpZnQzMik6CisKIDIwMTEtMDctMDcgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4K IAogICAgICAgICBFbmNvZGUganVtcCBhbmQgbGluayBzaXplcyBpbnRvIHRoZSBhcHByb3ByaWF0 ZSBlbnVtcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NSVBTQXNzZW1i bGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NSVBT QXNzZW1ibGVyLmgJKHJldmlzaW9uIDkwNTc4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9NSVBTQXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTc1Myw3ICs3NTMsOCBA QCBwdWJsaWM6CiAgICAgICAgIGludDMyX3QgcmVzdWx0ID0gKCppbnNuICYgMHgwMDAwZmZmZikg PDwgMTY7CiAgICAgICAgIGluc24rKzsKICAgICAgICAgQVNTRVJUKCgqaW5zbiAmIDB4ZmMwMDAw MDApID09IDB4MzQwMDAwMDApOyAvLyBvcmkKLSAgICAgICAgcmVzdWx0IHw9ICppbnNuICYgMHgw MDAwZmZmZgorICAgICAgICByZXN1bHQgfD0gKmluc24gJiAweDAwMDBmZmZmOworICAgICAgICBy ZXR1cm4gcmVzdWx0OwogICAgIH0KICAgICAKICAgICBzdGF0aWMgdm9pZCByZXBhdGNoQ29tcGFj dCh2b2lkKiB3aGVyZSwgaW50MzJfdCB2YWx1ZSkKQEAgLTc2OCw3ICs3NjksNyBAQCBwdWJsaWM6 CiAKICAgICBzdGF0aWMgdm9pZCogcmVhZFBvaW50ZXIodm9pZCogZnJvbSkKICAgICB7Ci0gICAg ICAgIHJldHVybiBzdGF0aWNfY2FzdDx2b2lkKj4ocmVhZEludDMyKGZyb20pKTsKKyAgICAgICAg cmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KHJlYWRJbnQzMihmcm9tKSk7CiAgICAgfQog CiBwcml2YXRlOgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlck1JUFMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1i bGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCShyZXZpc2lvbiA5MDU3OCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgJKHdvcmtpbmcgY29weSkK QEAgLTMzMCw2ICszMzAsMTEgQEAgcHVibGljOgogICAgICAgICBtX2Fzc2VtYmxlci5zcmEoZGVz dCwgZGVzdCwgaW1tLm1fdmFsdWUpOwogICAgIH0KIAorICAgIHZvaWQgcnNoaWZ0MzIoUmVnaXN0 ZXJJRCBzcmMsIFRydXN0ZWRJbW0zMiBpbW0sIFJlZ2lzdGVySUQgZGVzdCkKKyAgICB7CisgICAg ICAgIG1fYXNzZW1ibGVyLnNyYShkZXN0LCBzcmMsIGltbS5tX3ZhbHVlKTsKKyAgICB9CisKICAg ICB2b2lkIHVyc2hpZnQzMihSZWdpc3RlcklEIHNoaWZ0QW1vdW50LCBSZWdpc3RlcklEIGRlc3Qp CiAgICAgewogICAgICAgICBtX2Fzc2VtYmxlci5zcmx2KGRlc3QsIGRlc3QsIHNoaWZ0QW1vdW50 KTsK