63959 2011-07-05 16:13:45 -0700 garden-o-matic should know how to fetch test results from the (NRWT) bots 2011-07-05 18:18:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dglazkov eric ojan webkit.review.bot oldest_to_newest 432459 0 abarth 2011-07-05 16:13:45 -0700 garden-o-matic should know how to fetch test results from the (NRWT) bots 432460 1 99758 abarth 2011-07-05 16:14:53 -0700 Created attachment 99758 Patch 432462 2 abarth 2011-07-05 16:15:31 -0700 @ojan: Can we make the server understand the normal JSONP "callback" parameter? That would make the client side code cleaner (and more robust). 432468 3 ojan 2011-07-05 16:22:29 -0700 (In reply to comment #2) > @ojan: Can we make the server understand the normal JSONP "callback" parameter? That would make the client side code cleaner (and more robust). That's fine with me. The only issue is the local results.html file needs to load full_results.json from the local filesystem, which as you are well aware we can't do XHR to the local filesystem in Chrome. So, at least for that script, we need the callback built in to the written out JSON. If we're going to have it for that one, may as well have it for all of them? That said, we could have the server replace the hard-coded call with the callback, but that gains us less. Open to better suggestions of course. I agree this isn't ideal. 432469 4 abarth 2011-07-05 16:24:46 -0700 I think it's fine for the server to replace the default callback with one specified in the URL. That seems like the easiest solution. 432487 5 99765 abarth 2011-07-05 17:12:31 -0700 Created attachment 99765 Patch 432488 6 99765 eric 2011-07-05 17:17:12 -0700 Comment on attachment 99765 Patch OK. 432489 7 99765 ojan 2011-07-05 17:18:22 -0700 Comment on attachment 99765 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99765&action=review > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:15 > + function fetchResults(builder_name, success) { nit: I tend to call paramters likes this "onsuccess" or "successHandler" or something that makes it clear it's a function not a boolean. 432490 8 ojan 2011-07-05 17:19:06 -0700 Whoops. Didn't mean to reset the cq+. I'll leave it cq? for now in case you want to address my nit. Feel free to ignore it though. 432492 9 99766 abarth 2011-07-05 17:25:52 -0700 Created attachment 99766 Patch 432493 10 abarth 2011-07-05 17:26:31 -0700 > nit: I tend to call paramters likes this "onsuccess" or "successHandler" or something that makes it clear it's a function not a boolean. Yeah, I was emulating the name jquey uses in its $.get function, but onsuccess does seem much clearer. :) 432521 11 99766 webkit.review.bot 2011-07-05 18:18:34 -0700 Comment on attachment 99766 Patch Clearing flags on attachment: 99766 Committed r90424: <http://trac.webkit.org/changeset/90424> 432522 12 webkit.review.bot 2011-07-05 18:18:39 -0700 All reviewed patches have been landed. Closing bug. 99758 2011-07-05 16:14:53 -0700 2011-07-05 17:12:27 -0700 Patch bug-63959-20110705161452.patch text/plain 3752 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTA0MTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1NjEyMDlkZDkyMDIxYTgxYWU3ZjhmODYzN2M1MTA4OTVm MGNjNjk1Li5jMjRkMDc5NTRlYWFkNDhiY2MyZjBlY2Y3ZTU1ODBhZmVhNjY1NTQ4IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTEtMDctMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAg ICBnYXJkZW4tby1tYXRpYyBzaG91bGQga25vdyBob3cgdG8gZmV0Y2ggdGVzdCByZXN1bHRzIGZy b20gdGhlIChOUldUKSBib3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02Mzk1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEN1cnJlbnRseSwgdGhpcyBjb2RlIGp1c3QgZmV0Y2hlcyB0aGUgcmVzdWx0cyBh bmQgZXhwZWN0YXRpb25zIEpTT04KKyAgICAgICAgYmxvYiBmb3IgTGludXggZnJvbSB0aGUgc2Vy dmVyIGFuZCBsb2dzIGl0IHRvIHRoZSBjb25zb2xlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvaW5kZXguaHRtbDoKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9y ZXN1bHRzLmpzOiBBZGRlZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVy cy9nYXJkZW5pbmdzZXJ2ZXIucHk6CisKKzIwMTEtMDctMDUgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KKwogICAgICAgICBBZGQgYmFzaWMgYWpheCBzdXBwb3J0IHRvIGdhcmRlbi1v LW1hdGljCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 Mzg3NAogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9k YXRhL2dhcmRlbmluZ3NlcnZlci9pbmRleC5odG1sIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvaW5kZXguaHRtbAppbmRleCBhOWMyODIz YjE4NjgyOWIwMDJlZGYzMjIwODkwNTViNDM4MDhkMzhiLi45NzNmZDQ4NDRkMDk5OWEzYWNjZDVi OThhMDk4MTMzZjE3NTNiNzNkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9pbmRleC5odG1sCisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL2luZGV4Lmh0 bWwKQEAgLTM1LDUgKzM1LDYgQEAgaDEgewogPC91bD4KIDxzY3JpcHQgc3JjPSJodHRwczovL2Fq YXguZ29vZ2xlYXBpcy5jb20vYWpheC9saWJzL2pxdWVyeS8xLjQuMi9qcXVlcnkubWluLmpzIj48 L3NjcmlwdD4gCiA8c2NyaXB0IHNyYz0ibWFpbi5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0i cmVzdWx0cy5qcyI+PC9zY3JpcHQ+CiA8L2JvZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9yZXN1 bHRzLmpzIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5p bmdzZXJ2ZXIvcmVzdWx0cy5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43MTI4ZDJiMjgyMzgwODg4MTBjZDBmMjUz NjU2OWZjMDcyNWE5NDQ5Ci0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvcmVzdWx0cy5qcwpAQCAtMCwwICsx LDQzIEBACisoZnVuY3Rpb24oKSB7CisgIHZhciBURVNUX1JFU1VMVFNfU0VSVkVSID0gJ2h0dHA6 Ly90ZXN0LXJlc3VsdHMuYXBwc3BvdC5jb20vJzsKKyAgdmFyIFRFU1RfVFlQRSA9ICdsYXlvdXQt dGVzdHMnOworICB2YXIgUkVTVUxUU19OQU1FID0gJ3Jlc3VsdHMtc21hbGwuanNvbic7CisgIHZh ciBFWFBFQ1RBVElPTlNfTkFNRSA9ICdleHBlY3RhdGlvbnMuanNvbic7CisgIHZhciBNQVNURVJf TkFNRSA9ICdDaHJvbWl1bVdlYmtpdCc7CisKKyAgZnVuY3Rpb24gcmVzdWx0c1VSTChidWlsZGVy X25hbWUsIG5hbWUpIHsKKyAgICByZXR1cm4gVEVTVF9SRVNVTFRTX1NFUlZFUiArICd0ZXN0Zmls ZScgKworICAgICAgICAnP2J1aWxkZXI9JyArIGJ1aWxkZXJfbmFtZSArCisgICAgICAgICcmbWFz dGVyPScgKyBNQVNURVJfTkFNRSArCisgICAgICAgICcmdGVzdHR5cGU9JyArIFRFU1RfVFlQRSAr CisgICAgICAgICcmbmFtZT0nICsgbmFtZTsKKyAgfQorCisgIGZ1bmN0aW9uIGZldGNoUmVzdWx0 cyhidWlsZGVyX25hbWUsIHN1Y2Nlc3MpIHsKKyAgICAkLmFqYXgoeworICAgICAgdXJsOiByZXN1 bHRzVVJMKGJ1aWxkZXJfbmFtZSwgUkVTVUxUU19OQU1FKSwKKyAgICAgIGRhdGFUeXBlOiAnanNv bnAnLAorICAgICAganNvbnBDYWxsYmFjazogJ0FERF9SRVNVTFRTJywKKyAgICAgIHN1Y2Nlc3M6 IHN1Y2Nlc3MKKyAgICB9KTsKKyAgfQorCisgIGZ1bmN0aW9uIGZldGNoRXhwZWN0YXRpb25zKGJ1 aWxkZXJfbmFtZSwgc3VjY2VzcykgeworICAgICQuYWpheCh7CisgICAgICB1cmw6IHJlc3VsdHNV UkwoYnVpbGRlcl9uYW1lLCBFWFBFQ1RBVElPTlNfTkFNRSksCisgICAgICBkYXRhVHlwZTogJ2pz b25wJywKKyAgICAgIGpzb25wQ2FsbGJhY2s6ICdBRERfRVhQRUNUQVRJT05TJywKKyAgICAgIHN1 Y2Nlc3M6IHN1Y2Nlc3MKKyAgICB9KTsKKyAgfQorCisgIGZldGNoUmVzdWx0cygnV2Via2l0IExp bnV4JywgZnVuY3Rpb24oZGF0YSkgeworICAgIGNvbnNvbGUubG9nKCI9PSBSZXN1bHRzID09IikK KyAgICBjb25zb2xlLmxvZyhkYXRhKTsKKyAgfSk7CisKKyAgZmV0Y2hFeHBlY3RhdGlvbnMoJ1dl YmtpdCBMaW51eCcsIGZ1bmN0aW9uKGRhdGEpIHsKKyAgICBjb25zb2xlLmxvZygiPT0gRXhwZWN0 YXRpb25zID09IikKKyAgICBjb25zb2xlLmxvZyhkYXRhKTsKKyAgfSk7Cit9KSgpOwpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5nc2VydmVy LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5nc2VydmVy LnB5CmluZGV4IDcyMDdlM2I0NWYyZmI4OThlM2NlMTZhOTEyZDU0YjFlNzg1M2M3OWMuLmRmNThh YmUwNDNhMWZlZjMzMjU5ZjA2MDNjYjljYTRjZDcxOGU2MzggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2dhcmRlbmluZ3NlcnZlci5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9nYXJkZW5pbmdzZXJ2ZXIucHkKQEAgLTM4 LDYgKzM4LDcgQEAgY2xhc3MgR2FyZGVuaW5nSFRUUFJlcXVlc3RIYW5kbGVyKFJlZmxlY3Rpb25I YW5kbGVyKToKICAgICBTVEFUSUNfRklMRV9OQU1FUyA9IGZyb3plbnNldChbCiAgICAgICAgICJp bmRleC5odG1sIiwKICAgICAgICAgIm1haW4uanMiLAorICAgICAgICAicmVzdWx0cy5qcyIsCiAg ICAgXSkKIAogICAgIFNUQVRJQ19GSUxFX0RJUkVDVE9SWSA9IG9zLnBhdGguam9pbihvcy5wYXRo LmRpcm5hbWUoX19maWxlX18pLCAiZGF0YSIsICJnYXJkZW5pbmdzZXJ2ZXIiKQo= 99765 2011-07-05 17:12:31 -0700 2011-07-05 17:25:48 -0700 Patch bug-63959-20110705171230.patch text/plain 3306 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTA0MTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1NjEyMDlkZDkyMDIxYTgxYWU3ZjhmODYzN2M1MTA4OTVm MGNjNjk1Li5jMjRkMDc5NTRlYWFkNDhiY2MyZjBlY2Y3ZTU1ODBhZmVhNjY1NTQ4IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTEtMDctMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAg ICBnYXJkZW4tby1tYXRpYyBzaG91bGQga25vdyBob3cgdG8gZmV0Y2ggdGVzdCByZXN1bHRzIGZy b20gdGhlIChOUldUKSBib3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02Mzk1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEN1cnJlbnRseSwgdGhpcyBjb2RlIGp1c3QgZmV0Y2hlcyB0aGUgcmVzdWx0cyBh bmQgZXhwZWN0YXRpb25zIEpTT04KKyAgICAgICAgYmxvYiBmb3IgTGludXggZnJvbSB0aGUgc2Vy dmVyIGFuZCBsb2dzIGl0IHRvIHRoZSBjb25zb2xlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvaW5kZXguaHRtbDoKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9y ZXN1bHRzLmpzOiBBZGRlZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVy cy9nYXJkZW5pbmdzZXJ2ZXIucHk6CisKKzIwMTEtMDctMDUgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KKwogICAgICAgICBBZGQgYmFzaWMgYWpheCBzdXBwb3J0IHRvIGdhcmRlbi1v LW1hdGljCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 Mzg3NAogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9k YXRhL2dhcmRlbmluZ3NlcnZlci9pbmRleC5odG1sIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvaW5kZXguaHRtbAppbmRleCBhOWMyODIz YjE4NjgyOWIwMDJlZGYzMjIwODkwNTViNDM4MDhkMzhiLi45NzNmZDQ4NDRkMDk5OWEzYWNjZDVi OThhMDk4MTMzZjE3NTNiNzNkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9pbmRleC5odG1sCisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL2luZGV4Lmh0 bWwKQEAgLTM1LDUgKzM1LDYgQEAgaDEgewogPC91bD4KIDxzY3JpcHQgc3JjPSJodHRwczovL2Fq YXguZ29vZ2xlYXBpcy5jb20vYWpheC9saWJzL2pxdWVyeS8xLjQuMi9qcXVlcnkubWluLmpzIj48 L3NjcmlwdD4gCiA8c2NyaXB0IHNyYz0ibWFpbi5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0i cmVzdWx0cy5qcyI+PC9zY3JpcHQ+CiA8L2JvZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9yZXN1 bHRzLmpzIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5p bmdzZXJ2ZXIvcmVzdWx0cy5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xMDM5Y2QzMjJkMWE0NmI1MWFhMjYyMWRm ZDZmZjRhNDY5NGJhMmE4Ci0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvcmVzdWx0cy5qcwpAQCAtMCwwICsx LDI3IEBACisoZnVuY3Rpb24oKSB7CisgIHZhciBURVNUX1JFU1VMVFNfU0VSVkVSID0gJ2h0dHA6 Ly90ZXN0LXJlc3VsdHMuYXBwc3BvdC5jb20vJzsKKyAgdmFyIFRFU1RfVFlQRSA9ICdsYXlvdXQt dGVzdHMnOworICB2YXIgUkVTVUxUU19OQU1FID0gJ2Z1bGxfcmVzdWx0cy5qc29uJzsKKyAgdmFy IE1BU1RFUl9OQU1FID0gJ0Nocm9taXVtV2Via2l0JzsKKworICBmdW5jdGlvbiByZXN1bHRzVVJM KGJ1aWxkZXJfbmFtZSwgbmFtZSkgeworICAgIHJldHVybiBURVNUX1JFU1VMVFNfU0VSVkVSICsg J3Rlc3RmaWxlJyArCisgICAgICAgICc/YnVpbGRlcj0nICsgYnVpbGRlcl9uYW1lICsKKyAgICAg ICAgJyZtYXN0ZXI9JyArIE1BU1RFUl9OQU1FICsKKyAgICAgICAgJyZ0ZXN0dHlwZT0nICsgVEVT VF9UWVBFICsKKyAgICAgICAgJyZuYW1lPScgKyBuYW1lOworICB9CisKKyAgZnVuY3Rpb24gZmV0 Y2hSZXN1bHRzKGJ1aWxkZXJfbmFtZSwgc3VjY2VzcykgeworICAgICQuYWpheCh7CisgICAgICB1 cmw6IHJlc3VsdHNVUkwoYnVpbGRlcl9uYW1lLCBSRVNVTFRTX05BTUUpLAorICAgICAgZGF0YVR5 cGU6ICdqc29ucCcsCisgICAgICBzdWNjZXNzOiBzdWNjZXNzCisgICAgfSk7CisgIH0KKworICBm ZXRjaFJlc3VsdHMoJ1dlYmtpdCBMaW51eCcsIGZ1bmN0aW9uKGRhdGEpIHsKKyAgICBjb25zb2xl LmxvZygiPT0gUmVzdWx0cyA9PSIpCisgICAgY29uc29sZS5sb2coZGF0YSk7CisgIH0pOworfSko KTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2dhcmRl bmluZ3NlcnZlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2dhcmRl bmluZ3NlcnZlci5weQppbmRleCA3MjA3ZTNiNDVmMmZiODk4ZTNjZTE2YTkxMmQ1NGIxZTc4NTNj NzljLi5kZjU4YWJlMDQzYTFmZWYzMzI1OWYwNjAzY2I5Y2E0Y2Q3MThlNjM4IDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9nYXJkZW5pbmdzZXJ2ZXIucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5nc2VydmVy LnB5CkBAIC0zOCw2ICszOCw3IEBAIGNsYXNzIEdhcmRlbmluZ0hUVFBSZXF1ZXN0SGFuZGxlcihS ZWZsZWN0aW9uSGFuZGxlcik6CiAgICAgU1RBVElDX0ZJTEVfTkFNRVMgPSBmcm96ZW5zZXQoWwog ICAgICAgICAiaW5kZXguaHRtbCIsCiAgICAgICAgICJtYWluLmpzIiwKKyAgICAgICAgInJlc3Vs dHMuanMiLAogICAgIF0pCiAKICAgICBTVEFUSUNfRklMRV9ESVJFQ1RPUlkgPSBvcy5wYXRoLmpv aW4ob3MucGF0aC5kaXJuYW1lKF9fZmlsZV9fKSwgImRhdGEiLCAiZ2FyZGVuaW5nc2VydmVyIikK 99766 2011-07-05 17:25:52 -0700 2011-07-05 18:18:34 -0700 Patch bug-63959-20110705172551.patch text/plain 3307 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTA0MTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1NjEyMDlkZDkyMDIxYTgxYWU3ZjhmODYzN2M1MTA4OTVm MGNjNjk1Li5kMjA0Yjk0MDMwN2FlNDFiMTZhNDI2ZDQ4YWQyOGNiZjk3YzNlNjhhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTEtMDctMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAg ICBnYXJkZW4tby1tYXRpYyBzaG91bGQga25vdyBob3cgdG8gZmV0Y2ggdGVzdCByZXN1bHRzIGZy b20gdGhlIChOUldUKSBib3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02Mzk1OQorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgorCisg ICAgICAgIEN1cnJlbnRseSwgdGhpcyBjb2RlIGp1c3QgZmV0Y2hlcyB0aGUgcmVzdWx0cyBhbmQg ZXhwZWN0YXRpb25zIEpTT04KKyAgICAgICAgYmxvYiBmb3IgTGludXggZnJvbSB0aGUgc2VydmVy IGFuZCBsb2dzIGl0IHRvIHRoZSBjb25zb2xlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvaW5kZXguaHRtbDoKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9yZXN1 bHRzLmpzOiBBZGRlZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9n YXJkZW5pbmdzZXJ2ZXIucHk6CisKKzIwMTEtMDctMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Vi a2l0Lm9yZz4KKwogICAgICAgICBBZGQgYmFzaWMgYWpheCBzdXBwb3J0IHRvIGdhcmRlbi1vLW1h dGljCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mzg3 NAogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRh L2dhcmRlbmluZ3NlcnZlci9pbmRleC5odG1sIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvaW5kZXguaHRtbAppbmRleCBhOWMyODIzYjE4 NjgyOWIwMDJlZGYzMjIwODkwNTViNDM4MDhkMzhiLi45NzNmZDQ4NDRkMDk5OWEzYWNjZDViOThh MDk4MTMzZjE3NTNiNzNkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv c2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9pbmRleC5odG1sCisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL2luZGV4Lmh0bWwK QEAgLTM1LDUgKzM1LDYgQEAgaDEgewogPC91bD4KIDxzY3JpcHQgc3JjPSJodHRwczovL2FqYXgu Z29vZ2xlYXBpcy5jb20vYWpheC9saWJzL2pxdWVyeS8xLjQuMi9qcXVlcnkubWluLmpzIj48L3Nj cmlwdD4gCiA8c2NyaXB0IHNyYz0ibWFpbi5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0icmVz dWx0cy5qcyI+PC9zY3JpcHQ+CiA8L2JvZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9yZXN1bHRz LmpzIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdz ZXJ2ZXIvcmVzdWx0cy5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wY2I5NzkyOWNlZjgzYmFmMDEyM2E3NTk1YjJi NzNlNmYwYWU2YjRhCi0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvcmVzdWx0cy5qcwpAQCAtMCwwICsxLDI3 IEBACisoZnVuY3Rpb24oKSB7CisgIHZhciBURVNUX1JFU1VMVFNfU0VSVkVSID0gJ2h0dHA6Ly90 ZXN0LXJlc3VsdHMuYXBwc3BvdC5jb20vJzsKKyAgdmFyIFRFU1RfVFlQRSA9ICdsYXlvdXQtdGVz dHMnOworICB2YXIgUkVTVUxUU19OQU1FID0gJ2Z1bGxfcmVzdWx0cy5qc29uJzsKKyAgdmFyIE1B U1RFUl9OQU1FID0gJ0Nocm9taXVtV2Via2l0JzsKKworICBmdW5jdGlvbiByZXN1bHRzVVJMKGJ1 aWxkZXJfbmFtZSwgbmFtZSkgeworICAgIHJldHVybiBURVNUX1JFU1VMVFNfU0VSVkVSICsgJ3Rl c3RmaWxlJyArCisgICAgICAgICc/YnVpbGRlcj0nICsgYnVpbGRlcl9uYW1lICsKKyAgICAgICAg JyZtYXN0ZXI9JyArIE1BU1RFUl9OQU1FICsKKyAgICAgICAgJyZ0ZXN0dHlwZT0nICsgVEVTVF9U WVBFICsKKyAgICAgICAgJyZuYW1lPScgKyBuYW1lOworICB9CisKKyAgZnVuY3Rpb24gZmV0Y2hS ZXN1bHRzKGJ1aWxkZXJfbmFtZSwgb25zdWNjZXNzKSB7CisgICAgJC5hamF4KHsKKyAgICAgIHVy bDogcmVzdWx0c1VSTChidWlsZGVyX25hbWUsIFJFU1VMVFNfTkFNRSksCisgICAgICBkYXRhVHlw ZTogJ2pzb25wJywKKyAgICAgIHN1Y2Nlc3M6IG9uc3VjY2VzcworICAgIH0pOworICB9CisKKyAg ZmV0Y2hSZXN1bHRzKCdXZWJraXQgTGludXgnLCBmdW5jdGlvbihkYXRhKSB7CisgICAgY29uc29s ZS5sb2coIj09IFJlc3VsdHMgPT0iKQorICAgIGNvbnNvbGUubG9nKGRhdGEpOworICB9KTsKK30p KCk7CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9nYXJk ZW5pbmdzZXJ2ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9nYXJk ZW5pbmdzZXJ2ZXIucHkKaW5kZXggNzIwN2UzYjQ1ZjJmYjg5OGUzY2UxNmE5MTJkNTRiMWU3ODUz Yzc5Yy4uZGY1OGFiZTA0M2ExZmVmMzMyNTlmMDYwM2NiOWNhNGNkNzE4ZTYzOCAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5nc2VydmVyLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2dhcmRlbmluZ3NlcnZl ci5weQpAQCAtMzgsNiArMzgsNyBAQCBjbGFzcyBHYXJkZW5pbmdIVFRQUmVxdWVzdEhhbmRsZXIo UmVmbGVjdGlvbkhhbmRsZXIpOgogICAgIFNUQVRJQ19GSUxFX05BTUVTID0gZnJvemVuc2V0KFsK ICAgICAgICAgImluZGV4Lmh0bWwiLAogICAgICAgICAibWFpbi5qcyIsCisgICAgICAgICJyZXN1 bHRzLmpzIiwKICAgICBdKQogCiAgICAgU1RBVElDX0ZJTEVfRElSRUNUT1JZID0gb3MucGF0aC5q b2luKG9zLnBhdGguZGlybmFtZShfX2ZpbGVfXyksICJkYXRhIiwgImdhcmRlbmluZ3NlcnZlciIp Cg==