63943 2011-07-05 09:08:29 -0700 Spelling error in v8WebSocket::constructorCallback error 2011-10-13 22:11:44 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P1 Normal --- 1 skylined abarth abarth eric webkit.review.bot oldest_to_newest 432297 0 skylined 2011-07-05 09:08:29 -0700 Adam, I think you misspelled "constructor": WebKit/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp@53: return throwError("DOM object custructor cannot be called as a function."); Repro/test: <script> try { WebSocket() } catch(e) { document.write(e.message.indexOf('custructor') == -1 ? 'PASS' : 'FAIL:' + e.message);} </script> 483611 1 110922 abarth 2011-10-13 16:18:43 -0700 Created attachment 110922 Patch 483613 2 110924 abarth 2011-10-13 16:20:02 -0700 Created attachment 110924 Patch 483761 3 110924 webkit.review.bot 2011-10-13 22:11:40 -0700 Comment on attachment 110924 Patch Clearing flags on attachment: 110924 Committed r97441: <http://trac.webkit.org/changeset/97441> 483763 4 webkit.review.bot 2011-10-13 22:11:44 -0700 All reviewed patches have been landed. Closing bug. 110922 2011-10-13 16:18:43 -0700 2011-10-13 16:19:58 -0700 Patch bug-63943-20111013161842.patch text/plain 1990 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdlYlNvY2tldEN1c3Rv bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4 V2ViU29ja2V0Q3VzdG9tLmNwcAkocmV2aXNpb24gOTc0MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9jdXN0b20vVjhXZWJTb2NrZXRDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC01Niw3ICs1Niw3IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOFdlYlNvY2tldDo6Y29uc3QK ICAgICBJTkNfU1RBVFMoIkRPTS5XZWJTb2NrZXQuQ29uc3RydWN0b3IiKTsKIAogICAgIGlmICgh YXJncy5Jc0NvbnN0cnVjdENhbGwoKSkKLSAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoIkRPTSBv YmplY3QgY3VzdHJ1Y3RvciBjYW5ub3QgYmUgY2FsbGVkIGFzIGEgZnVuY3Rpb24uIiwgVjhQcm94 eTo6VHlwZUVycm9yKTsKKyAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoIkRPTSBvYmplY3QgY29u c3RydWN0b3IgY2Fubm90IGJlIGNhbGxlZCBhcyBhIGZ1bmN0aW9uLiIsIFY4UHJveHk6OlR5cGVF cnJvcik7CiAgICAgaWYgKGFyZ3MuTGVuZ3RoKCkgPT0gMCkKICAgICAgICAgcmV0dXJuIHRocm93 RXJyb3IoIk5vdCBlbm91Z2ggYXJndW1lbnRzIiwgVjhQcm94eTo6U3ludGF4RXJyb3IpOwogCklu ZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2RvbS9jYWxsLWEtY29uc3Ry dWN0b3ItYXMtYS1mdW5jdGlvbi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9kb20vY2FsbC1hLWNvbnN0cnVjdG9yLWFzLWEtZnVu Y3Rpb24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA5NzQxNCkKKysrIExheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL2Zhc3QvZG9tL2NhbGwtYS1jb25zdHJ1Y3Rvci1hcy1hLWZ1bmN0aW9uLWV4 cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMjIsNyArMjIsNyBAQCBQQVNTIFVpbnQzMkFy cmF5KCkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFCiBQQVNTIFVpbnQ4QXJyYXkoKSB0aHJldyBleGNl cHRpb24gVHlwZUVycm9yOiBET00gb2JqZWN0IGNvbnN0cnVjdG9yIGNhbm5vdCBiZSBjYWxsZWQg YXMgYSBmdW5jdGlvbi4uCiBQQVNTIFdlYktpdENTU01hdHJpeCgpIHRocmV3IGV4Y2VwdGlvbiBU eXBlRXJyb3I6IERPTSBvYmplY3QgY29uc3RydWN0b3IgY2Fubm90IGJlIGNhbGxlZCBhcyBhIGZ1 bmN0aW9uLi4KIFBBU1MgV2ViS2l0UG9pbnQoKSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBE T00gb2JqZWN0IGNvbnN0cnVjdG9yIGNhbm5vdCBiZSBjYWxsZWQgYXMgYSBmdW5jdGlvbi4uCi1Q QVNTIFdlYlNvY2tldCgpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IERPTSBvYmplY3QgY3Vz dHJ1Y3RvciBjYW5ub3QgYmUgY2FsbGVkIGFzIGEgZnVuY3Rpb24uLgorUEFTUyBXZWJTb2NrZXQo KSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBET00gb2JqZWN0IGNvbnN0cnVjdG9yIGNhbm5v dCBiZSBjYWxsZWQgYXMgYSBmdW5jdGlvbi4uCiBQQVNTIFdvcmtlcigpIHRocmV3IGV4Y2VwdGlv biBUeXBlRXJyb3I6IERPTSBvYmplY3QgY29uc3RydWN0b3IgY2Fubm90IGJlIGNhbGxlZCBhcyBh IGZ1bmN0aW9uLi4KIFBBU1MgWE1MSHR0cFJlcXVlc3QoKSB0aHJldyBleGNlcHRpb24gVHlwZUVy cm9yOiBET00gb2JqZWN0IGNvbnN0cnVjdG9yIGNhbm5vdCBiZSBjYWxsZWQgYXMgYSBmdW5jdGlv bi4uCiBQQVNTIFhTTFRQcm9jZXNzb3IoKSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBET00g b2JqZWN0IGNvbnN0cnVjdG9yIGNhbm5vdCBiZSBjYWxsZWQgYXMgYSBmdW5jdGlvbi4uCg== 110924 2011-10-13 16:20:02 -0700 2011-10-13 22:11:40 -0700 Patch bug-63943-20111013162001.patch text/plain 3246 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3NDE5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTMgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBTcGVsbGluZyBlcnJvciBpbiB2OFdl YlNvY2tldDo6Y29uc3RydWN0b3JDYWxsYmFjayBlcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM5NDMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdHlwby4KKworICAgICAgICAqIGJpbmRpbmdz L3Y4L2N1c3RvbS9WOFdlYlNvY2tldEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFdl YlNvY2tldDo6Y29uc3RydWN0b3JDYWxsYmFjayk6CisKIDIwMTEtMTAtMTMgIEtlbnRhcm8gSGFy YSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEltcGxlbWVudCBhIEJlZm9yZUxv YWRFdmVudCBjb25zdHJ1Y3RvciBmb3IgVjgKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L2N1c3RvbS9WOFdlYlNvY2tldEN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4V2ViU29ja2V0Q3VzdG9tLmNwcAkocmV2aXNpb24g OTc0MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXZWJTb2NrZXRD dXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Niw3ICs1Niw3IEBAIHY4OjpIYW5kbGU8djg6 OlZhbHVlPiBWOFdlYlNvY2tldDo6Y29uc3QKICAgICBJTkNfU1RBVFMoIkRPTS5XZWJTb2NrZXQu Q29uc3RydWN0b3IiKTsKIAogICAgIGlmICghYXJncy5Jc0NvbnN0cnVjdENhbGwoKSkKLSAgICAg ICAgcmV0dXJuIHRocm93RXJyb3IoIkRPTSBvYmplY3QgY3VzdHJ1Y3RvciBjYW5ub3QgYmUgY2Fs bGVkIGFzIGEgZnVuY3Rpb24uIiwgVjhQcm94eTo6VHlwZUVycm9yKTsKKyAgICAgICAgcmV0dXJu IHRocm93RXJyb3IoIkRPTSBvYmplY3QgY29uc3RydWN0b3IgY2Fubm90IGJlIGNhbGxlZCBhcyBh IGZ1bmN0aW9uLiIsIFY4UHJveHk6OlR5cGVFcnJvcik7CiAgICAgaWYgKGFyZ3MuTGVuZ3RoKCkg PT0gMCkKICAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoIk5vdCBlbm91Z2ggYXJndW1lbnRzIiwg VjhQcm94eTo6U3ludGF4RXJyb3IpOwogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA5NzQxOSkKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEx LTEwLTEzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgU3BlbGxp bmcgZXJyb3IgaW4gdjhXZWJTb2NrZXQ6OmNvbnN0cnVjdG9yQ2FsbGJhY2sgZXJyb3IKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzOTQzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJv bWl1bS9mYXN0L2RvbS9jYWxsLWEtY29uc3RydWN0b3ItYXMtYS1mdW5jdGlvbi1leHBlY3RlZC50 eHQ6CisKIDIwMTEtMTAtMTMgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIEltcGxlbWVudCBhIEJlZm9yZUxvYWRFdmVudCBjb25zdHJ1Y3RvciBmb3IgVjgK SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZG9tL2NhbGwtYS1jb25z dHJ1Y3Rvci1hcy1hLWZ1bmN0aW9uLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2RvbS9jYWxsLWEtY29uc3RydWN0b3ItYXMtYS1m dW5jdGlvbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDk3NDE0KQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vZmFzdC9kb20vY2FsbC1hLWNvbnN0cnVjdG9yLWFzLWEtZnVuY3Rpb24t ZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yMiw3ICsyMiw3IEBAIFBBU1MgVWludDMy QXJyYXkoKSB0aHJldyBleGNlcHRpb24gVHlwZUUKIFBBU1MgVWludDhBcnJheSgpIHRocmV3IGV4 Y2VwdGlvbiBUeXBlRXJyb3I6IERPTSBvYmplY3QgY29uc3RydWN0b3IgY2Fubm90IGJlIGNhbGxl ZCBhcyBhIGZ1bmN0aW9uLi4KIFBBU1MgV2ViS2l0Q1NTTWF0cml4KCkgdGhyZXcgZXhjZXB0aW9u IFR5cGVFcnJvcjogRE9NIG9iamVjdCBjb25zdHJ1Y3RvciBjYW5ub3QgYmUgY2FsbGVkIGFzIGEg ZnVuY3Rpb24uLgogUEFTUyBXZWJLaXRQb2ludCgpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6 IERPTSBvYmplY3QgY29uc3RydWN0b3IgY2Fubm90IGJlIGNhbGxlZCBhcyBhIGZ1bmN0aW9uLi4K LVBBU1MgV2ViU29ja2V0KCkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogRE9NIG9iamVjdCBj dXN0cnVjdG9yIGNhbm5vdCBiZSBjYWxsZWQgYXMgYSBmdW5jdGlvbi4uCitQQVNTIFdlYlNvY2tl dCgpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IERPTSBvYmplY3QgY29uc3RydWN0b3IgY2Fu bm90IGJlIGNhbGxlZCBhcyBhIGZ1bmN0aW9uLi4KIFBBU1MgV29ya2VyKCkgdGhyZXcgZXhjZXB0 aW9uIFR5cGVFcnJvcjogRE9NIG9iamVjdCBjb25zdHJ1Y3RvciBjYW5ub3QgYmUgY2FsbGVkIGFz IGEgZnVuY3Rpb24uLgogUEFTUyBYTUxIdHRwUmVxdWVzdCgpIHRocmV3IGV4Y2VwdGlvbiBUeXBl RXJyb3I6IERPTSBvYmplY3QgY29uc3RydWN0b3IgY2Fubm90IGJlIGNhbGxlZCBhcyBhIGZ1bmN0 aW9uLi4KIFBBU1MgWFNMVFByb2Nlc3NvcigpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IERP TSBvYmplY3QgY29uc3RydWN0b3IgY2Fubm90IGJlIGNhbGxlZCBhcyBhIGZ1bmN0aW9uLi4K