63925 2011-07-05 01:17:32 -0700 [V8][Chromium] Remove use of OwnHandle from V8LocalContext 2011-07-05 15:18:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hans hans abarth dslomov webkit.review.bot oldest_to_newest 432144 0 hans 2011-07-05 01:17:32 -0700 [V8][Chromium] Remove use of OwnHandle from V8LocalContext 432146 1 99677 hans 2011-07-05 01:22:44 -0700 Created attachment 99677 Patch 432148 2 hans 2011-07-05 01:24:51 -0700 Uploaded as per the discussion in Bug 62345. 432350 3 dslomov 2011-07-05 11:36:35 -0700 (In reply to comment #2) > Uploaded as per the discussion in Bug 62345. LGTM. Just to note, it is still unclear why OwnHandle does not do the job - I will investigate this more. > Source/WebCore/bindings/v8/V8Utilities.cpp:52 > + : m_context(v8::Context::New()) It does not matter one bit currently, but logically we want to do any V8 operations (including newing up the context) after we ensure that V8BindingPerIsolateData is initialized. 432414 4 abarth 2011-07-05 14:47:37 -0700 > It does not matter one bit currently, but logically we want to do any V8 operations (including newing up the context) after we ensure that V8BindingPerIsolateData is initialized. So you're saying we shouldn't do this in the initializer list? 432427 5 99677 webkit.review.bot 2011-07-05 15:13:55 -0700 Comment on attachment 99677 Patch Clearing flags on attachment: 99677 Committed r90407: <http://trac.webkit.org/changeset/90407> 432428 6 webkit.review.bot 2011-07-05 15:13:59 -0700 All reviewed patches have been landed. Closing bug. 432433 7 dslomov 2011-07-05 15:18:54 -0700 (In reply to comment #4) > > It does not matter one bit currently, but logically we want to do any V8 operations (including newing up the context) after we ensure that V8BindingPerIsolateData is initialized. > > So you're saying we shouldn't do this in the initializer list? In the Grand Scheme Of Things (TM), yes, but it does not matter as of today. 99677 2011-07-05 01:22:44 -0700 2011-07-05 15:13:55 -0700 Patch bug-63925-20110705092243.patch text/plain 2528 hans U3VidmVyc2lvbiBSZXZpc2lvbjogOTAzODQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlZDJlZTE3NTMyNDdmYWFh NzU1OWRhN2JkNzMzNjUzMzNhZGIzZTFkLi4wNmI1MjY2MjJjMTdkZmY2OGZkNWY2ZDc0YzhlODg4 NDUyOGMwODRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDctMDUgIEhhbnMg V2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdW0Nocm9taXVtXSBS ZW1vdmUgdXNlIG9mIE93bkhhbmRsZSBmcm9tIFY4TG9jYWxDb250ZXh0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzkyNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2UgdGhlIE93bkhhbmRsZTw+ IG1lbWJlciBpbiBWOExvY2FsQ29udGV4dCB3aXRoCisgICAgICAgIHY4OjpQZXJzaXN0ZW50PHY4 OjpDb250ZXh0Pi4KKyAgICAgICAgVGhlIGNvZGUgdGhhdCB1c2VkIE93bkhhbmRsZTw+IHdvdWxk IG5vdCBjb3JyZWN0bHkgRGlzcG9zZQorICAgICAgICBvZiB0aGUgQ29udGV4dCwgd2hpY2ggd291 bGQgY2F1c2UgdGhlIG1lbW9yeSB0byBmaWxsIHVwIHdoZW4gY3JlYXRpbmcKKyAgICAgICAgYW5k IGRlc3RydWN0aW5nIG1hbnkgVjhMb2NhbENvbnRleHQgb2JqZWN0cywgc3VjaCBhcyBpbiB0aGUg Y2FzZQorICAgICAgICBvZiBJbmRleGVkREIuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFV0 aWxpdGllcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOExvY2FsQ29udGV4dDo6VjhMb2NhbENv bnRleHQpOgorICAgICAgICAoV2ViQ29yZTo6VjhMb2NhbENvbnRleHQ6On5WOExvY2FsQ29udGV4 dCk6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhVdGlsaXRpZXMuaDoKKwogMjAxMS0wNy0wNCAg RG9taW5pYyBDb29uZXkgICA8ZG9taW5pY2NAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFNpbXBs aWZ5IDxwcm9ncmVzcz4gZWxlbWVudCdzIGlzRGV0ZXJtaW5hdGUgbG9naWMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFV0aWxpdGllcy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOFV0aWxpdGllcy5jcHAKaW5kZXggNDkwY2I3NDg1NzkyZmNlYjQz M2UyNzNmMzRlZThmZTY4NzMzYmMxMS4uNGY3ODNiNjE1M2UzNThjMWEzZmI4NzQyMjAwMTA3YjBl MjQ0YjhlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhVdGlsaXRp ZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmNwcApA QCAtNDksMTYgKzQ5LDE3IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFY4TG9jYWxDb250ZXh0 OjpWOExvY2FsQ29udGV4dCgpCisgICAgOiBtX2NvbnRleHQodjg6OkNvbnRleHQ6Ok5ldygpKQog ewogICAgIFY4QmluZGluZ1Blcklzb2xhdGVEYXRhOjplbnN1cmVJbml0aWFsaXplZCh2ODo6SXNv bGF0ZTo6R2V0Q3VycmVudCgpKTsKLSAgICBtX2NvbnRleHQuc2V0KHY4OjpDb250ZXh0OjpOZXco KSk7Ci0gICAgbV9jb250ZXh0LmdldCgpLT5FbnRlcigpOworICAgIG1fY29udGV4dC0+RW50ZXIo KTsKIH0KIAogCi1WOExvY2FsQ29udGV4dDo6flY4TG9jYWxDb250ZXh0KCkgCitWOExvY2FsQ29u dGV4dDo6flY4TG9jYWxDb250ZXh0KCkKIHsKLSAgICBtX2NvbnRleHQuZ2V0KCktPkV4aXQoKTsK KyAgICBtX2NvbnRleHQtPkV4aXQoKTsKKyAgICBtX2NvbnRleHQuRGlzcG9zZSgpOwogfQogCiAv LyBVc2UgYW4gYXJyYXkgdG8gaG9sZCBkZXBlbmRlbnRzLiBJdCB3b3JrcyBsaWtlIGEgcmVmLWNv dW50ZWQgc2NoZW1lLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhV dGlsaXRpZXMuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmgKaW5k ZXggNmY0ODkwNzNlYjgzYTI4YTkxYjE1YzllNDU1ZGNjNDM2NGNiOTczNy4uYzIxNzk2NDg2MWFi ZWJhNDQxMzVlNmI2YmI5NjZkZTUzM2Y0YzhmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhVdGlsaXRpZXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOFV0aWxpdGllcy5oCkBAIC03MSw3ICs3MSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAg ICAgICAgdmlydHVhbCB+VjhMb2NhbENvbnRleHQoKTsKICAgICBwcml2YXRlOgogICAgICAgICB2 ODo6SGFuZGxlU2NvcGUgbV9oYW5kbGVTY29wZTsKLSAgICAgICAgT3duSGFuZGxlPHY4OjpDb250 ZXh0PiBtX2NvbnRleHQ7CisgICAgICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpDb250ZXh0PiBtX2Nv bnRleHQ7CiAgICAgfTsKIAogICAgIC8vICdGdW5jdGlvbk9ubHknIGlzIGFzc3VtZWQgZm9yIHRo ZSBjcmVhdGVkIGNhbGxiYWNrLgo=