63919 2011-07-04 16:07:32 -0700 WebKitGtk+ fails to build on win32 against GTK3 2012-03-08 11:15:28 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 0 greg.hellings webkit-unassigned erik-webkit gustavo kalevlember webkit.review.bot oldest_to_newest 432061 0 greg.hellings 2011-07-04 16:07:32 -0700 I am attempting to build webkit-1.4.2 against GTK3 cross-compiling from Fedora Core 15 with the mingw32 toolchain. After fixing a bug with the gtk3 missing gdk/win32 headers, I am attempting to compile webkitgtk against gtk3. Compile fails with the following message: CXX Source/WebCore/plugins/gtk/libwebkitgtk_3_0_la-PluginViewGtk.lo Source/WebCore/plugins/gtk/PluginViewGtk.cpp: In member function 'bool WebCore::PluginView::platformStart()': Source/WebCore/plugins/gtk/PluginViewGtk.cpp:834:42: error: 'gtk_socket_new' was not declared in this scope GtkSocket is not available with the gdk/win32 backend, only with X11. 443888 1 102346 mikkel 2011-07-29 04:50:54 -0700 Created attachment 102346 Don't use gtk_socket_new Don't use gtk_socket_new if using GDK_WINDOWING_WIN32 and GTK3, since GtkSocket is X11 only in Gtk3 Not sure it will work, but it compiles. 459507 2 kalevlember 2011-08-31 01:14:51 -0700 If you want to get the patch included, should format it with svn-create-patch as described in http://www.webkit.org/coding/contributing.html and raise the review? flag. 571735 3 102346 gustavo 2012-03-06 04:44:15 -0800 Comment on attachment 102346 Don't use gtk_socket_new View in context: https://bugs.webkit.org/attachment.cgi?id=102346&action=review > webkit-1.4.2/Source/WebCore/plugins/gtk/PluginViewGtk.cpp:830 > +#if defined(GDK_WINDOWING_WIN32) && !defined(GTK_API_VERSION_2) > + setPlatformWidget(0); This should be #if PLATFORM(WINDOWS) instead of GDK_WINDOWING_WIN32, I think. 1.4.2 is very old, but this patch seems to be still necessary. It needs to be fixed to build on master, and have a ChangeLog entry like kalev mentioned. 573895 4 130835 tuxator 2012-03-08 10:02:18 -0800 Created attachment 130835 Updated patch with changelog entry 573896 5 webkit.review.bot 2012-03-08 10:04:20 -0800 Attachment 130835 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 573910 6 130841 tuxator 2012-03-08 10:21:06 -0800 Created attachment 130841 Updated patch with changelog entry 573979 7 130841 webkit.review.bot 2012-03-08 11:15:23 -0800 Comment on attachment 130841 Updated patch with changelog entry Clearing flags on attachment: 130841 Committed r110178: <http://trac.webkit.org/changeset/110178> 573981 8 webkit.review.bot 2012-03-08 11:15:28 -0800 All reviewed patches have been landed. Closing bug. 102346 2011-07-29 04:50:54 -0700 2012-03-06 04:44:15 -0800 Don't use gtk_socket_new webkit-1.4.2-mingw-gtk3.patch text/plain 696 mikkel ZGlmZiAtTnVyIHdlYmtpdC0xLjQuMi5vcmlnL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1Bs dWdpblZpZXdHdGsuY3BwIHdlYmtpdC0xLjQuMi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2d0ay9Q bHVnaW5WaWV3R3RrLmNwcAotLS0gd2Via2l0LTEuNC4yLm9yaWcvU291cmNlL1dlYkNvcmUvcGx1 Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAJMjAxMS0wNi0zMCAyMToyNDo1MC4wMDAwMDAwMDAg KzAyMDAKKysrIHdlYmtpdC0xLjQuMi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5W aWV3R3RrLmNwcAkyMDExLTA3LTI5IDEzOjIxOjQwLjk2OTA1NTA5NSArMDIwMApAQCAtODI2LDcg KzgyNiwxMSBAQAogICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIHNldFBsYXRmb3JtV2lkZ2V0 KGd0a194dGJpbl9uZXcocGFnZUNsaWVudCwgMCkpOwogI2Vsc2UKKyNpZiBkZWZpbmVkKEdES19X SU5ET1dJTkdfV0lOMzIpICYmICFkZWZpbmVkKEdUS19BUElfVkVSU0lPTl8yKQorICAgICAgICBz ZXRQbGF0Zm9ybVdpZGdldCgwKTsKKyNlbHNlCiAgICAgICAgIHNldFBsYXRmb3JtV2lkZ2V0KGd0 a19zb2NrZXRfbmV3KCkpOworI2VuZGlmCiAgICAgICAgIGd0a19jb250YWluZXJfYWRkKEdUS19D T05UQUlORVIocGFnZUNsaWVudCksIHBsYXRmb3JtUGx1Z2luV2lkZ2V0KCkpOwogI2VuZGlmCiAg ICAgfSBlbHNlIHsK 130835 2012-03-08 10:02:18 -0800 2012-03-08 10:21:06 -0800 Updated patch with changelog entry compile_on_gtk3.diff text/plain 1292 tuxator ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYTlmOWZkLi5lZTU0NWY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDMtMDggIE1pa2tlbCBLcnVzZSBKb2huc2VuICA8bWlra2VsQGxpbmV0LmRrPgor CisgICAgICAgIFdlYktpdEd0aysgZmFpbHMgdG8gYnVpbGQgb24gd2luMzIgYWdhaW5zdCBHVEsz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzkxOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4KKworICAgICAgICAqIHBsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwOiBEb24ndCB1 c2UgZ3RrX3NvY2tldF9uZXcgd2l0aCBHVEszIG9uCisJV2luMzIKKyAgICAgICAgKFdlYkNvcmU6 OlBsdWdpblZpZXc6OnBsYXRmb3JtU3RhcnQpOgorCiAyMDEyLTAzLTA4ICBSb2JpbiBDYW8gIDxy b2Jpbi5jYW9AdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBVcHN0 cmVhbSBXZWJHTCByZWxhdGVkIGZpbGVzIGZyb20gcGxhdGZvcm0vZ3JhcGhpY3MKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwIGIvU291cmNl L1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKaW5kZXggM2VmMjAzZi4uYzU2 OGE0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0 ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAK QEAgLTg4NCw3ICs4ODQsMTEgQEAgYm9vbCBQbHVnaW5WaWV3OjpwbGF0Zm9ybVN0YXJ0KCkKICAg ICAgICAgfSBlbHNlCiAgICAgICAgICAgICBzZXRQbGF0Zm9ybVdpZGdldChndGtfeHRiaW5fbmV3 KHBhZ2VDbGllbnQsIDApKTsKICNlbHNlCisjaWYgT1MoV0lORE9XUykgJiYgIWRlZmluZWQoR1RL X0FQSV9WRVJTSU9OXzIpCisgICAgICAgIHNldFBsYXRmb3JtV2lkZ2V0KDApOworI2Vsc2UKICAg ICAgICAgc2V0UGxhdGZvcm1XaWRnZXQoZ3RrX3NvY2tldF9uZXcoKSk7CisjZW5kaWYKICAgICAg ICAgZ3RrX2NvbnRhaW5lcl9hZGQoR1RLX0NPTlRBSU5FUihwYWdlQ2xpZW50KSwgcGxhdGZvcm1Q bHVnaW5XaWRnZXQoKSk7CiAjZW5kaWYKICAgICB9IGVsc2Ugewo= 130841 2012-03-08 10:21:06 -0800 2012-03-08 11:15:22 -0800 Updated patch with changelog entry compile_on_gtk3.diff text/plain 1265 tuxator ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYTlmOWZkLi5kMWYyM2IzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTItMDMtMDggIE1pa2tlbCBLcnVzZSBKb2huc2VuICA8bWlra2VsQGxpbmV0LmRrPgor CisgICAgICAgIFdlYktpdEd0aysgZmFpbHMgdG8gYnVpbGQgb24gd2luMzIgYWdhaW5zdCBHVEsz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzkxOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGx1Z2lu cy9ndGsvUGx1Z2luVmlld0d0ay5jcHA6IERvbid0IHVzZSBndGtfc29ja2V0X25ldyB3aXRoIEdU SzMgb24gV2luMzIKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnBsYXRmb3JtU3RhcnQp OgorCiAyMDEyLTAzLTA4ICBSb2JpbiBDYW8gIDxyb2Jpbi5jYW9AdG9yY2htb2JpbGUuY29tLmNu PgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBVcHN0cmVhbSBXZWJHTCByZWxhdGVkIGZpbGVzIGZy b20gcGxhdGZvcm0vZ3JhcGhpY3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMv Z3RrL1BsdWdpblZpZXdHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2lu Vmlld0d0ay5jcHAKaW5kZXggM2VmMjAzZi4uYzU2OGE0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKQEAgLTg4NCw3ICs4ODQsMTEgQEAgYm9vbCBQ bHVnaW5WaWV3OjpwbGF0Zm9ybVN0YXJ0KCkKICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICBz ZXRQbGF0Zm9ybVdpZGdldChndGtfeHRiaW5fbmV3KHBhZ2VDbGllbnQsIDApKTsKICNlbHNlCisj aWYgT1MoV0lORE9XUykgJiYgIWRlZmluZWQoR1RLX0FQSV9WRVJTSU9OXzIpCisgICAgICAgIHNl dFBsYXRmb3JtV2lkZ2V0KDApOworI2Vsc2UKICAgICAgICAgc2V0UGxhdGZvcm1XaWRnZXQoZ3Rr X3NvY2tldF9uZXcoKSk7CisjZW5kaWYKICAgICAgICAgZ3RrX2NvbnRhaW5lcl9hZGQoR1RLX0NP TlRBSU5FUihwYWdlQ2xpZW50KSwgcGxhdGZvcm1QbHVnaW5XaWRnZXQoKSk7CiAjZW5kaWYKICAg ICB9IGVsc2Ugewo=