63893 2011-07-04 01:38:36 -0700 Make "Add optimised paths for a few maths functions" work on Qt 2011-07-05 18:20:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 63757 1 zherczeg webkit-unassigned abecsi barraclough eric loki oliver webkit.review.bot oldest_to_newest 431839 0 zherczeg 2011-07-04 01:38:36 -0700 Make it works! 431849 1 99610 zherczeg 2011-07-04 02:00:08 -0700 Created attachment 99610 patch 431852 2 99610 loki 2011-07-04 02:10:18 -0700 Comment on attachment 99610 patch View in context: https://bugs.webkit.org/attachment.cgi?id=99610&action=review > Source/JavaScriptCore/ChangeLog:8 > + Move the generated code to the .text section instead of .data section. Nice catch! Would it make sense to try this optimization on ARM? 431910 3 zherczeg 2011-07-04 06:32:07 -0700 > Would it make sense to try this optimization on ARM? We need to detect whether hard or softfp ABI is present. Hopefully the compiler will tell us... 431960 4 99610 oliver 2011-07-04 09:26:46 -0700 Comment on attachment 99610 patch View in context: https://bugs.webkit.org/attachment.cgi?id=99610&action=review > Source/JavaScriptCore/jit/ThunkGenerators.cpp:142 > + "jmp " SYMBOL_STRING_RELOCATION(function) "\n" \ Changing this to a jump will misalign the stack on x86_32/mac are you sure it's not complaining about it? 431966 5 zherczeg 2011-07-04 09:46:56 -0700 > Changing this to a jump will misalign the stack on x86_32/mac are you sure it's not complaining about it? Misalign? Why? Keeps 8 byte alignment, even if you don't push an extra 8 byte return address to it. Or is that 16 byte aligned? I don't know about mac ABI. 432004 6 oliver 2011-07-04 11:55:35 -0700 (In reply to comment #5) > > Changing this to a jump will misalign the stack on x86_32/mac are you sure it's not complaining about it? > > Misalign? Why? Keeps 8 byte alignment, even if you don't push an extra 8 byte return address to it. Or is that 16 byte aligned? I don't know about mac ABI. Mac ABI requires 16byte alignment 432009 7 zherczeg 2011-07-04 12:33:35 -0700 > Mac ABI requires 16byte alignment thanks for letting me know. Tomorrow I will put it back and resubmit the patch. 432171 8 99685 zherczeg 2011-07-05 02:23:13 -0700 Created attachment 99685 updated patch 432517 9 eric 2011-07-05 18:08:46 -0700 Seems reasonable to me, but the real JSC experts shoudl comment. 432523 10 99685 webkit.review.bot 2011-07-05 18:20:39 -0700 Comment on attachment 99685 updated patch Clearing flags on attachment: 99685 Committed r90425: <http://trac.webkit.org/changeset/90425> 432524 11 webkit.review.bot 2011-07-05 18:20:44 -0700 All reviewed patches have been landed. Closing bug. 99610 2011-07-04 02:00:08 -0700 2011-07-05 02:23:13 -0700 patch 0001-math.patch text/plain 3114 zherczeg RnJvbSBlMGIwMWUyZWNjYTQwYWU3Mzg5NzhkNjM4MDA5Njg0OTkyOWQwNWZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBNb24sIDQgSnVsIDIwMTEgMDE6NTM6MDcgLTA3MDAKU3ViamVjdDogW1BBVENI XSBtYXRoCgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICB8ICAgMTMgKysrKysrKysrKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2Vu ZXJhdG9ycy5jcHAgfCAgIDI3ICsrKysrKysrKysrKystLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hh bmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKaW5kZXggYjBjYjRlMS4uZGU1MjY5ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMDQgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAaW5m LnUtc3plZ2VkLmh1PgorCisgICAgICAgIE1ha2UgIkFkZCBvcHRpbWlzZWQgcGF0aHMgZm9yIGEg ZmV3IG1hdGhzIGZ1bmN0aW9ucyIgd29yayBvbiBRdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM4OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIHRoZSBnZW5lcmF0ZWQgY29kZSB0byB0aGUgLnRl eHQgc2VjdGlvbiBpbnN0ZWFkIG9mIC5kYXRhIHNlY3Rpb24uCisgICAgICAgIENoYW5nZSB0aGUg NjQgYml0IHRodW5rIGNvZGUgdG8gYSB0YWlsIGNhbGwuCisgICAgICAgIEZpeCBhbGlnbm1lbnQg Zm9yIHRoZSAzMiBiaXQgdGh1bmsgY29kZS4KKworICAgICAgICAqIGppdC9UaHVua0dlbmVyYXRv cnMuY3BwOgorCiAyMDExLTA3LTAzICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFw cGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjM4NzkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5l cmF0b3JzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNw cAppbmRleCBmZGNlOTM4Li45M2MwODZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9UaHVua0dlbmVyYXRvcnMuY3BwCkBAIC0xMzIsMzIgKzEzMiwzMyBAQCBkb3VibGUganNSb3Vu ZChkb3VibGUgZCkKIAogfQogICAgIAotI2lmIENQVShYODZfNjQpICYmIENPTVBJTEVSKEdDQykg JiYgUExBVEZPUk0oTUFDKQorI2lmIENQVShYODZfNjQpICYmIENPTVBJTEVSKEdDQykgJiYgKFBM QVRGT1JNKE1BQykgfHwgUExBVEZPUk0oUVQpKQogCiAjZGVmaW5lIGRlZmluZVVuYXJ5RG91Ymxl T3BXcmFwcGVyKGZ1bmN0aW9uKSBcCiAgICAgYXNtKCBcCisgICAgICAgICIudGV4dFxuIiBcCiAg ICAgICAgICIuZ2xvYmwgIiBTWU1CT0xfU1RSSU5HKGZ1bmN0aW9uIyNUaHVuaykgIlxuIiBcCiAg ICAgICAgIFNZTUJPTF9TVFJJTkcoZnVuY3Rpb24jI1RodW5rKSAiOiIgIlxuIiBcCi0gICAgICAg ICJjYWxsICIgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKGZ1bmN0aW9uKSAiXG4iIFwKLSAgICAg ICAgInJldFxuIiBcCisgICAgICAgICJqbXAgIiBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04oZnVu Y3Rpb24pICJcbiIgXAogICAgICk7XAogICAgIGV4dGVybiAiQyIgeyBcCiAgICAgICAgIE1hdGhU aHVua0NhbGxpbmdDb252ZW50aW9uIGZ1bmN0aW9uIyNUaHVuayhNYXRoVGh1bmtDYWxsaW5nQ29u dmVudGlvbik7IFwKICAgICB9IFwKICAgICBzdGF0aWMgTWF0aFRodW5rIFVuYXJ5RG91YmxlT3BX cmFwcGVyKGZ1bmN0aW9uKSA9ICZmdW5jdGlvbiMjVGh1bms7CiAKLSNlbGlmIENQVShYODYpICYm IENPTVBJTEVSKEdDQykgJiYgUExBVEZPUk0oTUFDKQorI2VsaWYgQ1BVKFg4NikgJiYgQ09NUElM RVIoR0NDKSAmJiAoUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShRVCkpCiAjZGVmaW5lIGRlZmlu ZVVuYXJ5RG91YmxlT3BXcmFwcGVyKGZ1bmN0aW9uKSBcCiAgICAgYXNtKCBcCi0gICAgICAgICAi Lmdsb2JsICIgU1lNQk9MX1NUUklORyhmdW5jdGlvbiMjVGh1bmspICJcbiIgXAotICAgICAgICAg U1lNQk9MX1NUUklORyhmdW5jdGlvbiMjVGh1bmspICI6IiAiXG4iIFwKLSAgICAgICAgICJzdWJs ICQ4LCAlZXNwXG4iIFwKLSAgICAgICAgICJtb3ZzZCAleG1tMCwgKCVlc3ApIFxuIiBcCi0gICAg ICAgICAiY2FsbCAiIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihmdW5jdGlvbikgIlxuIiBcCi0g ICAgICAgICAiZnN0cGwgKCVlc3ApIFxuIiBcCi0gICAgICAgICAibW92c2QgKCVlc3ApLCAleG1t MCBcbiIgXAotICAgICAgICAgImFkZGwgJDgsICVlc3BcbiIgXAotICAgICAgICAgInJldFxuIiBc CisgICAgICAgICIudGV4dFxuIiBcCisgICAgICAgICIuZ2xvYmwgIiBTWU1CT0xfU1RSSU5HKGZ1 bmN0aW9uIyNUaHVuaykgIlxuIiBcCisgICAgICAgIFNZTUJPTF9TVFJJTkcoZnVuY3Rpb24jI1Ro dW5rKSAiOiIgIlxuIiBcCisgICAgICAgICJzdWJsICQ4LCAlZXNwXG4iIFwKKyAgICAgICAgIm1v dnNkICV4bW0wLCAoJWVzcCkgXG4iIFwKKyAgICAgICAgImNhbGwgIiBTWU1CT0xfU1RSSU5HX1JF TE9DQVRJT04oZnVuY3Rpb24pICJcbiIgXAorICAgICAgICAiZnN0cGwgKCVlc3ApIFxuIiBcCisg ICAgICAgICJtb3ZzZCAoJWVzcCksICV4bW0wIFxuIiBcCisgICAgICAgICJhZGRsICQ4LCAlZXNw XG4iIFwKKyAgICAgICAgInJldFxuIiBcCiAgICAgKTtcCiAgICAgZXh0ZXJuICJDIiB7IFwKICAg ICAgICAgTWF0aFRodW5rQ2FsbGluZ0NvbnZlbnRpb24gZnVuY3Rpb24jI1RodW5rKE1hdGhUaHVu a0NhbGxpbmdDb252ZW50aW9uKTsgXAotLSAKMS43LjIuMwoK 99685 2011-07-05 02:23:13 -0700 2011-07-05 18:20:39 -0700 updated patch 0001-math.patch text/plain 2911 zherczeg RnJvbSBmMGEyZjUyZTQ0N2QzNmU1NmFiZDlmYWQ0ZjIwZDE1YTE0ODdmOWEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBUdWUsIDUgSnVsIDIwMTEgMDI6MjA6MTEgLTA3MDAKU3ViamVjdDogW1BBVENI XSBtYXRoCgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICB8ICAgMTIgKysrKysrKysrKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2Vu ZXJhdG9ycy5jcHAgfCAgIDI0ICsrKysrKysrKysrKystLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFu Z2VkLCAyNSBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwppbmRleCBiMGNiNGUxLi44ZWQ3MzdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wNy0wNCAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0BpbmYu dS1zemVnZWQuaHU+CisKKyAgICAgICAgTWFrZSAiQWRkIG9wdGltaXNlZCBwYXRocyBmb3IgYSBm ZXcgbWF0aHMgZnVuY3Rpb25zIiB3b3JrIG9uIFF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mzg5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgdGhlIGdlbmVyYXRlZCBjb2RlIHRvIHRoZSAudGV4 dCBzZWN0aW9uIGluc3RlYWQgb2YgLmRhdGEgc2VjdGlvbi4KKyAgICAgICAgRml4IGFsaWdubWVu dCBmb3IgdGhlIDMyIGJpdCB0aHVuayBjb2RlLgorCisgICAgICAgICogaml0L1RodW5rR2VuZXJh dG9ycy5jcHA6CisKIDIwMTEtMDctMDMgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hA YXBwbGUuY29tPgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02Mzg3OQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dl bmVyYXRvcnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMu Y3BwCmluZGV4IGZkY2U5MzguLjNiYzZmNWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L1RodW5rR2VuZXJhdG9ycy5jcHAKQEAgLTEzMiwxMCArMTMyLDExIEBAIGRvdWJsZSBqc1Jv dW5kKGRvdWJsZSBkKQogCiB9CiAgICAgCi0jaWYgQ1BVKFg4Nl82NCkgJiYgQ09NUElMRVIoR0ND KSAmJiBQTEFURk9STShNQUMpCisjaWYgQ1BVKFg4Nl82NCkgJiYgQ09NUElMRVIoR0NDKSAmJiAo UExBVEZPUk0oTUFDKSB8fCBPUyhMSU5VWCkpCiAKICNkZWZpbmUgZGVmaW5lVW5hcnlEb3VibGVP cFdyYXBwZXIoZnVuY3Rpb24pIFwKICAgICBhc20oIFwKKyAgICAgICAgIi50ZXh0XG4iIFwKICAg ICAgICAgIi5nbG9ibCAiIFNZTUJPTF9TVFJJTkcoZnVuY3Rpb24jI1RodW5rKSAiXG4iIFwKICAg ICAgICAgU1lNQk9MX1NUUklORyhmdW5jdGlvbiMjVGh1bmspICI6IiAiXG4iIFwKICAgICAgICAg ImNhbGwgIiBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04oZnVuY3Rpb24pICJcbiIgXApAQCAtMTQ2 LDE4ICsxNDcsMTkgQEAgZG91YmxlIGpzUm91bmQoZG91YmxlIGQpCiAgICAgfSBcCiAgICAgc3Rh dGljIE1hdGhUaHVuayBVbmFyeURvdWJsZU9wV3JhcHBlcihmdW5jdGlvbikgPSAmZnVuY3Rpb24j I1RodW5rOwogCi0jZWxpZiBDUFUoWDg2KSAmJiBDT01QSUxFUihHQ0MpICYmIFBMQVRGT1JNKE1B QykKKyNlbGlmIENQVShYODYpICYmIENPTVBJTEVSKEdDQykgJiYgKFBMQVRGT1JNKE1BQykgfHwg T1MoTElOVVgpKQogI2RlZmluZSBkZWZpbmVVbmFyeURvdWJsZU9wV3JhcHBlcihmdW5jdGlvbikg XAogICAgIGFzbSggXAotICAgICAgICAgIi5nbG9ibCAiIFNZTUJPTF9TVFJJTkcoZnVuY3Rpb24j I1RodW5rKSAiXG4iIFwKLSAgICAgICAgIFNZTUJPTF9TVFJJTkcoZnVuY3Rpb24jI1RodW5rKSAi OiIgIlxuIiBcCi0gICAgICAgICAic3VibCAkOCwgJWVzcFxuIiBcCi0gICAgICAgICAibW92c2Qg JXhtbTAsICglZXNwKSBcbiIgXAotICAgICAgICAgImNhbGwgIiBTWU1CT0xfU1RSSU5HX1JFTE9D QVRJT04oZnVuY3Rpb24pICJcbiIgXAotICAgICAgICAgImZzdHBsICglZXNwKSBcbiIgXAotICAg ICAgICAgIm1vdnNkICglZXNwKSwgJXhtbTAgXG4iIFwKLSAgICAgICAgICJhZGRsICQ4LCAlZXNw XG4iIFwKLSAgICAgICAgICJyZXRcbiIgXAorICAgICAgICAiLnRleHRcbiIgXAorICAgICAgICAi Lmdsb2JsICIgU1lNQk9MX1NUUklORyhmdW5jdGlvbiMjVGh1bmspICJcbiIgXAorICAgICAgICBT WU1CT0xfU1RSSU5HKGZ1bmN0aW9uIyNUaHVuaykgIjoiICJcbiIgXAorICAgICAgICAic3VibCAk OCwgJWVzcFxuIiBcCisgICAgICAgICJtb3ZzZCAleG1tMCwgKCVlc3ApIFxuIiBcCisgICAgICAg ICJjYWxsICIgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKGZ1bmN0aW9uKSAiXG4iIFwKKyAgICAg ICAgImZzdHBsICglZXNwKSBcbiIgXAorICAgICAgICAibW92c2QgKCVlc3ApLCAleG1tMCBcbiIg XAorICAgICAgICAiYWRkbCAkOCwgJWVzcFxuIiBcCisgICAgICAgICJyZXRcbiIgXAogICAgICk7 XAogICAgIGV4dGVybiAiQyIgeyBcCiAgICAgICAgIE1hdGhUaHVua0NhbGxpbmdDb252ZW50aW9u IGZ1bmN0aW9uIyNUaHVuayhNYXRoVGh1bmtDYWxsaW5nQ29udmVudGlvbik7IFwKLS0gCjEuNy4y LjMKCg==