63889 2011-07-03 22:46:40 -0700 HTMLProgressElement implementation should be simplified 2011-07-04 21:21:42 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dominicc dominicc morrita tkent webkit.review.bot oldest_to_newest 431811 0 dominicc 2011-07-03 22:46:40 -0700 Per the thread on bug 63861, progress element should be indeterminate when the value attribute is missing, per the spec here: <http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-progress-element> As is, HTMLProgressElement::isDeterminate tests whether the value is specified, and also < max. 431903 1 dominicc 2011-07-04 06:24:42 -0700 It duplicates the logic for isDeterminate, uses slower attribute accessors than is necessary, and checks an impossible case (InvalidPosition) only used in its RenderProgress. I originally thought that this was buggy, however I don’t believe it is—just slightly obfuscated. Should HTMLProgressElement::InvalidPosition be deported to RenderProgress? That is the only place it is used, as a kind of flag to test whether the render object has been updated from the element for the first time or not. 431907 2 99624 dominicc 2011-07-04 06:29:50 -0700 Created attachment 99624 Patch 432063 3 tkent 2011-07-04 17:27:53 -0700 (In reply to comment #1) > It duplicates the logic for isDeterminate, uses slower attribute accessors than is necessary, and checks an impossible case (InvalidPosition) only used in its RenderProgress. ok, it would be reasonable. > Should HTMLProgressElement::InvalidPosition be deported to RenderProgress? That is the only place it is used, as a kind of flag to test whether the render object has been updated from the element for the first time or not. I think InvalidPosition is not needed. we can initialize RenderProgress::m_position with element->position(). Morita-san, what do you think? 432096 4 99624 morrita 2011-07-04 20:28:01 -0700 Comment on attachment 99624 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99624&action=review Looks good in general. have one question: > Source/WebCore/html/HTMLProgressElement.cpp:-140 > - return (HTMLProgressElement::IndeterminatePosition != currentPosition && HTMLProgressElement::InvalidPosition != currentPosition); Do we need InvalidPosition yet ? 432097 5 99668 dominicc 2011-07-04 20:32:42 -0700 Created attachment 99668 Removes InvalidPosition 432098 6 dominicc 2011-07-04 20:34:26 -0700 (In reply to comment #4) > Do we need InvalidPosition yet ? InvalidPosition was only used by RenderProgress; it initializes its position to InvalidPosition and then gets updated from the element. I have uploaded a patch that removes InvalidPosition entirely by initializing the position in the RenderProgress straight away… WDYT? 432100 7 99668 dominicc 2011-07-04 20:38:30 -0700 Comment on attachment 99668 Removes InvalidPosition Initial InvalidPosition is still needed for starting indeterminate state animation. 432101 8 99624 webkit.review.bot 2011-07-04 21:21:38 -0700 Comment on attachment 99624 Patch Clearing flags on attachment: 99624 Committed r90384: <http://trac.webkit.org/changeset/90384> 432102 9 webkit.review.bot 2011-07-04 21:21:42 -0700 All reviewed patches have been landed. Closing bug. 99624 2011-07-04 06:29:50 -0700 2011-07-04 21:21:37 -0700 Patch bug-63889-20110704222948.patch text/plain 2741 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogOTAzNTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlZmFkMWE4ZGMwMTU4MzVj MGI5MDQ4M2NkNDJkZTVkNjlkNjY5OTUzLi5kYTdiYTI1YjE1NDY4NDc1MTQ2ZWY2NTMyNGJkNDVi ZTY3YjkzOGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDctMDQgIERvbWlu aWMgQ29vbmV5ICAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KKworICAgICAgICBTaW1wbGlmeSA8 cHJvZ3Jlc3M+IGVsZW1lbnQncyBpc0RldGVybWluYXRlIGxvZ2ljLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM4ODkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3Rz CisgICAgICAgIGZhc3QvZG9tL0hUTUxQcm9ncmVzc0VsZW1lbnQvaW5kZXRlcm1pbmF0ZS1wcm9n cmVzcy0qLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MUHJvZ3Jlc3NFbGVtZW50Ojpwb3NpdGlvbik6IGRvbid0IGR1 cGxpY2F0ZSBpc0RldGVybWluYXRlCisgICAgICAgIChXZWJDb3JlOjpIVE1MUHJvZ3Jlc3NFbGVt ZW50Ojppc0RldGVybWluYXRlKTogcmVtb3ZlIHJlZHVuZGFudCB0ZXN0cworICAgICAgICAoV2Vi Q29yZTo6SFRNTFByb2dyZXNzRWxlbWVudDo6ZGlkRWxlbWVudFN0YXRlQ2hhbmdlKTogZml4IGZv cm1hdHRpbmcKKyAgICAgICAgKiBodG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuaDoKKwogMjAxMS0w Ny0wMyAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg VGhlIHZhbHVlIHByb3BlcnR5IG9mIGFuIGluZGV0ZXJtaW5hdGUgcHJvZ3Jlc3MgZWxlbWVudCBz aG91bGQgYmUgemVybwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jl c3NFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5j cHAKaW5kZXggYjQ2YTg5ZDY5NjUyZTRmMDc5ZmM3MGM0MzExN2NhMzkxMjJlMTBjNS4uOTYwZjE1 NzgyZWZhMDRhNTAzN2JkYjZhNGM5OTdhOWRmYzdkYTM5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuY3BwCkBAIC0xMjksMjAgKzEyOSwxOSBAQCB2b2lkIEhU TUxQcm9ncmVzc0VsZW1lbnQ6OnNldE1heChkb3VibGUgbWF4LCBFeGNlcHRpb25Db2RlJiBlYykK IAogZG91YmxlIEhUTUxQcm9ncmVzc0VsZW1lbnQ6OnBvc2l0aW9uKCkgY29uc3QKIHsKLSAgICBp ZiAoIWhhc0F0dHJpYnV0ZSh2YWx1ZUF0dHIpKQorICAgIGlmICghaXNEZXRlcm1pbmF0ZSgpKQog ICAgICAgICByZXR1cm4gSFRNTFByb2dyZXNzRWxlbWVudDo6SW5kZXRlcm1pbmF0ZVBvc2l0aW9u OwogICAgIHJldHVybiB2YWx1ZSgpIC8gbWF4KCk7CiB9CiAKLWJvb2wgSFRNTFByb2dyZXNzRWxl bWVudDo6aXNEZXRlcm1pbmF0ZSgpCitib29sIEhUTUxQcm9ncmVzc0VsZW1lbnQ6OmlzRGV0ZXJt aW5hdGUoKSBjb25zdAogewotICAgIGRvdWJsZSBjdXJyZW50UG9zaXRpb24gPSBwb3NpdGlvbigp OwotICAgIHJldHVybiAoSFRNTFByb2dyZXNzRWxlbWVudDo6SW5kZXRlcm1pbmF0ZVBvc2l0aW9u ICE9IGN1cnJlbnRQb3NpdGlvbiAmJiBIVE1MUHJvZ3Jlc3NFbGVtZW50OjpJbnZhbGlkUG9zaXRp b24gIT0gY3VycmVudFBvc2l0aW9uKTsKKyAgICByZXR1cm4gZmFzdEhhc0F0dHJpYnV0ZSh2YWx1 ZUF0dHIpOwogfQogICAgIAogdm9pZCBIVE1MUHJvZ3Jlc3NFbGVtZW50OjpkaWRFbGVtZW50U3Rh dGVDaGFuZ2UoKQogewotICAgIG1fdmFsdWUtPnNldFdpZHRoUGVyY2VudGFnZShwb3NpdGlvbigp KjEwMCk7CisgICAgbV92YWx1ZS0+c2V0V2lkdGhQZXJjZW50YWdlKHBvc2l0aW9uKCkgKiAxMDAp OwogICAgIGlmIChyZW5kZXJlcigpKSB7CiAgICAgICAgIFJlbmRlclByb2dyZXNzKiByZW5kZXIg PSB0b1JlbmRlclByb2dyZXNzKHJlbmRlcmVyKCkpOwogICAgICAgICBib29sIHdhc0RldGVybWlu YXRlID0gcmVuZGVyLT5pc0RldGVybWluYXRlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBy b2dyZXNzRWxlbWVudC5oCmluZGV4IDhkZWJlNWM5YmE5NTJiOTdjZmQ3ZTcwYmVkYmY1ZjljZWNm OGUwMDkuLjJlZTRjNmJhODU4OWE2NDVhZTEwMzFlODg0ZTNhM2Y1YzRjMmYxMzcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5oCkBAIC00Myw3ICs0Myw3IEBAIHB1 YmxpYzoKIAogICAgIGRvdWJsZSBwb3NpdGlvbigpIGNvbnN0OwogCi0gICAgYm9vbCBpc0RldGVy bWluYXRlKCk7CisgICAgYm9vbCBpc0RldGVybWluYXRlKCkgY29uc3Q7CiAgICAgCiAgICAgdmly dHVhbCBib29sIGNhbkNvbnRhaW5SYW5nZUVuZFBvaW50KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7 IH0KIAo= 99668 2011-07-04 20:32:42 -0700 2011-07-04 20:38:29 -0700 Removes InvalidPosition bug-63889-20110705123240.patch text/plain 4565 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogOTAzODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxYzkzMDJjZThkZGRlMzI4 ODBkNmZmMWZjNWRjNjIyYWU0MTE4OWEwLi5kYmMwM2E3OGU5Yjk0NGUwMTc5NTQ4MzQ3ZmRlOTE3 OTE2ZjY0MzBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDctMDQgIERvbWlu aWMgQ29vbmV5ICAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KKworICAgICAgICBTaW1wbGlmeSA8 cHJvZ3Jlc3M+IGVsZW1lbnQncyBpc0RldGVybWluYXRlIGxvZ2ljLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM4ODkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3Rz CisgICAgICAgIGZhc3QvZG9tL0hUTUxQcm9ncmVzc0VsZW1lbnQvaW5kZXRlcm1pbmF0ZS1wcm9n cmVzcy0qLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MUHJvZ3Jlc3NFbGVtZW50Ojpwb3NpdGlvbik6IGRvbid0IGR1 cGxpY2F0ZSBpc0RldGVybWluYXRlCisgICAgICAgIChXZWJDb3JlOjpIVE1MUHJvZ3Jlc3NFbGVt ZW50Ojppc0RldGVybWluYXRlKTogcmVtb3ZlIHJlZHVuZGFudCB0ZXN0cworICAgICAgICAoV2Vi Q29yZTo6SFRNTFByb2dyZXNzRWxlbWVudDo6ZGlkRWxlbWVudFN0YXRlQ2hhbmdlKTogZml4IGZv cm1hdHRpbmcKKyAgICAgICAgKiBodG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuaDoKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyUHJvZ3Jlc3MuY3BwOiByZW1vdmUgdW5uZWNlc3NhcnkgJ2ludmFs aWQnIHN0YXRlCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJQcm9ncmVzczo6UmVuZGVyUHJvZ3Jl c3MpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUHJvZ3Jlc3M6OmlzRGV0ZXJtaW5hdGUpOgor CiAyMDExLTA3LTA0ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MUHJvZ3Jlc3NFbGVtZW50LmNwcAppbmRleCBiNDZhODlkNjk2NTJlNGYwNzlmYzcwYzQzMTE3 Y2EzOTEyMmUxMGM1Li5mOTMyZjQ2MTBhODhkMjYyNGVhYzRlNTk5NDc5NzcwZTJkOWU4MTJlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5jcHAKQEAgLTQwLDcg KzQwLDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsK IAogY29uc3QgZG91YmxlIEhUTUxQcm9ncmVzc0VsZW1lbnQ6OkluZGV0ZXJtaW5hdGVQb3NpdGlv biA9IC0xOwotY29uc3QgZG91YmxlIEhUTUxQcm9ncmVzc0VsZW1lbnQ6OkludmFsaWRQb3NpdGlv biA9IC0yOwogCiBIVE1MUHJvZ3Jlc3NFbGVtZW50OjpIVE1MUHJvZ3Jlc3NFbGVtZW50KGNvbnN0 IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50KiBkb2N1bWVudCwgSFRNTEZvcm1FbGVt ZW50KiBmb3JtKQogICAgIDogSFRNTEZvcm1Db250cm9sRWxlbWVudCh0YWdOYW1lLCBkb2N1bWVu dCwgZm9ybSkKQEAgLTEyOSwyMCArMTI4LDE5IEBAIHZvaWQgSFRNTFByb2dyZXNzRWxlbWVudDo6 c2V0TWF4KGRvdWJsZSBtYXgsIEV4Y2VwdGlvbkNvZGUmIGVjKQogCiBkb3VibGUgSFRNTFByb2dy ZXNzRWxlbWVudDo6cG9zaXRpb24oKSBjb25zdAogewotICAgIGlmICghaGFzQXR0cmlidXRlKHZh bHVlQXR0cikpCisgICAgaWYgKCFpc0RldGVybWluYXRlKCkpCiAgICAgICAgIHJldHVybiBIVE1M UHJvZ3Jlc3NFbGVtZW50OjpJbmRldGVybWluYXRlUG9zaXRpb247CiAgICAgcmV0dXJuIHZhbHVl KCkgLyBtYXgoKTsKIH0KIAotYm9vbCBIVE1MUHJvZ3Jlc3NFbGVtZW50Ojppc0RldGVybWluYXRl KCkKK2Jvb2wgSFRNTFByb2dyZXNzRWxlbWVudDo6aXNEZXRlcm1pbmF0ZSgpIGNvbnN0CiB7Ci0g ICAgZG91YmxlIGN1cnJlbnRQb3NpdGlvbiA9IHBvc2l0aW9uKCk7Ci0gICAgcmV0dXJuIChIVE1M UHJvZ3Jlc3NFbGVtZW50OjpJbmRldGVybWluYXRlUG9zaXRpb24gIT0gY3VycmVudFBvc2l0aW9u ICYmIEhUTUxQcm9ncmVzc0VsZW1lbnQ6OkludmFsaWRQb3NpdGlvbiAhPSBjdXJyZW50UG9zaXRp b24pOworICAgIHJldHVybiBmYXN0SGFzQXR0cmlidXRlKHZhbHVlQXR0cik7CiB9CiAgICAgCiB2 b2lkIEhUTUxQcm9ncmVzc0VsZW1lbnQ6OmRpZEVsZW1lbnRTdGF0ZUNoYW5nZSgpCiB7Ci0gICAg bV92YWx1ZS0+c2V0V2lkdGhQZXJjZW50YWdlKHBvc2l0aW9uKCkqMTAwKTsKKyAgICBtX3ZhbHVl LT5zZXRXaWR0aFBlcmNlbnRhZ2UocG9zaXRpb24oKSAqIDEwMCk7CiAgICAgaWYgKHJlbmRlcmVy KCkpIHsKICAgICAgICAgUmVuZGVyUHJvZ3Jlc3MqIHJlbmRlciA9IHRvUmVuZGVyUHJvZ3Jlc3Mo cmVuZGVyZXIoKSk7CiAgICAgICAgIGJvb2wgd2FzRGV0ZXJtaW5hdGUgPSByZW5kZXItPmlzRGV0 ZXJtaW5hdGUoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNz RWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmgKaW5k ZXggOGRlYmU1YzliYTk1MmI5N2NmZDdlNzBiZWRiZjVmOWNlY2Y4ZTAwOS4uMWIzNDE5NTc4NTZl MDlmZTEzNTRiNWIyNzUxNDJhOThhOWRjNzhjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M UHJvZ3Jlc3NFbGVtZW50LmgKQEAgLTMxLDcgKzMxLDYgQEAgY2xhc3MgUHJvZ3Jlc3NWYWx1ZUVs ZW1lbnQ7CiBjbGFzcyBIVE1MUHJvZ3Jlc3NFbGVtZW50IDogcHVibGljIEhUTUxGb3JtQ29udHJv bEVsZW1lbnQgewogcHVibGljOgogICAgIHN0YXRpYyBjb25zdCBkb3VibGUgSW5kZXRlcm1pbmF0 ZVBvc2l0aW9uOwotICAgIHN0YXRpYyBjb25zdCBkb3VibGUgSW52YWxpZFBvc2l0aW9uOwogCiAg ICAgc3RhdGljIFBhc3NSZWZQdHI8SFRNTFByb2dyZXNzRWxlbWVudD4gY3JlYXRlKGNvbnN0IFF1 YWxpZmllZE5hbWUmLCBEb2N1bWVudCosIEhUTUxGb3JtRWxlbWVudCopOwogCkBAIC00Myw3ICs0 Miw3IEBAIHB1YmxpYzoKIAogICAgIGRvdWJsZSBwb3NpdGlvbigpIGNvbnN0OwogCi0gICAgYm9v bCBpc0RldGVybWluYXRlKCk7CisgICAgYm9vbCBpc0RldGVybWluYXRlKCkgY29uc3Q7CiAgICAg CiAgICAgdmlydHVhbCBib29sIGNhbkNvbnRhaW5SYW5nZUVuZFBvaW50KCkgY29uc3QgeyByZXR1 cm4gZmFsc2U7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clByb2dyZXNzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJQcm9ncmVzcy5j cHAKaW5kZXggZDVhYTVkYTQwZWQ2MmQ4OTk1NGM4ZTlmMjI4YjMzNTk1YmMwZmMzMy4uZjAzNzll NTIyNjUyOWU0NWRiNDcyOWIwMGMzZTQ2MDQ2OTE3Mjc5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclByb2dyZXNzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyUHJvZ3Jlc3MuY3BwCkBAIC0zNyw3ICszNyw3IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogUmVuZGVyUHJvZ3Jlc3M6OlJlbmRlclByb2dyZXNzKEhUTUxQcm9ncmVzc0Vs ZW1lbnQqIGVsZW1lbnQpCiAgICAgOiBSZW5kZXJCbG9jayhlbGVtZW50KQotICAgICwgbV9wb3Np dGlvbihIVE1MUHJvZ3Jlc3NFbGVtZW50OjpJbnZhbGlkUG9zaXRpb24pCisgICAgLCBtX3Bvc2l0 aW9uKGVsZW1lbnQtPnBvc2l0aW9uKCkpCiAgICAgLCBtX2FuaW1hdGlvblN0YXJ0VGltZSgwKQog ICAgICwgbV9hbmltYXRpb25SZXBlYXRJbnRlcnZhbCgwKQogICAgICwgbV9hbmltYXRpb25EdXJh dGlvbigwKQpAQCAtNjgsOCArNjgsNyBAQCBkb3VibGUgUmVuZGVyUHJvZ3Jlc3M6OmFuaW1hdGlv blByb2dyZXNzKCkgY29uc3QKIAogYm9vbCBSZW5kZXJQcm9ncmVzczo6aXNEZXRlcm1pbmF0ZSgp IGNvbnN0CiB7Ci0gICAgcmV0dXJuIChIVE1MUHJvZ3Jlc3NFbGVtZW50OjpJbmRldGVybWluYXRl UG9zaXRpb24gIT0gcG9zaXRpb24oKQotICAgICAgICAgICAgJiYgSFRNTFByb2dyZXNzRWxlbWVu dDo6SW52YWxpZFBvc2l0aW9uICE9IHBvc2l0aW9uKCkpOworICAgIHJldHVybiBIVE1MUHJvZ3Jl c3NFbGVtZW50OjpJbmRldGVybWluYXRlUG9zaXRpb24gIT0gcG9zaXRpb24oKTsKIH0KIAogdm9p ZCBSZW5kZXJQcm9ncmVzczo6YW5pbWF0aW9uVGltZXJGaXJlZChUaW1lcjxSZW5kZXJQcm9ncmVz cz4qKQo=