<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>6388</bug_id>
          
          <creation_ts>2006-01-05 14:06:14 -0800</creation_ts>
          <short_desc>REGRESSION: Incomplete repaint when dragging the map on Google maps</short_desc>
          <delta_ts>2006-01-31 21:20:54 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://maps.google.com/</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>mitz</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>alice.barraclough</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>27804</commentid>
    <comment_count>0</comment_count>
    <who name="">mitz</who>
    <bug_when>2006-01-05 14:06:14 -0800</bug_when>
    <thetext>If you drag the map slowly straight down (or straight to the right), it &quot;smears&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>27806</commentid>
    <comment_count>1</comment_count>
    <who name="">mitz</who>
    <bug_when>2006-01-05 14:17:51 -0800</bug_when>
    <thetext>The regression happened between Nov 6 and Nov 8 so I&apos;m guessing it&apos;s from fixing bug 5633.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>27822</commentid>
    <comment_count>2</comment_count>
      <attachid>5506</attachid>
    <who name="">mitz</who>
    <bug_when>2006-01-05 16:10:35 -0800</bug_when>
    <thetext>Created attachment 5506
Reduced testcase

The optimized repaint code thinks that the image only resized, rather than
moved.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>28255</commentid>
    <comment_count>3</comment_count>
    <who name="Alice Liu">alice.barraclough</who>
    <bug_when>2006-01-11 13:25:43 -0800</bug_when>
    <thetext>&lt;rdar://problem/4405688&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>29775</commentid>
    <comment_count>4</comment_count>
      <attachid>5931</attachid>
    <who name="">mitz</who>
    <bug_when>2006-01-24 15:55:40 -0800</bug_when>
    <thetext>Created attachment 5931
Possible fix

This fixes the Google maps site and the testcase. I think the bug (mistaking a move for a resize due to clipping) can only happen to objects that have a layer, since otherwise repaintDuringLayoutIfMoved handles it.

If the patch is good, please r- and I&apos;ll resubmit with a ChangeLog entry and a manual test (unfortunately repaint issues can&apos;t be tested automatically).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>29789</commentid>
    <comment_count>5</comment_count>
      <attachid>5931</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-01-24 19:29:21 -0800</bug_when>
    <thetext>Comment on attachment 5931
Possible fix

Looks good. I think you can move on to the next step on this one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>29794</commentid>
    <comment_count>6</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2006-01-24 20:19:28 -0800</bug_when>
    <thetext>Could you explain this further?  I don&apos;t see why these extra fields are necessary.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>29795</commentid>
    <comment_count>7</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2006-01-24 20:23:25 -0800</bug_when>
    <thetext>This is marked as a regression.  Was it caused by the checkin I did a month or two ago to optimize repainting when a block resized but didn&apos;t move?
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>29807</commentid>
    <comment_count>8</comment_count>
    <who name="">mitz</who>
    <bug_when>2006-01-24 22:15:24 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; This is marked as a regression.  Was it caused by the checkin I did a month or
&gt; two ago to optimize repainting when a block resized but didn&apos;t move?

Yes. There are several of those, some fixed, some still not.

(In reply to comment #6)
&gt; Could you explain this further?  I don&apos;t see why these extra fields are
&gt; necessary.
 
Using absolute repaint rects, all repaintAfterLayoutIfNeeded sees is a resize, due to clipping. This extra info is what&apos;s needed to break the move/resize ambiguity.

There is at least one other case where repaintAfterLayoutIfNeeded lacks enough information to determine what really changed (see bug 6770), so perhaps repaintAfterLayoutIfNeeded will need to take extra arguments (e.g. the object&apos;s unclipped rect in absolute coordinates), in which case layers will need to cache that info.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>29810</commentid>
    <comment_count>9</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2006-01-24 22:50:55 -0800</bug_when>
    <thetext>Ok, yeah I see now.  I think I might rename the member variables m_repaintX and m_repaintY or something like that, since they are really just cached values for the repaint check step.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>29837</commentid>
    <comment_count>10</comment_count>
      <attachid>5946</attachid>
    <who name="">mitz</who>
    <bug_when>2006-01-25 08:27:36 -0800</bug_when>
    <thetext>Created attachment 5946
Updated patch

Renamed member variables and added ChangeLog and manual test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>29846</commentid>
    <comment_count>11</comment_count>
      <attachid>5946</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-01-25 09:38:47 -0800</bug_when>
    <thetext>Comment on attachment 5946
Updated patch

Nice. Lets go with this. r=me

Onward to the other repaint problems. :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>30279</commentid>
    <comment_count>12</comment_count>
    <who name="">mitz</who>
    <bug_when>2006-01-27 01:02:13 -0800</bug_when>
    <thetext>Verified in r12402 nightly</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>30890</commentid>
    <comment_count>13</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2006-01-31 21:20:54 -0800</bug_when>
    <thetext>Removing Regression keyword from bugs already fixed.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>5506</attachid>
            <date>2006-01-05 16:10:35 -0800</date>
            <delta_ts>2006-01-05 16:10:35 -0800</delta_ts>
            <desc>Reduced testcase</desc>
            <filename>layer-repaint.html</filename>
            <type>text/html</type>
            <size>536</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">PGh0bWw+CjxoZWFkPgo8dGl0bGU+bGF5ZXIgcmVwYWludCBnbGl0Y2g8L3RpdGxlPgo8L2hlYWQ+
Cjxib2R5Pgo8cD5QcmVzcyB0aGUgVGVzdCBidXR0b24sIHRoZW4gZm9yY2UgcmVwYWludCBieSBj
aG9vc2luZyBFZGl0ID4gU2VsZWN0IEFsbDwvcD4KPGJ1dHRvbiBvbmNsaWNrPSJkb2N1bWVudC5n
ZXRFbGVtZW50QnlJZCgnb3V0c2lkZScpLnN0eWxlLmxlZnQgPSAtMTAwIj5UZXN0PC9idXR0b24+
CjxkaXYgc3R5bGU9IndpZHRoOiAyMzVweDsgaGVpZ2h0OiAxNzdweDsgb3ZlcmZsb3c6IGhpZGRl
bjsgcG9zaXRpb246IHJlbGF0aXZlIj4KICAgIDxkaXYgaWQ9Im91dHNpZGUiIHN0eWxlPSJwb3Np
dGlvbjphYnNvbHV0ZTsgd2lkdGg6IDA7IGhlaWdodDogMDsiPgogICAgICAgIDxpbWcgc3JjPSJo
dHRwOi8vd2Via2l0Lm9wZW5kYXJ3aW4ub3JnL2ltYWdlcy93ZWJraXQtYmFja2dyb3VuZC5wbmci
IHN0eWxlPSJwb3NpdGlvbjogYWJzb2x1dGU7IGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOyI+CiAg
ICA8L2Rpdj4KPC9kaXY+CjwvYm9keT4=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>5931</attachid>
            <date>2006-01-24 15:55:40 -0800</date>
            <delta_ts>2006-01-24 19:29:21 -0800</delta_ts>
            <desc>Possible fix</desc>
            <filename>6388_r0.patch</filename>
            <type>text/plain</type>
            <size>2286</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL3JlbmRlcl9sYXllci5jcHAKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
V2ViQ29yZS9yZW5kZXJpbmcvcmVuZGVyX2xheWVyLmNwcAkocmV2aXNpb24gMTIzMTEpCisrKyBX
ZWJDb3JlL3JlbmRlcmluZy9yZW5kZXJfbGF5ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjEs
OCArMTYxLDEwIEBACiB2b2lkIFJlbmRlckxheWVyOjpjb21wdXRlUmVwYWludFJlY3RzKCkKIHsK
ICAgICAvLyBGSVhNRTogQ2hpbGQgb2JqZWN0IGNvdWxkIG92ZXJyaWRlIHZpc2liaWxpdHkuCi0g
ICAgaWYgKG1fb2JqZWN0LT5zdHlsZSgpLT52aXNpYmlsaXR5KCkgPT0gVklTSUJMRSkKKyAgICBp
ZiAobV9vYmplY3QtPnN0eWxlKCktPnZpc2liaWxpdHkoKSA9PSBWSVNJQkxFKSB7CiAgICAgICAg
IG1fb2JqZWN0LT5nZXRBYnNvbHV0ZVJlcGFpbnRSZWN0SW5jbHVkaW5nRmxvYXRzKG1fcmVwYWlu
dFJlY3QsIG1fZnVsbFJlcGFpbnRSZWN0KTsKKyAgICAgICAgbV9vYmplY3QtPmFic29sdXRlUG9z
aXRpb24obV9vYmpBYnNYLCBtX29iakFic1kpOworICAgIH0KICAgICBmb3IgKFJlbmRlckxheWVy
KiBjaGlsZCA9IGZpcnN0Q2hpbGQoKTsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5n
KCkpCiAgICAgICAgIGNoaWxkLT5jb21wdXRlUmVwYWludFJlY3RzKCk7CiB9CkBAIC0xODgsOCAr
MTkwLDIyIEBACiAgICAgfQogCiAgICAgLy8gRklYTUU6IENoaWxkIG9iamVjdCBjb3VsZCBvdmVy
cmlkZSB2aXNpYmlsaXR5LgotICAgIGlmIChjaGVja0ZvclJlcGFpbnQgJiYgKG1fb2JqZWN0LT5z
dHlsZSgpLT52aXNpYmlsaXR5KCkgPT0gVklTSUJMRSkpCi0gICAgICAgIG1fb2JqZWN0LT5yZXBh
aW50QWZ0ZXJMYXlvdXRJZk5lZWRlZChtX3JlcGFpbnRSZWN0LCBtX2Z1bGxSZXBhaW50UmVjdCk7
CisgICAgaWYgKGNoZWNrRm9yUmVwYWludCAmJiAobV9vYmplY3QtPnN0eWxlKCktPnZpc2liaWxp
dHkoKSA9PSBWSVNJQkxFKSkgeworICAgICAgICBpbnQgeCwgeTsKKyAgICAgICAgbV9vYmplY3Qt
PmFic29sdXRlUG9zaXRpb24oeCwgeSk7CisgICAgICAgIGlmICh4ID09IG1fb2JqQWJzWCAmJiB5
ID09IG1fb2JqQWJzWSkKKyAgICAgICAgICAgIG1fb2JqZWN0LT5yZXBhaW50QWZ0ZXJMYXlvdXRJ
Zk5lZWRlZChtX3JlcGFpbnRSZWN0LCBtX2Z1bGxSZXBhaW50UmVjdCk7CisgICAgICAgIGVsc2Ug
eworICAgICAgICAgICAgUmVuZGVyQ2FudmFzICpjID0gbV9vYmplY3QtPmNhbnZhcygpOworICAg
ICAgICAgICAgaWYgKGMgJiYgIWMtPnByaW50aW5nTW9kZSgpKSB7CisgICAgICAgICAgICAgICAg
Yy0+cmVwYWludFZpZXdSZWN0YW5nbGUobV9mdWxsUmVwYWludFJlY3QpOworICAgICAgICAgICAg
ICAgIEludFJlY3QgbmV3UmVjdCwgbmV3RnVsbFJlY3Q7CisgICAgICAgICAgICAgICAgbV9vYmpl
Y3QtPmdldEFic29sdXRlUmVwYWludFJlY3RJbmNsdWRpbmdGbG9hdHMobmV3UmVjdCwgbmV3RnVs
bFJlY3QpOworICAgICAgICAgICAgICAgIGlmIChuZXdSZWN0ICE9IG1fcmVwYWludFJlY3QpCisg
ICAgICAgICAgICAgICAgICAgIGMtPnJlcGFpbnRWaWV3UmVjdGFuZ2xlKG5ld0Z1bGxSZWN0KTsK
KyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgIH0KICAgICAKICAgICBmb3IgKFJlbmRlckxh
eWVyKiBjaGlsZCA9IGZpcnN0Q2hpbGQoKTsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPm5leHRTaWJs
aW5nKCkpCiAgICAgICAgIGNoaWxkLT51cGRhdGVMYXllclBvc2l0aW9ucyhkb0Z1bGxSZXBhaW50
LCBjaGVja0ZvclJlcGFpbnQpOwpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvcmVuZGVyX2xheWVy
LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvcmVuZGVyX2xheWVyLmgJKHJldmlz
aW9uIDEyMzExKQorKysgV2ViQ29yZS9yZW5kZXJpbmcvcmVuZGVyX2xheWVyLmgJKHdvcmtpbmcg
Y29weSkKQEAgLTM1Miw2ICszNTIsOCBAQAogCiAgICAgSW50UmVjdCBtX3JlcGFpbnRSZWN0OyAv
LyBDYWNoZWQgcmVwYWludCByZWN0cy4gVXNlZCBieSBsYXlvdXQuCiAgICAgSW50UmVjdCBtX2Z1
bGxSZXBhaW50UmVjdDsKKyAgICBpbnQgbV9vYmpBYnNYOworICAgIGludCBtX29iakFic1k7CiAK
ICAgICAvLyBPdXIgY3VycmVudCByZWxhdGl2ZSBwb3NpdGlvbiBvZmZzZXQuCiAgICAgaW50IG1f
cmVsWDsK
</data>
<flag name="review"
          id="1388"
          type_id="1"
          status="-"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>5946</attachid>
            <date>2006-01-25 08:27:36 -0800</date>
            <delta_ts>2006-01-25 09:38:47 -0800</delta_ts>
            <desc>Updated patch</desc>
            <filename>6388_r1.patch</filename>
            <type>text/plain</type>
            <size>4716</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAxMjM0OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTggQEAKKzIwMDYtMDEtIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdA
bWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisg
ICAgICAgIAorICAgICAgICAtIGZpeCBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hv
d19idWcuY2dpP2lkPTYzODgKKyAgICAgICAgICBSRUdSRVNTSU9OOiBJbmNvbXBsZXRlIHJlcGFp
bnQgd2hlbiBkcmFnZ2luZyB0aGUgbWFwIG9uIEdvb2dsZSBtYXBzCisKKyAgICAgICAgKiBtYW51
YWwtdGVzdHMvYnVnemlsbGEtNjM4OC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiByZW5kZXJpbmcv
cmVuZGVyX2xheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpjb21wdXRl
UmVwYWludFJlY3RzKTogQ2FjaGUgdGhlIG9iamVjdCdzIGFic29sdXRlIHBvc2l0aW9uCisgICAg
ICAgIGJlZm9yZSB1cGRhdGUuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6dXBkYXRl
TGF5ZXJQb3NpdGlvbnMpOiBVc2UgdGhlIGNhY2hlZCBwb3NpdGlvbiB0byBkZXRlcm1pbmUgaWYK
KyAgICAgICAgdGhlIG9iamVjdCBtb3ZlZC4gSWYgaXQgZGlkLCBkbyBhIGZ1bGwgcmVwYWludC4K
KyAgICAgICAgKiByZW5kZXJpbmcvcmVuZGVyX2xheWVyLmg6CisKIDIwMDYtMDEtMjQgIERhcmlu
IEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkZWxlLgpJ
bmRleDogV2ViQ29yZS9tYW51YWwtdGVzdHMvYnVnemlsbGEtNjM4OC5odG1sCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFdlYkNvcmUvbWFudWFsLXRlc3RzL2J1Z3ppbGxhLTYzODguaHRtbAkocmV2aXNpb24gMCkK
KysrIFdlYkNvcmUvbWFudWFsLXRlc3RzL2J1Z3ppbGxhLTYzODguaHRtbAkocmV2aXNpb24gMCkK
QEAgLTAsMCArMSwzMSBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1M
IDQuMDEvL0VOIgorICAgICAgICAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvc3RyaWN0LmR0
ZCI+Cis8aHRtbCBsYW5nPSJlbiI+Cis8aGVhZD4KKzwvaGVhZD4KKzxib2R5PgorPHA+PGI+QlVH
IElEOjwvYj4gPGEgaHJlZj0iaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVn
LmNnaT9pZD02Mzg4Ij5CdWd6aWxsYSBidWcgNjM4ODwvYT4gUkVHUkVTU0lPTjogSW5jb21wbGV0
ZSByZXBhaW50IHdoZW4gZHJhZ2dpbmcgdGhlIG1hcCBvbiBHb29nbGUgbWFwczwvcD4KKworPHAg
aWQ9InRlc3QiIHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOnNreWJsdWU7IHBhZGRpbmc6M3B4OyI+
PGI+U1RFUFMgVE8gVEVTVDo8L2I+IAorQ2xpY2sgdGhlIFRlc3QgYnV0dG9uIGJlbG93LgorPC9w
PgorCis8cCBpZD0ic3VjY2VzcyIgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6cGFsZWdyZWVuOyBw
YWRkaW5nOjNweDsiPjxiPlRFU1QgUEFTUzo8L2I+IAorVGhlIGJsdWUgc3F1YXJlIHdpbGwgY2hh
bmdlIHRvIGdyZWVuLgorPC9wPgorCis8cCBpZD0iZmFpbHVyZSIgc3R5bGU9ImJhY2tncm91bmQt
Y29sb3I6I0ZGMzMwMDsgcGFkZGluZzozcHg7Ij48Yj5URVNUIEZBSUw6PC9iPiAgCitUaGUgYmx1
ZSBzcXVhcmUgd2lsbCBOT1QgY2hhbmdlIHRvIGdyZWVuLgorPC9wPgorCis8ZGl2IHN0eWxlPSJ3
aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7IG92ZXJmbG93OiBoaWRkZW47IHBvc2l0aW9uOiBy
ZWxhdGl2ZSI+CisgICAgPGRpdiBpZD0ib3V0c2lkZSIgc3R5bGU9InBvc2l0aW9uOmFic29sdXRl
OyB3aWR0aDogMDsgaGVpZ2h0OiAwOyI+CisgICAgICAgIDxkaXYgc3R5bGU9IndpZHRoOiAyMDBw
eDsgaGVpZ2h0OiAxMDBweDsgcG9zaXRpb246IGFic29sdXRlOyBiYWNrZ3JvdW5kOiBncmVlbjsi
PgorICAgICAgICAgICAgPGRpdiBzdHlsZT0id2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDEwMHB4OyBi
YWNrZ3JvdW5kOiBibHVlOyI+PC9kaXY+CisgICAgICAgIDwvZGl2PgorICAgIDwvZGl2PgorPC9k
aXY+Cis8YnI+Cis8YnV0dG9uIG9uY2xpY2s9ImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdvdXRz
aWRlJykuc3R5bGUubGVmdCA9ICctMTAwcHgnIj5UZXN0PC9idXR0b24+Cis8L2JvZHk+Cis8L2h0
bWw+CkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9yZW5kZXJfbGF5ZXIuY3BwCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFdlYkNvcmUvcmVuZGVyaW5nL3JlbmRlcl9sYXllci5jcHAJKHJldmlzaW9uIDEyMzQ4KQor
KysgV2ViQ29yZS9yZW5kZXJpbmcvcmVuZGVyX2xheWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt
MTYxLDggKzE2MSwxMCBAQCBSZW5kZXJMYXllcjo6flJlbmRlckxheWVyKCkKIHZvaWQgUmVuZGVy
TGF5ZXI6OmNvbXB1dGVSZXBhaW50UmVjdHMoKQogewogICAgIC8vIEZJWE1FOiBDaGlsZCBvYmpl
Y3QgY291bGQgb3ZlcnJpZGUgdmlzaWJpbGl0eS4KLSAgICBpZiAobV9vYmplY3QtPnN0eWxlKCkt
PnZpc2liaWxpdHkoKSA9PSBWSVNJQkxFKQorICAgIGlmIChtX29iamVjdC0+c3R5bGUoKS0+dmlz
aWJpbGl0eSgpID09IFZJU0lCTEUpIHsKICAgICAgICAgbV9vYmplY3QtPmdldEFic29sdXRlUmVw
YWludFJlY3RJbmNsdWRpbmdGbG9hdHMobV9yZXBhaW50UmVjdCwgbV9mdWxsUmVwYWludFJlY3Qp
OworICAgICAgICBtX29iamVjdC0+YWJzb2x1dGVQb3NpdGlvbihtX3JlcGFpbnRYLCBtX3JlcGFp
bnRZKTsKKyAgICB9CiAgICAgZm9yIChSZW5kZXJMYXllciogY2hpbGQgPSBmaXJzdENoaWxkKCk7
IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKQogICAgICAgICBjaGlsZC0+Y29t
cHV0ZVJlcGFpbnRSZWN0cygpOwogfQpAQCAtMTg4LDggKzE5MCwyMiBAQCB2b2lkIFJlbmRlckxh
eWVyOjp1cGRhdGVMYXllclBvc2l0aW9ucyhiCiAgICAgfQogCiAgICAgLy8gRklYTUU6IENoaWxk
IG9iamVjdCBjb3VsZCBvdmVycmlkZSB2aXNpYmlsaXR5LgotICAgIGlmIChjaGVja0ZvclJlcGFp
bnQgJiYgKG1fb2JqZWN0LT5zdHlsZSgpLT52aXNpYmlsaXR5KCkgPT0gVklTSUJMRSkpCi0gICAg
ICAgIG1fb2JqZWN0LT5yZXBhaW50QWZ0ZXJMYXlvdXRJZk5lZWRlZChtX3JlcGFpbnRSZWN0LCBt
X2Z1bGxSZXBhaW50UmVjdCk7CisgICAgaWYgKGNoZWNrRm9yUmVwYWludCAmJiAobV9vYmplY3Qt
PnN0eWxlKCktPnZpc2liaWxpdHkoKSA9PSBWSVNJQkxFKSkgeworICAgICAgICBpbnQgeCwgeTsK
KyAgICAgICAgbV9vYmplY3QtPmFic29sdXRlUG9zaXRpb24oeCwgeSk7CisgICAgICAgIGlmICh4
ID09IG1fcmVwYWludFggJiYgeSA9PSBtX3JlcGFpbnRZKQorICAgICAgICAgICAgbV9vYmplY3Qt
PnJlcGFpbnRBZnRlckxheW91dElmTmVlZGVkKG1fcmVwYWludFJlY3QsIG1fZnVsbFJlcGFpbnRS
ZWN0KTsKKyAgICAgICAgZWxzZSB7CisgICAgICAgICAgICBSZW5kZXJDYW52YXMgKmMgPSBtX29i
amVjdC0+Y2FudmFzKCk7CisgICAgICAgICAgICBpZiAoYyAmJiAhYy0+cHJpbnRpbmdNb2RlKCkp
IHsKKyAgICAgICAgICAgICAgICBjLT5yZXBhaW50Vmlld1JlY3RhbmdsZShtX2Z1bGxSZXBhaW50
UmVjdCk7CisgICAgICAgICAgICAgICAgSW50UmVjdCBuZXdSZWN0LCBuZXdGdWxsUmVjdDsKKyAg
ICAgICAgICAgICAgICBtX29iamVjdC0+Z2V0QWJzb2x1dGVSZXBhaW50UmVjdEluY2x1ZGluZ0Zs
b2F0cyhuZXdSZWN0LCBuZXdGdWxsUmVjdCk7CisgICAgICAgICAgICAgICAgaWYgKG5ld1JlY3Qg
IT0gbV9yZXBhaW50UmVjdCkKKyAgICAgICAgICAgICAgICAgICAgYy0+cmVwYWludFZpZXdSZWN0
YW5nbGUobmV3RnVsbFJlY3QpOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgfQogICAg
IAogICAgIGZvciAoUmVuZGVyTGF5ZXIqIGNoaWxkID0gZmlyc3RDaGlsZCgpOyBjaGlsZDsgY2hp
bGQgPSBjaGlsZC0+bmV4dFNpYmxpbmcoKSkKICAgICAgICAgY2hpbGQtPnVwZGF0ZUxheWVyUG9z
aXRpb25zKGRvRnVsbFJlcGFpbnQsIGNoZWNrRm9yUmVwYWludCk7CkluZGV4OiBXZWJDb3JlL3Jl
bmRlcmluZy9yZW5kZXJfbGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9y
ZW5kZXJfbGF5ZXIuaAkocmV2aXNpb24gMTIzNDgpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9yZW5k
ZXJfbGF5ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzUyLDYgKzM1Miw4IEBAIHByb3RlY3RlZDog
ICAKIAogICAgIEludFJlY3QgbV9yZXBhaW50UmVjdDsgLy8gQ2FjaGVkIHJlcGFpbnQgcmVjdHMu
IFVzZWQgYnkgbGF5b3V0LgogICAgIEludFJlY3QgbV9mdWxsUmVwYWludFJlY3Q7CisgICAgaW50
IG1fcmVwYWludFg7CisgICAgaW50IG1fcmVwYWludFk7CiAKICAgICAvLyBPdXIgY3VycmVudCBy
ZWxhdGl2ZSBwb3NpdGlvbiBvZmZzZXQuCiAgICAgaW50IG1fcmVsWDsK
</data>
<flag name="review"
          id="1397"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>