63873 2011-07-03 04:44:01 -0700 ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly 2011-07-04 13:28:31 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vsevik vsevik ap webkit.review.bot oldest_to_newest 431693 0 vsevik 2011-07-03 04:44:01 -0700 ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly. 431962 1 99637 vsevik 2011-07-04 09:34:23 -0700 Created attachment 99637 Patch 432015 2 99637 ap 2011-07-04 12:47:30 -0700 Comment on attachment 99637 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99637&action=review > Source/WebCore/ChangeLog:9 > + * loader/ResourceLoadNotifier.cpp: > + (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): Even for a very simple change like this, having per-function comments in ChangeLog would be helpful. 432041 3 99637 webkit.review.bot 2011-07-04 13:28:26 -0700 Comment on attachment 99637 Patch Clearing flags on attachment: 99637 Committed r90376: <http://trac.webkit.org/changeset/90376> 432042 4 webkit.review.bot 2011-07-04 13:28:31 -0700 All reviewed patches have been landed. Closing bug. 99637 2011-07-04 09:34:23 -0700 2011-07-04 13:28:26 -0700 Patch bug-63873-20110704203421.patch text/plain 2057 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTAzNjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYTUxNTdjYzg4NTk5Y2Ni ZjgzOGNkMTJjOGNmOWU1MjhiY2E5MGRjLi5kZDkwM2Q1YTI3ZjAxNGE5MTkyM2RhYmQ2MjFhZTIy MDY2ZDE2NWQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDctMDQgIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVzb3VyY2VMb2Fk Tm90aWZpZXI6OmRpc3BhdGNoV2lsbFNlbmRSZXF1ZXN0IHNob3VsZCBub3QgY29tcGFyZSBTdHJp bmdJbXBsIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02Mzg3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogbG9hZGVyL1Jlc291cmNlTG9hZE5vdGlmaWVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlc291cmNlTG9hZE5vdGlmaWVyOjpkaXNwYXRjaFdpbGxTZW5kUmVxdWVzdCk6CisKIDIw MTEtMDctMDQgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IGltcGxlbWVudCBzZXR0aW5ncyBwYW5lbC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWROb3RpZmllci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkTm90aWZpZXIuY3BwCmluZGV4IGFjNDZhOTQ0N2ZlNWMz NjI4ZjQ3MzUyZThjMmNjYTIyYmRlODNhNDguLmE0MTYzY2E0ZjQ1NjBkZGRkODFkN2FmYmQyNGE2 MzliNjIzMWIxYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxv YWROb3RpZmllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZE5v dGlmaWVyLmNwcApAQCAtMTA3LDEzICsxMDcsMTMgQEAgdm9pZCBSZXNvdXJjZUxvYWROb3RpZmll cjo6YXNzaWduSWRlbnRpZmllclRvSW5pdGlhbFJlcXVlc3QodW5zaWduZWQgbG9uZyBpZGVudGkK IAogdm9pZCBSZXNvdXJjZUxvYWROb3RpZmllcjo6ZGlzcGF0Y2hXaWxsU2VuZFJlcXVlc3QoRG9j dW1lbnRMb2FkZXIqIGxvYWRlciwgdW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBSZXNvdXJjZVJl cXVlc3QmIHJlcXVlc3QsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlZGlyZWN0UmVzcG9uc2Up CiB7Ci0gICAgU3RyaW5nSW1wbCogb2xkUmVxdWVzdFVSTCA9IHJlcXVlc3QudXJsKCkuc3RyaW5n KCkuaW1wbCgpOworICAgIFN0cmluZyBvbGRSZXF1ZXN0VVJMID0gcmVxdWVzdC51cmwoKS5zdHJp bmcoKTsKICAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKS0+ZGlkVGVsbENs aWVudEFib3V0TG9hZChyZXF1ZXN0LnVybCgpKTsKIAogICAgIG1fZnJhbWUtPmxvYWRlcigpLT5j bGllbnQoKS0+ZGlzcGF0Y2hXaWxsU2VuZFJlcXVlc3QobG9hZGVyLCBpZGVudGlmaWVyLCByZXF1 ZXN0LCByZWRpcmVjdFJlc3BvbnNlKTsKIAogICAgIC8vIElmIHRoZSBVUkwgY2hhbmdlZCwgdGhl biB3ZSB3YW50IHRvIHB1dCB0aGF0IG5ldyBVUkwgaW4gdGhlICJkaWQgdGVsbCBjbGllbnQiIHNl dCB0b28uCi0gICAgaWYgKCFyZXF1ZXN0LmlzTnVsbCgpICYmIG9sZFJlcXVlc3RVUkwgIT0gcmVx dWVzdC51cmwoKS5zdHJpbmcoKS5pbXBsKCkpCisgICAgaWYgKCFyZXF1ZXN0LmlzTnVsbCgpICYm IG9sZFJlcXVlc3RVUkwgIT0gcmVxdWVzdC51cmwoKS5zdHJpbmcoKSkKICAgICAgICAgbV9mcmFt ZS0+bG9hZGVyKCktPmRvY3VtZW50TG9hZGVyKCktPmRpZFRlbGxDbGllbnRBYm91dExvYWQocmVx dWVzdC51cmwoKSk7CiAKICAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OndpbGxTZW5kUmVx dWVzdChtX2ZyYW1lLCBpZGVudGlmaWVyLCBsb2FkZXIsIHJlcXVlc3QsIHJlZGlyZWN0UmVzcG9u c2UpOwo=