63857 2011-07-01 18:16:54 -0700 [DRT] implement createPopupMenu for Chromium DRT port 2011-07-07 10:17:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jnd webkit-unassigned satish tony toyoshim webkit.review.bot oldest_to_newest 431564 0 jnd 2011-07-01 18:16:54 -0700 In WebKit, the keystroke configurations of selection list below (see dom/SelectElement.cpp) // Configure platform-specific behavior when focused pop-up receives arrow/space/return keystroke. // (PLATFORM(MAC) and PLATFORM(GTK) are always false in Chromium, hence the extra tests.) #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && OS(DARWIN)) #define ARROW_KEYS_POP_MENU 1 #define SPACE_OR_RETURN_POP_MENU 0 #elif PLATFORM(GTK) || (PLATFORM(CHROMIUM) && OS(UNIX)) #define ARROW_KEYS_POP_MENU 0 #define SPACE_OR_RETURN_POP_MENU 1 #else #define ARROW_KEYS_POP_MENU 0 #define SPACE_OR_RETURN_POP_MENU 0 #endif According to the configuration, On Linux and Chromium unix-like platforms, with configuration of SPACE_OR_RETURN_POP_MENU, pressing '\r' or space on a <select> which acts as menuList render object is to trigger showing popup menu. (instead of doing implicit submit, see SelectElement::menuListDefaultEventHandler.). However the behavior causes crash on Chromium's layout tests. It's because showing popup calls WebViewHost::createPopupMenu() which is not implemented by Chromium DRT. Like test LayoutTest/fast/forms/select-script-onchange.html. See bug 61515. I am working on a patch to fix this issue, which simply creating WebPopupMenu with a empty WidgetClient delegate. It should be enough for layout test. 431568 1 99545 jnd 2011-07-01 18:31:50 -0700 Created attachment 99545 patch v1 431569 2 webkit.review.bot 2011-07-01 18:33:10 -0700 Attachment 99545 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Tools/DumpRenderTree/chromium/WebViewHost.cpp:244: One space before end of line comments [whitespace/comments] [5] Tools/DumpRenderTree/chromium/WebViewHost.cpp:248: Use 0 instead of NULL. [readability/null] [5] Tools/DumpRenderTree/chromium/WebViewHost.cpp:256: Use 0 instead of NULL. [readability/null] [5] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 431876 3 99545 satish 2011-07-04 04:27:09 -0700 Comment on attachment 99545 patch v1 Looks good to me, but someone else has to approve as I'm not a reviewer. Please fix all reported style issues as well. In file Tools/DumpRenderTree/chromium/WebViewHost.cpp line 250: Indent to right by 2 more spaces? 432833 4 99545 tony 2011-07-06 09:44:13 -0700 Comment on attachment 99545 patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=99545&action=review Just some small style nits. > Tools/DumpRenderTree/chromium/WebViewHost.cpp:249 > + if (widget) Nit: Do we really need this check? Shouldn't WebPopupMenu::create always succeed? > Tools/DumpRenderTree/chromium/WebViewHost.cpp:254 > + default: > + ASSERT_NOT_REACHED(); I would remove the default case. That way if someone adds another WebPopupType, there will be a compiler error and the person can update this code. > Tools/DumpRenderTree/chromium/WebViewHost.cpp:261 > + // In Chromium, we do not this method. Nit: This comment isn't that useful. Can you either explain why we don't need this method or just remove the comment? 432838 5 99845 jnd 2011-07-06 09:45:46 -0700 Created attachment 99845 patch v1 (fix style complain) 432840 6 webkit.review.bot 2011-07-06 09:48:10 -0700 Attachment 99845 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/chromium/test_expectations.txt:3990: Can't specify both modifier 'snowleopard' and macro 'mac' fast/events/click-focus-anchor.html [test/expectations] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 433025 7 99880 jnd 2011-07-06 14:23:14 -0700 Created attachment 99880 patch v2 > > Tools/DumpRenderTree/chromium/WebViewHost.cpp:249 > > + if (widget) > > Nit: Do we really need this check? Shouldn't WebPopupMenu::create always succeed? If not considering OOM situation, we need not to check the pointer. I will drop it since WebKit will eventually crash if OOM. > > > Tools/DumpRenderTree/chromium/WebViewHost.cpp:254 > > + default: > > + ASSERT_NOT_REACHED(); > > I would remove the default case. That way if someone adds another WebPopupType, there will be a compiler error and the person can update this code. done. > > Tools/DumpRenderTree/chromium/WebViewHost.cpp:261 > > + // In Chromium, we do not this method. > > Nit: This comment isn't that useful. Can you either explain why we don't need this method or just remove the comment? done. 433093 8 99880 webkit.review.bot 2011-07-06 16:14:41 -0700 Comment on attachment 99880 patch v2 Rejecting attachment 99880 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: yer request failed: MERGE of '/repository/webkit/trunk': timed out waiting for server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 572 Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/8984925 433116 9 99880 tony 2011-07-06 16:46:42 -0700 Comment on attachment 99880 patch v2 trying again 433126 10 99880 webkit.review.bot 2011-07-06 17:09:49 -0700 Comment on attachment 99880 patch v2 Clearing flags on attachment: 99880 Committed r90518: <http://trac.webkit.org/changeset/90518> 433127 11 webkit.review.bot 2011-07-06 17:09:54 -0700 All reviewed patches have been landed. Closing bug. 433565 12 eric 2011-07-07 10:17:17 -0700 *** Bug 61515 has been marked as a duplicate of this bug. *** 99545 2011-07-01 18:31:50 -0700 2011-07-06 09:45:46 -0700 patch v1 select-crash-new.patch text/plain 5959 jnd SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5MDMwNykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDctMDEgIEpvaG5ueSBEaW5nICA8am5kQGNocm9taXVtLm9yZz4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM4NTcKKyAgICAgICAg Q2hlY2sgV2ViV2lkZ2V0Q2xpZW50IGJlZm9yZSBjYWxsaW5nIGl0IHRvIGNsb3NlIHdpZGdldC4g IAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3Jj L1dlYlBvcHVwTWVudUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQb3B1cE1lbnVJbXBs Ojpwb3B1cENsb3NlZCk6CisKIDIwMTEtMDctMDEgIFNjb3R0IEJ5ZXIgIDxzY290dGJ5ZXJAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBsLmNwcAkocmV2aXNp b24gOTAyNDUpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBs LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc1LDcgKzM3NSw4IEBAIHZvaWQgV2ViUG9wdXBNZW51 SW1wbDo6cG9wdXBDbG9zZWQoRnJhbWUKICAgICAgICAgbV93aWRnZXQtPnNldENsaWVudCgwKTsK ICAgICAgICAgbV93aWRnZXQgPSAwOwogICAgIH0KLSAgICBtX2NsaWVudC0+Y2xvc2VXaWRnZXRT b29uKCk7CisgICAgaWYgKG1fY2xpZW50KQorICAgICAgICBtX2NsaWVudC0+Y2xvc2VXaWRnZXRT b29uKCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJbmRleDogVG9vbHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gOTAzMDcpCisrKyBUb29s cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wNy0wMSAg Sm9obm55IERpbmcgIDxqbmRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mzg1NworICAgICAgICBJbXBsZW1lbnQgY3JlYXRl UG9wdXBNZW51IGZvciBDaHJvbWl1bSBEUlQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9z dC5jcHA6CisgICAgICAgIChXZWJWaWV3SG9zdDo6Y3JlYXRlUG9wdXBNZW51KToKKyAgICAgICAg KFdlYlZpZXdIb3N0Ojp+V2ViVmlld0hvc3QpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2No cm9taXVtL1dlYlZpZXdIb3N0Lmg6CisKIDIwMTEtMDctMDEgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBUdXJuIG9mZiBuZXctcnVuLXdlYmtpdC10ZXN0cyBhbmQg cmVtb3ZlIHNvbWUgZGVidWcgbG9nZ2luZy4KSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL1dlYlZpZXdIb3N0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAJKHJldmlzaW9uIDkwMjQ1KQorKysgVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00 Niw2ICs0Niw4IEBACiAjaW5jbHVkZSAiV2ViR2VvbG9jYXRpb25DbGllbnRNb2NrLmgiCiAjaW5j bHVkZSAiV2ViSGlzdG9yeUl0ZW0uaCIKICNpbmNsdWRlICJXZWJOb2RlLmgiCisjaW5jbHVkZSAi V2ViUG9wdXBNZW51LmgiCisjaW5jbHVkZSAiV2ViUG9wdXBUeXBlLmgiCiAjaW5jbHVkZSAiV2Vi UmFuZ2UuaCIKICNpbmNsdWRlICJXZWJSZWN0LmgiCiAjaW5jbHVkZSAiV2ViU2NyZWVuSW5mby5o IgpAQCAtMjM2LDEzICsyMzgsMjggQEAgV2ViVmlldyogV2ViVmlld0hvc3Q6OmNyZWF0ZVZpZXco V2ViRnJhbQogICAgIHJldHVybiBtX3NoZWxsLT5jcmVhdGVOZXdXaW5kb3coV2ViVVJMKCkpLT53 ZWJWaWV3KCk7CiB9CiAKLVdlYldpZGdldCogV2ViVmlld0hvc3Q6OmNyZWF0ZVBvcHVwTWVudShX ZWJQb3B1cFR5cGUpCitXZWJXaWRnZXQqIFdlYlZpZXdIb3N0OjpjcmVhdGVQb3B1cE1lbnUoV2Vi UG9wdXBUeXBlIHR5cGUpCiB7Ci0gICAgcmV0dXJuIDA7CisgICAgc3dpdGNoICh0eXBlKSB7Cisg ICAgY2FzZSBXZWJLaXQ6OldlYlBvcHVwVHlwZU5vbmU6ICAvLyBOb3RoaW5nIHRvIGNyZWF0ZS4K KyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBXZWJLaXQ6OldlYlBvcHVwVHlwZVNlbGVjdDoKKyAg ICBjYXNlIFdlYktpdDo6V2ViUG9wdXBUeXBlU3VnZ2VzdGlvbjogeworICAgICAgICBXZWJXaWRn ZXQqIHdpZGdldCA9IFdlYlBvcHVwTWVudTo6Y3JlYXRlKE5VTEwpOworICAgICAgICBpZiAod2lk Z2V0KQorICAgICAgICAgIG1fcG9wdXBtZW51cy5hcHBlbmQod2lkZ2V0KTsKKyAgICAgICAgcmV0 dXJuIHdpZGdldDsKKyAgICB9CisgICAgZGVmYXVsdDoKKyAgICAgICAgQVNTRVJUX05PVF9SRUFD SEVEKCk7CisgICAgfQorICAgIHJldHVybiBOVUxMOwogfQogCiBXZWJXaWRnZXQqIFdlYlZpZXdI b3N0OjpjcmVhdGVQb3B1cE1lbnUoY29uc3QgV2ViUG9wdXBNZW51SW5mbyYpCiB7CisgICAgLy8g SW4gQ2hyb21pdW0sIHdlIGRvIG5vdCB0aGlzIG1ldGhvZC4KKyAgICBBU1NFUlRfTk9UX1JFQUNI RUQoKTsKICAgICByZXR1cm4gMDsKIH0KIApAQCAtMTE1NCw4ICsxMTcxLDExIEBAIFdlYlZpZXdI b3N0Ojp+V2ViVmlld0hvc3QoKQogICAgICAgICBsb2FkVVJMRm9yRnJhbWUoR1VSTCgiYWJvdXQ6 YmxhbmsiKSwgV2ViU3RyaW5nKCkpOwogICAgIH0KIAotICAgIHdlYldpZGdldCgpLT5jbG9zZSgp OworICAgIGZvciAoVmVjdG9yPFdlYktpdDo6V2ViV2lkZ2V0Kj46Oml0ZXJhdG9yIGl0ID0gbV9w b3B1cG1lbnVzLmJlZ2luKCk7CisgICAgICAgICBpdCA8IG1fcG9wdXBtZW51cy5lbmQoKTsgKytp dCkKKyAgICAgICAgKCppdCktPmNsb3NlKCk7CiAKKyAgICB3ZWJXaWRnZXQoKS0+Y2xvc2UoKTsK ICAgICBpZiAobV9pbk1vZGFsTG9vcCkKICAgICAgICAgd2Via2l0X3N1cHBvcnQ6OlF1aXRNZXNz YWdlTG9vcCgpOwogfQpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmll d0hvc3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJW aWV3SG9zdC5oCShyZXZpc2lvbiA5MDI0NSkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL1dlYlZpZXdIb3N0LmgJKHdvcmtpbmcgY29weSkKQEAgLTM1MCw2ICszNTAsNyBAQCBwcml2 YXRlOgogICAgIFdlYktpdDo6V2ViVGV4dENoZWNraW5nQ29tcGxldGlvbiogbV9sYXN0UmVxdWVz dGVkVGV4dENoZWNraW5nQ29tcGxldGlvbjsKIAogICAgIFRhc2tMaXN0IG1fdGFza0xpc3Q7Cisg ICAgVmVjdG9yPFdlYktpdDo6V2ViV2lkZ2V0Kj4gbV9wb3B1cG1lbnVzOwogfTsKIAogI2VuZGlm IC8vIFdlYlZpZXdIb3N0X2gKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwMzA3KQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDctMDEg IEpvaG5ueSBEaW5nICA8am5kQGNocm9taXVtLm9yZz4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM4NTcKKyAgICAgICAgUmVtb3ZlIHNvbWUgY3Jh c2ggZXhwZWN0YXRpb24gYWZ0ZXIgaW1wbGVtZW50aW5nICJjcmVhdGVQb3B1cE1lbnUiCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9j aHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTEtMDctMDEgIEtlbnQgVGFtdXJh ICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcu CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBl Y3RhdGlvbnMudHh0CShyZXZpc2lvbiA5MDI0NSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2No cm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMjYyNywxMyAr MjYyNywxMiBAQCBCVUdfRFJUIE1BQyA6IGZhc3QvZG9tL1dpbmRvdy9QbHVnLWlucy5oCiBCVUdf RFJUIE1BQyA6IGZhc3QvZG9tL1dpbmRvdy9hbGVydC11bmRlZmluZWQuaHRtbCA9IFRJTUVPVVQg UEFTUwogQlVHX0RSVCBNQUMgOiBmYXN0L2RvbS9iZWZvcmVsb2FkL3NjcmlwdC1iZWZvcmUtbG9h ZC1keW5hbWljLmh0bWwgPSBUSU1FT1VUIFBBU1MKIEJVR19EUlQgOiBmYXN0L2R5bmFtaWMvd2lu ZG93LXJlc2l6ZS1zY3JvbGxiYXJzLXRlc3QuaHRtbCA9IElNQUdFK1RFWFQKLUJVR19EUlQgTElO VVggOiBmYXN0L2V2ZW50cy9zZWxlY3Qtb25jaGFuZ2UtY3Jhc2guaHRtbCA9IENSQVNICiBCVUdf RFJUIERFQlVHIDogZmFzdC9mcmFtZXMvY2FsY3VsYXRlLXJvdW5kLmh0bWwgPSBUSU1FT1VUIFBB U1MKIEJVR19EUlQgQlVHQ1I0Mzg5MCBXSU4gREVCVUcgU0xPVyA6IGZhc3QvZm9ybXMvaW1wbGlj aXQtc3VibWlzc2lvbi5odG1sID0gUEFTUyBURVhUCiBCVUdfRFJUIEJVR0NSNDM4OTAgTElOVVgg OiBmYXN0L2Zvcm1zL2ltcGxpY2l0LXN1Ym1pc3Npb24uaHRtbCA9IENSQVNICiBCVUdfRFJUIEJV R0NSNDM4OTAgTUFDIERFQlVHIFNMT1cgOiBmYXN0L2Zvcm1zL2ltcGxpY2l0LXN1Ym1pc3Npb24u aHRtbCA9IFBBU1MgVEVYVAotQlVHX0RSVCBCVUdDUjIxMTQxIExJTlVYIDogZmFzdC9mb3Jtcy9z ZWxlY3QtZG91YmxlLW9uY2hhbmdlLmh0bWwgPSBDUkFTSCBGQUlMCi1CVUdfRFJUIEJVR0NSMjEx NDEgTElOVVggOiBmYXN0L2Zvcm1zL3NlbGVjdC1zY3JpcHQtb25jaGFuZ2UuaHRtbCA9IENSQVNI IEZBSUwKK0JVR19EUlQgQlVHQ1IyMTE0MSBMSU5VWCA6IGZhc3QvZm9ybXMvc2VsZWN0LWRvdWJs ZS1vbmNoYW5nZS5odG1sID0gRkFJTAorQlVHX0RSVCBCVUdDUjIxMTQxIExJTlVYIDogZmFzdC9m b3Jtcy9zZWxlY3Qtc2NyaXB0LW9uY2hhbmdlLmh0bWwgPSBGQUlMCiBCVUdfRFJUIE1BQyA6IGZh c3QvaW1hZ2VzL2V4dHJhLWltYWdlLWluLWltYWdlLWRvY3VtZW50Lmh0bWwgPSBUSU1FT1VUIFBB U1MKIEJVR19EUlQgTUFDIDogZmFzdC9sb2FkZXIvZm9udC1mYWNlLWVtcHR5Lmh0bWwgPSBUSU1F T1VUIFBBU1MKIEJVR19EUlQgTUFDIDogZmFzdC9sb2FkZXIvZm9yLXdpbmRvdy1ldmVudC1vbmxv YWQtc2NyaXB0cy5odG1sID0gVElNRU9VVCBQQVNTCg== 99845 2011-07-06 09:45:46 -0700 2011-07-06 09:47:13 -0700 patch v1 (fix style complain) select-crash-new2.patch text/plain 5917 jnd SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5MDMwNykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDctMDEgIEpvaG5ueSBEaW5nICA8am5kQGNocm9taXVtLm9yZz4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM4NTcKKyAgICAgICAg Q2hlY2sgV2ViV2lkZ2V0Q2xpZW50IGJlZm9yZSBjYWxsaW5nIGl0IHRvIGNsb3NlIHdpZGdldC4g IAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3Jj L1dlYlBvcHVwTWVudUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQb3B1cE1lbnVJbXBs Ojpwb3B1cENsb3NlZCk6CisKIDIwMTEtMDctMDEgIFNjb3R0IEJ5ZXIgIDxzY290dGJ5ZXJAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBsLmNwcAkocmV2aXNp b24gOTAyNDUpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBs LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc1LDcgKzM3NSw4IEBAIHZvaWQgV2ViUG9wdXBNZW51 SW1wbDo6cG9wdXBDbG9zZWQoRnJhbWUKICAgICAgICAgbV93aWRnZXQtPnNldENsaWVudCgwKTsK ICAgICAgICAgbV93aWRnZXQgPSAwOwogICAgIH0KLSAgICBtX2NsaWVudC0+Y2xvc2VXaWRnZXRT b29uKCk7CisgICAgaWYgKG1fY2xpZW50KQorICAgICAgICBtX2NsaWVudC0+Y2xvc2VXaWRnZXRT b29uKCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJbmRleDogVG9vbHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gOTAzMDcpCisrKyBUb29s cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wNy0wMSAg Sm9obm55IERpbmcgIDxqbmRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mzg1NworICAgICAgICBJbXBsZW1lbnQgY3JlYXRl UG9wdXBNZW51IGZvciBDaHJvbWl1bSBEUlQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9z dC5jcHA6CisgICAgICAgIChXZWJWaWV3SG9zdDo6Y3JlYXRlUG9wdXBNZW51KToKKyAgICAgICAg KFdlYlZpZXdIb3N0Ojp+V2ViVmlld0hvc3QpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2No cm9taXVtL1dlYlZpZXdIb3N0Lmg6CisKIDIwMTEtMDctMDEgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBUdXJuIG9mZiBuZXctcnVuLXdlYmtpdC10ZXN0cyBhbmQg cmVtb3ZlIHNvbWUgZGVidWcgbG9nZ2luZy4KSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL1dlYlZpZXdIb3N0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAJKHJldmlzaW9uIDkwMjQ1KQorKysgVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00 Niw2ICs0Niw4IEBACiAjaW5jbHVkZSAiV2ViR2VvbG9jYXRpb25DbGllbnRNb2NrLmgiCiAjaW5j bHVkZSAiV2ViSGlzdG9yeUl0ZW0uaCIKICNpbmNsdWRlICJXZWJOb2RlLmgiCisjaW5jbHVkZSAi V2ViUG9wdXBNZW51LmgiCisjaW5jbHVkZSAiV2ViUG9wdXBUeXBlLmgiCiAjaW5jbHVkZSAiV2Vi UmFuZ2UuaCIKICNpbmNsdWRlICJXZWJSZWN0LmgiCiAjaW5jbHVkZSAiV2ViU2NyZWVuSW5mby5o IgpAQCAtMjM2LDEzICsyMzgsMjggQEAgV2ViVmlldyogV2ViVmlld0hvc3Q6OmNyZWF0ZVZpZXco V2ViRnJhbQogICAgIHJldHVybiBtX3NoZWxsLT5jcmVhdGVOZXdXaW5kb3coV2ViVVJMKCkpLT53 ZWJWaWV3KCk7CiB9CiAKLVdlYldpZGdldCogV2ViVmlld0hvc3Q6OmNyZWF0ZVBvcHVwTWVudShX ZWJQb3B1cFR5cGUpCitXZWJXaWRnZXQqIFdlYlZpZXdIb3N0OjpjcmVhdGVQb3B1cE1lbnUoV2Vi UG9wdXBUeXBlIHR5cGUpCiB7CisgICAgc3dpdGNoICh0eXBlKSB7CisgICAgY2FzZSBXZWJLaXQ6 OldlYlBvcHVwVHlwZU5vbmU6CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgV2ViS2l0OjpXZWJQ b3B1cFR5cGVTZWxlY3Q6CisgICAgY2FzZSBXZWJLaXQ6OldlYlBvcHVwVHlwZVN1Z2dlc3Rpb246 IHsKKyAgICAgICAgV2ViV2lkZ2V0KiB3aWRnZXQgPSBXZWJQb3B1cE1lbnU6OmNyZWF0ZSgwKTsK KyAgICAgICAgaWYgKHdpZGdldCkKKyAgICAgICAgICAgIG1fcG9wdXBtZW51cy5hcHBlbmQod2lk Z2V0KTsKKyAgICAgICAgcmV0dXJuIHdpZGdldDsKKyAgICB9CisgICAgZGVmYXVsdDoKKyAgICAg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgfQogICAgIHJldHVybiAwOwogfQogCiBXZWJX aWRnZXQqIFdlYlZpZXdIb3N0OjpjcmVhdGVQb3B1cE1lbnUoY29uc3QgV2ViUG9wdXBNZW51SW5m byYpCiB7CisgICAgLy8gSW4gQ2hyb21pdW0sIHdlIGRvIG5vdCB0aGlzIG1ldGhvZC4KKyAgICBB U1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICByZXR1cm4gMDsKIH0KIApAQCAtMTE1NCw4ICsxMTcx LDExIEBAIFdlYlZpZXdIb3N0Ojp+V2ViVmlld0hvc3QoKQogICAgICAgICBsb2FkVVJMRm9yRnJh bWUoR1VSTCgiYWJvdXQ6YmxhbmsiKSwgV2ViU3RyaW5nKCkpOwogICAgIH0KIAotICAgIHdlYldp ZGdldCgpLT5jbG9zZSgpOworICAgIGZvciAoVmVjdG9yPFdlYktpdDo6V2ViV2lkZ2V0Kj46Oml0 ZXJhdG9yIGl0ID0gbV9wb3B1cG1lbnVzLmJlZ2luKCk7CisgICAgICAgICBpdCA8IG1fcG9wdXBt ZW51cy5lbmQoKTsgKytpdCkKKyAgICAgICAgKCppdCktPmNsb3NlKCk7CiAKKyAgICB3ZWJXaWRn ZXQoKS0+Y2xvc2UoKTsKICAgICBpZiAobV9pbk1vZGFsTG9vcCkKICAgICAgICAgd2Via2l0X3N1 cHBvcnQ6OlF1aXRNZXNzYWdlTG9vcCgpOwogfQpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUv Y2hyb21pdW0vV2ViVmlld0hvc3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oCShyZXZpc2lvbiA5MDI0NSkKKysrIFRvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmgJKHdvcmtpbmcgY29weSkKQEAgLTM1MCw2 ICszNTAsNyBAQCBwcml2YXRlOgogICAgIFdlYktpdDo6V2ViVGV4dENoZWNraW5nQ29tcGxldGlv biogbV9sYXN0UmVxdWVzdGVkVGV4dENoZWNraW5nQ29tcGxldGlvbjsKIAogICAgIFRhc2tMaXN0 IG1fdGFza0xpc3Q7CisgICAgVmVjdG9yPFdlYktpdDo6V2ViV2lkZ2V0Kj4gbV9wb3B1cG1lbnVz OwogfTsKIAogI2VuZGlmIC8vIFdlYlZpZXdIb3N0X2gKSW5kZXg6IExheW91dFRlc3RzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwMzA3 KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDctMDEgIEpvaG5ueSBEaW5nICA8am5kQGNocm9taXVtLm9yZz4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM4NTcKKyAgICAgICAg UmVtb3ZlIHNvbWUgY3Jhc2ggZXhwZWN0YXRpb24gYWZ0ZXIgaW1wbGVtZW50aW5nICJjcmVhdGVQ b3B1cE1lbnUiCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTEtMDct MDEgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFRvbnkgQ2hhbmcuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CShyZXZpc2lvbiA5MDI0NSkKKysrIExheW91dFRl c3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5 KQpAQCAtMjYyNywxMyArMjYyNywxMiBAQCBCVUdfRFJUIE1BQyA6IGZhc3QvZG9tL1dpbmRvdy9Q bHVnLWlucy5oCiBCVUdfRFJUIE1BQyA6IGZhc3QvZG9tL1dpbmRvdy9hbGVydC11bmRlZmluZWQu aHRtbCA9IFRJTUVPVVQgUEFTUwogQlVHX0RSVCBNQUMgOiBmYXN0L2RvbS9iZWZvcmVsb2FkL3Nj cmlwdC1iZWZvcmUtbG9hZC1keW5hbWljLmh0bWwgPSBUSU1FT1VUIFBBU1MKIEJVR19EUlQgOiBm YXN0L2R5bmFtaWMvd2luZG93LXJlc2l6ZS1zY3JvbGxiYXJzLXRlc3QuaHRtbCA9IElNQUdFK1RF WFQKLUJVR19EUlQgTElOVVggOiBmYXN0L2V2ZW50cy9zZWxlY3Qtb25jaGFuZ2UtY3Jhc2guaHRt bCA9IENSQVNICiBCVUdfRFJUIERFQlVHIDogZmFzdC9mcmFtZXMvY2FsY3VsYXRlLXJvdW5kLmh0 bWwgPSBUSU1FT1VUIFBBU1MKIEJVR19EUlQgQlVHQ1I0Mzg5MCBXSU4gREVCVUcgU0xPVyA6IGZh c3QvZm9ybXMvaW1wbGljaXQtc3VibWlzc2lvbi5odG1sID0gUEFTUyBURVhUCiBCVUdfRFJUIEJV R0NSNDM4OTAgTElOVVggOiBmYXN0L2Zvcm1zL2ltcGxpY2l0LXN1Ym1pc3Npb24uaHRtbCA9IENS QVNICiBCVUdfRFJUIEJVR0NSNDM4OTAgTUFDIERFQlVHIFNMT1cgOiBmYXN0L2Zvcm1zL2ltcGxp Y2l0LXN1Ym1pc3Npb24uaHRtbCA9IFBBU1MgVEVYVAotQlVHX0RSVCBCVUdDUjIxMTQxIExJTlVY IDogZmFzdC9mb3Jtcy9zZWxlY3QtZG91YmxlLW9uY2hhbmdlLmh0bWwgPSBDUkFTSCBGQUlMCi1C VUdfRFJUIEJVR0NSMjExNDEgTElOVVggOiBmYXN0L2Zvcm1zL3NlbGVjdC1zY3JpcHQtb25jaGFu Z2UuaHRtbCA9IENSQVNIIEZBSUwKK0JVR19EUlQgQlVHQ1IyMTE0MSBMSU5VWCA6IGZhc3QvZm9y bXMvc2VsZWN0LWRvdWJsZS1vbmNoYW5nZS5odG1sID0gRkFJTAorQlVHX0RSVCBCVUdDUjIxMTQx IExJTlVYIDogZmFzdC9mb3Jtcy9zZWxlY3Qtc2NyaXB0LW9uY2hhbmdlLmh0bWwgPSBGQUlMCiBC VUdfRFJUIE1BQyA6IGZhc3QvaW1hZ2VzL2V4dHJhLWltYWdlLWluLWltYWdlLWRvY3VtZW50Lmh0 bWwgPSBUSU1FT1VUIFBBU1MKIEJVR19EUlQgTUFDIDogZmFzdC9sb2FkZXIvZm9udC1mYWNlLWVt cHR5Lmh0bWwgPSBUSU1FT1VUIFBBU1MKIEJVR19EUlQgTUFDIDogZmFzdC9sb2FkZXIvZm9yLXdp bmRvdy1ldmVudC1vbmxvYWQtc2NyaXB0cy5odG1sID0gVElNRU9VVCBQQVNTCg== 99880 2011-07-06 14:23:14 -0700 2011-07-06 17:09:49 -0700 patch v2 select-crash-new2.patch text/plain 5849 jnd SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5MDMwNykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDctMDEgIEpvaG5ueSBEaW5nICA8am5kQGNocm9taXVtLm9yZz4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM4NTcKKyAgICAgICAg Q2hlY2sgV2ViV2lkZ2V0Q2xpZW50IGJlZm9yZSBjYWxsaW5nIGl0IHRvIGNsb3NlIHdpZGdldC4g IAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3Jj L1dlYlBvcHVwTWVudUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQb3B1cE1lbnVJbXBs Ojpwb3B1cENsb3NlZCk6CisKIDIwMTEtMDctMDEgIFNjb3R0IEJ5ZXIgIDxzY290dGJ5ZXJAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBsLmNwcAkocmV2aXNp b24gOTAyNDUpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBs LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc1LDcgKzM3NSw4IEBAIHZvaWQgV2ViUG9wdXBNZW51 SW1wbDo6cG9wdXBDbG9zZWQoRnJhbWUKICAgICAgICAgbV93aWRnZXQtPnNldENsaWVudCgwKTsK ICAgICAgICAgbV93aWRnZXQgPSAwOwogICAgIH0KLSAgICBtX2NsaWVudC0+Y2xvc2VXaWRnZXRT b29uKCk7CisgICAgaWYgKG1fY2xpZW50KQorICAgICAgICBtX2NsaWVudC0+Y2xvc2VXaWRnZXRT b29uKCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJbmRleDogVG9vbHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gOTAzMDcpCisrKyBUb29s cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wNy0wMSAg Sm9obm55IERpbmcgIDxqbmRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mzg1NworICAgICAgICBJbXBsZW1lbnQgY3JlYXRl UG9wdXBNZW51IGZvciBDaHJvbWl1bSBEUlQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9z dC5jcHA6CisgICAgICAgIChXZWJWaWV3SG9zdDo6Y3JlYXRlUG9wdXBNZW51KToKKyAgICAgICAg KFdlYlZpZXdIb3N0Ojp+V2ViVmlld0hvc3QpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2No cm9taXVtL1dlYlZpZXdIb3N0Lmg6CisKIDIwMTEtMDctMDEgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBUdXJuIG9mZiBuZXctcnVuLXdlYmtpdC10ZXN0cyBhbmQg cmVtb3ZlIHNvbWUgZGVidWcgbG9nZ2luZy4KSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL1dlYlZpZXdIb3N0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAJKHJldmlzaW9uIDkwMjQ1KQorKysgVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00 Niw2ICs0Niw4IEBACiAjaW5jbHVkZSAiV2ViR2VvbG9jYXRpb25DbGllbnRNb2NrLmgiCiAjaW5j bHVkZSAiV2ViSGlzdG9yeUl0ZW0uaCIKICNpbmNsdWRlICJXZWJOb2RlLmgiCisjaW5jbHVkZSAi V2ViUG9wdXBNZW51LmgiCisjaW5jbHVkZSAiV2ViUG9wdXBUeXBlLmgiCiAjaW5jbHVkZSAiV2Vi UmFuZ2UuaCIKICNpbmNsdWRlICJXZWJSZWN0LmgiCiAjaW5jbHVkZSAiV2ViU2NyZWVuSW5mby5o IgpAQCAtMjM2LDEzICsyMzgsMjMgQEAgV2ViVmlldyogV2ViVmlld0hvc3Q6OmNyZWF0ZVZpZXco V2ViRnJhbQogICAgIHJldHVybiBtX3NoZWxsLT5jcmVhdGVOZXdXaW5kb3coV2ViVVJMKCkpLT53 ZWJWaWV3KCk7CiB9CiAKLVdlYldpZGdldCogV2ViVmlld0hvc3Q6OmNyZWF0ZVBvcHVwTWVudShX ZWJQb3B1cFR5cGUpCitXZWJXaWRnZXQqIFdlYlZpZXdIb3N0OjpjcmVhdGVQb3B1cE1lbnUoV2Vi UG9wdXBUeXBlIHR5cGUpCiB7CisgICAgc3dpdGNoICh0eXBlKSB7CisgICAgY2FzZSBXZWJLaXQ6 OldlYlBvcHVwVHlwZU5vbmU6CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgV2ViS2l0OjpXZWJQ b3B1cFR5cGVTZWxlY3Q6CisgICAgY2FzZSBXZWJLaXQ6OldlYlBvcHVwVHlwZVN1Z2dlc3Rpb246 CisgICAgICAgIG1fcG9wdXBtZW51cy5hcHBlbmQoV2ViUG9wdXBNZW51OjpjcmVhdGUoMCkpOwor ICAgICAgICByZXR1cm4gbV9wb3B1cG1lbnVzLmxhc3QoKTsKKyAgICB9CiAgICAgcmV0dXJuIDA7 CiB9CiAKIFdlYldpZGdldCogV2ViVmlld0hvc3Q6OmNyZWF0ZVBvcHVwTWVudShjb25zdCBXZWJQ b3B1cE1lbnVJbmZvJikKIHsKKyAgICAvLyBEbyBub3QgdXNlIHRoaXMgbWV0aG9kLiBJdCdzIGJl ZW4gcmVwbGFjZWQgYnkgY3JlYXRlRXh0ZXJuYWxQb3B1cE1lbnUuCisgICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7CiAgICAgcmV0dXJuIDA7CiB9CiAKQEAgLTExNTQsOCArMTE2NiwxMSBAQCBXZWJW aWV3SG9zdDo6fldlYlZpZXdIb3N0KCkKICAgICAgICAgbG9hZFVSTEZvckZyYW1lKEdVUkwoImFi b3V0OmJsYW5rIiksIFdlYlN0cmluZygpKTsKICAgICB9CiAKLSAgICB3ZWJXaWRnZXQoKS0+Y2xv c2UoKTsKKyAgICBmb3IgKFZlY3RvcjxXZWJLaXQ6OldlYldpZGdldCo+OjppdGVyYXRvciBpdCA9 IG1fcG9wdXBtZW51cy5iZWdpbigpOworICAgICAgICAgaXQgPCBtX3BvcHVwbWVudXMuZW5kKCk7 ICsraXQpCisgICAgICAgICgqaXQpLT5jbG9zZSgpOwogCisgICAgd2ViV2lkZ2V0KCktPmNsb3Nl KCk7CiAgICAgaWYgKG1faW5Nb2RhbExvb3ApCiAgICAgICAgIHdlYmtpdF9zdXBwb3J0OjpRdWl0 TWVzc2FnZUxvb3AoKTsKIH0KSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dl YlZpZXdIb3N0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v V2ViVmlld0hvc3QuaAkocmV2aXNpb24gOTAyNDUpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9XZWJWaWV3SG9zdC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNTAsNiArMzUwLDcgQEAg cHJpdmF0ZToKICAgICBXZWJLaXQ6OldlYlRleHRDaGVja2luZ0NvbXBsZXRpb24qIG1fbGFzdFJl cXVlc3RlZFRleHRDaGVja2luZ0NvbXBsZXRpb247CiAKICAgICBUYXNrTGlzdCBtX3Rhc2tMaXN0 OworICAgIFZlY3RvcjxXZWJLaXQ6OldlYldpZGdldCo+IG1fcG9wdXBtZW51czsKIH07CiAKICNl bmRpZiAvLyBXZWJWaWV3SG9zdF9oCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA5MDMwNykKKysrIExheW91 dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDExLTA3 LTAxICBKb2hubnkgRGluZyAgPGpuZEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzODU3CisgICAgICAgIFJlbW92ZSBzb21l IGNyYXNoIGV4cGVjdGF0aW9uIGFmdGVyIGltcGxlbWVudGluZyAiY3JlYXRlUG9wdXBNZW51Igor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZv cm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0OgorCiAyMDExLTA3LTAxICBLZW50IFRh bXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IENo YW5nLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlv bnMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3Rf ZXhwZWN0YXRpb25zLnR4dAkocmV2aXNpb24gOTAyNDUpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTI2Mjcs MTMgKzI2MjcsMTIgQEAgQlVHX0RSVCBNQUMgOiBmYXN0L2RvbS9XaW5kb3cvUGx1Zy1pbnMuaAog QlVHX0RSVCBNQUMgOiBmYXN0L2RvbS9XaW5kb3cvYWxlcnQtdW5kZWZpbmVkLmh0bWwgPSBUSU1F T1VUIFBBU1MKIEJVR19EUlQgTUFDIDogZmFzdC9kb20vYmVmb3JlbG9hZC9zY3JpcHQtYmVmb3Jl LWxvYWQtZHluYW1pYy5odG1sID0gVElNRU9VVCBQQVNTCiBCVUdfRFJUIDogZmFzdC9keW5hbWlj L3dpbmRvdy1yZXNpemUtc2Nyb2xsYmFycy10ZXN0Lmh0bWwgPSBJTUFHRStURVhUCi1CVUdfRFJU IExJTlVYIDogZmFzdC9ldmVudHMvc2VsZWN0LW9uY2hhbmdlLWNyYXNoLmh0bWwgPSBDUkFTSAog QlVHX0RSVCBERUJVRyA6IGZhc3QvZnJhbWVzL2NhbGN1bGF0ZS1yb3VuZC5odG1sID0gVElNRU9V VCBQQVNTCiBCVUdfRFJUIEJVR0NSNDM4OTAgV0lOIERFQlVHIFNMT1cgOiBmYXN0L2Zvcm1zL2lt cGxpY2l0LXN1Ym1pc3Npb24uaHRtbCA9IFBBU1MgVEVYVAogQlVHX0RSVCBCVUdDUjQzODkwIExJ TlVYIDogZmFzdC9mb3Jtcy9pbXBsaWNpdC1zdWJtaXNzaW9uLmh0bWwgPSBDUkFTSAogQlVHX0RS VCBCVUdDUjQzODkwIE1BQyBERUJVRyBTTE9XIDogZmFzdC9mb3Jtcy9pbXBsaWNpdC1zdWJtaXNz aW9uLmh0bWwgPSBQQVNTIFRFWFQKLUJVR19EUlQgQlVHQ1IyMTE0MSBMSU5VWCA6IGZhc3QvZm9y bXMvc2VsZWN0LWRvdWJsZS1vbmNoYW5nZS5odG1sID0gQ1JBU0ggRkFJTAotQlVHX0RSVCBCVUdD UjIxMTQxIExJTlVYIDogZmFzdC9mb3Jtcy9zZWxlY3Qtc2NyaXB0LW9uY2hhbmdlLmh0bWwgPSBD UkFTSCBGQUlMCitCVUdfRFJUIEJVR0NSMjExNDEgTElOVVggOiBmYXN0L2Zvcm1zL3NlbGVjdC1k b3VibGUtb25jaGFuZ2UuaHRtbCA9IEZBSUwKK0JVR19EUlQgQlVHQ1IyMTE0MSBMSU5VWCA6IGZh c3QvZm9ybXMvc2VsZWN0LXNjcmlwdC1vbmNoYW5nZS5odG1sID0gRkFJTAogQlVHX0RSVCBNQUMg OiBmYXN0L2ltYWdlcy9leHRyYS1pbWFnZS1pbi1pbWFnZS1kb2N1bWVudC5odG1sID0gVElNRU9V VCBQQVNTCiBCVUdfRFJUIE1BQyA6IGZhc3QvbG9hZGVyL2ZvbnQtZmFjZS1lbXB0eS5odG1sID0g VElNRU9VVCBQQVNTCiBCVUdfRFJUIE1BQyA6IGZhc3QvbG9hZGVyL2Zvci13aW5kb3ctZXZlbnQt b25sb2FkLXNjcmlwdHMuaHRtbCA9IFRJTUVPVVQgUEFTUwo=