63853 2011-07-01 16:11:02 -0700 [GTK] editing/selection/directionality-after-undo-replace.html is failing 2015-05-07 17:48:48 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa webkit-unassigned inferno mrobinson ojan webkit.review.bot oldest_to_newest 431507 0 rniwa 2011-07-01 16:11:02 -0700 editing/selection/directionality-after-undo-replace.html has been failing since it was checked. 431521 1 mrobinson 2011-07-01 16:28:52 -0700 Thanks for filling this bug. The issue here seems to be that there are so many leapForwards that the test is exceeding the double-click timeout on GTK+. This change causes the test to start passing: --- a/LayoutTests/editing/selection/directionality-after-undo-replace.html +++ b/LayoutTests/editing/selection/directionality-after-undo-replace.html @@ -23,12 +23,11 @@ if (window.layoutTestController) { var test = document.getElementById('target'); eventSender.mouseMoveTo(target.offsetLeft + target.offsetWidth / 2, target.offsetTop + target.offsetHeight / 2); eventSender.mouseDown(); - eventSender.leapForward(200); eventSender.mouseUp(); eventSender.leapForward(200); + eventSender.mouseDown(); - eventSender.leapForward(200); eventSender.mouseUp(); document.execCommand('InsertText', false, 'a'); 431562 2 99543 rniwa 2011-07-01 18:10:31 -0700 Created attachment 99543 Patch 431572 3 99543 webkit.review.bot 2011-07-01 19:35:05 -0700 Comment on attachment 99543 Patch Clearing flags on attachment: 99543 Committed r90309: <http://trac.webkit.org/changeset/90309> 431573 4 webkit.review.bot 2011-07-01 19:35:09 -0700 All reviewed patches have been landed. Closing bug. 431576 5 rniwa 2011-07-01 22:00:31 -0700 Now the test is hitting an assertion :( http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r90310%20(23936)/editing/selection/directionality-after-undo-replace-stderr.txt 431577 6 rniwa 2011-07-01 22:02:12 -0700 This might be related to https://bugs.webkit.org/show_bug.cgi?id=63440. 431578 7 rniwa 2011-07-01 22:02:48 -0700 It's certainly related to https://bugs.webkit.org/show_bug.cgi?id=63611. 431579 8 inferno 2011-07-01 22:05:38 -0700 That is awesome!!, We can get to the root cause and have more inspiration to fix this. Fixing this might fix many textiterator read crashes. 1092910 9 mrobinson 2015-05-07 17:48:48 -0700 This seems okay now on GTK+. 99543 2011-07-01 18:10:31 -0700 2011-07-01 19:35:05 -0700 Patch bug-63853-20110701181029.patch text/plain 1547 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDkwMzA3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDctMDEgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0dUS10gZWRpdGluZy9zZWxlY3Rpb24vZGlyZWN0 aW9uYWxpdHktYWZ0ZXItdW5kby1yZXBsYWNlLmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM4NTMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBkbyBsZWFwRm9yd2FyZCBi ZXR3ZWVuIG1vdXNlRG93biBhbmQgbW91c2VVcCBzbyB0aGF0IEdUSyByZWNvZ25pemVzIHRoZSBk b3VibGUtY2xpY2suCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9kaXJlY3Rpb25hbGl0 eS1hZnRlci11bmRvLXJlcGxhY2UuaHRtbDoKKwogMjAxMS0wNy0wMSAgS2VudCBUYW11cmEgIDx0 a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KSW5k ZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2RpcmVjdGlvbmFsaXR5LWFmdGVyLXVu ZG8tcmVwbGFjZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0 aW9uL2RpcmVjdGlvbmFsaXR5LWFmdGVyLXVuZG8tcmVwbGFjZS5odG1sCShyZXZpc2lvbiA5MDMw NSkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2RpcmVjdGlvbmFsaXR5LWFmdGVy LXVuZG8tcmVwbGFjZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yMywxMiArMjMsMTEgQEAgaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgICAgICB2YXIgdGVzdCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCd0YXJnZXQnKTsKICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VN b3ZlVG8odGFyZ2V0Lm9mZnNldExlZnQgKyB0YXJnZXQub2Zmc2V0V2lkdGggLyAyLCB0YXJnZXQu b2Zmc2V0VG9wICsgdGFyZ2V0Lm9mZnNldEhlaWdodCAvIDIpOwogICAgICAgICBldmVudFNlbmRl ci5tb3VzZURvd24oKTsKLSAgICAgICAgZXZlbnRTZW5kZXIubGVhcEZvcndhcmQoMjAwKTsKICAg ICAgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOwogCiAgICAgICAgIGV2ZW50U2VuZGVyLmxlYXBG b3J3YXJkKDIwMCk7CisKICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7Ci0gICAgICAg IGV2ZW50U2VuZGVyLmxlYXBGb3J3YXJkKDIwMCk7CiAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNl VXAoKTsKIAogICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgnSW5zZXJ0VGV4dCcsIGZhbHNl LCAnYScpOwo=