63850 2011-07-01 14:41:34 -0700 [chromium] Upload root layer textures first so that it is less likely to be skipped 2011-07-01 15:04:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne enne jamesr vangelis oldest_to_newest 431460 0 enne 2011-07-01 14:41:34 -0700 [chromium] Upload root layer textures first so that it is less likely to be skipped 431462 1 99525 enne 2011-07-01 14:42:56 -0700 Created attachment 99525 Patch 431466 2 99525 jamesr 2011-07-01 14:45:48 -0700 Comment on attachment 99525 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99525&action=review Cool > Source/WebCore/ChangeLog:10 > + [chromium] Upload root layer textures first so that it is less likely to be skipped > + https://bugs.webkit.org/show_bug.cgi?id=63850 > + > + This is a tiny follow-on patch to bug 63760. If the root layer is not > + uploaded first, then it may not have enough space to fit into texture > + memory and might be skipped, leaving a blue background. > + > + Reviewed by NOBODY (OOPS!). can you put the "Reviewed by " line above the long description? 431477 3 enne 2011-07-01 15:04:41 -0700 Committed r90283: <http://trac.webkit.org/changeset/90283> 99525 2011-07-01 14:42:56 -0700 2011-07-01 14:45:48 -0700 Patch bug-63850-20110701144255.patch text/plain 1938 enne U3VidmVyc2lvbiBSZXZpc2lvbjogOTAyNDYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiY2NlYjMyYzgxZjU4Y2Rm MmZlYmQ4Y2MxYWJhZjYxZGUxNDU1NDc2Li4zNWRjMTU5NmUzYTFkOWRhY2I4ODgxYTVlNzI3OTVi NDMxNzA3ZTk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMDEgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIFVwbG9h ZCByb290IGxheWVyIHRleHR1cmVzIGZpcnN0IHNvIHRoYXQgaXQgaXMgbGVzcyBsaWtlbHkgdG8g YmUgc2tpcHBlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjM4NTAKKworICAgICAgICBUaGlzIGlzIGEgdGlueSBmb2xsb3ctb24gcGF0Y2ggdG8gYnVn IDYzNzYwLiAgSWYgdGhlIHJvb3QgbGF5ZXIgaXMgbm90CisgICAgICAgIHVwbG9hZGVkIGZpcnN0 LCB0aGVuIGl0IG1heSBub3QgaGF2ZSBlbm91Z2ggc3BhY2UgdG8gZml0IGludG8gdGV4dHVyZQor ICAgICAgICBtZW1vcnkgYW5kIG1pZ2h0IGJlIHNraXBwZWQsIGxlYXZpbmcgYSBibHVlIGJhY2tn cm91bmQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlckNocm9taXVtOjp1cGRhdGVMYXllcnMpOgor CiAyMDExLTA3LTAxICBKb29uZSBIdXIgIDxqb29uZS5odXJAY29sbGFib3JhLmNvLnVrPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRl cmVyQ2hyb21pdW0uY3BwCmluZGV4IGZkM2RlNmIyMDM0MzkyMGUyYWZmMDBhMGZlZTQ2MTZmZTlm MGI1ODYuLmQyYTZkZGEyYmFlOGZkNmM1MWE3MWZlYzE0YThiMzFiNjU5YzFhM2MgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVy ZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcApAQCAtMzQ5LDEzICszNDksMTMgQEAgdm9p ZCBMYXllclJlbmRlcmVyQ2hyb21pdW06OnVwZGF0ZUxheWVycyhMYXllckxpc3QmIHJlbmRlclN1 cmZhY2VMYXllckxpc3QpCiAjaWZuZGVmIE5ERUJVRwogICAgIHNfaW5QYWludExheWVyQ29udGVu dHMgPSBmYWxzZTsKICNlbmRpZgotCi0gICAgdXBkYXRlQ29tcG9zaXRvclJlc291cmNlcyhyZW5k ZXJTdXJmYWNlTGF5ZXJMaXN0KTsKICAgICAvLyBVcGRhdGUgY29tcG9zaXRvciByZXNvdXJjZXMg Zm9yIHJvb3QgbGF5ZXIuCiAgICAgewogICAgICAgICBUUkFDRV9FVkVOVCgiTGF5ZXJSZW5kZXJl ckNocm9taXVtOjp1cGRhdGVMYXllcjo6dXBkYXRlUm9vdCIsIHRoaXMsIDApOwogICAgICAgICBt X3Jvb3RMYXllckNvbnRlbnRUaWxlci0+dXBkYXRlUmVjdChtX3Jvb3RMYXllclRleHR1cmVVcGRh dGVyLmdldCgpKTsKICAgICB9CisKKyAgICB1cGRhdGVDb21wb3NpdG9yUmVzb3VyY2VzKHJlbmRl clN1cmZhY2VMYXllckxpc3QpOwogfQogCiB2b2lkIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6cGFp bnRMYXllckNvbnRlbnRzKGNvbnN0IExheWVyTGlzdCYgcmVuZGVyU3VyZmFjZUxheWVyTGlzdCkK