63837 2011-07-01 13:16:18 -0700 We shouldn't wait for ReportCrash while the timeout is running 2011-07-01 14:21:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dpranke eric webkit.review.bot oldest_to_newest 431386 0 abarth 2011-07-01 13:16:18 -0700 We shouldn't wait for ReportCrash while the timeout is running 431389 1 99513 abarth 2011-07-01 13:17:28 -0700 Created attachment 99513 Patch 431393 2 99513 eric 2011-07-01 13:19:59 -0700 Comment on attachment 99513 Patch Makes sense. How do we test this? 431394 3 99513 dpranke 2011-07-01 13:20:39 -0700 Comment on attachment 99513 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99513&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py:133 > + self._port.executive().wait_newest(self._port.is_crash_reporter) Does it make sense to only do this if the previous test crashed? Or was it your intent to block *every* worker if a crash reporter is running? It will be interesting to see what kind of impact that has on test run time on the many-core machines like the big mac pros and xserves. 431397 4 abarth 2011-07-01 13:23:44 -0700 > Or was it your intent to block *every* worker if a crash reporter is running? Yes. > It will be interesting to see what kind of impact that has on test run time on the many-core machines like the big mac pros and xserves. In my machine (a big mac pro), this appears to be necessary for test stability. When tests crash (rare), it adds ~minutes of waiting. 431442 5 99513 webkit.review.bot 2011-07-01 14:21:21 -0700 Comment on attachment 99513 Patch Clearing flags on attachment: 99513 Committed r90277: <http://trac.webkit.org/changeset/90277> 431443 6 webkit.review.bot 2011-07-01 14:21:25 -0700 All reviewed patches have been landed. Closing bug. 99513 2011-07-01 13:17:28 -0700 2011-07-01 14:21:21 -0700 Patch bug-63837-20110701131727.patch text/plain 2680 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkwMjY5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDctMDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBXZSBzaG91bGRuJ3Qgd2FpdCBmb3IgUmVwb3J0Q3Jhc2ggd2hpbGUgdGhlIHRpbWVv dXQgaXMgcnVubmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjM4MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbnN0ZWFkLCB3ZSBzaG91bGQgbW92ZSB0aGlzIGNoZWNrIHRvIHdvcmtlci5weS4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Np bmdsZV90ZXN0X3J1bm5lci5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9sYXlvdXRfcGFja2FnZS93b3JrZXIucHk6CisKIDIwMTEtMDctMDEgIEFkYW0gUm9iZW4g IDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3Agc2V0dGluZyB1bnNhZmUgaGVhZGVy cyBvbiBQT1NUcyB2aWEgWEhSIGZyb20gVGVzdEZhaWx1cmVzIHBhZ2UKSW5kZXg6IFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3NpbmdsZV90ZXN0X3J1 bm5lci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9sYXlvdXRfcGFja2FnZS9zaW5nbGVfdGVzdF9ydW5uZXIucHkJKHJldmlzaW9uIDkwMjYyKQor KysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2Uvc2lu Z2xlX3Rlc3RfcnVubmVyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMjUsMTEgKzEyNSw2IEBAIGNs YXNzIFNpbmdsZVRlc3RSdW5uZXI6CiAgICAgICAgIHJldHVybiBzZWxmLl9ydW5fY29tcGFyZV90 ZXN0KCkKIAogICAgIGRlZiBfcnVuX2NvbXBhcmVfdGVzdChzZWxmKToKLSAgICAgICAgIyBCZWZv cmUgcnVubmluZyB0aGUgdGVzdCwgd2Ugd2FpdCBmb3IgYW55IGNyYXNoIHJlcG9ydGVycyB0byBm aW5pc2gKLSAgICAgICAgIyBydW5uaW5nLiBPbiBNYWMsIFJlcG9ydENyYXNoIGNoZXdzIHVwIGEg YnVuY2ggb2YgcmVzb3VyY2VzIGFuZAotICAgICAgICAjIGNhdXNlcyB0aGUgdGVzdHMgdG8gYmVj b21lIHVuc3RhYmxlLCBzbyB3ZSBkb24ndCB3YW50IHRvIHJ1biBpbgotICAgICAgICAjIHBhcmFs bGVsIHdpdGggUmVwb3J0Q3Jhc2guCi0gICAgICAgIHNlbGYuX3BvcnQuZXhlY3V0aXZlKCkud2Fp dF9uZXdlc3Qoc2VsZi5fcG9ydC5pc19jcmFzaF9yZXBvcnRlcikKICAgICAgICAgZHJpdmVyX291 dHB1dCA9IHNlbGYuX2RyaXZlci5ydW5fdGVzdChzZWxmLl9kcml2ZXJfaW5wdXQoKSkKICAgICAg ICAgZXhwZWN0ZWRfZHJpdmVyX291dHB1dCA9IHNlbGYuX2V4cGVjdGVkX2RyaXZlcl9vdXRwdXQo KQogICAgICAgICB0ZXN0X3Jlc3VsdCA9IHNlbGYuX2NvbXBhcmVfb3V0cHV0KGRyaXZlcl9vdXRw dXQsIGV4cGVjdGVkX2RyaXZlcl9vdXRwdXQpCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS93b3JrZXIucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2Uvd29ya2VyLnB5 CShyZXZpc2lvbiA5MDI2MikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L2xheW91dF9wYWNrYWdlL3dvcmtlci5weQkod29ya2luZyBjb3B5KQpAQCAtMTI2LDYgKzEyNiwx MiBAQCBjbGFzcyBXb3JrZXIobWFuYWdlcl93b3JrZXJfYnJva2VyLkFic3RyCiAgICAgICAgIHNl bGYuX2RvbmUgPSBUcnVlCiAKICAgICBkZWYgX3J1bl90ZXN0KHNlbGYsIHRlc3RfaW5wdXQpOgor ICAgICAgICAjIEJlZm9yZSBydW5uaW5nIHRoZSB0ZXN0LCB3ZSB3YWl0IGZvciBhbnkgY3Jhc2gg cmVwb3J0ZXJzIHRvIGZpbmlzaAorICAgICAgICAjIHJ1bm5pbmcuIE9uIE1hYywgUmVwb3J0Q3Jh c2ggY2hld3MgdXAgYSBidW5jaCBvZiByZXNvdXJjZXMgYW5kCisgICAgICAgICMgY2F1c2VzIHRo ZSB0ZXN0cyB0byBiZWNvbWUgdW5zdGFibGUsIHNvIHdlIGRvbid0IHdhbnQgdG8gcnVuIGluCisg ICAgICAgICMgcGFyYWxsZWwgd2l0aCBSZXBvcnRDcmFzaC4KKyAgICAgICAgc2VsZi5fcG9ydC5l eGVjdXRpdmUoKS53YWl0X25ld2VzdChzZWxmLl9wb3J0LmlzX2NyYXNoX3JlcG9ydGVyKQorCiAg ICAgICAgIHRlc3RfdGltZW91dF9zZWMgPSBzZWxmLnRpbWVvdXQodGVzdF9pbnB1dCkKICAgICAg ICAgc3RhcnQgPSB0aW1lLnRpbWUoKQogICAgICAgICBzZWxmLl93b3JrZXJfY29ubmVjdGlvbi5w b3N0X21lc3NhZ2UoJ3N0YXJ0ZWRfdGVzdCcsIHRlc3RfaW5wdXQsIHRlc3RfdGltZW91dF9zZWMp Cg==