63835 2011-07-01 12:54:15 -0700 WorkerScriptLoader::notifyFinished() ASSERTs on re-entry 2011-07-01 15:06:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62066 1 japhet japhet dimich levin webkit.review.bot oldest_to_newest 431366 0 japhet 2011-07-01 12:54:15 -0700 Specifically, WorkerScriptLoader::notifyFinished() will lead to unsetPendingAcitivity() being called for its ActiveDOMObject client. If it re-enters, activity is unset twice and we assert. 431368 1 99509 japhet 2011-07-01 12:57:03 -0700 Created attachment 99509 patch 431428 2 99509 dimich 2011-07-01 14:07:58 -0700 Comment on attachment 99509 patch r=me. Could you please add a description of a scenario when re-entrance happens in this bug? To document the case. 431429 3 japhet 2011-07-01 14:08:26 -0700 (In reply to comment #2) > (From update of attachment 99509 [details]) > r=me. Could you please add a description of a scenario when re-entrance happens in this bug? To document the case. The sequence that causes this re-entrancy is: * WorkerScriptLoader fails, Worker::notifyFinished() is called. * notifyFinished() calls unsetPendingActivity() and fires the Worker's error event. * The error event cancels the load (e.g., window.stop). This causes DocumentLoader to cancel all SubresourceLoaders. * The WorkerScriptLoader's SubresourceLoader hasn't been removed from the DocumentLoader's list yet, so it is cancelled again, causing unsetPendingActivity() to be called a second time. 431479 4 99509 webkit.review.bot 2011-07-01 15:06:20 -0700 Comment on attachment 99509 patch Clearing flags on attachment: 99509 Committed r90284: <http://trac.webkit.org/changeset/90284> 431480 5 webkit.review.bot 2011-07-01 15:06:24 -0700 All reviewed patches have been landed. Closing bug. 99509 2011-07-01 12:57:03 -0700 2011-07-01 15:06:20 -0700 patch wsl.txt text/plain 3586 japhet SW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy93b3JrZXItZmluaXNoLWNyYXNoLWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWZp bmlzaC1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L3dvcmtlcnMvd29ya2VyLWZpbmlzaC1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMyBAQAorVGVzdCB0byBlbnN1cmUgdGhhdCBmaW5pc2hpbmcgYSBXb3JrZXIgd29u J3QgcmUtZW50ZXIuIFdlIHBhc3MgaWYgd2UgZG9uJ3QgY3Jhc2guCisKKwpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1maW5pc2gtY3Jhc2guaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWZpbmlzaC1jcmFzaC5odG1sCShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1maW5pc2gtY3Jhc2gu aHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxOCBAQAorPGJvZHk+Cis8cD5UZXN0IHRvIGVu c3VyZSB0aGF0IGZpbmlzaGluZyBhIFdvcmtlciB3b24ndCByZS1lbnRlci4gV2UgcGFzcyBpZiB3 ZSBkb24ndCBjcmFzaC48L3A+Cis8c2NyaXB0PgorCitpZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIGxh eW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKK30KKwordmFyIHdvcmtlciA9IG5l dyBXb3JrZXIoImRvZXMtbm90LWV4aXN0LmpzIik7Cit3b3JrZXIub25lcnJvciA9IGZ1bmN0aW9u KCkgeworICAgIHdpbmRvdy5zdG9wKCk7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworfQorCis8 L3NjcmlwdD4KKzwvYm9keT4KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwMjY3KQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDctMDEg IE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KKworICAgICAgICBUZXN0IGZvciBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM4MzUuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3dvcmtlcnMvd29y a2VyLWZpbmlzaC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvd29y a2Vycy93b3JrZXItZmluaXNoLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDExLTA3LTAxICBNaWhh aSBQYXJwYXJpdGEgIDxtaWhhaXBAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBtb3JlIGZh aWxpbmcgdGVzdCBleHBlY3RhdGlvbnMgZm9yIENocm9taXVtIG1lZGlhIHRlc3RzIG9uIFdpbmRv d3MgNwpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTAyNjcpCisrKyBTb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wNy0wMSAgTmF0 ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEVuc3VyZSBXb3JrZXJT Y3JpcHRMb2FkZXI6Om5vdGlmeUZpbmlzaGVkKCkgZG9lc24ndCByZS1lbnRlci4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzODM1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC93b3JrZXJz L3dvcmtlci1maW5pc2gtY3Jhc2guaHRtbAorCisgICAgICAgICogd29ya2Vycy9Xb3JrZXJTY3Jp cHRMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyU2NyaXB0TG9hZGVyOjpXb3Jr ZXJTY3JpcHRMb2FkZXIpOgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyU2NyaXB0TG9hZGVyOjpu b3RpZnlGaW5pc2hlZCk6CisgICAgICAgICogd29ya2Vycy9Xb3JrZXJTY3JpcHRMb2FkZXIuaDoK KwogMjAxMS0wNy0wMSAgVmFuZ2VsaXMgS29ra2V2aXMgIDx2YW5nZWxpc0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS93b3JrZXJzL1dvcmtlclNjcmlwdExvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJTY3JpcHRMb2FkZXIuY3BwCShyZXZpc2lvbiA5MDIzMCkK KysrIFNvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyU2NyaXB0TG9hZGVyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNTIsNiArNTIsNyBAQAogICAgICwgbV9mYWlsZWQoZmFsc2UpCiAgICAgLCBt X2lkZW50aWZpZXIoMCkKICAgICAsIG1fdGFyZ2V0VHlwZSh0YXJnZXRUeXBlKQorICAgICwgbV9m aW5pc2hpbmcoZmFsc2UpCiB7CiB9CiAKQEAgLTE4MSw4ICsxODIsMTEgQEAKICAgICAKIHZvaWQg V29ya2VyU2NyaXB0TG9hZGVyOjpub3RpZnlGaW5pc2hlZCgpCiB7Ci0gICAgaWYgKG1fY2xpZW50 KQotICAgICAgICBtX2NsaWVudC0+bm90aWZ5RmluaXNoZWQoKTsKKyAgICBpZiAoIW1fY2xpZW50 IHx8IG1fZmluaXNoaW5nKQorICAgICAgICByZXR1cm47CisKKyAgICBtX2ZpbmlzaGluZyA9IHRy dWU7CisgICAgbV9jbGllbnQtPm5vdGlmeUZpbmlzaGVkKCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyU2NyaXB0TG9hZGVy LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJTY3JpcHRMb2Fk ZXIuaAkocmV2aXNpb24gOTAyMzApCisrKyBTb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlclNj cmlwdExvYWRlci5oCSh3b3JraW5nIGNvcHkpCkBAIC05Miw2ICs5Miw3IEBACiAgICAgICAgIGJv b2wgbV9mYWlsZWQ7CiAgICAgICAgIHVuc2lnbmVkIGxvbmcgbV9pZGVudGlmaWVyOwogICAgICAg ICBSZXNvdXJjZVJlcXVlc3RCYXNlOjpUYXJnZXRUeXBlIG1fdGFyZ2V0VHlwZTsKKyAgICAgICAg Ym9vbCBtX2ZpbmlzaGluZzsKICAgICB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==