6380 2006-01-04 23:05:24 -0800 bison reports conflicts in CSS parser 2008-07-28 09:48:29 -0700 1 1 1 Unclassified WebKit CSS 420+ Mac OS X 10.4 RESOLVED FIXED P3 Normal --- 8055 1 ricciadams webkit-unassigned ap ian webkit oldest_to_newest 27766 0 ricciadams 2006-01-04 23:05:24 -0800 Upon checking a change to the JavaScript parser, I noticed that the CSS yacc file was reporting 37 shift/ reduce conflicts and 4 reduce/reduce conflicts. Excerpt from build log below. ... /bin/sh -c bison\ -d\ -p\ cssyy\ \"$INPUT_FILE_PATH\"\ -o\ \"$DERIVED_FILE_DIR/$INPUT_FILE_BASE.cpp \" cat\ \"$DERIVED_FILE_DIR/$INPUT_FILE_BASE.cpp.h\"\ \"$DERIVED_FILE_DIR/$INPUT_FILE_BASE.hpp\"\ >\ \"$DERIVED_FILE_DIR/$INPUT_FILE_BASE.h\"\ 2>\ /dev/null\ ||\ echo\ -n /Volumes/Home/Projects/WebKit/WebCore/khtml/css/parser.y contains 37 shift/reduce conflicts and 4 reduce/reduce conflicts. ... 27786 1 ggaren 2006-01-05 09:09:17 -0800 Is this a recent behavior change? (I checked in a change to the lexer on 1/4. Previously, I didn't think we had any conflicts.) 28021 2 ggaren 2006-01-08 18:10:01 -0800 Disregard previous comment. I thought we were talking about the JS parser. 28062 3 darin 2006-01-09 09:09:17 -0800 When I removed all the conflicts from the JavaScript grammar, I took a lot at doing it for the CSS grammar too. One of the biggest challenges is the curious handling of whitespace (done because whitespace is significant in selector syntax, but could be done differently). 28911 4 christopher_jerome 2006-01-19 08:36:49 -0800 (In reply to comment #0) > Upon checking a change to the JavaScript parser, I noticed that the CSS yacc file was reporting 37 shift/ > reduce conflicts and 4 reduce/reduce conflicts. Excerpt from build log below. > > ... > /bin/sh -c bison\ -d\ -p\ cssyy\ \"$INPUT_FILE_PATH\"\ -o\ \"$DERIVED_FILE_DIR/ $INPUT_FILE_BASE.cpp > \" > cat\ \"$DERIVED_FILE_DIR/$INPUT_FILE_BASE.cpp.h\"\ \"$DERIVED_FILE_DIR/$INPUT_FILE_BASE.hpp \"\ >\ > \"$DERIVED_FILE_DIR/$INPUT_FILE_BASE.h\"\ 2>\ /dev/null\ ||\ echo\ -n > /Volumes/Home/Projects/WebKit/WebCore/khtml/css/parser.y contains 37 shift/reduce conflicts and 4 > reduce/reduce conflicts. > ... I Have noticed this too, I have seen shift/reduce reduce/reduce conflicts for a while now. It is still the same. Also why are we not using bison 2.x.x on OS X? is there a particular 'technical' or engineering reason for this? 87134 5 webkit 2008-07-28 02:59:26 -0700 I think the bug was fixed long time ago. Any confirmations? 87154 6 ap 2008-07-28 07:33:51 -0700 CSSGrammar.y has 49 shift/reduce conflicts now, which are silenced with an %expect. Assuming we have no reduce/reduce conflicts, I think that this can be closed - shift/reduce ones do not necessarily indicate real bugs. 87163 7 webkit 2008-07-28 09:48:29 -0700 (In reply to comment #6) > Assuming we have no reduce/reduce conflicts, I think that this can be > closed - shift/reduce ones do not necessarily indicate real bugs. > Done.