63795 2011-07-01 02:09:54 -0700 ReportCrash destabilizes new-run-webkit-tests 2011-07-01 13:21:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth dpranke eric ossy oldest_to_newest 431062 0 abarth 2011-07-01 02:09:54 -0700 ReportCrash destabilizes new-run-webkit-tests 431063 1 99445 abarth 2011-07-01 02:12:51 -0700 Created attachment 99445 Patch 431267 2 99445 abarth 2011-07-01 11:14:41 -0700 Comment on attachment 99445 Patch Clearing flags on attachment: 99445 Committed r90246: <http://trac.webkit.org/changeset/90246> 431268 3 abarth 2011-07-01 11:14:44 -0700 All reviewed patches have been landed. Closing bug. 431275 4 99445 eric 2011-07-01 11:21:06 -0700 Comment on attachment 99445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99445&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:671 > + if self._port.executive().running_pids(self._port.is_crash_reporter): This call is expensive. How often do we run this? 431277 5 eric 2011-07-01 11:21:23 -0700 CCing ossy in case this slows down the Qt bots again. 431285 6 abarth 2011-07-01 11:30:47 -0700 > This call is expensive. How often do we run this? Once a second. If it turns out to be a problem, I have an idea how to optimize it. 431296 7 eric 2011-07-01 11:37:24 -0700 It's not entirely clear to me why ReportCrash would destablize the run, since DRT should theoretically be taking up 100% of the CPU before it crashes, so the fact that ReportCrash is taking up 100% of that core in DRT's stead should be OK. Do we run more DRTs than we have cores? (Actually I think we run 2x iirc?) 431304 8 abarth 2011-07-01 11:41:51 -0700 Maybe it's something specific to my system? ReportCrash make the UI in all my programs sluggish, maybe because causing the kernel to do a lot of work somehow? Anecdotally, this patch has been a big stability win on my machine. Crashes in some tests used to trigger other tests to timeout, and that doesn't happen anymore. 431364 9 99445 dpranke 2011-07-01 12:50:10 -0700 Comment on attachment 99445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99445&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:132 > + self._port.executive().wait_newest(self._port.is_crash_reporter) You might want to wait for the crash reporter in worker._run_test instead, since you can do in between tests (when the test timeout does not apply). 431395 10 abarth 2011-07-01 13:21:34 -0700 > You might want to wait for the crash reporter in worker._run_test instead, since you can do in between tests (when the test timeout does not apply). https://bugs.webkit.org/show_bug.cgi?id=63837 99445 2011-07-01 02:12:51 -0700 2011-07-01 12:50:10 -0700 Patch bug-63795-20110701021250.patch text/plain 5755 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkwMjIwKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMjUgQEAKKzIwMTEtMDctMDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBvcnRDcmFz aCBkZXN0YWJpbGl6ZXMgbmV3LXJ1bi13ZWJraXQtdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNzk1CisKKyAgICAgICAgUmVwb3J0Q3Jhc2gg Y2hld3MgdXAgdG9vIG1hbnkgc3lzdGVtIHJlc291cmNlcyB0aGF0IGl0IGRlc3RhYmxpemVzCisg ICAgICAgIHRlc3RzIHJ1biBjb25jdXJyZW50bHkuICBUaGlzIHBhdGNoIGNhdXNlcyB1cyB0byBz cGluIGRvd24gYWxsIHRoZQorICAgICAgICB3b3JrZXIgcHJvY2Vzc2VzIHdoZW4gUmVwb3J0Q3Jh c2ggaXMgcnVubmluZy4KKworICAgICAgICBBbHNvLCB0aGlzIHBhdGNoIGNhdXNlcyB0aGUgbWFz dGVyIHByb2Nlc3MgdG8gdGVsbCB0aGUgdXNlciB3ZSdyZQorICAgICAgICB3YWl0aW5nIGZvciB0 aGUgY3Jhc2ggcmVwb3J0ZXIgcmF0aGVyIHRoYW4gaGF2aW5nIHRoYXQgYmUgdGhlIHdvcmtlcidz CisgICAgICAgIGpvYi4gIFRoaXMgc3RvcHMgdGhlIHVzZXIgZnJvbSBnZXR0aW5nIHNwYW1tZWQg d2l0aCB0b28gbWFueSAid2FpdGluZworICAgICAgICBmb3IgY3Jhc2ggcmVwb3J0ZXIiIG1lc3Nh Z2VzIGFuZCBhbHNvIGNsZWFucyB1cCBzb21lIG1pbm9yIFVJIGlzc3VlcworICAgICAgICB3aXRo IHRoZSBtZXRlci4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xh eW91dF9wYWNrYWdlL21hbmFnZXIucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvbGF5b3V0X3BhY2thZ2Uvc2luZ2xlX3Rlc3RfcnVubmVyLnB5OgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weToKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5OgorCiAy MDExLTA3LTAxICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByOTAyMTMuCkluZGV4OiBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9tYW5hZ2VyLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNr YWdlL21hbmFnZXIucHkJKHJldmlzaW9uIDkwMjE0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvbWFuYWdlci5weQkod29ya2luZyBjb3B5KQpA QCAtNjY4LDcgKzY2OCw5IEBAIGNsYXNzIE1hbmFnZXI6CiAKICAgICAgICAgdHJ5OgogICAgICAg ICAgICAgd2hpbGUgbm90IHNlbGYuaXNfZG9uZSgpOgotICAgICAgICAgICAgICAgICMgRklYTUU6 IERvIHdlIG5lZWQgdG8gcnVuIGluIGEgbG9vcCBhbnltb3JlPworICAgICAgICAgICAgICAgIGlm IHNlbGYuX3BvcnQuZXhlY3V0aXZlKCkucnVubmluZ19waWRzKHNlbGYuX3BvcnQuaXNfY3Jhc2hf cmVwb3J0ZXIpOgorICAgICAgICAgICAgICAgICAgICBzZWxmLl9wcmludGVyLnByaW50X3VwZGF0 ZSgiV2FpdGluZyBmb3IgY3Jhc2ggcmVwb3J0ZXIgLi4uIikKKyAgICAgICAgICAgICAgICAgICAg c2VsZi5fcG9ydC5leGVjdXRpdmUoKS53YWl0X25ld2VzdChzZWxmLl9wb3J0LmlzX2NyYXNoX3Jl cG9ydGVyKQogICAgICAgICAgICAgICAgIG1hbmFnZXJfY29ubmVjdGlvbi5ydW5fbWVzc2FnZV9s b29wKGRlbGF5X3NlY3M9MS4wKQogCiAgICAgICAgICAgICAjIE1ha2Ugc3VyZSBhbGwgb2YgdGhl IHdvcmtlcnMgaGF2ZSBzaHV0IGRvd24gKGlmIHBvc3NpYmxlKS4KQEAgLTc4Miw5ICs3ODQsNyBA QCBjbGFzcyBNYW5hZ2VyOgogCiAgICAgICAgIHN0YXJ0X3RpbWUgPSB0aW1lLnRpbWUoKQogCi0g ICAgICAgIGludGVycnVwdGVkLCBrZXlib2FyZF9pbnRlcnJ1cHRlZCwgdGhyZWFkX3RpbWluZ3Ms IHRlc3RfdGltaW5ncywgXAotICAgICAgICAgICAgaW5kaXZpZHVhbF90ZXN0X3RpbWluZ3MgPSAo Ci0gICAgICAgICAgICBzZWxmLl9ydW5fdGVzdHMoc2VsZi5fdGVzdF9maWxlc19saXN0LCByZXN1 bHRfc3VtbWFyeSkpCisgICAgICAgIGludGVycnVwdGVkLCBrZXlib2FyZF9pbnRlcnJ1cHRlZCwg dGhyZWFkX3RpbWluZ3MsIHRlc3RfdGltaW5ncywgaW5kaXZpZHVhbF90ZXN0X3RpbWluZ3MgPSBz ZWxmLl9ydW5fdGVzdHMoc2VsZi5fdGVzdF9maWxlc19saXN0LCByZXN1bHRfc3VtbWFyeSkKIAog ICAgICAgICAjIFdlIGV4Y2x1ZGUgdGhlIGNyYXNoZXMgZnJvbSB0aGUgbGlzdCBvZiByZXN1bHRz IHRvIHJldHJ5LCBiZWNhdXNlCiAgICAgICAgICMgd2Ugd2FudCB0byB0cmVhdCBldmVuIGEgcG90 ZW50aWFsbHkgZmxha3kgY3Jhc2ggYXMgYW4gZXJyb3IuCkluZGV4OiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9zaW5nbGVfdGVzdF9ydW5uZXIucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0 X3BhY2thZ2Uvc2luZ2xlX3Rlc3RfcnVubmVyLnB5CShyZXZpc2lvbiA5MDIxMikKKysrIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3NpbmdsZV90ZXN0 X3J1bm5lci5weQkod29ya2luZyBjb3B5KQpAQCAtMTI1LDYgKzEyNSwxMSBAQCBjbGFzcyBTaW5n bGVUZXN0UnVubmVyOgogICAgICAgICByZXR1cm4gc2VsZi5fcnVuX2NvbXBhcmVfdGVzdCgpCiAK ICAgICBkZWYgX3J1bl9jb21wYXJlX3Rlc3Qoc2VsZik6CisgICAgICAgICMgQmVmb3JlIHJ1bm5p bmcgdGhlIHRlc3QsIHdlIHdhaXQgZm9yIGFueSBjcmFzaCByZXBvcnRlcnMgdG8gZmluaXNoCisg ICAgICAgICMgcnVubmluZy4gT24gTWFjLCBSZXBvcnRDcmFzaCBjaGV3cyB1cCBhIGJ1bmNoIG9m IHJlc291cmNlcyBhbmQKKyAgICAgICAgIyBjYXVzZXMgdGhlIHRlc3RzIHRvIGJlY29tZSB1bnN0 YWJsZSwgc28gd2UgZG9uJ3Qgd2FudCB0byBydW4gaW4KKyAgICAgICAgIyBwYXJhbGxlbCB3aXRo IFJlcG9ydENyYXNoLgorICAgICAgICBzZWxmLl9wb3J0LmV4ZWN1dGl2ZSgpLndhaXRfbmV3ZXN0 KHNlbGYuX3BvcnQuaXNfY3Jhc2hfcmVwb3J0ZXIpCiAgICAgICAgIGRyaXZlcl9vdXRwdXQgPSBz ZWxmLl9kcml2ZXIucnVuX3Rlc3Qoc2VsZi5fZHJpdmVyX2lucHV0KCkpCiAgICAgICAgIGV4cGVj dGVkX2RyaXZlcl9vdXRwdXQgPSBzZWxmLl9leHBlY3RlZF9kcml2ZXJfb3V0cHV0KCkKICAgICAg ICAgdGVzdF9yZXN1bHQgPSBzZWxmLl9jb21wYXJlX291dHB1dChkcml2ZXJfb3V0cHV0LCBleHBl Y3RlZF9kcml2ZXJfb3V0cHV0KQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9iYXNlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQkocmV2aXNpb24gOTAyMTIpCisrKyBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkJKHdvcmtpbmcgY29weSkKQEAg LTEzOCw2ICsxMzgsOSBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgIHNlbGYuX3Jlc3Vs dHNfZGlyZWN0b3J5ID0gTm9uZQogICAgICAgICBzZWxmLnNldF9vcHRpb25fZGVmYXVsdCgndXNl X2FwYWNoZScsIHNlbGYuX2RlZmF1bHRfdG9fYXBhY2hlKCkpCiAKKyAgICBkZWYgZXhlY3V0aXZl KHNlbGYpOgorICAgICAgICByZXR1cm4gc2VsZi5fZXhlY3V0aXZlCisKICAgICBkZWYgd2RpZmZf YXZhaWxhYmxlKHNlbGYpOgogICAgICAgICBpZiBzZWxmLl93ZGlmZl9hdmFpbGFibGUgaXMgTm9u ZToKICAgICAgICAgICAgIHNlbGYuX3dkaWZmX2F2YWlsYWJsZSA9IHNlbGYuY2hlY2tfd2RpZmYo bG9nZ2luZz1GYWxzZSkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQkocmV2aXNpb24gOTAyMTIp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9j ZXNzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNzIsNyArMTcyLDYgQEAgY2xhc3MgU2VydmVyUHJv Y2VzczoKICAgICAgICAgaWYgc3lzLnBsYXRmb3JtICE9ICJkYXJ3aW4iOgogICAgICAgICAgICAg cmV0dXJuCiAgICAgICAgIHRyeToKLSAgICAgICAgICAgIHNlbGYuX2xvZygnU2FtcGxpbmcgJXMg cHJvY2Vzcy4uLiAodXNlIC0tbm8tc2FtcGxlLW9uLXRpbWVvdXQgdG8gc2tpcCB0aGlzIHN0ZXAp JyAlIHNlbGYuX25hbWUpCiAgICAgICAgICAgICBoYW5nX3JlcG9ydCA9IG9zLnBhdGguam9pbihz ZWxmLl9wb3J0LnJlc3VsdHNfZGlyZWN0b3J5KCksICIlcy0lcy5zYW1wbGUudHh0IiAlIChzZWxm Ll9uYW1lLCBzZWxmLl9wcm9jLnBpZCkpCiAgICAgICAgICAgICBzZWxmLl9leGVjdXRpdmUucnVu X2NvbW1hbmQoWwogICAgICAgICAgICAgICAgICIvdXNyL2Jpbi9zYW1wbGUiLApAQCAtMTk3LDEx ICsxOTYsOSBAQCBjbGFzcyBTZXJ2ZXJQcm9jZXNzOgogCiAgICAgICAgICAgICBub3cgPSB0aW1l LnRpbWUoKQogICAgICAgICAgICAgaWYgbm93ID4gZGVhZGxpbmU6Ci0gICAgICAgICAgICAgICAg aWYgc2VsZi5fZXhlY3V0aXZlLnJ1bm5pbmdfcGlkcyhzZWxmLl9wb3J0LmlzX2NyYXNoX3JlcG9y dGVyKToKLSAgICAgICAgICAgICAgICAgICAgc2VsZi5fbG9nKCdXYWl0aW5nIGZvciBjcmFzaCBy ZXBvcnRlci4uLicpCi0gICAgICAgICAgICAgICAgICAgIHNlbGYuX2V4ZWN1dGl2ZS53YWl0X25l d2VzdChzZWxmLl9wb3J0LmlzX2NyYXNoX3JlcG9ydGVyKQotICAgICAgICAgICAgICAgICAgICBp ZiBub3Qgc2VsZi5jcmFzaGVkOgotICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5fY2hlY2tf Zm9yX2NyYXNoKCkKKyAgICAgICAgICAgICAgICBzZWxmLl9leGVjdXRpdmUud2FpdF9uZXdlc3Qo c2VsZi5fcG9ydC5pc19jcmFzaF9yZXBvcnRlcikKKyAgICAgICAgICAgICAgICBpZiBub3Qgc2Vs Zi5jcmFzaGVkOgorICAgICAgICAgICAgICAgICAgICBzZWxmLl9jaGVja19mb3JfY3Jhc2goKQog ICAgICAgICAgICAgICAgIHNlbGYudGltZWRfb3V0ID0gVHJ1ZQogICAgICAgICAgICAgICAgIGlm IG5vdCBzZWxmLmNyYXNoZWQ6CiAgICAgICAgICAgICAgICAgICAgIHNlbGYuX3NhbXBsZSgpCg==