63779 2011-06-30 18:44:30 -0700 [WebKit2] Fix code paths that can leave frame view paint behavior in the wrong state 2011-08-05 11:23:46 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin webkit.review.bot oldest_to_newest 430927 0 darin 2011-06-30 18:44:30 -0700 [WebKit2] Fix code paths that can leave frame view paint behavior in the wrong state 430928 1 99415 darin 2011-06-30 18:47:00 -0700 Created attachment 99415 Patch 447302 2 99415 webkit.review.bot 2011-08-05 11:23:42 -0700 Comment on attachment 99415 Patch Clearing flags on attachment: 99415 Committed r92491: <http://trac.webkit.org/changeset/92491> 447303 3 webkit.review.bot 2011-08-05 11:23:46 -0700 All reviewed patches have been landed. Closing bug. 99415 2011-06-30 18:47:00 -0700 2011-08-05 11:23:42 -0700 Patch bug-63779-20110630184658.patch text/plain 4811 darin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwMTkwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDYtMzAgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtXZWJLaXQyXSBGaXggY29kZSBwYXRocyB0aGF0IGNhbiBsZWF2ZSBm cmFtZSB2aWV3IHBhaW50IGJlaGF2aW9yIGluIHRoZSB3cm9uZyBzdGF0ZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM3NzkKKworICAgICAgICAqIFdl YlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGx1Z2lu Vmlldzo6aGFuZGxlRXZlbnQpOiBVbnJlbGF0ZWQgY2xlYW51cC4gUmVtb3ZlZCB1bm5lZWRlZCBs b2NhbCB2YXJpYWJsZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c25hcHNob3RJblZpZXdDb29yZGluYXRlcyk6 IFJlYXJyYW5nZWQgY29kZSBzbyB0aGF0IHRoZSBjYWxsIHRvCisgICAgICAgIHNldFBhaW50QmVo YXZpb3IgaXMgYWZ0ZXIgdGhlIGVhcmx5IGV4aXQuIEFsc28gZ290IHJpZCBvZiB1bm5lZWRlZCBz YXZlL3Jlc3RvcmUgc2luY2UKKyAgICAgICAgdGhlIGZ1bmN0aW9uIHVzZXMgYSBncmFwaGljcyBj b250ZXh0IHRoYXQgaXQgdGhlbiB0aHJvd3MgYXdheS4KKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZTo6c2NhbGVkU25hcHNob3RJbkRvY3VtZW50Q29vcmRpbmF0ZXMpOiBEaXR0by4KKwogMjAxMS0w Ni0zMCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgV2lu ZG93cyBidWlsZC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVn aW5WaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdp bnMvUGx1Z2luVmlldy5jcHAJKHJldmlzaW9uIDkwMTg5KQorKysgU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzgsOCAr NTc4LDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpoYW5kbGVFdmVudChFdmVudCogZXZlbgogICAgICAg ICAgICAgZm9jdXNQbHVnaW5FbGVtZW50KCk7CiAgICAgICAgIAogICAgICAgICAvLyBBZGp1c3Qg bW91c2UgY29vcmRpbmF0ZXMgdG8gYWNjb3VudCBmb3IgcGFnZVNjYWxlRmFjdG9yCi0gICAgICAg IGZsb2F0IHNjYWxlRmFjdG9yID0gZnJhbWUoKS0+cGFnZVNjYWxlRmFjdG9yKCk7Ci0gICAgICAg IFdlYk1vdXNlRXZlbnQgZXZlbnRXaXRoU2NhbGVkQ29vcmRpbmF0ZXMoKihzdGF0aWNfY2FzdDxj b25zdCBXZWJNb3VzZUV2ZW50Kj4oY3VycmVudEV2ZW50KSksIHNjYWxlRmFjdG9yKTsKKyAgICAg ICAgV2ViTW91c2VFdmVudCBldmVudFdpdGhTY2FsZWRDb29yZGluYXRlcygqc3RhdGljX2Nhc3Q8 Y29uc3QgV2ViTW91c2VFdmVudCo+KGN1cnJlbnRFdmVudCksIGZyYW1lKCktPnBhZ2VTY2FsZUZh Y3RvcigpKTsKICAgICAgICAgZGlkSGFuZGxlRXZlbnQgPSBtX3BsdWdpbi0+aGFuZGxlTW91c2VF dmVudChldmVudFdpdGhTY2FsZWRDb29yZGluYXRlcyk7CiAgICAgfSBlbHNlIGlmIChldmVudC0+ dHlwZSgpID09IGV2ZW50TmFtZXMoKS5tb3VzZXdoZWVsRXZlbnQgJiYgY3VycmVudEV2ZW50LT50 eXBlKCkgPT0gV2ViRXZlbnQ6OldoZWVsKSB7CiAgICAgICAgIC8vIFdlIGhhdmUgYSB3aGVlbCBl dmVudC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5jcHAJKHJldmlzaW9uIDkwMTg5KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NjksMjIgKzg2OSwxOCBAQCBQYXNz UmVmUHRyPFdlYkltYWdlPiBXZWJQYWdlOjpzbmFwc2hvdEluCiAgICAgaWYgKCFmcmFtZVZpZXcp CiAgICAgICAgIHJldHVybiAwOwogCi0gICAgZnJhbWVWaWV3LT51cGRhdGVMYXlvdXRBbmRTdHls ZUlmTmVlZGVkUmVjdXJzaXZlKCk7Ci0KLSAgICBQYWludEJlaGF2aW9yIG9sZEJlaGF2aW9yID0g ZnJhbWVWaWV3LT5wYWludEJlaGF2aW9yKCk7Ci0gICAgZnJhbWVWaWV3LT5zZXRQYWludEJlaGF2 aW9yKG9sZEJlaGF2aW9yIHwgUGFpbnRCZWhhdmlvckZsYXR0ZW5Db21wb3NpdGluZ0xheWVycyk7 Ci0KICAgICBSZWZQdHI8V2ViSW1hZ2U+IHNuYXBzaG90ID0gV2ViSW1hZ2U6OmNyZWF0ZShyZWN0 LnNpemUoKSwgb3B0aW9ucyk7CiAgICAgaWYgKCFzbmFwc2hvdC0+Yml0bWFwKCkpCiAgICAgICAg IHJldHVybiAwOwogICAgIAogICAgIE93blB0cjxXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ+IGdy YXBoaWNzQ29udGV4dCA9IHNuYXBzaG90LT5iaXRtYXAoKS0+Y3JlYXRlR3JhcGhpY3NDb250ZXh0 KCk7Ci0KLSAgICBncmFwaGljc0NvbnRleHQtPnNhdmUoKTsKICAgICBncmFwaGljc0NvbnRleHQt PnRyYW5zbGF0ZSgtcmVjdC54KCksIC1yZWN0LnkoKSk7Ci0gICAgZnJhbWVWaWV3LT5wYWludChn cmFwaGljc0NvbnRleHQuZ2V0KCksIHJlY3QpOwotICAgIGdyYXBoaWNzQ29udGV4dC0+cmVzdG9y ZSgpOwogCisgICAgZnJhbWVWaWV3LT51cGRhdGVMYXlvdXRBbmRTdHlsZUlmTmVlZGVkUmVjdXJz aXZlKCk7CisKKyAgICBQYWludEJlaGF2aW9yIG9sZEJlaGF2aW9yID0gZnJhbWVWaWV3LT5wYWlu dEJlaGF2aW9yKCk7CisgICAgZnJhbWVWaWV3LT5zZXRQYWludEJlaGF2aW9yKG9sZEJlaGF2aW9y IHwgUGFpbnRCZWhhdmlvckZsYXR0ZW5Db21wb3NpdGluZ0xheWVycyk7CisgICAgZnJhbWVWaWV3 LT5wYWludChncmFwaGljc0NvbnRleHQuZ2V0KCksIHJlY3QpOwogICAgIGZyYW1lVmlldy0+c2V0 UGFpbnRCZWhhdmlvcihvbGRCZWhhdmlvcik7CiAKICAgICByZXR1cm4gc25hcHNob3QucmVsZWFz ZSgpOwpAQCAtODk2LDMwICs4OTIsMjAgQEAgUGFzc1JlZlB0cjxXZWJJbWFnZT4gV2ViUGFnZTo6 c2NhbGVkU25hcAogICAgIGlmICghZnJhbWVWaWV3KQogICAgICAgICByZXR1cm4gMDsKIAotICAg IGZyYW1lVmlldy0+dXBkYXRlTGF5b3V0QW5kU3R5bGVJZk5lZWRlZFJlY3Vyc2l2ZSgpOwotCi0g ICAgUGFpbnRCZWhhdmlvciBvbGRCZWhhdmlvciA9IGZyYW1lVmlldy0+cGFpbnRCZWhhdmlvcigp OwotICAgIGZyYW1lVmlldy0+c2V0UGFpbnRCZWhhdmlvcihvbGRCZWhhdmlvciB8IFBhaW50QmVo YXZpb3JGbGF0dGVuQ29tcG9zaXRpbmdMYXllcnMpOwotCi0gICAgYm9vbCBzY2FsZSA9IHNjYWxl RmFjdG9yICE9IDE7Ci0gICAgSW50U2l6ZSBzaXplID0gcmVjdC5zaXplKCk7Ci0gICAgaWYgKHNj YWxlKSAKLSAgICAgICAgc2l6ZSA9IEludFNpemUoY2VpbChyZWN0LndpZHRoKCkgKiBzY2FsZUZh Y3RvciksIGNlaWwocmVjdC5oZWlnaHQoKSAqIHNjYWxlRmFjdG9yKSk7Ci0KKyAgICBJbnRTaXpl IHNpemUoY2VpbChyZWN0LndpZHRoKCkgKiBzY2FsZUZhY3RvciksIGNlaWwocmVjdC5oZWlnaHQo KSAqIHNjYWxlRmFjdG9yKSk7CiAgICAgUmVmUHRyPFdlYkltYWdlPiBzbmFwc2hvdCA9IFdlYklt YWdlOjpjcmVhdGUoc2l6ZSwgb3B0aW9ucyk7CiAgICAgaWYgKCFzbmFwc2hvdC0+Yml0bWFwKCkp CiAgICAgICAgIHJldHVybiAwOwotICAgIAorCiAgICAgT3duUHRyPFdlYkNvcmU6OkdyYXBoaWNz Q29udGV4dD4gZ3JhcGhpY3NDb250ZXh0ID0gc25hcHNob3QtPmJpdG1hcCgpLT5jcmVhdGVHcmFw aGljc0NvbnRleHQoKTsKLSAgICBncmFwaGljc0NvbnRleHQtPnNhdmUoKTsKLSAgICAKLSAgICBp ZiAoc2NhbGUpCi0gICAgICAgIGdyYXBoaWNzQ29udGV4dC0+c2NhbGUoRmxvYXRTaXplKHNjYWxl RmFjdG9yLCBzY2FsZUZhY3RvcikpOwotICAgIAorICAgIGdyYXBoaWNzQ29udGV4dC0+c2NhbGUo RmxvYXRTaXplKHNjYWxlRmFjdG9yLCBzY2FsZUZhY3RvcikpOwogICAgIGdyYXBoaWNzQ29udGV4 dC0+dHJhbnNsYXRlKC1yZWN0LngoKSwgLXJlY3QueSgpKTsKLSAgICBmcmFtZVZpZXctPnBhaW50 Q29udGVudHMoZ3JhcGhpY3NDb250ZXh0LmdldCgpLCByZWN0KTsKLSAgICBncmFwaGljc0NvbnRl eHQtPnJlc3RvcmUoKTsKIAorICAgIGZyYW1lVmlldy0+dXBkYXRlTGF5b3V0QW5kU3R5bGVJZk5l ZWRlZFJlY3Vyc2l2ZSgpOworCisgICAgUGFpbnRCZWhhdmlvciBvbGRCZWhhdmlvciA9IGZyYW1l Vmlldy0+cGFpbnRCZWhhdmlvcigpOworICAgIGZyYW1lVmlldy0+c2V0UGFpbnRCZWhhdmlvcihv bGRCZWhhdmlvciB8IFBhaW50QmVoYXZpb3JGbGF0dGVuQ29tcG9zaXRpbmdMYXllcnMpOworICAg IGZyYW1lVmlldy0+cGFpbnRDb250ZW50cyhncmFwaGljc0NvbnRleHQuZ2V0KCksIHJlY3QpOwog ICAgIGZyYW1lVmlldy0+c2V0UGFpbnRCZWhhdmlvcihvbGRCZWhhdmlvcik7CiAKICAgICByZXR1 cm4gc25hcHNob3QucmVsZWFzZSgpOwo=