63763 2011-06-30 15:51:55 -0700 new-run-webkit-tests should stop when I ^C it 2011-06-30 16:07:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dpranke eric webkit.review.bot oldest_to_newest 430751 0 abarth 2011-06-30 15:51:55 -0700 new-run-webkit-tests should stop when I ^C it 430753 1 99383 abarth 2011-06-30 15:53:23 -0700 Created attachment 99383 Patch 430761 2 99383 dpranke 2011-06-30 16:00:25 -0700 Comment on attachment 99383 Patch Ah! I'd been meaning to figure out why that had regressed. Thanks for fixing this. 430765 3 dpranke 2011-06-30 16:02:48 -0700 Oh, as to the "not fast enough" comment ... I agree that it's slow, but much of that slowness is in trying to make sure everything gets cleaned up properly. On some platforms it appears that the child processes don't always get killed themselves by the ctrl-C. I don't know how much actual room for improvement there may be (in the sense that I literally have no idea, not that I think I had previously done the best possible job). 430770 4 99383 abarth 2011-06-30 16:05:28 -0700 Comment on attachment 99383 Patch Yeah, I don't have any ideas for making it faster. Just that it should be faster. :) 430775 5 abarth 2011-06-30 16:07:20 -0700 Committed r90176: <http://trac.webkit.org/changeset/90176> 99383 2011-06-30 15:53:23 -0700 2011-06-30 16:05:28 -0700 Patch bug-63763-20110630155322.patch text/plain 2264 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkwMTc0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMDYtMzAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBuZXctcnVuLXdl YmtpdC10ZXN0cyBzaG91bGQgc3RvcCB3aGVuIEkgXkMgaXQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNzYzCisKKyAgICAgICAgSXQgc3RpbGwgZG9l c24ndCBzdG9wIGZhc3QgZW5vdWdoLCBidXQgYXQgbGVhc3Qgd2l0aCB0aGlzIHBhdGNoIGl0Cisg ICAgICAgIGRvZXNuJ3QgcnVuIG1vcmUgdGVzdHMuCisKKyAgICAgICAgQWxzbywgSSB0d2Vha2Vk IHRoZSBVSSB0aGF0IGhhcHBlbnMgd2hlbiB0aGVyZSdzIGEga2V5Ym9hcmQgaW50ZXJydXB0Cisg ICAgICAgIHRvIG5vdCBiZSBhbWF6aW5nbHkgdWdseS4gIFRoZXJlJ3Mgc3RpbGwgYSBnYXJiYWdl ICJUZSIgbGVmdCBvbiB0aGUKKyAgICAgICAgY29uc29sZSwgYnV0IHRoYXQncyBhIHByb2JsZW0g Zm9yIGFub3RoZXIgZGF5LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvbGF5b3V0X3BhY2thZ2UvbWFuYWdlci5weToKKwogMjAxMS0wNi0zMCAgQWRhbSBSb2JlbiAg PGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBUZXN0RmFpbHVyZXMgbmV2ZXIgdHJl YXQgYSB0b28tbWFueS1mYWlsdXJlcyBidWlsZCBhcyBhIGxhc3QtcGFzc2luZyBidWlsZCBmb3Ig YSB0ZXN0CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRf cGFja2FnZS9tYW5hZ2VyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL21hbmFnZXIucHkJKHJldmlzaW9uIDkwMTQxKQor KysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvbWFu YWdlci5weQkod29ya2luZyBjb3B5KQpAQCAtNjg3LDcgKzY4Nyw3IEBAIGNsYXNzIE1hbmFnZXI6 CiAgICAgICAgICAgICAgICAgICAgICAgICBfbG9nLmVycm9yKCdXb3JrZXIgJWQgZGlkIG5vdCBl eGl0IGluIHRpbWUuJyAlIHdvcmtlcl9zdGF0ZS5udW1iZXIpCiAKICAgICAgICAgZXhjZXB0IEtl eWJvYXJkSW50ZXJydXB0OgotICAgICAgICAgICAgX2xvZy5pbmZvKCJJbnRlcnJ1cHRlZCwgZXhp dGluZyIpCisgICAgICAgICAgICBzZWxmLl9wcmludGVyLnByaW50X3VwZGF0ZSgnSW50ZXJydXB0 ZWQsIGV4aXRpbmcgLi4uJykKICAgICAgICAgICAgIHNlbGYuY2FuY2VsX3dvcmtlcnMoKQogICAg ICAgICAgICAga2V5Ym9hcmRfaW50ZXJydXB0ZWQgPSBUcnVlCiAgICAgICAgIGV4Y2VwdCBUZXN0 UnVuSW50ZXJydXB0ZWRFeGNlcHRpb24sIGU6CkBAIC03OTcsOCArNzk3LDcgQEAgY2xhc3MgTWFu YWdlcjoKICAgICAgICAgIyB3ZSB3YW50IHRvIHRyZWF0IGV2ZW4gYSBwb3RlbnRpYWxseSBmbGFr eSBjcmFzaCBhcyBhbiBlcnJvci4KICAgICAgICAgZmFpbHVyZXMgPSBzZWxmLl9nZXRfZmFpbHVy ZXMocmVzdWx0X3N1bW1hcnksIGluY2x1ZGVfY3Jhc2hlcz1GYWxzZSwgaW5jbHVkZV9taXNzaW5n PUZhbHNlKQogICAgICAgICByZXRyeV9zdW1tYXJ5ID0gcmVzdWx0X3N1bW1hcnkKLSAgICAgICAg d2hpbGUgKGxlbihmYWlsdXJlcykgYW5kIHNlbGYuX29wdGlvbnMucmV0cnlfZmFpbHVyZXMgYW5k Ci0gICAgICAgICAgICBub3Qgc2VsZi5fcmV0cnlpbmcgYW5kIG5vdCBpbnRlcnJ1cHRlZCk6Cisg ICAgICAgIHdoaWxlIChsZW4oZmFpbHVyZXMpIGFuZCBzZWxmLl9vcHRpb25zLnJldHJ5X2ZhaWx1 cmVzIGFuZCBub3Qgc2VsZi5fcmV0cnlpbmcgYW5kIG5vdCBpbnRlcnJ1cHRlZCBhbmQgbm90IGtl eWJvYXJkX2ludGVycnVwdGVkKToKICAgICAgICAgICAgIF9sb2cuaW5mbygnJykKICAgICAgICAg ICAgIF9sb2cuaW5mbygiUmV0cnlpbmcgJWQgdW5leHBlY3RlZCBmYWlsdXJlKHMpIC4uLiIgJSBs ZW4oZmFpbHVyZXMpKQogICAgICAgICAgICAgX2xvZy5pbmZvKCcnKQo=