63759 2011-06-30 15:27:10 -0700 Clean up output from new-run-webkit-tests 2011-06-30 16:40:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dpranke eric webkit.review.bot oldest_to_newest 430724 0 abarth 2011-06-30 15:27:10 -0700 Clean up output from new-run-webkit-tests 430728 1 99377 abarth 2011-06-30 15:29:37 -0700 Created attachment 99377 Patch 430801 2 99377 darin 2011-06-30 16:25:09 -0700 Comment on attachment 99377 Patch While I am not an expert on your Python tools, I think I am expert enough to review+ this patch. 430805 3 99377 darin 2011-06-30 16:25:50 -0700 Comment on attachment 99377 Patch I meant "our python tools", not "your python tools" 430808 4 99377 dpranke 2011-06-30 16:27:50 -0700 Comment on attachment 99377 Patch looks fine to me as well. 430826 5 abarth 2011-06-30 16:37:41 -0700 > I meant "our python tools", not "your python tools" :) 430830 6 webkit.review.bot 2011-06-30 16:39:15 -0700 The commit-queue encountered the following flaky tests while processing attachment 99377: perf/object-keys.html bug 63769 (author: ojan@chromium.org) The commit-queue is continuing to process your patch. 430833 7 99377 webkit.review.bot 2011-06-30 16:40:44 -0700 Comment on attachment 99377 Patch Clearing flags on attachment: 99377 Committed r90184: <http://trac.webkit.org/changeset/90184> 430834 8 webkit.review.bot 2011-06-30 16:40:49 -0700 All reviewed patches have been landed. Closing bug. 99377 2011-06-30 15:29:37 -0700 2011-06-30 16:40:44 -0700 Patch bug-63759-20110630152936.patch text/plain 5066 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkwMTcwKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMDYtMzAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhbiB1cCBv dXRwdXQgZnJvbSBuZXctcnVuLXdlYmtpdC10ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM3NTkKKworICAgICAgICBQcmludGluZyBtZXNzYWdl cyBmcm9tIHRoZSBjaGlsZCBwcm9jZXNzIGxvb2tzIHN1cGVyIHVnbHkgYmVjYXVzZSBvZgorICAg ICAgICB0aGUgd2F5IHRoZSBwcmV0dHktcHJpbnRlciB3b3Jrcy4gIFByaW50aW5nIGEgYmxhbmsg bGluZSBmaXJzdCBpcyBhCisgICAgICAgIGhhY2ssIGJ1dCBpdCBtYWtlcyB0aGluZ3MgYXQgbGVh c3QgcGFydGlhbGx5IHNhbmUuCisKKyAgICAgICAgQWxzbywgaGFuZGxlIHRoZSBjYXNlIHdoZXJl IGNhbGxpbmcgc2FtcGxlIHRocm93cyBhbiBleGNlcHRpb24uCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5OgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvc2VydmVyX3Byb2Nlc3NfdW5pdHRl c3QucHk6CisKIDIwMTEtMDYtMzAgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAg ICAgICAgIE1ha2UgVGVzdEZhaXVscmVzIG9ubHkgbG9hZCBvbGQtcmVzdWx0cyBkaXJlY3Rvcmll cyBhcyBuZWVkZWQKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvc2VydmVyX3Byb2Nlc3MucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQkocmV2aXNpb24gOTAxNDEpCisr KyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNz LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zOSw3ICszOSw3IEBAIGltcG9ydCB0aW1lCiBpZiBzeXMu cGxhdGZvcm0gIT0gJ3dpbjMyJzoKICAgICBpbXBvcnQgZmNudGwKIAotZnJvbSB3ZWJraXRweS5j b21tb24uc3lzdGVtLmV4ZWN1dGl2ZSBpbXBvcnQgRXhlY3V0aXZlCitmcm9tIHdlYmtpdHB5LmNv bW1vbi5zeXN0ZW0uZXhlY3V0aXZlIGltcG9ydCBFeGVjdXRpdmUsIFNjcmlwdEVycm9yCiAKIF9s b2cgPSBsb2dnaW5nLmdldExvZ2dlcihfX2ZpbGVfXykKIApAQCAtMTY2LDE5ICsxNjYsMjggQEAg Y2xhc3MgU2VydmVyUHJvY2VzczoKICAgICAgICAgICAgIHNlbGYuY3Jhc2hlZCA9IFRydWUKICAg ICAgICAgICAgIHNlbGYuaGFuZGxlX2ludGVycnVwdCgpCiAKKyAgICBkZWYgX2xvZyhzZWxmLCBt ZXNzYWdlKToKKyAgICAgICAgIyBUaGlzIGlzIGEgYml0IG9mIGEgaGFjaywgYnV0IHdlIGZpcnN0 IGxvZyBhIGJsYW5rIGxpbmUgdG8gYXZvaWQKKyAgICAgICAgIyBtZXNzaW5nIHVwIHRoZSBtYXN0 ZXIgcHJvY2VzcydzIG91dHB1dC4KKyAgICAgICAgX2xvZy5pbmZvKCcnKQorICAgICAgICBfbG9n LmluZm8obWVzc2FnZSkKKwogICAgIGRlZiBfc2FtcGxlKHNlbGYpOgogICAgICAgICBpZiBzeXMu cGxhdGZvcm0gIT0gImRhcndpbiI6CiAgICAgICAgICAgICByZXR1cm4KLSAgICAgICAgX2xvZy53 YXJuaW5nKCdTYW1wbGluZyBwcm9jZXNzLi4uICh1c2UgLS1uby1zYW1wbGUtb24tdGltZW91dCB0 byBza2lwIHRoaXMgc3RlcCknKQotICAgICAgICBoYW5nX3JlcG9ydCA9IG9zLnBhdGguam9pbihz ZWxmLl9wb3J0LnJlc3VsdHNfZGlyZWN0b3J5KCksICIlcy0lcy5zYW1wbGUudHh0IiAlIChzZWxm Ll9uYW1lLCBzZWxmLl9wcm9jLnBpZCkpCi0gICAgICAgIHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29t bWFuZChbCi0gICAgICAgICAgICAiL3Vzci9iaW4vc2FtcGxlIiwKLSAgICAgICAgICAgIHNlbGYu X3Byb2MucGlkLAotICAgICAgICAgICAgMTAsCi0gICAgICAgICAgICAxMCwKLSAgICAgICAgICAg ICItZmlsZSIsCi0gICAgICAgICAgICBoYW5nX3JlcG9ydCwKLSAgICAgICAgXSkKKyAgICAgICAg dHJ5OgorICAgICAgICAgICAgc2VsZi5fbG9nKCdTYW1wbGluZyAlcyBwcm9jZXNzLi4uICh1c2Ug LS1uby1zYW1wbGUtb24tdGltZW91dCB0byBza2lwIHRoaXMgc3RlcCknICUgc2VsZi5fbmFtZSkK KyAgICAgICAgICAgIGhhbmdfcmVwb3J0ID0gb3MucGF0aC5qb2luKHNlbGYuX3BvcnQucmVzdWx0 c19kaXJlY3RvcnkoKSwgIiVzLSVzLnNhbXBsZS50eHQiICUgKHNlbGYuX25hbWUsIHNlbGYuX3By b2MucGlkKSkKKyAgICAgICAgICAgIHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbCisgICAg ICAgICAgICAgICAgIi91c3IvYmluL3NhbXBsZSIsCisgICAgICAgICAgICAgICAgc2VsZi5fcHJv Yy5waWQsCisgICAgICAgICAgICAgICAgMTAsCisgICAgICAgICAgICAgICAgMTAsCisgICAgICAg ICAgICAgICAgIi1maWxlIiwKKyAgICAgICAgICAgICAgICBoYW5nX3JlcG9ydCwKKyAgICAgICAg ICAgIF0pCisgICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToKKyAgICAgICAgICAgIHNlbGYu X2xvZygnVW5hYmxlIHRvIHNhbXBsZSBwcm9jZXNzLicpCiAKICAgICBkZWYgX3JlYWQoc2VsZiwg dGltZW91dCwgc2l6ZSk6CiAgICAgICAgICIiIkludGVybmFsIHJvdXRpbmUgdGhhdCBhY3R1YWxs eSBkb2VzIHRoZSByZWFkLiIiIgpAQCAtMTkzLDcgKzIwMiw3IEBAIGNsYXNzIFNlcnZlclByb2Nl c3M6CiAgICAgICAgICAgICBub3cgPSB0aW1lLnRpbWUoKQogICAgICAgICAgICAgaWYgbm93ID4g ZGVhZGxpbmU6CiAgICAgICAgICAgICAgICAgaWYgc2VsZi5fZXhlY3V0aXZlLnJ1bm5pbmdfcGlk cyhzZWxmLl9wb3J0LmlzX2NyYXNoX3JlcG9ydGVyKToKLSAgICAgICAgICAgICAgICAgICAgX2xv Zy53YXJuaW5nKCdXYWl0aW5nIGZvciBjcmFzaCByZXBvcnRlci4uLicpCisgICAgICAgICAgICAg ICAgICAgIHNlbGYuX2xvZygnV2FpdGluZyBmb3IgY3Jhc2ggcmVwb3J0ZXIuLi4nKQogICAgICAg ICAgICAgICAgICAgICBzZWxmLl9leGVjdXRpdmUud2FpdF9uZXdlc3Qoc2VsZi5fcG9ydC5pc19j cmFzaF9yZXBvcnRlcikKICAgICAgICAgICAgICAgICAgICAgaWYgbm90IHNlbGYuY3Jhc2hlZDoK ICAgICAgICAgICAgICAgICAgICAgICAgIHNlbGYuX2NoZWNrX2Zvcl9jcmFzaCgpCkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzX3Vu aXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvc2VydmVyX3Byb2Nlc3NfdW5pdHRlc3QucHkJKHJldmlzaW9uIDkwMTQxKQorKysg VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzc191 bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMzAsNiArMzAsNyBAQCBpbXBvcnQgc3lzCiBp bXBvcnQgdW5pdHRlc3QKIAogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydCBpbXBvcnQg c2VydmVyX3Byb2Nlc3MKK2Zyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5leGVjdXRpdmUgaW1w b3J0IFNjcmlwdEVycm9yCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZlX21v Y2sgaW1wb3J0IE1vY2tFeGVjdXRpdmUyCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0ub3V0 cHV0Y2FwdHVyZSBpbXBvcnQgT3V0cHV0Q2FwdHVyZQogCkBAIC0zOCw2ICszOSwxMCBAQCBkZWYg X2xvZ2dpbmdfcnVuX2NvbW1hbmQoYXJncyk6CiAgICAgcHJpbnQgYXJncwogCiAKK2RlZiBfdGhy b3dpbmdfcnVuX2NvbW1hbmQoYXJncyk6CisgICAgcmFpc2UgU2NyaXB0RXJyb3IoIk1PQ0sgc2Ny aXB0IGVycm9yIikKKworCiBjbGFzcyBUcml2aWFsTW9ja1BvcnQob2JqZWN0KToKICAgICBkZWYg cmVzdWx0c19kaXJlY3Rvcnkoc2VsZik6CiAgICAgICAgIHJldHVybiAiL21vY2svcmVzdWx0cyIK QEAgLTkyLDMgKzk3LDExIEBAIGNsYXNzIFRlc3RTZXJ2ZXJQcm9jZXNzKHVuaXR0ZXN0LlRlc3RD YXMKICAgICAgICAgc2VydmVyX3Byb2Nlc3MuX3Byb2MgPSBNb2NrUHJvYyhzZXJ2ZXJfcHJvY2Vz cykKICAgICAgICAgZXhwZWN0ZWRfc3Rkb3V0ID0gIlsnL3Vzci9iaW4vc2FtcGxlJywgMSwgMTAs IDEwLCAnLWZpbGUnLCAnL21vY2svcmVzdWx0cy90ZXN0LTEuc2FtcGxlLnR4dCddXG4iCiAgICAg ICAgIE91dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBzZXJ2ZXJfcHJvY2Vzcy5f c2FtcGxlLCBleHBlY3RlZF9zdGRvdXQ9ZXhwZWN0ZWRfc3Rkb3V0KQorCisgICAgZGVmIHRlc3Rf c2FtcGxlX3Byb2Nlc3NfdGhyb3dzX2V4Y2VwdGlvbihzZWxmKToKKyAgICAgICAgIyBDdXJyZW50 bHksIHNhbXBsZS1vbi10aW1lb3V0IG9ubHkgd29ya3Mgb24gRGFyd2luLgorICAgICAgICBpZiBz eXMucGxhdGZvcm0gIT0gImRhcndpbiI6CisgICAgICAgICAgICByZXR1cm4KKyAgICAgICAgc2Vy dmVyX3Byb2Nlc3MgPSBGYWtlU2VydmVyUHJvY2Vzcyhwb3J0X29iaj1Ucml2aWFsTW9ja1BvcnQo KSwgbmFtZT0idGVzdCIsIGNtZD1bInRlc3QiXSwgZXhlY3V0aXZlPU1vY2tFeGVjdXRpdmUyKHJ1 bl9jb21tYW5kX2ZuPV90aHJvd2luZ19ydW5fY29tbWFuZCkpCisgICAgICAgIHNlcnZlcl9wcm9j ZXNzLl9wcm9jID0gTW9ja1Byb2Moc2VydmVyX3Byb2Nlc3MpCisgICAgICAgIE91dHB1dENhcHR1 cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBzZXJ2ZXJfcHJvY2Vzcy5fc2FtcGxlKQo=