63756 2011-06-30 15:20:44 -0700 Prevent unnecessary delete of texture 0 in DrawingBuffer 2011-07-04 11:16:50 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 twiz webkit-unassigned mdelaney7 senorblanco webkit.review.bot oldest_to_newest 430718 0 twiz 2011-06-30 15:20:44 -0700 The code in DrawingBuffer::clear is structured so that multiple calls to clear will result in deletion of texture 0. This is general bad GL form, and should be corrected. Issue also tracked via Chromium bug: crbug.com/87292 431975 1 99641 twiz 2011-07-04 10:05:56 -0700 Created attachment 99641 Patch 431984 2 99641 senorblanco 2011-07-04 10:35:02 -0700 Comment on attachment 99641 Patch Looks good. r=me 431997 3 99641 webkit.review.bot 2011-07-04 11:16:46 -0700 Comment on attachment 99641 Patch Clearing flags on attachment: 99641 Committed r90369: <http://trac.webkit.org/changeset/90369> 431998 4 webkit.review.bot 2011-07-04 11:16:50 -0700 All reviewed patches have been landed. Closing bug. 99641 2011-07-04 10:05:56 -0700 2011-07-04 11:16:46 -0700 Patch bug-63756-20110704130300.patch text/plain 1985 twiz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwMTczKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMzAgIEplZmYgVGlt YW51cyAgPHR3aXpAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFByZXZlbnQgY2FsbHMgdG8gR3JhcGljc0NvbnRleHQzRDo6ZGVs ZXRlVGV4dHVyZSB3aXRoIGlkIDAgaW4gRHJhd2luZ0J1ZmZlcjo6Y2xlYXIoKS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNzU2CisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2luZ0J1ZmZlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpEcmF3aW5nQnVmZmVyOjpjbGVhcik6CisKIDIwMTEtMDYtMzAgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggY2xhbmcgYnVpbGQuCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2luZ0J1ZmZlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L0RyYXdp bmdCdWZmZXIuY3BwCShyZXZpc2lvbiA5MDAzNCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dwdS9EcmF3aW5nQnVmZmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTgsMzYg KzU4LDM5IEBAIHZvaWQgRHJhd2luZ0J1ZmZlcjo6Y2xlYXIoKQogewogICAgIGlmICghbV9jb250 ZXh0KQogICAgICAgICByZXR1cm47Ci0gICAgICAgIAorCiAgICAgbV9jb250ZXh0LT5tYWtlQ29u dGV4dEN1cnJlbnQoKTsKLSAgICBtX2NvbnRleHQtPmRlbGV0ZVRleHR1cmUobV9jb2xvckJ1ZmZl cik7Ci0gICAgbV9jb2xvckJ1ZmZlciA9IDA7Ci0gICAgCisKKyAgICBpZiAobV9jb2xvckJ1ZmZl cikgeworICAgICAgICBtX2NvbnRleHQtPmRlbGV0ZVRleHR1cmUobV9jb2xvckJ1ZmZlcik7Cisg ICAgICAgIG1fY29sb3JCdWZmZXIgPSAwOworICAgIH0KKwogICAgIGlmIChtX211bHRpc2FtcGxl Q29sb3JCdWZmZXIpIHsKICAgICAgICAgbV9jb250ZXh0LT5kZWxldGVSZW5kZXJidWZmZXIobV9t dWx0aXNhbXBsZUNvbG9yQnVmZmVyKTsKICAgICAgICAgbV9tdWx0aXNhbXBsZUNvbG9yQnVmZmVy ID0gMDsKICAgICB9Ci0gICAgCisKICAgICBpZiAobV9kZXB0aFN0ZW5jaWxCdWZmZXIpIHsKICAg ICAgICAgbV9jb250ZXh0LT5kZWxldGVSZW5kZXJidWZmZXIobV9kZXB0aFN0ZW5jaWxCdWZmZXIp OwogICAgICAgICBtX2RlcHRoU3RlbmNpbEJ1ZmZlciA9IDA7CiAgICAgfQotICAgIAorCiAgICAg aWYgKG1fZGVwdGhCdWZmZXIpIHsKICAgICAgICAgbV9jb250ZXh0LT5kZWxldGVSZW5kZXJidWZm ZXIobV9kZXB0aEJ1ZmZlcik7CiAgICAgICAgIG1fZGVwdGhCdWZmZXIgPSAwOwogICAgIH0KLSAg ICAKKwogICAgIGlmIChtX3N0ZW5jaWxCdWZmZXIpIHsKICAgICAgICAgbV9jb250ZXh0LT5kZWxl dGVSZW5kZXJidWZmZXIobV9zdGVuY2lsQnVmZmVyKTsKICAgICAgICAgbV9zdGVuY2lsQnVmZmVy ID0gMDsKICAgICB9Ci0gICAgCisKICAgICBpZiAobV9tdWx0aXNhbXBsZUZCTykgewogICAgICAg ICBtX2NvbnRleHQtPmRlbGV0ZUZyYW1lYnVmZmVyKG1fbXVsdGlzYW1wbGVGQk8pOwogICAgICAg ICBtX211bHRpc2FtcGxlRkJPID0gMDsKICAgICB9Ci0gICAgICAgIAorCiAgICAgbV9jb250ZXh0 LT5kZWxldGVGcmFtZWJ1ZmZlcihtX2Zibyk7CiAgICAgbV9mYm8gPSAwOwogfQo=