63753 2011-06-30 14:45:59 -0700 WebKit2: DidFinishLoadForFrame is never called on iframes when loads are cancelled by willSendRequest 2011-07-01 09:51:52 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein andersca ap beidson jberlin sam oldest_to_newest 430690 0 bweinstein 2011-06-30 14:45:59 -0700 Consider the snippet of code: <html> <body> <iframe src="http://example.com"></iframe> </body> </html> If willSendRequest returns 0 for the load of http://example.com, DidFinishLoadForFrame is never called for either the iframe, or the main frame. This is the cause of the unexpected failures mentioned in the Mac WebKit2 Skipped list: # Unexplained failures after implementing willSendRequestReturnsNull fast/loader/onload-willSendRequest-null-for-frame.html plugins/plugin-document-willSendRequest-null.html 430725 1 99376 bweinstein 2011-06-30 15:29:03 -0700 Created attachment 99376 [PATCH] Fix 430797 2 99376 darin 2011-06-30 16:23:46 -0700 Comment on attachment 99376 [PATCH] Fix Your patch did not apply in the EWS for some reason. But the code change looks great! 430804 3 bweinstein 2011-06-30 16:25:16 -0700 (In reply to comment #2) > (From update of attachment 99376 [details]) > Your patch did not apply in the EWS for some reason. But the code change looks great! That is because mac-wk2/Skipped was moved to just platform/wk2/Skipped this morning. I'll need to update and move my Skipped list changes over to that file instead. Thanks for the review! 430856 4 jberlin 2011-06-30 16:57:54 -0700 (In reply to comment #1) > Created an attachment (id=99376) [details] > [PATCH] Fix Would it be possible to write an API test for this? 430870 5 bweinstein 2011-06-30 17:12:15 -0700 (In reply to comment #4) > (In reply to comment #1) > > Created an attachment (id=99376) [details] [details] > > [PATCH] Fix > > Would it be possible to write an API test for this? This is covered by layout tests. I could enhance the output of the testing here slightly by having this test dump frame loading callbacks, but it wouldn't change what is being tested. 431229 6 bweinstein 2011-07-01 09:51:52 -0700 Landed in r90238. 99376 2011-06-30 15:29:03 -0700 2011-06-30 16:23:46 -0700 [PATCH] Fix didfinishloadforframe_iframe_willsendrequest.patch text/plain 2799 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwMTcwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMzAgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdDI6IERpZEZpbmlzaExvYWRGb3JGcmFtZSBp cyBuZXZlciBjYWxsZWQgb24gaWZyYW1lcyB3aGVuIGxvYWRzIGFyZSAKKyAgICAgICAgY2FuY2Vs bGVkIGJ5IHdpbGxTZW5kUmVxdWVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjM3NTMKKyAgICAgICAgCisgICAgICAgIFdoZW4gZGVjaWRpbmcgYSBw b2xpY3kgZm9yIGEgbnVsbCByZXF1ZXN0LCBjYWxsIHRoZSBjYWxsYmFjayB0aGF0IHdhcyBwYXNz ZWQKKyAgICAgICAgdG8gV2ViS2l0MiBhbmQgc2F5IHRoYXQgd2UgdXNlZCB0aGUgbG9hZGVyLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVu dC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERl Y2lkZVBvbGljeUZvclJlc3BvbnNlKToKKwogMjAxMS0wNi0zMCAgTWFyayBSb3dlICA8bXJvd2VA YXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgV2luZG93cyBidWlsZC4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCShyZXZpc2lvbiA4OTY1MCkKKysrIFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC02MDEsOCArNjAxLDEwIEBAIHZvaWQgV2ViRnJhbWVMb2FkZXJD bGllbnQ6OmRpc3BhdGNoRGVjaWQKICAgICBpZiAoIXdlYlBhZ2UpCiAgICAgICAgIHJldHVybjsK IAotICAgIGlmICghcmVxdWVzdC51cmwoKS5zdHJpbmcoKSkKKyAgICBpZiAoIXJlcXVlc3QudXJs KCkuc3RyaW5nKCkpIHsKKyAgICAgICAgKG1fZnJhbWUtPmNvcmVGcmFtZSgpLT5sb2FkZXIoKS0+ cG9saWN5Q2hlY2tlcigpLT4qZnVuY3Rpb24pKFBvbGljeVVzZSk7CiAgICAgICAgIHJldHVybjsK KyAgICB9CiAKICAgICBSZWZQdHI8QVBJT2JqZWN0PiB1c2VyRGF0YTsKIApJbmRleDogTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2 aXNpb24gOTAxNzApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wNi0zMCAgQnJpYW4gV2VpbnN0ZWluICA8YndlaW5zdGVpbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2ViS2l0MjogRGlkRmluaXNoTG9hZEZvckZyYW1lIGlzIG5ldmVyIGNhbGxlZCBvbiBpZnJh bWVzIHdoZW4gbG9hZHMgYXJlIAorICAgICAgICBjYW5jZWxsZWQgYnkgd2lsbFNlbmRSZXF1ZXN0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mzc1Mwor ICAgICAgICAKKyAgICAgICAgVW5za2lwIFdlYktpdDIgdGVzdHMgdGhhdCBub3cgcGFzcy4KKwor ICAgICAgICAqIHBsYXRmb3JtL21hYy13azIvU2tpcHBlZDoKKwogMjAxMS0wNi0zMCAgSnVsaWVu IENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBOaWtvbGFzIFppbW1lcm1hbm4uCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sy L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9Ta2lw cGVkCShyZXZpc2lvbiA4OTY1MCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvU2tp cHBlZAkod29ya2luZyBjb3B5KQpAQCAtMjAxMSwxMCArMjAxMSw2IEBAIGVkaXRpbmcvcGFzdGVi b2FyZC9jb3B5LXN0YW5kYWxvbmUtaW1hZ2UKICMgTXlzdGVyaW91cyBmYWlsdXJlIGFmdGVyIGVu YWJsaW5nIHBhc3RlIHRlc3RzCiBwbGF0Zm9ybS9tYWMvZWRpdGluZy9wYXN0ZWJvYXJkL3RleHQt cHJlY29tcG9zZWQuaHRtbAogCi0jIFVuZXhwbGFpbmVkIGZhaWx1cmVzIGFmdGVyIGltcGxlbWVu dGluZyB3aWxsU2VuZFJlcXVlc3RSZXR1cm5zTnVsbAotZmFzdC9sb2FkZXIvb25sb2FkLXdpbGxT ZW5kUmVxdWVzdC1udWxsLWZvci1mcmFtZS5odG1sCi1wbHVnaW5zL3BsdWdpbi1kb2N1bWVudC13 aWxsU2VuZFJlcXVlc3QtbnVsbC5odG1sCi0KICMgQW4gZW1wdHkgbGF5ZXIgaXMgbWlzc2luZy4K IHBsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL2lucHV0LWFwcGVhcmFuY2Utc3BpbmJ1dHRvbi11cC5o dG1sCiAK