63752 2011-06-30 14:38:14 -0700 Tester pages on TestFailures page load very slowly 2011-06-30 14:50:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build.webkit.org/TestFailures/ P2 Normal --- 1 aroben webkit-unassigned aroben oldest_to_newest 430683 0 aroben 2011-06-30 14:38:14 -0700 To reproduce: 1. Go to http://build.webkit.org/TestFailures/ 2. Click on a tester The tester page loads very slowly. We should make it faster! 430684 1 aroben 2011-06-30 14:38:38 -0700 This is because we load both the results directory and old-results directory for the tester up front. We should only load the old-results directory if needed. 430689 2 99367 aroben 2011-06-30 14:45:27 -0700 Created attachment 99367 Make TestFaiulres only load old-results directories as needed 430697 3 aroben 2011-06-30 14:50:04 -0700 Committed r90165: <http://trac.webkit.org/changeset/90165> 99367 2011-06-30 14:45:27 -0700 2011-06-30 14:47:35 -0700 Make TestFaiulres only load old-results directories as needed bug-63752-20110630174525.patch text/plain 7736 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogOTAxNTMKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9C dWlsZGVyLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL0J1aWxkZXIuanMKaW5kZXggY2Y2ZTFlNzhlMGFk N2FjOGE0MjlhNTU2MDU3MzEzYjlhMmYyOTRmOC4uYWJhYzFiNjdmMzdlNTlkN2E2NjA4MDliNmE1 N2Y4MmI5YmMwZDQzZCAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL0J1aWxkZXIuanMKKysr IGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvVGVzdEZhaWx1cmVzL0J1aWxkZXIuanMKQEAgLTU3LDYgKzU3LDEwIEBAIEJ1aWxkZXIu cHJvdG90eXBlID0gewogICAgICAgICByZXR1cm4gZGlhZ25vc3RpY0luZm9bdGVzdFJlc3VsdC5m YWlsdXJlVHlwZV07CiAgICAgfSwKIAorICAgIGdldEJ1aWxkTmFtZXM6IGZ1bmN0aW9uKGNhbGxi YWNrKSB7CisgICAgICAgIHRoaXMuX2dldEJ1aWxkTmFtZXNGcm9tUmVzdWx0c0RpcmVjdG9yeSh0 aGlzLmJ1aWxkYm90LmJhc2VVUkwgKyAncmVzdWx0cy8nICsgdGhpcy5uYW1lLCBjYWxsYmFjayk7 CisgICAgfSwKKwogICAgIGdldE1vc3RSZWNlbnRDb21wbGV0ZWRCdWlsZE51bWJlcjogZnVuY3Rp b24oY2FsbGJhY2spIHsKICAgICAgICAgdmFyIGNhY2hlS2V5ID0gJ2dldE1vc3RSZWNlbnRDb21w bGV0ZWRCdWlsZE51bWJlcic7CiAgICAgICAgIGlmIChjYWNoZUtleSBpbiB0aGlzLl9jYWNoZSkg ewpAQCAtMTQ2LDYgKzE1MCwxMCBAQCBCdWlsZGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgfSk7 CiAgICAgfSwKIAorICAgIGdldE9sZEJ1aWxkTmFtZXM6IGZ1bmN0aW9uKGNhbGxiYWNrKSB7Cisg ICAgICAgIHRoaXMuX2dldEJ1aWxkTmFtZXNGcm9tUmVzdWx0c0RpcmVjdG9yeSh0aGlzLmJ1aWxk Ym90LmJhc2VVUkwgKyAnb2xkLXJlc3VsdHMvJyArIHRoaXMubmFtZSwgY2FsbGJhY2spOworICAg IH0sCisKICAgICByZXN1bHRzRGlyZWN0b3J5VVJMOiBmdW5jdGlvbihidWlsZE5hbWUpIHsKICAg ICAgICAgcmV0dXJuIHRoaXMuYnVpbGRib3QucmVzdWx0c0RpcmVjdG9yeVVSTCh0aGlzLm5hbWUs IGJ1aWxkTmFtZSk7CiAgICAgfSwKQEAgLTE2OSw4ICsxNzcsOCBAQCBCdWlsZGVyLnByb3RvdHlw ZSA9IHsKICAgICAgICAgfSk7CiAgICAgfSwKIAotICAgIGdldEJ1aWxkTmFtZXM6IGZ1bmN0aW9u KGNhbGxiYWNrKSB7Ci0gICAgICAgIHZhciBjYWNoZUtleSA9ICdfZ2V0QnVpbGROYW1lcyc7Cisg ICAgX2dldEJ1aWxkTmFtZXNGcm9tUmVzdWx0c0RpcmVjdG9yeTogZnVuY3Rpb24oZGlyZWN0b3J5 VVJMLCBjYWxsYmFjaykgeworICAgICAgICB2YXIgY2FjaGVLZXkgPSAnX2dldEJ1aWxkTmFtZXNG cm9tUmVzdWx0c0RpcmVjdG9yeS4nICsgZGlyZWN0b3J5VVJMOwogICAgICAgICBpZiAoY2FjaGVL ZXkgaW4gdGhpcy5fY2FjaGUpIHsKICAgICAgICAgICAgIGNhbGxiYWNrKHRoaXMuX2NhY2hlW2Nh Y2hlS2V5XSk7CiAgICAgICAgICAgICByZXR1cm47CkBAIC0xOTIsMTMgKzIwMCwxMCBAQCBCdWls ZGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHJldHVybiBidWlsZE5hbWVzOwogICAgICAg ICB9CiAKLSAgICAgICAgZ2V0UmVzb3VyY2Uoc2VsZi5idWlsZGJvdC5iYXNlVVJMICsgJ3Jlc3Vs dHMvJyArIHNlbGYubmFtZSwgZnVuY3Rpb24oeGhyKSB7Ci0gICAgICAgICAgICAvLyBGSVhNRTog SXQgd291bGQgYmUgYmV0dGVyIGZvciBwZXJmb3JtYW5jZSBpZiB3ZSBjb3VsZCBhdm9pZCBsb2Fk aW5nIG9sZC1yZXN1bHRzIHVudGlsIG5lZWRlZC4KLSAgICAgICAgICAgIGdldFJlc291cmNlKHNl bGYuYnVpbGRib3QuYmFzZVVSTCArICdvbGQtcmVzdWx0cy8nICsgc2VsZi5uYW1lLCBmdW5jdGlv bihvbGRYSFIpIHsKLSAgICAgICAgICAgICAgICB2YXIgYnVpbGROYW1lcyA9IGJ1aWxkTmFtZXNG cm9tRGlyZWN0b3J5WEhSKHhocikuY29uY2F0KGJ1aWxkTmFtZXNGcm9tRGlyZWN0b3J5WEhSKG9s ZFhIUikpOwotICAgICAgICAgICAgICAgIHNlbGYuX2NhY2hlW2NhY2hlS2V5XSA9IGJ1aWxkTmFt ZXM7Ci0gICAgICAgICAgICAgICAgY2FsbGJhY2soYnVpbGROYW1lcyk7Ci0gICAgICAgICAgICB9 KTsKKyAgICAgICAgZ2V0UmVzb3VyY2UoZGlyZWN0b3J5VVJMLCBmdW5jdGlvbih4aHIpIHsKKyAg ICAgICAgICAgIHZhciBidWlsZE5hbWVzID0gYnVpbGROYW1lc0Zyb21EaXJlY3RvcnlYSFIoeGhy KTsKKyAgICAgICAgICAgIHNlbGYuX2NhY2hlW2NhY2hlS2V5XSA9IGJ1aWxkTmFtZXM7CisgICAg ICAgICAgICBjYWxsYmFjayhidWlsZE5hbWVzKTsKICAgICAgICAgfSk7CiAgICAgfSwKIH07CmRp ZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvTGF5b3V0VGVzdEhpc3RvcnlBbmFseXplci5qcyBi L1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19o dG1sL1Rlc3RGYWlsdXJlcy9MYXlvdXRUZXN0SGlzdG9yeUFuYWx5emVyLmpzCmluZGV4IDQzMzBl NDVmMTViMzhlMjAxZjkxMzczNTFiMDA0N2E4MTUxYTM4NDEuLjJhNjYyYjY2MjE2ZWUyNmVhYjM0 MGIwNmRhY2VkMTM4MjkwMTk3ZDAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9MYXlvdXRU ZXN0SGlzdG9yeUFuYWx5emVyLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9MYXlvdXRUZXN0SGlz dG9yeUFuYWx5emVyLmpzCkBAIC02OSwyOCArNjksNDYgQEAgTGF5b3V0VGVzdEhpc3RvcnlBbmFs eXplci5wcm90b3R5cGUgPSB7CiAgICAgc3RhcnQ6IGZ1bmN0aW9uKGNhbGxiYWNrKSB7CiAgICAg ICAgIHZhciBzZWxmID0gdGhpczsKICAgICAgICAgc2VsZi5fYnVpbGRlci5nZXRCdWlsZE5hbWVz KGZ1bmN0aW9uKGJ1aWxkTmFtZXMpIHsKLSAgICAgICAgICAgIGZ1bmN0aW9uIGlubmVyKGJ1aWxk SW5kZXgpIHsKLSAgICAgICAgICAgICAgICBzZWxmLl9pbmNvcnBvcmF0ZUJ1aWxkSGlzdG9yeShi dWlsZE5hbWVzLCBidWlsZEluZGV4LCBmdW5jdGlvbihjYWxsQWdhaW4pIHsKLSAgICAgICAgICAg ICAgICAgICAgdmFyIG5leHRJbmRleCA9IGJ1aWxkSW5kZXggKyAxOwotICAgICAgICAgICAgICAg ICAgICBpZiAobmV4dEluZGV4ID49IGJ1aWxkTmFtZXMubGVuZ3RoKQotICAgICAgICAgICAgICAg ICAgICAgICAgY2FsbEFnYWluID0gZmFsc2U7Ci0gICAgICAgICAgICAgICAgICAgIHZhciBkYXRh ID0gewotICAgICAgICAgICAgICAgICAgICAgICAgaGlzdG9yeTogc2VsZi5faGlzdG9yeSwKLSAg ICAgICAgICAgICAgICAgICAgICAgIHBvc3NpYmx5Rmxha3k6IHt9LAotICAgICAgICAgICAgICAg ICAgICB9OwotICAgICAgICAgICAgICAgICAgICBzZWxmLl9mbGFraW5lc3NEZXRlY3Rvci5wb3Nz aWJseUZsYWt5VGVzdHMuZm9yRWFjaChmdW5jdGlvbih0ZXN0TmFtZSkgewotICAgICAgICAgICAg ICAgICAgICAgICAgZGF0YS5wb3NzaWJseUZsYWt5W3Rlc3ROYW1lXSA9IHNlbGYuX2ZsYWtpbmVz c0RldGVjdG9yLmZsYWtpbmVzc0V4YW1wbGVzKHRlc3ROYW1lKTsKLSAgICAgICAgICAgICAgICAg ICAgfSk7Ci0gICAgICAgICAgICAgICAgICAgIHZhciBjYWxsYmFja1JlcXVlc3RlZFN0b3AgPSAh Y2FsbGJhY2soZGF0YSwgY2FsbEFnYWluKTsKLSAgICAgICAgICAgICAgICAgICAgaWYgKGNhbGxi YWNrUmVxdWVzdGVkU3RvcCB8fCAhY2FsbEFnYWluKQotICAgICAgICAgICAgICAgICAgICAgICAg cmV0dXJuOwotICAgICAgICAgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeyBpbm5l cihuZXh0SW5kZXgpIH0sIDApOworICAgICAgICAgICAgc2VsZi5fYW5hbHl6ZUJ1aWxkcyhidWls ZE5hbWVzLCBjYWxsYmFjaywgZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgICAgc2VsZi5fYnVp bGRlci5nZXRPbGRCdWlsZE5hbWVzKGZ1bmN0aW9uKG9sZEJ1aWxkTmFtZXMpIHsKKyAgICAgICAg ICAgICAgICAgICAgc2VsZi5fYW5hbHl6ZUJ1aWxkcyhvbGRCdWlsZE5hbWVzLCBjYWxsYmFjayk7 CiAgICAgICAgICAgICAgICAgfSk7Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICBpbm5lcigw KTsKKyAgICAgICAgICAgIH0pOwogICAgICAgICB9KTsKICAgICB9LAogCisgICAgX2FuYWx5emVC dWlsZHM6IGZ1bmN0aW9uKGJ1aWxkTmFtZXMsIGNhbGxiYWNrLCBhbmFseXplZEFsbEJ1aWxkc0Nh bGxiYWNrKSB7CisgICAgICAgIHZhciBzZWxmID0gdGhpczsKKyAgICAgICAgZnVuY3Rpb24gaW5u ZXIoYnVpbGRJbmRleCkgeworICAgICAgICAgICAgc2VsZi5faW5jb3Jwb3JhdGVCdWlsZEhpc3Rv cnkoYnVpbGROYW1lcywgYnVpbGRJbmRleCwgZnVuY3Rpb24oY2FsbEFnYWluKSB7CisgICAgICAg ICAgICAgICAgdmFyIGRhdGEgPSB7CisgICAgICAgICAgICAgICAgICAgIGhpc3Rvcnk6IHNlbGYu X2hpc3RvcnksCisgICAgICAgICAgICAgICAgICAgIHBvc3NpYmx5Rmxha3k6IHt9LAorICAgICAg ICAgICAgICAgIH07CisgICAgICAgICAgICAgICAgc2VsZi5fZmxha2luZXNzRGV0ZWN0b3IucG9z c2libHlGbGFreVRlc3RzLmZvckVhY2goZnVuY3Rpb24odGVzdE5hbWUpIHsKKyAgICAgICAgICAg ICAgICAgICAgZGF0YS5wb3NzaWJseUZsYWt5W3Rlc3ROYW1lXSA9IHNlbGYuX2ZsYWtpbmVzc0Rl dGVjdG9yLmZsYWtpbmVzc0V4YW1wbGVzKHRlc3ROYW1lKTsKKyAgICAgICAgICAgICAgICB9KTsK KworICAgICAgICAgICAgICAgIHZhciBuZXh0SW5kZXggPSBidWlsZEluZGV4ICsgMTsKKyAgICAg ICAgICAgICAgICB2YXIgYW5hbHl6ZWRBbGxCdWlsZHMgPSBuZXh0SW5kZXggPj0gYnVpbGROYW1l cy5sZW5ndGg7CisgICAgICAgICAgICAgICAgdmFyIGhhdmVNb3JlRGF0YVRvRmV0Y2ggPSAhYW5h bHl6ZWRBbGxCdWlsZHMgfHwgYW5hbHl6ZWRBbGxCdWlsZHNDYWxsYmFjazsKKworICAgICAgICAg ICAgICAgIHZhciBjYWxsYmFja1JlcXVlc3RlZFN0b3AgPSAhY2FsbGJhY2soZGF0YSwgaGF2ZU1v cmVEYXRhVG9GZXRjaCk7CisgICAgICAgICAgICAgICAgaWYgKGNhbGxiYWNrUmVxdWVzdGVkU3Rv cCkKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgICAgICAgICAgaWYgKGFu YWx5emVkQWxsQnVpbGRzKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChhbmFseXplZEFsbEJ1 aWxkc0NhbGxiYWNrKQorICAgICAgICAgICAgICAgICAgICAgICAgYW5hbHl6ZWRBbGxCdWlsZHND YWxsYmFjaygpOworICAgICAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAgICAg fQorCisgICAgICAgICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsgaW5uZXIobmV4dElu ZGV4KSB9LCAwKTsKKyAgICAgICAgICAgIH0pOworICAgICAgICB9CisgICAgICAgIGlubmVyKDAp OworICAgIH0sCisKICAgICBfaW5jb3Jwb3JhdGVCdWlsZEhpc3Rvcnk6IGZ1bmN0aW9uKGJ1aWxk TmFtZXMsIGJ1aWxkSW5kZXgsIGNhbGxiYWNrKSB7CiAgICAgICAgIHZhciBwcmV2aW91c0J1aWxk TmFtZSA9IE9iamVjdC5rZXlzKHRoaXMuX2hpc3RvcnkpLmxhc3QoKTsKICAgICAgICAgdmFyIG5l eHRCdWlsZE5hbWUgPSBidWlsZE5hbWVzW2J1aWxkSW5kZXhdOwpkaWZmIC0tZ2l0IGEvVG9vbHMv Q2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDU2ODZjZTc0ZTM4YTM4NGIxNmVkZTI0 MTIwY2NiNzBkODA4NzNkYzAuLmY5YTM0MjhjOWE1ZDFjMWM2ZDYxZGFlMjkxZjEzNDVlYjQ1NWJl ODAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAg LTEsNSArMSwyOCBAQAogMjAxMS0wNi0zMCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+ CiAKKyAgICAgICAgTWFrZSBUZXN0RmFpdWxyZXMgb25seSBsb2FkIG9sZC1yZXN1bHRzIGRpcmVj dG9yaWVzIGFzIG5lZWRlZAorCisgICAgICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzYz NzUyPiBUZXN0ZXIgcGFnZXMgb24gVGVzdEZhaWx1cmVzIHBhZ2UgbG9hZCB2ZXJ5IHNsb3dseQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRT bGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1 cmVzL0J1aWxkZXIuanM6CisgICAgICAgIChCdWlsZGVyLnByb3RvdHlwZS5nZXRCdWlsZE5hbWVz KTogTW92ZWQgdXAgaW50byB0aGUgQVBJIHNlY3Rpb24gb2YgdGhlIGNsYXNzLiBOb3cganVzdAor ICAgICAgICBjYWxscyB0aHJvdWdoIHRvIF9nZXRCdWlsZE5hbWVzRnJvbVJlc3VsdHNEaXJlY3Rv cnkuCisgICAgICAgIChCdWlsZGVyLnByb3RvdHlwZS5nZXRPbGRCdWlsZE5hbWVzKTogQWRkZWQu IEp1c3QgY2FsbHMgdGhyb3VnaCB0bworICAgICAgICBfZ2V0QnVpbGROYW1lc0Zyb21SZXN1bHRz RGlyZWN0b3J5LgorICAgICAgICAoQnVpbGRlci5wcm90b3R5cGUuX2dldEJ1aWxkTmFtZXNGcm9t UmVzdWx0c0RpcmVjdG9yeSk6IFJlbmFtZWQgZnJvbSBnZXRCdWlsZE5hbWVzLiBOb3cKKyAgICAg ICAgdGFrZXMgdGhlIGRpcmVjdG9yeSBVUkwgYXMgYW4gYXJndW1lbnQgYW5kIG9ubHkgZmV0Y2hl cyB0aGF0IHNpbmdsZSBVUkwuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvTGF5b3V0VGVzdEhpc3Rv cnlBbmFseXplci5qczoKKyAgICAgICAgKExheW91dFRlc3RIaXN0b3J5QW5hbHl6ZXIucHJvdG90 eXBlLnN0YXJ0KTogTW92ZWQgbW9zdCBsb2dpYyB0byBfYW5hbHl6ZUJ1aWxkcy4gRmlyc3QKKyAg ICAgICAgYW5hbHl6ZXMgYnVpbGRzIGZyb20gQnVpbGRlci5nZXRCdWlsZE5hbWVzLCB0aGVuIGZy b20gQnVpbGRlci5nZXRPbGRCdWlsZE5hbWVzIGlmIG5lZWRlZC4KKyAgICAgICAgKExheW91dFRl c3RIaXN0b3J5QW5hbHl6ZXIucHJvdG90eXBlLl9hbmFseXplQnVpbGRzKTogTW92ZWQgbG9naWMg aGVyZSBmcm9tIHN0YXJ0LiAoTW9zdAorICAgICAgICBjaGFuZ2VzIGFyZSBqdXN0IGluZGVudGF0 aW9uLikgTm93IHRha2VzIGEgY2FsbGJhY2sgdG8gY2FsbCB3aGVuIHdlJ3ZlIGZpbmlzaGVkIGFu YWx5emluZworICAgICAgICBhbGwgYnVpbGRzIGluIGJ1aWxkTmFtZXMgc28gdGhhdCB3ZSBjYW4g dHJ5IHRvIGZldGNoIG1vcmUgYnVpbGQgbmFtZXMgaWYgbmVlZGVkLgorCisyMDExLTA2LTMwICBB ZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKwogICAgICAgICBJZGVudGlmeSByZXZpc2lv bnMgdGhhdCBtb2RpZmllZCBmYWlsaW5nIHRlc3RzIG9uIFRlc3RGYWlsdXJlcyBwYWdlCiAKICAg ICAgICAgRml4ZXMgPGh0dHA6Ly93ZWJraXQub3JnL2IvNjM3MTY+IFRlc3RGYWlsdXJlcyBwYWdl IHNob3VsZCB0cnkgdG8gaW5mZXIgd2hpY2ggY29tbWl0IGNhdXNlZAo=