63742 2011-06-30 11:44:38 -0700 Remove redundant tests in TestFailuresTest 2011-06-30 11:56:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric abarth dpranke webkit.review.bot oldest_to_newest 430582 0 eric 2011-06-30 11:44:38 -0700 Remove redundant tests in TestFailuresTest 430586 1 99348 eric 2011-06-30 11:45:34 -0700 Created attachment 99348 Patch 430588 2 dpranke 2011-06-30 11:47:08 -0700 I was going to ask why you were adding these :) ... 430597 3 eric 2011-06-30 11:55:41 -0700 (In reply to comment #2) > I was going to ask why you were adding these :) ... Removing? I noticed because I searched for all places where FailureCrash() was called, and this was one of them. BUt then I saw test_loads() and saw this test was redundant. 430599 4 99348 webkit.review.bot 2011-06-30 11:56:41 -0700 Comment on attachment 99348 Patch Clearing flags on attachment: 99348 Committed r90140: <http://trac.webkit.org/changeset/90140> 430600 5 webkit.review.bot 2011-06-30 11:56:45 -0700 All reviewed patches have been landed. Closing bug. 99348 2011-06-30 11:45:34 -0700 2011-06-30 11:56:41 -0700 Patch bug-63742-20110630114533.patch text/plain 2114 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTAxMzgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4NWU2MGUzMTUzZmMwOTc0ZjY3ZjliMzYwZjA3YWMzY2Fj OTM5ODY5Li44Y2FiNjQxNGY4NjVjNjM0Nzc1ZDc1YWJjYTc2NTJlM2I2MTVjYjIxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDYtMzAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSByZWR1bmRhbnQg dGVzdHMgaW4gVGVzdEZhaWx1cmVzVGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjM3NDIKKworICAgICAgICBUaGVzZSB0ZXN0cyBhcmUgYWxsIGFs cmVhZHkgY292ZXJlZCBieSBUZXN0RmFpbHVyZXNUZXN0LnRlc3RfbG9hZHMuCisgICAgICAgIEkg YWxzbyBhZGRlZCB0aGUgbWlzc2luZyAiVCIgZnJvbSBUZXN0RmFpbHVyZXNlc3QuIDopCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90ZXN0 X2ZhaWx1cmVzX3VuaXR0ZXN0LnB5OgorCiAyMDExLTA2LTMwICBBZGFtIEJhcnRoICA8YWJhcnRo QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90 ZXN0X2ZhaWx1cmVzX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvbGF5b3V0X3BhY2thZ2UvdGVzdF9mYWlsdXJlc191bml0dGVzdC5weQppbmRleCBiN2Ni ZDRhMjhhNGJlN2I5ZTA2NTg4Y2FhZGNhOTQ2Njc3MGEyMmJhLi5lMTM3Yzc0YjYwNTk0NzNlOWQz M2U2YjI4ZWNjODY3YmEzNmUyYTI5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90ZXN0X2ZhaWx1cmVzX3VuaXR0ZXN0LnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rl c3RfZmFpbHVyZXNfdW5pdHRlc3QucHkKQEAgLTMzLDcgKzMzLDcgQEAgaW1wb3J0IHVuaXR0ZXN0 CiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5sYXlvdXRfcGFja2FnZS50ZXN0X2ZhaWx1cmVz IGltcG9ydCAqCiAKIAotY2xhc3MgVGVzdEZhaWx1cmVzZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToK K2NsYXNzIFRlc3RGYWlsdXJlc1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiBhc3Nl cnRfbG9hZHMoc2VsZiwgY2xzKToKICAgICAgICAgZmFpbHVyZV9vYmogPSBjbHMoKQogICAgICAg ICBzID0gZmFpbHVyZV9vYmouZHVtcHMoKQpAQCAtNDUsMjQgKzQ1LDYgQEAgY2xhc3MgVGVzdEZh aWx1cmVzZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgIyBBbHNvIHRlc3QgdGhhdCAh PSBpcyBpbXBsZW1lbnRlZC4KICAgICAgICAgc2VsZi5hc3NlcnRGYWxzZShmYWlsdXJlX29iaiAh PSBuZXdfZmFpbHVyZV9vYmopCiAKLSAgICBkZWYgdGVzdF9jcmFzaChzZWxmKToKLSAgICAgICAg RmFpbHVyZUNyYXNoKCkKLQotICAgIGRlZiB0ZXN0X2hhc2hfaW5jb3JyZWN0KHNlbGYpOgotICAg ICAgICBGYWlsdXJlSW1hZ2VIYXNoSW5jb3JyZWN0KCkKLQotICAgIGRlZiB0ZXN0X21pc3Npbmco c2VsZik6Ci0gICAgICAgIEZhaWx1cmVNaXNzaW5nUmVzdWx0KCkKLQotICAgIGRlZiB0ZXN0X21p c3NpbmdfaW1hZ2Uoc2VsZik6Ci0gICAgICAgIEZhaWx1cmVNaXNzaW5nSW1hZ2UoKQotCi0gICAg ZGVmIHRlc3RfbWlzc2luZ19pbWFnZV9oYXNoKHNlbGYpOgotICAgICAgICBGYWlsdXJlTWlzc2lu Z0ltYWdlSGFzaCgpCi0KLSAgICBkZWYgdGVzdF90aW1lb3V0KHNlbGYpOgotICAgICAgICBGYWls dXJlVGltZW91dCgpCi0KICAgICBkZWYgdGVzdF91bmtub3duX2ZhaWx1cmVfdHlwZShzZWxmKToK ICAgICAgICAgY2xhc3MgVW5rbm93bkZhaWx1cmUoVGVzdEZhaWx1cmUpOgogICAgICAgICAgICAg cGFzcwo=