6373 2006-01-04 07:00:35 -0800 REGRESSION: JavaScript hang when comparing large array to null 2006-01-22 04:57:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 VERIFIED FIXED http://www.theregister.com/2005/12/20/nec_lavie_yonah/ InRadar P1 Critical --- 1 mitz andersca eric oldest_to_newest 27729 0 mitz 2006-01-04 07:00:35 -0800 Safari hangs on the above URL. It turns out that it's looping over a huge array in a ToString operation, with element->isUndefinedOrNull() in array_object.cpp:467 returning true all the time. Rolling out the changes to operations.cpp from the patch for bug 6268 fixes the problem. 27814 1 alice.barraclough 2006-01-05 14:57:23 -0800 <rdar://problem/4400333> 27873 2 eric 2006-01-06 14:25:02 -0800 *** Bug 6399 has been marked as a duplicate of this bug. *** 27884 3 andersca 2006-01-06 15:56:55 -0800 I have a patch that fixes this 27912 4 5523 andersca 2006-01-07 02:25:16 -0800 Created attachment 5523 Fix The problem was that my change to operations.cpp made checks against null convert objects to primitives, and converting a large sparse array to a string would simply hang the browser. 27914 5 5523 mjs 2006-01-07 02:28:31 -0800 Comment on attachment 5523 Fix r=me 29402 6 joost 2006-01-22 04:57:18 -0800 Removing keyword(s) since bug is fixed. 5523 2006-01-07 02:25:16 -0800 2006-01-07 02:28:31 -0800 Fix null-check-fix.txt text/plain 6318 andersca SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zz L3Jvb3QvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjk0 OQpkaWZmIC1wIC11IC1yMS45NDkgSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCi0tLSBKYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cJNiBKYW4gMjAwNiAyMzo1MDo1NyAtMDAwMAkxLjk0OQorKysgSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCTcgSmFuIDIwMDYgMTA6MjI6MTIgLTAwMDAKQEAgLTEsMyAr MSwxOSBAQAorMjAwNi0wMS0wNyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAbWFjLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAg IC0gZml4IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM3 MworICAgICAgICBSRUdSRVNTSU9OOiBKYXZhU2NyaXB0IGhhbmcgd2hlbiBjb21wYXJpbmcgbGFy Z2UgYXJyYXkgdG8gbnVsbAorICAgICAgICAKKyAgICAgICAgKiBranMvb2JqZWN0Lmg6CisgICAg ICAgIChLSlM6OkpTT2JqZWN0Ojppc0VxdWFsVG9OdWxsKToKKyAgICAgICAgQWRkIG5ldyBmdW5j dGlvbiB3aGljaCByZXR1cm5zIHRydWUgaWYgYW4gb2JqZWN0IHNob3VsZCBiZSB0cmVhdGVkIGFz IG51bGwgd2hlbgorICAgICAgICBkb2luZyBjb21wYXJpc29ucy4KKyAgICAgICAgCisgICAgICAg ICoga2pzL29wZXJhdGlvbnMuY3BwOgorICAgICAgICAoS0pTOjplcXVhbCk6CisgICAgICAgIFVz ZSBpc0VxdWFsVG9OdWxsLgorCiAyMDA2LTAxLTA2ICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0Bh cHBsZS5jb20+CiAKIAlSZXZpZXdlZCBieSBEYXJpbi4KQEAgLTcsNyArMjMsNyBAQAogCQogICAg ICAgICBDaGFuZ2VzIG1vc3RseSB0aGFua3MgdG8gTWFrcyBPcmxvdmljaCwgdHdlYWtlZCBhIGxp dHRsZSBieSBtZS4KIAotICAgICAgICAqIGtqcy9jcmVhdGVfaGFzaF90YWJsZTogVXNlIHRoZSBz YW1lIGhhc2ggYXMgdGhlIG9uZSB1c2VkIGJ1eSBJZGVudGlmaWVyLgorICAgICAgICAqIGtqcy9j cmVhdGVfaGFzaF90YWJsZTogVXNlIHRoZSBzYW1lIGhhc2ggYXMgdGhlIG9uZSB1c2VkIGJ5IElk ZW50aWZpZXIuCiAgICAgICAgICoga2pzL2Z1bmN0aW9uLmNwcDoKICAgICAgICAgKEtKUzo6RnVu Y3Rpb25JbXA6OnByb2Nlc3NQYXJhbWV0ZXJzKTogVXNlIHRoZSBuZXcgTGlzdDo6Y29weUZyb20K ICAgICAgICAgKEtKUzo6QWN0aXZhdGlvbkltcDo6QWN0aXZhdGlvbkltcCk6IHRyYWNrIHZhcmlh YmxlIHdoaWxlIGl0ZXJhdGluZwpJbmRleDogSmF2YVNjcmlwdENvcmUva2pzL29iamVjdC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9KYXZhU2NyaXB0Q29yZS9ranMvb2JqZWN0Lmgs dgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNTIKZGlmZiAtcCAtdSAtcjEuNTIgSmF2YVNjcmlwdENv cmUva2pzL29iamVjdC5oCi0tLSBKYXZhU2NyaXB0Q29yZS9ranMvb2JqZWN0LmgJMjcgRGVjIDIw MDUgMDk6MjQ6MTMgLTAwMDAJMS41MgorKysgSmF2YVNjcmlwdENvcmUva2pzL29iamVjdC5oCTcg SmFuIDIwMDYgMTA6MjI6MTIgLTAwMDAKQEAgLTQ5MSw5ICs0OTEsMTIgQEAgbmFtZXNwYWNlIEtK UyB7CiAgICAgZG91YmxlIHRvTnVtYmVyKEV4ZWNTdGF0ZSAqZXhlYykgY29uc3Q7CiAgICAgVVN0 cmluZyB0b1N0cmluZyhFeGVjU3RhdGUgKmV4ZWMpIGNvbnN0OwogICAgIEpTT2JqZWN0ICp0b09i amVjdChFeGVjU3RhdGUgKmV4ZWMpIGNvbnN0OwotCisgICAgCiAgICAgYm9vbCBnZXRQcm9wZXJ0 eUF0dHJpYnV0ZXMoY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBpbnQmIGF0dHJpYnV0 ZXMpIGNvbnN0OwogICAgIAorICAgIC8vIFJldHVybnMgd2hldGhlciB0aGUgb2JqZWN0IHNob3Vs ZCBiZSB0cmVhdGVkIGFzIG51bGwgd2hlbiBkb2luZyBlcXVhbGl0eSBjb21wYXJpc29ucworICAg IHZpcnR1YWwgYm9vbCBpc0VxdWFsVG9OdWxsKEV4ZWNTdGF0ZSAqKSBjb25zdCB7IHJldHVybiBm YWxzZTsgfQorICAgIAogICAgIC8vIFRoaXMgZ2V0IGZ1bmN0aW9uIG9ubHkgbG9va3MgYXQgdGhl IHByb3BlcnR5IG1hcC4KICAgICAvLyBUaGlzIGlzIHVzZWQgZS5nLiBieSBsb29rdXBPckNyZWF0 ZUZ1bmN0aW9uICh0byBjYWNoZSBhIGZ1bmN0aW9uLCB3ZSBkb24ndCB3YW50CiAgICAgLy8gdG8g bG9vayB1cCBpbiB0aGUgcHJvdG90eXBlLCBpdCBtaWdodCBhbHJlYWR5IGV4aXN0IHRoZXJlKQpJ bmRleDogSmF2YVNjcmlwdENvcmUva2pzL29wZXJhdGlvbnMuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZp bGU6IC9jdnMvcm9vdC9KYXZhU2NyaXB0Q29yZS9ranMvb3BlcmF0aW9ucy5jcHAsdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuMTUKZGlmZiAtcCAtdSAtcjEuMTUgSmF2YVNjcmlwdENvcmUva2pzL29w ZXJhdGlvbnMuY3BwCi0tLSBKYXZhU2NyaXB0Q29yZS9ranMvb3BlcmF0aW9ucy5jcHAJMjkgRGVj IDIwMDUgMDg6MTg6NDAgLTAwMDAJMS4xNQorKysgSmF2YVNjcmlwdENvcmUva2pzL29wZXJhdGlv bnMuY3BwCTcgSmFuIDIwMDYgMTA6MjI6MTIgLTAwMDAKQEAgLTEyOSwxMiArMTI5LDEyIEBAIGJv b2wgZXF1YWwoRXhlY1N0YXRlICpleGVjLCBKU1ZhbHVlICp2MSwKICAgICAgICAgfSBlbHNlIHsK ICAgICAgICAgICAgIGlmICgodDEgPT0gU3RyaW5nVHlwZSB8fCB0MSA9PSBOdW1iZXJUeXBlKSAm JiB0MiA+PSBPYmplY3RUeXBlKQogICAgICAgICAgICAgICAgIHJldHVybiBlcXVhbChleGVjLCB2 MSwgdjItPnRvUHJpbWl0aXZlKGV4ZWMpKTsKLSAgICAgICAgICAgIGlmICh0MSA9PSBOdWxsVHlw ZSAmJiB0MiA+PSBPYmplY3RUeXBlKQotICAgICAgICAgICAgICAgIHJldHVybiBlcXVhbChleGVj LCB2MSwgdjItPnRvUHJpbWl0aXZlKGV4ZWMsIE51bGxUeXBlKSk7CisgICAgICAgICAgICBpZiAo dDEgPT0gTnVsbFR5cGUgJiYgdDIgPT0gT2JqZWN0VHlwZSkKKyAgICAgICAgICAgICAgICByZXR1 cm4gc3RhdGljX2Nhc3Q8SlNPYmplY3QgKj4odjIpLT5pc0VxdWFsVG9OdWxsKGV4ZWMpOwogICAg ICAgICAgICAgaWYgKHQxID49IE9iamVjdFR5cGUgJiYgKHQyID09IFN0cmluZ1R5cGUgfHwgdDIg PT0gTnVtYmVyVHlwZSkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGVxdWFsKGV4ZWMsIHYxLT50 b1ByaW1pdGl2ZShleGVjKSwgdjIpOwotICAgICAgICAgICAgaWYgKHQxID49IE9iamVjdFR5cGUg JiYgdDIgPT0gTnVsbFR5cGUpCi0gICAgICAgICAgICAgICAgcmV0dXJuIGVxdWFsKGV4ZWMsIHYx LT50b1ByaW1pdGl2ZShleGVjLCBOdWxsVHlwZSksIHYyKTsKKyAgICAgICAgICAgIGlmICh0MSA9 PSBPYmplY3RUeXBlICYmIHQyID09IE51bGxUeXBlKQorICAgICAgICAgICAgICAgIHJldHVybiBz dGF0aWNfY2FzdDxKU09iamVjdCAqPih2MSktPmlzRXF1YWxUb051bGwoZXhlYyk7CiAgICAgICAg ICAgICBpZiAodDEgIT0gdDIpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAg ICB9CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jv b3QvV2ViQ29yZS9DaGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOTYKZGlmZiAtcCAt dSAtcjEuOTYgV2ViQ29yZS9DaGFuZ2VMb2cKLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCTcgSmFuIDIw MDYgMDI6MTU6MTUgLTAwMDAJMS45NgorKysgV2ViQ29yZS9DaGFuZ2VMb2cJNyBKYW4gMjAwNiAx MDoyMjoyMSAtMDAwMApAQCAtMSwzICsxLDE3IEBACisyMDA2LTAxLTA3ICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBtYWMuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIC0gRml4IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjM3MworICAgICAgICBSRUdSRVNTSU9OOiBKYXZhU2NyaXB0IGhhbmcgd2hl biBjb21wYXJpbmcgbGFyZ2UgYXJyYXkgdG8gbnVsbAorICAgICAgICAKKyAgICAgICAgKiBraHRt bC9lY21hL2tqc19odG1sLmNwcDoKKyAgICAgICAgUmVtb3ZlIHRvUHJpbWl0aXZlLgorICAgICAg ICAKKyAgICAgICAgKiBraHRtbC9lY21hL2tqc19odG1sLmg6CisgICAgICAgIChLSlM6OkhUTUxB bGxDb2xsZWN0aW9uOjppc0VxdWFsVG9OdWxsKToKKyAgICAgICAgSW1wbGVtZW50IGlzRXF1YWxU b051bGwgYW5kIGhhdmUgaXQgcmV0dXJuIHRydWUuCisKIDIwMDYtMDEtMDYgIEVyaWMgU2VpZGVs ICA8ZXNlaWRlbEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgZGFyaW4uCkluZGV4 OiBXZWJDb3JlL2todG1sL2VjbWEva2pzX2h0bWwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvcm9vdC9XZWJDb3JlL2todG1sL2VjbWEva2pzX2h0bWwuY3BwLHYKcmV0cmlldmluZyByZXZp c2lvbiAxLjE2NApkaWZmIC1wIC11IC1yMS4xNjQgV2ViQ29yZS9raHRtbC9lY21hL2tqc19odG1s LmNwcAotLS0gV2ViQ29yZS9raHRtbC9lY21hL2tqc19odG1sLmNwcAk0IEphbiAyMDA2IDIxOjA1 OjIzIC0wMDAwCTEuMTY0CisrKyBXZWJDb3JlL2todG1sL2VjbWEva2pzX2h0bWwuY3BwCTcgSmFu IDIwMDYgMTA6MjI6MjIgLTAwMDAKQEAgLTMzNTIsMTYgKzMzNTIsNiBAQCBKU1ZhbHVlICpLSlM6 OkhUTUxDb2xsZWN0aW9uUHJvdG9GdW5jOjpjCiAKIC8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAotSlNW YWx1ZSAqSFRNTEFsbENvbGxlY3Rpb246OnRvUHJpbWl0aXZlKEV4ZWNTdGF0ZSAqZXhlYywgVHlw ZSBwcmVmZXJyZWRUeXBlKSBjb25zdAotewotICAgIGlmIChwcmVmZXJyZWRUeXBlID09IE51bGxU eXBlKQotICAgICAgICByZXR1cm4ganNOdWxsKCk7Ci0gICAgZWxzZQotICAgICAgICByZXR1cm4g SFRNTENvbGxlY3Rpb246OnRvUHJpbWl0aXZlKGV4ZWMsIHByZWZlcnJlZFR5cGUpOwotfQotCi0v LyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCi0KIEhUTUxTZWxlY3RDb2xsZWN0aW9uOjpIVE1MU2VsZWN0Q29s bGVjdGlvbihFeGVjU3RhdGUgKmV4ZWMsIEhUTUxDb2xsZWN0aW9uSW1wbCAqYywgSFRNTFNlbGVj dEVsZW1lbnRJbXBsICplKQogICA6IEhUTUxDb2xsZWN0aW9uKGV4ZWMsIGMpLCBtX2VsZW1lbnQo ZSkKIHsKSW5kZXg6IFdlYkNvcmUva2h0bWwvZWNtYS9ranNfaHRtbC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL2VjbWEva2pzX2h0bWwuaCx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS42NgpkaWZmIC1wIC11IC1yMS42NiBXZWJDb3JlL2todG1sL2VjbWEva2pz X2h0bWwuaAotLS0gV2ViQ29yZS9raHRtbC9lY21hL2tqc19odG1sLmgJMjkgRGVjIDIwMDUgMDg6 MjA6MzcgLTAwMDAJMS42NgorKysgV2ViQ29yZS9raHRtbC9lY21hL2tqc19odG1sLmgJNyBKYW4g MjAwNiAxMDoyMjoyMiAtMDAwMApAQCAtMzM1LDcgKzMzNSw3IEBAIG5hbWVzcGFjZSBLSlMgewog ICAgIEhUTUxBbGxDb2xsZWN0aW9uKEV4ZWNTdGF0ZSAqZXhlYywgRE9NOjpIVE1MQ29sbGVjdGlv bkltcGwgKmMpIDoKICAgICAgIEhUTUxDb2xsZWN0aW9uKGV4ZWMsIGMpIHsgfQogICAgIHZpcnR1 YWwgYm9vbCB0b0Jvb2xlYW4oRXhlY1N0YXRlICopIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0g ICAgdmlydHVhbCBKU1ZhbHVlICp0b1ByaW1pdGl2ZShFeGVjU3RhdGUgKmV4ZWMsIFR5cGUgcHJl ZmVycmVkVHlwZSkgY29uc3Q7CisgICAgdmlydHVhbCBib29sIGlzRXF1YWxUb051bGwoRXhlY1N0 YXRlICopIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KICAgfTsKICAgCiAgIC8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8gT3B0aW9uIE9iamVjdCAvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8K