63717 2011-06-30 07:38:07 -0700 Broken build on QNX 2011-07-13 07:25:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 1 ademar ademar paroga webkit.review.bot oldest_to_newest 430401 0 ademar 2011-06-30 07:38:07 -0700 When building QtWebKit on QNX, we get plenty of compilation failures, most of them related to pthreads in JSC. Even after fixing these compilation failures, we still have a broken webkit in the end because JIT is not working, so it'll have to be disabled. Problem reported by Ritt Konstantin <ritt.ks@gmail.com>. I'll be uploading a patch based on his changes. 430408 1 99300 ademar 2011-06-30 07:52:54 -0700 Created attachment 99300 patch 430410 2 webkit.review.bot 2011-06-30 07:55:39 -0700 Attachment 99300 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/StackBounds.cpp:44: "pthread.h" already included at Source/JavaScriptCore/wtf/StackBounds.cpp:28 [build/include] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 430451 3 ademar 2011-06-30 09:05:01 -0700 (In reply to comment #2) > Source/JavaScriptCore/wtf/StackBounds.cpp:44: "pthread.h" already included at Source/JavaScriptCore/wtf/StackBounds.cpp:28 [build/include] [4] > Total errors found: 1 in 5 files This looks like a false positive, as the includes are guarded with #if OS(). 434525 4 99300 paroga 2011-07-09 13:29:05 -0700 Comment on attachment 99300 patch View in context: https://bugs.webkit.org/attachment.cgi?id=99300&action=review > Source/JavaScriptCore/heap/MachineStackMarker.cpp:83 > +#if !OS(QNX) > +/* QNX doesn't support SA_RESTART yet. */ Are you sure you want ENABLE(JSC_MULTIPLE_THREADS)? Why not disable JSC_MULTIPLE_THREADS if you can't support it correctly? > Source/JavaScriptCore/wtf/Platform.h:663 > +#if OS(QNX) > +#define ENABLE_JIT 0 > +#endif Why do you put it in it's own #if? IMHO http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/Platform.h?rev=90167#L1027 is the correct place for this. > Source/JavaScriptCore/wtf/StackBounds.cpp:49 > +#include <pthread.h> > #include <fcntl.h> > #include <sys/procfs.h> > #include <stdio.h> > #include <errno.h> > +#include <string.h> I agree with the false positive, but please sort the headers. 435909 5 ademar 2011-07-12 13:24:57 -0700 (In reply to comment #4) > (From update of attachment 99300 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=99300&action=review > Thanks for the review, the patch is much more clean now. :-) > > Source/JavaScriptCore/heap/MachineStackMarker.cpp:83 > > +#if !OS(QNX) > > +/* QNX doesn't support SA_RESTART yet. */ > > Are you sure you want ENABLE(JSC_MULTIPLE_THREADS)? > Why not disable JSC_MULTIPLE_THREADS if you can't support it correctly? Perfect, done. > > > Source/JavaScriptCore/wtf/Platform.h:663 > > +#if OS(QNX) > > +#define ENABLE_JIT 0 > > +#endif > > Why do you put it in it's own #if? > IMHO http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/Platform.h?rev=90167#L1027 is the correct place for this. Done. > > > Source/JavaScriptCore/wtf/StackBounds.cpp:49 > > +#include <pthread.h> > > #include <fcntl.h> > > #include <sys/procfs.h> > > #include <stdio.h> > > #include <errno.h> > > +#include <string.h> > > I agree with the false positive, but please sort the headers. Done. 435913 6 100552 ademar 2011-07-12 13:26:09 -0700 Created attachment 100552 patch v2 435915 7 webkit.review.bot 2011-07-12 13:28:18 -0700 Attachment 100552 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/StackBounds.cpp:46: "pthread.h" already included at Source/JavaScriptCore/wtf/StackBounds.cpp:28 [build/include] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 435990 8 100552 paroga 2011-07-12 14:56:30 -0700 Comment on attachment 100552 patch v2 LGTM, but I'm not a reviewer 436402 9 100552 kling 2011-07-13 06:32:27 -0700 Comment on attachment 100552 patch v2 Cool, r=me 436426 10 100552 webkit.review.bot 2011-07-13 07:25:37 -0700 Comment on attachment 100552 patch v2 Clearing flags on attachment: 100552 Committed r90916: <http://trac.webkit.org/changeset/90916> 436427 11 webkit.review.bot 2011-07-13 07:25:41 -0700 All reviewed patches have been landed. Closing bug. 99300 2011-06-30 07:52:54 -0700 2011-07-09 13:29:05 -0700 patch 0001-Broken-build-on-QNX.patch text/plain 4976 ademar RnJvbSAxYzUzMmNlNTA3NTFhZDc2YmEyMGIzYjVhYTE1MTcyYzY5YjAwZmUxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogVGh1LCAzMCBKdW4gMjAxMSAxMTo1MTo0OSAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIEJyb2tlbiBidWlsZCBvbiBRTlgKCmh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02MzcxNwotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgICAgfCAgIDE3ICsrKysrKysrKysrKysrKysrCiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaGVhcC9NYWNoaW5lU3RhY2tNYXJrZXIuY3BwIHwgICAgOSArKysrKysrKysK IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGguY3BwICAgICAgICAgICAgfCAgICAy ICstCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmggICAgICAgICAgICAgIHwg ICAgNCArKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1N0YWNrQm91bmRzLmNwcCAgICAg ICAgIHwgICAgMiArKwogNSBmaWxlcyBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBhMzE3MGQuLjZlOWY2MWMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDExLTA2LTMwICBBZGVt YXIgZGUgU291emEgUmVpcyBKci4gIDxhZGVtYXIucmVpc0BvcGVuYm9zc2Eub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJyb2tlbiBidWlsZCBv biBRTlgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYz NzE3CisKKyAgICAgICAgUU5YIGRvZXNuJ3Qgc3VwcG9ydCBwdGhyZWFkJ3MgU0FfUkVTVEFSVCwg SklUIGlzIGJyb2tlbiBhdAorICAgICAgICBydW50aW1lIGFuZCB0aGVyZSBhIGZldyBtaW5vciBj b21waWxhdGlvbiBlcnJvcnMgaGVyZSBhbmQgdGhlcmUuCisgICAgICAgIE9yaWdpbmFsIHBhdGNo IGJ5IFJpdHQgS29uc3RhbnRpbiA8cml0dC5rc0BnbWFpbC5jb20+LCBhbHNvCisgICAgICAgIHRl c3RlZCBieSBoaW0gb24gUU5YIHY2LjUgKHg4NikKKworICAgICAgICAqIGhlYXAvTWFjaGluZVN0 YWNrTWFya2VyLmNwcDogZml4IGJ1aWxkIG9uIFFOWCB3aGVyZSBTQV9SRVNUQVJUIGlzbid0IGlt cGxlbWVudGVkIHlldAorICAgICAgICAqIHd0Zi9EYXRlTWF0aC5jcHA6IGZpeCB1c2FnZSBvZiBh YnMvbGFicworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBEaXNhYmxlIEpJVAorICAgICAgICAq IHd0Zi9TdGFja0JvdW5kcy5jcHA6IEFkZCBhIGNvdXBsZSBvZiBtaXNzaW5nIGluY2x1ZGVzCisK IDIwMTEtMDYtMzAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI5MDEwMi4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hY2hpbmVTdGFja01hcmtlci5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaGVhcC9NYWNoaW5lU3RhY2tNYXJrZXIuY3BwCmluZGV4IDczYTNkYjYu LjBiYTg0N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hY2hpbmVT dGFja01hcmtlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFjaGluZVN0 YWNrTWFya2VyLmNwcApAQCAtNzksOSArNzksMTIgQEAKICNpZiBVU0UoUFRIUkVBRFMpICYmICFP UyhXSU5ET1dTKSAmJiAhT1MoREFSV0lOKQogI2luY2x1ZGUgPHNpZ25hbC5oPgogI2lmbmRlZiBT QV9SRVNUQVJUCisjaWYgIU9TKFFOWCkKKy8qIFFOWCBkb2Vzbid0IHN1cHBvcnQgU0FfUkVTVEFS VCB5ZXQuICovCiAjZXJyb3IgTWFjaGluZVRocmVhZHMgcmVxdWlyZXMgU0FfUkVTVEFSVAogI2Vu ZGlmCiAjZW5kaWYKKyNlbmRpZgogCiAjZW5kaWYKIApAQCAtMTExLDYgKzExNCw3IEBAIHR5cGVk ZWYgSEFORExFIFBsYXRmb3JtVGhyZWFkOwogdHlwZWRlZiBwdGhyZWFkX3QgUGxhdGZvcm1UaHJl YWQ7CiBzdGF0aWMgY29uc3QgaW50IFNpZ1RocmVhZFN1c3BlbmRSZXN1bWUgPSBTSUdVU1IyOwog CisjaWYgZGVmaW5lZChTQV9SRVNUQVJUKQogc3RhdGljIHZvaWQgcHRocmVhZFNpZ25hbEhhbmRs ZXJTdXNwZW5kUmVzdW1lKGludCBzaWdubykKIHsKICAgICBzaWdzZXRfdCBzaWduYWxTZXQ7CkBA IC0xMTksNiArMTIzLDcgQEAgc3RhdGljIHZvaWQgcHRocmVhZFNpZ25hbEhhbmRsZXJTdXNwZW5k UmVzdW1lKGludCBzaWdubykKICAgICBzaWdzdXNwZW5kKCZzaWduYWxTZXQpOwogfQogI2VuZGlm CisjZW5kaWYKIAogY2xhc3MgTWFjaGluZVRocmVhZHM6OlRocmVhZCB7CiBwdWJsaWM6CkBAIC0x MjgsMTEgKzEzMywxMyBAQCBwdWJsaWM6CiAgICAgICAgICwgc3RhY2tCYXNlKGJhc2UpCiAgICAg ewogI2lmIFVTRShQVEhSRUFEUykgJiYgIU9TKFdJTkRPV1MpICYmICFPUyhEQVJXSU4pCisjaWYg ZGVmaW5lZChTQV9SRVNUQVJUKQogICAgICAgICBzdHJ1Y3Qgc2lnYWN0aW9uIGFjdGlvbjsKICAg ICAgICAgYWN0aW9uLnNhX2hhbmRsZXIgPSBwdGhyZWFkU2lnbmFsSGFuZGxlclN1c3BlbmRSZXN1 bWU7CiAgICAgICAgIHNpZ2VtcHR5c2V0KCZhY3Rpb24uc2FfbWFzayk7CiAgICAgICAgIGFjdGlv bi5zYV9mbGFncyA9IFNBX1JFU1RBUlQ7CiAgICAgICAgIHNpZ2FjdGlvbihTaWdUaHJlYWRTdXNw ZW5kUmVzdW1lLCAmYWN0aW9uLCAwKTsKKyNlbmRpZgogCiAgICAgICAgIHNpZ3NldF90IG1hc2s7 CiAgICAgICAgIHNpZ2VtcHR5c2V0KCZtYXNrKTsKQEAgLTM3Myw5ICszODAsMTEgQEAgc3RhdGlj IHNpemVfdCBnZXRQbGF0Zm9ybVRocmVhZFJlZ2lzdGVycyhjb25zdCBQbGF0Zm9ybVRocmVhZCYg cGxhdGZvcm1UaHJlYWQsIFAKICAgICAvLyBlLmcuIG9uIEZyZWVCU0QgNS40LCBuZXVuZG9yZkBr ZGUub3JnCiAgICAgcHRocmVhZF9hdHRyX2dldF9ucChwbGF0Zm9ybVRocmVhZCwgJnJlZ3MpOwog I2Vsc2UKKyNpZiAhT1MoUU5YKQogICAgIC8vIEZJWE1FOiB0aGlzIGZ1bmN0aW9uIGlzIG5vbi1w b3J0YWJsZTsgb3RoZXIgUE9TSVggc3lzdGVtcyBtYXkgaGF2ZSBkaWZmZXJlbnQgbnAgYWx0ZXJu YXRpdmVzCiAgICAgcHRocmVhZF9nZXRhdHRyX25wKHBsYXRmb3JtVGhyZWFkLCAmcmVncyk7CiAj ZW5kaWYKKyNlbmRpZgogICAgIHJldHVybiAwOwogI2Vsc2UKICNlcnJvciBOZWVkIGEgd2F5IHRv IGdldCB0aHJlYWQgcmVnaXN0ZXJzIG9uIHRoaXMgcGxhdGZvcm0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGguY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9EYXRlTWF0aC5jcHAKaW5kZXggNWNhZThmNi4uOWZjMjU4OCAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9EYXRlTWF0aC5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3d0Zi9EYXRlTWF0aC5jcHAKQEAgLTY5OCw3ICs2OTgsNyBAQCBkb3VibGUgcGFyc2VF UzVEYXRlRnJvbU51bGxUZXJtaW5hdGVkQ2hhcmFjdGVycyhjb25zdCBjaGFyKiBkYXRlU3RyaW5n KQogICAgICAgICAgICAgcmV0dXJuIHN0ZDo6bnVtZXJpY19saW1pdHM8ZG91YmxlPjo6cXVpZXRf TmFOKCk7CiAgICAgICAgIGlmICgqcG9zdFBhcnNlUG9zaXRpb24gIT0gJzonIHx8IChwb3N0UGFy c2VQb3NpdGlvbiAtIGN1cnJlbnRQb3NpdGlvbikgIT0gMikKICAgICAgICAgICAgIHJldHVybiBz dGQ6Om51bWVyaWNfbGltaXRzPGRvdWJsZT46OnF1aWV0X05hTigpOwotICAgICAgICB0ekhvdXJz QWJzID0gYWJzKHR6SG91cnMpOworICAgICAgICB0ekhvdXJzQWJzID0gbGFicyh0ekhvdXJzKTsK ICAgICAgICAgY3VycmVudFBvc2l0aW9uID0gcG9zdFBhcnNlUG9zaXRpb24gKyAxOwogICAgICAg ICAKICAgICAgICAgaWYgKCFpc0FTQ0lJRGlnaXQoKmN1cnJlbnRQb3NpdGlvbikpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKaW5kZXggY2NkZmNkOC4uZTc5OGNkMSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaApAQCAtNjU4LDYgKzY1OCwxMCBAQAogI2RlZmluZSBF TkFCTEVfUFVSR0VBQkxFX01FTU9SWSAxCiAjZW5kaWYKIAorI2lmIE9TKFFOWCkKKyNkZWZpbmUg RU5BQkxFX0pJVCAwCisjZW5kaWYKKwogI2lmIFBMQVRGT1JNKElPUykKICNkZWZpbmUgRU5BQkxF X0NPTlRFWFRfTUVOVVMgMAogI2RlZmluZSBFTkFCTEVfRFJBR19TVVBQT1JUIDAKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvU3RhY2tCb3VuZHMuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi9TdGFja0JvdW5kcy5jcHAKaW5kZXggNDFlMGQ2MC4uMmQ4MzIzMyAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9TdGFja0JvdW5kcy5jcHAKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9TdGFja0JvdW5kcy5jcHAKQEAgLTQxLDEwICs0 MSwxMiBAQAogCiAjZWxpZiBPUyhRTlgpCiAKKyNpbmNsdWRlIDxwdGhyZWFkLmg+CiAjaW5jbHVk ZSA8ZmNudGwuaD4KICNpbmNsdWRlIDxzeXMvcHJvY2ZzLmg+CiAjaW5jbHVkZSA8c3RkaW8uaD4K ICNpbmNsdWRlIDxlcnJuby5oPgorI2luY2x1ZGUgPHN0cmluZy5oPgogCiAjZWxpZiBPUyhVTklY KQogCi0tIAoxLjcuMy40Cgo= 100552 2011-07-12 13:26:09 -0700 2011-07-13 07:25:37 -0700 patch v2 0001-Broken-build-on-QNX.patch text/plain 3749 ademar RnJvbSBjNmEwMThmYzcxNjAxYTgwYTMyZTlhMjNmZGFkNzE3NjBiODNkZWI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogVHVlLCAxMiBKdWwgMjAxMSAxNzoyMjozNSAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIEJyb2tlbiBidWlsZCBvbiBRTlgKCmh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02MzcxNwotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cgICAgICAgICAgIHwgICAxOCArKysrKysrKysrKysrKysrKysKIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvRGF0ZU1hdGguY3BwICAgIHwgICAgMiArLQogU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9QbGF0Zm9ybS5oICAgICAgfCAgICA1ICsrKy0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL1N0YWNrQm91bmRzLmNwcCB8ICAgIDYgKysrKy0tCiA0IGZpbGVzIGNoYW5nZWQsIDI2IGlu c2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXgg ODM4OWYwZC4uNmE4NjAzNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMDYtMzAgIEFkZW1hciBkZSBTb3V6YSBSZWlzIEpyLiAgPGFkZW1hci5yZWlzQG9w ZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQnJva2VuIGJ1aWxkIG9uIFFOWAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjM3MTcKKworICAgICAgICBRTlggZG9lc24ndCBzdXBwb3J0IHB0 aHJlYWQncyBTQV9SRVNUQVJUIChyZXF1aXJlZCBieQorICAgICAgICBKU0NfTVVMVElQTEVfVEhS RUFEUyksIEpJVCBpcyBicm9rZW4gYXQgcnVudGltZSBhbmQgdGhlcmUgYQorICAgICAgICBmZXcg bWlub3IgY29tcGlsYXRpb24gZXJyb3JzIGhlcmUgYW5kIHRoZXJlLgorCisgICAgICAgIE9yaWdp bmFsIHBhdGNoIGJ5IFJpdHQgS29uc3RhbnRpbiA8cml0dC5rc0BnbWFpbC5jb20+LCBhbHNvCisg ICAgICAgIHRlc3RlZCBieSBoaW0gb24gUU5YIHY2LjUgKHg4NikKKworICAgICAgICAqIHd0Zi9E YXRlTWF0aC5jcHA6IGZpeCB1c2FnZSBvZiBhYnMvbGFicworICAgICAgICAqIHd0Zi9QbGF0Zm9y bS5oOiBEaXNhYmxlIEpJVCBhbmQgSlNDX01VTFRJUExFX1RIUkVBRFMKKyAgICAgICAgKiB3dGYv U3RhY2tCb3VuZHMuY3BwOiBBZGQgYSBjb3VwbGUgb2YgbWlzc2luZyBpbmNsdWRlcyAoYW5kIHNv cnQgdGhlbSkKKwogMjAxMS0wNy0xMiAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAK ICAgICAgICAgRW5zdXJlIG5vIGludGVybWVkaWF0ZSBXVEY6OlN0cmluZ3MgYXJlIGNyZWF0ZWQg d2hlbiBjb25jYXRlbmF0aW5nIHdpdGggc3RyaW5nIGxpdGVyYWxzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvd3RmL0RhdGVNYXRoLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvRGF0ZU1hdGguY3BwCmluZGV4IDVjYWU4ZjYuLjlmYzI1ODggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGguY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93dGYvRGF0ZU1hdGguY3BwCkBAIC02OTgsNyArNjk4LDcgQEAgZG91YmxlIHBhcnNl RVM1RGF0ZUZyb21OdWxsVGVybWluYXRlZENoYXJhY3RlcnMoY29uc3QgY2hhciogZGF0ZVN0cmlu ZykKICAgICAgICAgICAgIHJldHVybiBzdGQ6Om51bWVyaWNfbGltaXRzPGRvdWJsZT46OnF1aWV0 X05hTigpOwogICAgICAgICBpZiAoKnBvc3RQYXJzZVBvc2l0aW9uICE9ICc6JyB8fCAocG9zdFBh cnNlUG9zaXRpb24gLSBjdXJyZW50UG9zaXRpb24pICE9IDIpCiAgICAgICAgICAgICByZXR1cm4g c3RkOjpudW1lcmljX2xpbWl0czxkb3VibGU+OjpxdWlldF9OYU4oKTsKLSAgICAgICAgdHpIb3Vy c0FicyA9IGFicyh0ekhvdXJzKTsKKyAgICAgICAgdHpIb3Vyc0FicyA9IGxhYnModHpIb3Vycyk7 CiAgICAgICAgIGN1cnJlbnRQb3NpdGlvbiA9IHBvc3RQYXJzZVBvc2l0aW9uICsgMTsKICAgICAg ICAgCiAgICAgICAgIGlmICghaXNBU0NJSURpZ2l0KCpjdXJyZW50UG9zaXRpb24pKQpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IGJjMjMyZmYuLjg4OGIzMWQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKQEAgLTU3OCw3ICs1NzgsNyBAQAogI2RlZmluZSBX VEZfVVNFX1BUSFJFQURfQkFTRURfUVQgMQogI2VuZGlmCiAKLSNpZiAoUExBVEZPUk0oR1RLKSB8 fCBQTEFURk9STShJT1MpIHx8IFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oV0lOKSB8fCAoUExB VEZPUk0oUVQpICYmIChPUyhEQVJXSU4pIHx8IFVTRShQVEhSRUFEX0JBU0VEX1FUKSkgJiYgIUVO QUJMRShTSU5HTEVfVEhSRUFERUQpKSkgJiYgIWRlZmluZWQoRU5BQkxFX0pTQ19NVUxUSVBMRV9U SFJFQURTKQorI2lmIChQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKElPUykgfHwgUExBVEZPUk0o TUFDKSB8fCBQTEFURk9STShXSU4pIHx8IChQTEFURk9STShRVCkgJiYgKE9TKERBUldJTikgfHwg VVNFKFBUSFJFQURfQkFTRURfUVQpKSAmJiAhRU5BQkxFKFNJTkdMRV9USFJFQURFRCkpKSAmJiAh T1MoUU5YKSAmJiAhZGVmaW5lZChFTkFCTEVfSlNDX01VTFRJUExFX1RIUkVBRFMpCiAjZGVmaW5l IEVOQUJMRV9KU0NfTVVMVElQTEVfVEhSRUFEUyAxCiAjZW5kaWYKIApAQCAtMTAyNyw3ICsxMDI3 LDggQEAKICNpZiAhZGVmaW5lZChFTkFCTEVfSklUKSBcCiAgICAgJiYgKENQVShYODYpIHx8IENQ VShYODZfNjQpIHx8IENQVShBUk0pIHx8IENQVShNSVBTKSkgXAogICAgICYmIChPUyhEQVJXSU4p IHx8ICFDT01QSUxFUihHQ0MpIHx8IEdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsIDEsIDApKSBcCi0g ICAgJiYgIU9TKFdJTkNFKQorICAgICYmICFPUyhXSU5DRSkgXAorICAgICYmICFPUyhRTlgpCiAj ZGVmaW5lIEVOQUJMRV9KSVQgMQogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93dGYvU3RhY2tCb3VuZHMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9T dGFja0JvdW5kcy5jcHAKaW5kZXggNDFlMGQ2MC4uNmI2MTI3MCAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3d0Zi9TdGFja0JvdW5kcy5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3d0Zi9TdGFja0JvdW5kcy5jcHAKQEAgLTQxLDEwICs0MSwxMiBAQAogCiAjZWxpZiBP UyhRTlgpCiAKKyNpbmNsdWRlIDxlcnJuby5oPgogI2luY2x1ZGUgPGZjbnRsLmg+Ci0jaW5jbHVk ZSA8c3lzL3Byb2Nmcy5oPgorI2luY2x1ZGUgPHB0aHJlYWQuaD4KICNpbmNsdWRlIDxzdGRpby5o PgotI2luY2x1ZGUgPGVycm5vLmg+CisjaW5jbHVkZSA8c3RyaW5nLmg+CisjaW5jbHVkZSA8c3lz L3Byb2Nmcy5oPgogCiAjZWxpZiBPUyhVTklYKQogCi0tIAoxLjcuMy40Cgo=