63675 2011-06-29 17:53:58 -0700 new-run-webkit-tests should tell you when it creates new expectations 2011-06-30 16:26:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dpranke eric webkit.review.bot oldest_to_newest 430042 0 abarth 2011-06-29 17:53:58 -0700 new-run-webkit-tests should tell you when it creates new expectations 430043 1 99196 abarth 2011-06-29 17:55:07 -0700 Created attachment 99196 Patch 430044 2 99196 eric 2011-06-29 17:57:21 -0700 Comment on attachment 99196 Patch OK. No way to test this with our current logging infrastructure I assume? 430064 3 99196 abarth 2011-06-29 18:17:29 -0700 Comment on attachment 99196 Patch Yeah, if I could figure out how to test it, I could figure how to stop it from spamming the console during testing. 430074 4 99196 dpranke 2011-06-29 18:30:34 -0700 Comment on attachment 99196 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99196&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:194 > + _log.warning('Writing new expected result "%s"' % result_name) This should be log.info(); these aren't warnings. 430092 5 abarth 2011-06-29 19:02:10 -0700 Committed r90079: <http://trac.webkit.org/changeset/90079> 430806 6 dpranke 2011-06-30 16:26:30 -0700 Oh, by the way, it occurred to me that if DRT happens to fail on a text-only test in such a way that dumpAsText() doesn't get called and we don't realize the test is test-only, then the code will incorrectly think that the image is missing and generate a new (wrong) baseline for it. This probably doesn't happen all that often, but is an argument for --no-new-test-results being on by default. Maybe this should be filed as a separate bug somewhere, but I'm not sure how we can actually fix the DRT flaw so that we would know from NRWT's side definitively whether a test should be text-only or not. 99196 2011-06-29 17:55:07 -0700 2011-06-29 18:32:12 -0700 Patch bug-63675-20110629175505.patch text/plain 1709 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkwMDc1KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDYtMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBuZXctcnVuLXdl YmtpdC10ZXN0cyBzaG91bGQgdGVsbCB5b3Ugd2hlbiBpdCBjcmVhdGVzIG5ldyBleHBlY3RhdGlv bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNjc1 CisKKyAgICAgICAgVW5mb3J1bmF0ZWx5LCB0aGlzIHBhdGNoIGNyZWF0ZXMgYSBidW5jaCBvZiB0 ZXN0LXdlYmtpdHB5IHNwYW0gYmVjYXVzZQorICAgICAgICB3ZSBkb24ndCB1bmRlcnN0YW5kIGhv dyBQeXRob24gbG9nZ2luZyB3b3JrcyB3ZWxsIGVub3VnaCB0byBzdG9wIHRoZQorICAgICAgICBz cGFtLiAgOigKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91 dF9wYWNrYWdlL3NpbmdsZV90ZXN0X3J1bm5lci5weToKKwogMjAxMS0wNi0yOSAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVs LgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2th Z2Uvc2luZ2xlX3Rlc3RfcnVubmVyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3NpbmdsZV90ZXN0X3J1bm5lci5weQko cmV2aXNpb24gOTAwNzIpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9s YXlvdXRfcGFja2FnZS9zaW5nbGVfdGVzdF9ydW5uZXIucHkJKHdvcmtpbmcgY29weSkKQEAgLTE4 NywxMCArMTg3LDExIEBAIGNsYXNzIFNpbmdsZVRlc3RSdW5uZXI6CiAgICAgICAgICAgICAgICAg Ii1leHBlY3RlZCIgKyBtb2RpZmllcikKICAgICAgICAgICAgIGZzLm1heWJlX21ha2VfZGlyZWN0 b3J5KG91dHB1dF9kaXIpCiAgICAgICAgICAgICBvdXRwdXRfcGF0aCA9IGZzLmpvaW4ob3V0cHV0 X2Rpciwgb3V0cHV0X2ZpbGUpCi0gICAgICAgICAgICBfbG9nLmRlYnVnKCdXcml0aW5nIG5ldyBi YXNlbGluZSByZXN1bHQgIiVzIicgJSBvdXRwdXRfcGF0aCkKICAgICAgICAgZWxzZToKICAgICAg ICAgICAgIG91dHB1dF9wYXRoID0gcG9ydC5leHBlY3RlZF9maWxlbmFtZShzZWxmLl9maWxlbmFt ZSwgbW9kaWZpZXIpCi0gICAgICAgICAgICBfbG9nLmRlYnVnKCdSZXNldHRpbmcgYmFzZWxpbmUg cmVzdWx0ICIlcyInICUgb3V0cHV0X3BhdGgpCisKKyAgICAgICAgcmVzdWx0X25hbWUgPSBmcy5y ZWxwYXRoKG91dHB1dF9wYXRoLCBwb3J0LmxheW91dF90ZXN0c19kaXIoKSkKKyAgICAgICAgX2xv Zy53YXJuaW5nKCdXcml0aW5nIG5ldyBleHBlY3RlZCByZXN1bHQgIiVzIicgJSByZXN1bHRfbmFt ZSkKIAogICAgICAgICBwb3J0LnVwZGF0ZV9iYXNlbGluZShvdXRwdXRfcGF0aCwgZGF0YSkKIAo=