63668 2011-06-29 16:08:32 -0700 REGRESSION(r89952): r89952 added a wrong assertion in visible_units.cpp 2011-06-29 16:45:57 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa oldest_to_newest 429953 0 rniwa 2011-06-29 16:08:32 -0700 820 if (type == Position::PositionIsOffsetInAnchor) { 821 ASSERT(type != Position::PositionIsOffsetInAnchor || !offset); should be 820 if (type == Position::PositionIsOffsetInAnchor) { 821 ASSERT(type == Position::PositionIsOffsetInAnchor || !offset); instead. Thanks Justin for finding this! 429959 1 99171 rniwa 2011-06-29 16:13:02 -0700 Created attachment 99171 Patch 429986 2 rniwa 2011-06-29 16:45:57 -0700 Committed r90064: <http://trac.webkit.org/changeset/90064> 99171 2011-06-29 16:13:02 -0700 2011-06-29 16:26:01 -0700 Patch bug-63668-20110629161301.patch text/plain 1285 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwMDU5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjkgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTihyODk5NTIpOiByODk5NTIgYWRkZWQgYSB3cm9u ZyBhc3NlcnRpb24gaW4gdmlzaWJsZV91bml0cy5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNjY4CisKKyAgICAgICAgV2UgbmVlZCB0byBhc3Nl cnQgdGhlIG9mZnNldCB0byBiZSB6ZXJvIG9ubHkgd2hlbiB0aGUgcG9zaXRpb24gaXMgTk9UIG9m ZnNldCBpbiBub2RlLgorCisgICAgICAgICogZWRpdGluZy92aXNpYmxlX3VuaXRzLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OnN0YXJ0T2ZQYXJhZ3JhcGgpOgorCiAyMDExLTA2LTI5ICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJl dGggRGFraW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL3Zpc2libGVfdW5pdHMuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvdmlzaWJsZV91bml0cy5jcHAJ KHJldmlzaW9uIDg5OTg3KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy92aXNpYmxlX3VuaXRz LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODE4LDcgKzgxOCw3IEBAIFZpc2libGVQb3NpdGlvbiBz dGFydE9mUGFyYWdyYXBoKGNvbnN0IFYKICAgICB9CiAKICAgICBpZiAodHlwZSA9PSBQb3NpdGlv bjo6UG9zaXRpb25Jc09mZnNldEluQW5jaG9yKSB7Ci0gICAgICAgIEFTU0VSVCh0eXBlICE9IFBv c2l0aW9uOjpQb3NpdGlvbklzT2Zmc2V0SW5BbmNob3IgfHwgIW9mZnNldCk7CisgICAgICAgIEFT U0VSVCh0eXBlID09IFBvc2l0aW9uOjpQb3NpdGlvbklzT2Zmc2V0SW5BbmNob3IgfHwgIW9mZnNl dCk7CiAgICAgICAgIHJldHVybiBWaXNpYmxlUG9zaXRpb24oUG9zaXRpb24obm9kZSwgb2Zmc2V0 LCB0eXBlKSwgRE9XTlNUUkVBTSk7CiAgICAgfQogCg==