63667 2011-06-29 16:03:50 -0700 Added a dummy write barrier emitting function in all the right places in the old JIT 2011-06-29 16:12:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren oldest_to_newest 429950 0 ggaren 2011-06-29 16:03:50 -0700 Added a dummy write barrier emitting function in all the right places in the old JIT 429956 1 99170 ggaren 2011-06-29 16:09:54 -0700 Created attachment 99170 Patch 429958 2 ggaren 2011-06-29 16:12:03 -0700 Committed r90060: <http://trac.webkit.org/changeset/90060> 99170 2011-06-29 16:09:54 -0700 2011-06-29 16:11:27 -0700 Patch bug-63667-20110629160953.patch text/plain 6936 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTAwNTkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzIgQEAK KzIwMTEtMDYtMjkgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIGR1bW15IHdy aXRlIGJhcnJpZXIgZW1pdHRpbmcgZnVuY3Rpb24gaW4gYWxsIHRoZSByaWdodCBwbGFjZXMgaW4g dGhlIG9sZCBKSVQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYzNjY3CisgICAgICAgIAorICAgICAgICBTdW5TcGlkZXIgcmVwb3J0cyBubyBjaGFuZ2Uu CisKKyAgICAgICAgKiBqaXQvSklULmg6CisgICAgICAgICogaml0L0pJVFByb3BlcnR5QWNjZXNz LmNwcDoKKyAgICAgICAgKEpTQzo6SklUOjplbWl0X29wX3B1dF9ieV9pZCk6CisgICAgICAgIChK U0M6OkpJVDo6ZW1pdF9vcF9wdXRfc2NvcGVkX3Zhcik6IERvIGl0LgorCisgICAgICAgIChKU0M6 OkpJVDo6ZW1pdF9vcF9wdXRfZ2xvYmFsX3Zhcik6IEdsb2JhbCBvYmplY3QgbmVlZHMgdG8gYmUg aW4gYSByZWdpc3RlcgorICAgICAgICBmb3IgdGhlIHNha2Ugb2YgdGhlIHdyaXRlIGJhcnJpZXIu CisKKyAgICAgICAgKEpTQzo6SklUOjplbWl0V3JpdGVCYXJyaWVyKTogRW1wdHkgZm9yIG5vdy4g Tm90IGZvciBsb25nIQorCisgICAgICAgICogaml0L0pJVFByb3BlcnR5QWNjZXNzMzJfNjQuY3Bw OgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfcHV0X2J5X3ZhbCk6CisgICAgICAgIChKU0M6 OkpJVDo6ZW1pdF9vcF9wdXRfYnlfaWQpOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfcHV0 X3Njb3BlZF92YXIpOiBEbyBpdC4KKworICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfcHV0X2ds b2JhbF92YXIpOiBHbG9iYWwgb2JqZWN0IG5lZWRzIHRvIGJlIGluIGEgcmVnaXN0ZXIKKyAgICAg ICAgZm9yIHRoZSBzYWtlIG9mIHRoZSB3cml0ZSBiYXJyaWVyLgorCisgICAgICAgIChKU0M6OkpJ VDo6ZW1pdFdyaXRlQmFycmllcik6IEVtcHR5IGZvciBub3cuIE5vdCBmb3IgbG9uZyEKKwogMjAx MS0wNi0yOSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KSVQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oCShy ZXZpc2lvbiA5MDA1MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmgJKHdvcmtp bmcgY29weSkKQEAgLTI5OSw2ICsyOTksOCBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAgICB2 b2lkIHRlc3RQcm90b3R5cGUoSlNWYWx1ZSwgSnVtcExpc3QmIGZhaWx1cmVDYXNlcyk7CiAKKyAg ICAgICAgdm9pZCBlbWl0V3JpdGVCYXJyaWVyKFJlZ2lzdGVySUQgb3duZXIsIFJlZ2lzdGVySUQg c2NyYXRjaCk7CisKICNpZiBVU0UoSlNWQUxVRTMyXzY0KQogICAgICAgICBib29sIGdldE9wZXJh bmRDb25zdGFudEltbWVkaWF0ZUludCh1bnNpZ25lZCBvcDEsIHVuc2lnbmVkIG9wMiwgdW5zaWdu ZWQmIG9wLCBpbnQzMl90JiBjb25zdGFudCk7CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MzMl82NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2VzczMyXzY0LmNwcAkocmV2aXNpb24gOTAw NTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzMzJfNjQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTksNiArMjU5LDcgQEAgdm9pZCBKSVQ6OmVtaXRfb3Bf cHV0X2J5X3ZhbChJbnN0cnVjdGlvbgogICAgIAogICAgIGFkZFNsb3dDYXNlKGJyYW5jaDMyKE5v dEVxdWFsLCByZWdUMywgVHJ1c3RlZEltbTMyKEpTVmFsdWU6OkludDMyVGFnKSkpOwogICAgIGVt aXRKdW1wU2xvd0Nhc2VJZk5vdEpTQ2VsbChiYXNlLCByZWdUMSk7CisgICAgZW1pdFdyaXRlQmFy cmllcihyZWdUMCwgcmVnVDEpOwogICAgIGFkZFNsb3dDYXNlKGJyYW5jaFB0cihOb3RFcXVhbCwg QWRkcmVzcyhyZWdUMCksIFRydXN0ZWRJbW1QdHIobV9nbG9iYWxEYXRhLT5qc0FycmF5VlB0cikp KTsKICAgICBhZGRTbG93Q2FzZShicmFuY2gzMihBYm92ZU9yRXF1YWwsIHJlZ1QyLCBBZGRyZXNz KHJlZ1QwLCBKU0FycmF5Ojp2ZWN0b3JMZW5ndGhPZmZzZXQoKSkpKTsKICAgICAKQEAgLTM5NCw2 ICszOTUsOCBAQCB2b2lkIEpJVDo6ZW1pdF9vcF9wdXRfYnlfaWQoSW5zdHJ1Y3Rpb24qCiAgICAg CiAgICAgZW1pdEp1bXBTbG93Q2FzZUlmTm90SlNDZWxsKGJhc2UsIHJlZ1QxKTsKICAgICAKKyAg ICBlbWl0V3JpdGVCYXJyaWVyKHJlZ1QwLCByZWdUMSk7CisgICAgCiAgICAgQkVHSU5fVU5JTlRF UlJVUFRFRF9TRVFVRU5DRShzZXF1ZW5jZVB1dEJ5SWQpOwogICAgIAogICAgIExhYmVsIGhvdFBh dGhCZWdpbih0aGlzKTsKQEAgLTEwMjgsMTAgKzEwMzEsMTEgQEAgdm9pZCBKSVQ6OmVtaXRfb3Bf cHV0X3Njb3BlZF92YXIoSW5zdHJ1YwogICAgIH0KICAgICB3aGlsZSAoc2tpcC0tKQogICAgICAg ICBsb2FkUHRyKEFkZHJlc3MocmVnVDIsIE9CSkVDVF9PRkZTRVRPRihTY29wZUNoYWluTm9kZSwg bmV4dCkpLCByZWdUMik7Ci0KICAgICBsb2FkUHRyKEFkZHJlc3MocmVnVDIsIE9CSkVDVF9PRkZT RVRPRihTY29wZUNoYWluTm9kZSwgb2JqZWN0KSksIHJlZ1QyKTsKLSAgICBsb2FkUHRyKEFkZHJl c3MocmVnVDIsIE9CSkVDVF9PRkZTRVRPRihKU1ZhcmlhYmxlT2JqZWN0LCBtX3JlZ2lzdGVycykp LCByZWdUMik7CiAKKyAgICBlbWl0V3JpdGVCYXJyaWVyKHJlZ1QyLCByZWdUMyk7CisKKyAgICBs b2FkUHRyKEFkZHJlc3MocmVnVDIsIE9CSkVDVF9PRkZTRVRPRihKU1ZhcmlhYmxlT2JqZWN0LCBt X3JlZ2lzdGVycykpLCByZWdUMik7CiAgICAgZW1pdFN0b3JlKGluZGV4LCByZWdUMSwgcmVnVDAs IHJlZ1QyKTsKICAgICBtYXAobV9ieXRlY29kZU9mZnNldCArIE9QQ09ERV9MRU5HVEgob3BfcHV0 X3Njb3BlZF92YXIpLCB2YWx1ZSwgcmVnVDEsIHJlZ1QwKTsKIH0KQEAgLTEwNTIsMTggKzEwNTYs MjcgQEAgdm9pZCBKSVQ6OmVtaXRfb3BfZ2V0X2dsb2JhbF92YXIoSW5zdHJ1YwogCiB2b2lkIEpJ VDo6ZW1pdF9vcF9wdXRfZ2xvYmFsX3ZhcihJbnN0cnVjdGlvbiogY3VycmVudEluc3RydWN0aW9u KQogewotICAgIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QgPSBtX2NvZGVCbG9jay0+Z2xv YmFsT2JqZWN0KCk7Ci0gICAgQVNTRVJUKGdsb2JhbE9iamVjdC0+aXNHbG9iYWxPYmplY3QoKSk7 CiAgICAgaW50IGluZGV4ID0gY3VycmVudEluc3RydWN0aW9uWzFdLnUub3BlcmFuZDsKICAgICBp bnQgdmFsdWUgPSBjdXJyZW50SW5zdHJ1Y3Rpb25bMl0udS5vcGVyYW5kOwogCisgICAgSlNHbG9i YWxPYmplY3QqIGdsb2JhbE9iamVjdCA9IG1fY29kZUJsb2NrLT5nbG9iYWxPYmplY3QoKTsKKwog ICAgIGVtaXRMb2FkKHZhbHVlLCByZWdUMSwgcmVnVDApOworICAgIG1vdmUoVHJ1c3RlZEltbVB0 cihnbG9iYWxPYmplY3QpLCByZWdUMik7CiAKLSAgICBsb2FkUHRyKCZnbG9iYWxPYmplY3QtPm1f cmVnaXN0ZXJzLCByZWdUMik7CisgICAgZW1pdFdyaXRlQmFycmllcihyZWdUMiwgcmVnVDMpOwor CisgICAgbG9hZFB0cihBZGRyZXNzKHJlZ1QyLCBPQkpFQ1RfT0ZGU0VUT0YoSlNWYXJpYWJsZU9i amVjdCwgbV9yZWdpc3RlcnMpKSwgcmVnVDIpOwogICAgIGVtaXRTdG9yZShpbmRleCwgcmVnVDEs IHJlZ1QwLCByZWdUMik7CiAgICAgbWFwKG1fYnl0ZWNvZGVPZmZzZXQgKyBPUENPREVfTEVOR1RI KG9wX3B1dF9nbG9iYWxfdmFyKSwgdmFsdWUsIHJlZ1QxLCByZWdUMCk7CiB9CiAKK3ZvaWQgSklU OjplbWl0V3JpdGVCYXJyaWVyKFJlZ2lzdGVySUQgb3duZXIsIFJlZ2lzdGVySUQgc2NyYXRjaCkK K3sKKyAgICBVTlVTRURfUEFSQU0ob3duZXIpOworICAgIFVOVVNFRF9QQVJBTShzY3JhdGNoKTsK K30KKwogfSAvLyBuYW1lc3BhY2UgSlNDCiAKICNlbmRpZiAvLyBVU0UoSlNWQUxVRTMyXzY0KQpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5j cHAJKHJldmlzaW9uIDkwMDUzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9w ZXJ0eUFjY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzMiw2ICs0MzIsOCBAQCB2b2lkIEpJ VDo6ZW1pdF9vcF9wdXRfYnlfaWQoSW5zdHJ1Y3Rpb24qCiAgICAgLy8gSnVtcCB0byBhIHNsb3cg Y2FzZSBpZiBlaXRoZXIgdGhlIGJhc2Ugb2JqZWN0IGlzIGFuIGltbWVkaWF0ZSwgb3IgaWYgdGhl IFN0cnVjdHVyZSBkb2VzIG5vdCBtYXRjaC4KICAgICBlbWl0SnVtcFNsb3dDYXNlSWZOb3RKU0Nl bGwocmVnVDAsIGJhc2VWUmVnKTsKIAorICAgIGVtaXRXcml0ZUJhcnJpZXIocmVnVDAsIHJlZ1Qy KTsKKwogICAgIEJFR0lOX1VOSU5URVJSVVBURURfU0VRVUVOQ0Uoc2VxdWVuY2VQdXRCeUlkKTsK IAogICAgIExhYmVsIGhvdFBhdGhCZWdpbih0aGlzKTsKQEAgLTk3Miw4ICs5NzQsOSBAQCB2b2lk IEpJVDo6ZW1pdF9vcF9wdXRfc2NvcGVkX3ZhcihJbnN0cnVjCiB7CiAgICAgaW50IHNraXAgPSBj dXJyZW50SW5zdHJ1Y3Rpb25bMl0udS5vcGVyYW5kOwogCi0gICAgZW1pdEdldEZyb21DYWxsRnJh bWVIZWFkZXJQdHIoUmVnaXN0ZXJGaWxlOjpTY29wZUNoYWluLCByZWdUMSk7CiAgICAgZW1pdEdl dFZpcnR1YWxSZWdpc3RlcihjdXJyZW50SW5zdHJ1Y3Rpb25bM10udS5vcGVyYW5kLCByZWdUMCk7 CisKKyAgICBlbWl0R2V0RnJvbUNhbGxGcmFtZUhlYWRlclB0cihSZWdpc3RlckZpbGU6OlNjb3Bl Q2hhaW4sIHJlZ1QxKTsKICAgICBib29sIGNoZWNrVG9wTGV2ZWwgPSBtX2NvZGVCbG9jay0+Y29k ZVR5cGUoKSA9PSBGdW5jdGlvbkNvZGUgJiYgbV9jb2RlQmxvY2stPm5lZWRzRnVsbFNjb3BlQ2hh aW4oKTsKICAgICBBU1NFUlQoc2tpcCB8fCAhY2hlY2tUb3BMZXZlbCk7CiAgICAgaWYgKGNoZWNr VG9wTGV2ZWwgJiYgc2tpcC0tKSB7CkBAIC05ODUsOCArOTg4LDEwIEBAIHZvaWQgSklUOjplbWl0 X29wX3B1dF9zY29wZWRfdmFyKEluc3RydWMKICAgICB9CiAgICAgd2hpbGUgKHNraXAtLSkKICAg ICAgICAgbG9hZFB0cihBZGRyZXNzKHJlZ1QxLCBPQkpFQ1RfT0ZGU0VUT0YoU2NvcGVDaGFpbk5v ZGUsIG5leHQpKSwgcmVnVDEpOwotCiAgICAgbG9hZFB0cihBZGRyZXNzKHJlZ1QxLCBPQkpFQ1Rf T0ZGU0VUT0YoU2NvcGVDaGFpbk5vZGUsIG9iamVjdCkpLCByZWdUMSk7CisKKyAgICBlbWl0V3Jp dGVCYXJyaWVyKHJlZ1QxLCByZWdUMik7CisKICAgICBsb2FkUHRyKEFkZHJlc3MocmVnVDEsIE9C SkVDVF9PRkZTRVRPRihKU1ZhcmlhYmxlT2JqZWN0LCBtX3JlZ2lzdGVycykpLCByZWdUMSk7CiAg ICAgc3RvcmVQdHIocmVnVDAsIEFkZHJlc3MocmVnVDEsIGN1cnJlbnRJbnN0cnVjdGlvblsxXS51 Lm9wZXJhbmQgKiBzaXplb2YoUmVnaXN0ZXIpKSk7CiB9CkBAIC0xMDAxLDEwICsxMDA2LDIxIEBA IHZvaWQgSklUOjplbWl0X29wX2dldF9nbG9iYWxfdmFyKEluc3RydWMKIAogdm9pZCBKSVQ6OmVt aXRfb3BfcHV0X2dsb2JhbF92YXIoSW5zdHJ1Y3Rpb24qIGN1cnJlbnRJbnN0cnVjdGlvbikKIHsK LSAgICBlbWl0R2V0VmlydHVhbFJlZ2lzdGVyKGN1cnJlbnRJbnN0cnVjdGlvblsyXS51Lm9wZXJh bmQsIHJlZ1QxKTsKLSAgICBKU1ZhcmlhYmxlT2JqZWN0KiBnbG9iYWxPYmplY3QgPSBtX2NvZGVC bG9jay0+Z2xvYmFsT2JqZWN0KCk7Ci0gICAgbG9hZFB0cigmZ2xvYmFsT2JqZWN0LT5tX3JlZ2lz dGVycywgcmVnVDApOwotICAgIHN0b3JlUHRyKHJlZ1QxLCBBZGRyZXNzKHJlZ1QwLCBjdXJyZW50 SW5zdHJ1Y3Rpb25bMV0udS5vcGVyYW5kICogc2l6ZW9mKFJlZ2lzdGVyKSkpOworICAgIEpTR2xv YmFsT2JqZWN0KiBnbG9iYWxPYmplY3QgPSBtX2NvZGVCbG9jay0+Z2xvYmFsT2JqZWN0KCk7CisK KyAgICBlbWl0R2V0VmlydHVhbFJlZ2lzdGVyKGN1cnJlbnRJbnN0cnVjdGlvblsyXS51Lm9wZXJh bmQsIHJlZ1QwKTsKKyAgICBtb3ZlKFRydXN0ZWRJbW1QdHIoZ2xvYmFsT2JqZWN0KSwgcmVnVDEp OworICAgIAorICAgIGVtaXRXcml0ZUJhcnJpZXIocmVnVDEsIHJlZ1QyKTsKKworICAgIGxvYWRQ dHIoQWRkcmVzcyhyZWdUMSwgT0JKRUNUX09GRlNFVE9GKEpTVmFyaWFibGVPYmplY3QsIG1fcmVn aXN0ZXJzKSksIHJlZ1QxKTsKKyAgICBzdG9yZVB0cihyZWdUMCwgQWRkcmVzcyhyZWdUMSwgY3Vy cmVudEluc3RydWN0aW9uWzFdLnUub3BlcmFuZCAqIHNpemVvZihSZWdpc3RlcikpKTsKK30KKwor dm9pZCBKSVQ6OmVtaXRXcml0ZUJhcnJpZXIoUmVnaXN0ZXJJRCBvd25lciwgUmVnaXN0ZXJJRCBz Y3JhdGNoKQoreworICAgIFVOVVNFRF9QQVJBTShvd25lcik7CisgICAgVU5VU0VEX1BBUkFNKHNj cmF0Y2gpOwogfQogCiAjZW5kaWYgLy8gVVNFKEpTVkFMVUU2NCkK