63665 2011-06-29 15:46:14 -0700 X86Assembler does not encode byte registers in 64-bit mode correctly. 2011-06-30 14:31:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 fpizlo webkit-unassigned barraclough webkit.review.bot oldest_to_newest 429938 0 fpizlo 2011-06-29 15:46:14 -0700 The JSC 64-bit JITs expect to be able to use any GPR as a byte register in 64-bit mode. But this does not work for sil, dil, spl, or bpl, because the X86Assembler fails to emit a blank REX (a REX with no bits set). 429951 1 99169 fpizlo 2011-06-29 16:05:02 -0700 Created attachment 99169 the patch 429952 2 webkit.review.bot 2011-06-29 16:07:35 -0700 Attachment 99169 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/X86Assembler.h:2005: Missing space inside { }. [whitespace/braces] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 429969 3 99178 fpizlo 2011-06-29 16:33:17 -0700 Created attachment 99178 the patch (fix style) 430052 4 99178 barraclough 2011-06-29 18:06:44 -0700 Comment on attachment 99178 the patch (fix style) r-ing per our discussion. 430207 5 99246 fpizlo 2011-06-29 23:57:16 -0700 Created attachment 99246 the patch (redid as per review) 430680 6 99246 webkit.review.bot 2011-06-30 14:31:09 -0700 Comment on attachment 99246 the patch (redid as per review) Clearing flags on attachment: 99246 Committed r90157: <http://trac.webkit.org/changeset/90157> 430681 7 webkit.review.bot 2011-06-30 14:31:13 -0700 All reviewed patches have been landed. Closing bug. 99169 2011-06-29 16:05:02 -0700 2011-06-29 16:33:17 -0700 the patch bytereg_patch_1.diff text/plain 3107 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTAwNTYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDYtMjkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBYODZBc3NlbWJsZXIgZG9lcyBu b3QgZW5jb2RlIGJ5dGUgcmVnaXN0ZXJzIGluIDY0LWJpdCBtb2RlIGNvcnJlY3RseS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNjY1CisKKyAgICAg ICAgKiBhc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6Olg4NkFzc2VtYmxl cjo6dGVzdGJfcnIpOgorICAgICAgICAoSlNDOjpYODZBc3NlbWJsZXI6OnRlc3RiX2k4cik6Cisg ICAgICAgIChKU0M6Olg4NkFzc2VtYmxlcjo6WDg2SW5zdHJ1Y3Rpb25Gb3JtYXR0ZXI6Om9uZUJ5 dGVPcE5lZWRSZXgpOgorICAgICAgICAoSlNDOjpYODZBc3NlbWJsZXI6Olg4Nkluc3RydWN0aW9u Rm9ybWF0dGVyOjpvbmVCeXRlT3A4TmVlZFJleCk6CisgICAgICAgIChKU0M6Olg4NkFzc2VtYmxl cjo6WDg2SW5zdHJ1Y3Rpb25Gb3JtYXR0ZXI6OmVtaXRSZXgpOgorCiAyMDExLTA2LTI5ICBGaWxp cCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2F2aW4g QmFycmFjbG91Z2guCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFz c2VtYmxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv WDg2QXNzZW1ibGVyLmgJKHJldmlzaW9uIDkwMDU1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtODc5LDcgKzg3OSw3 IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgdGVzdGJfcnIoUmVnaXN0ZXJJRCBzcmMsIFJlZ2lzdGVy SUQgZHN0KQogICAgIHsKLSAgICAgICAgbV9mb3JtYXR0ZXIub25lQnl0ZU9wKE9QX1RFU1RfRWJH Yiwgc3JjLCBkc3QpOworICAgICAgICBtX2Zvcm1hdHRlci5vbmVCeXRlT3BOZWVkUmV4KE9QX1RF U1RfRWJHYiwgc3JjLCBkc3QpOwogICAgIH0KIAogICAgIHZvaWQgdGVzdGJfaW0oaW50IGltbSwg aW50IG9mZnNldCwgUmVnaXN0ZXJJRCBiYXNlKQpAQCAtOTMzLDcgKzkzMyw3IEBAIHB1YmxpYzoK ICAgICAKICAgICB2b2lkIHRlc3RiX2k4cihpbnQgaW1tLCBSZWdpc3RlcklEIGRzdCkKICAgICB7 Ci0gICAgICAgIG1fZm9ybWF0dGVyLm9uZUJ5dGVPcDgoT1BfR1JPVVAzX0ViSWIsIEdST1VQM19P UF9URVNULCBkc3QpOworICAgICAgICBtX2Zvcm1hdHRlci5vbmVCeXRlT3A4TmVlZFJleChPUF9H Uk9VUDNfRWJJYiwgR1JPVVAzX09QX1RFU1QsIGRzdCk7CiAgICAgICAgIG1fZm9ybWF0dGVyLmlt bWVkaWF0ZTgoaW1tKTsKICAgICB9CiAKQEAgLTE2NzksNiArMTY3OSwxNCBAQCBwcml2YXRlOgog ICAgICAgICAgICAgcmVnaXN0ZXJNb2RSTShyZWcsIHJtKTsKICAgICAgICAgfQogCisgICAgICAg IHZvaWQgb25lQnl0ZU9wTmVlZFJleChPbmVCeXRlT3Bjb2RlSUQgb3Bjb2RlLCBpbnQgcmVnLCBS ZWdpc3RlcklEIHJtKQorICAgICAgICB7CisgICAgICAgICAgICBtX2J1ZmZlci5lbnN1cmVTcGFj ZShtYXhJbnN0cnVjdGlvblNpemUpOworICAgICAgICAgICAgZW1pdFJleChmYWxzZSwgcmVnLCAw LCBybSk7CisgICAgICAgICAgICBtX2J1ZmZlci5wdXRCeXRlVW5jaGVja2VkKG9wY29kZSk7Cisg ICAgICAgICAgICByZWdpc3Rlck1vZFJNKHJlZywgcm0pOworICAgICAgICB9CisKICAgICAgICAg dm9pZCBvbmVCeXRlT3AoT25lQnl0ZU9wY29kZUlEIG9wY29kZSwgaW50IHJlZywgUmVnaXN0ZXJJ RCBiYXNlLCBpbnQgb2Zmc2V0KQogICAgICAgICB7CiAgICAgICAgICAgICBtX2J1ZmZlci5lbnN1 cmVTcGFjZShtYXhJbnN0cnVjdGlvblNpemUpOwpAQCAtMTg2OCw2ICsxODc2LDE0IEBAIHByaXZh dGU6CiAgICAgICAgICAgICByZWdpc3Rlck1vZFJNKGdyb3VwT3AsIHJtKTsKICAgICAgICAgfQog CisgICAgICAgIHZvaWQgb25lQnl0ZU9wOE5lZWRSZXgoT25lQnl0ZU9wY29kZUlEIG9wY29kZSwg R3JvdXBPcGNvZGVJRCBncm91cE9wLCBSZWdpc3RlcklEIHJtKQorICAgICAgICB7CisgICAgICAg ICAgICBtX2J1ZmZlci5lbnN1cmVTcGFjZShtYXhJbnN0cnVjdGlvblNpemUpOworICAgICAgICAg ICAgZW1pdFJleChmYWxzZSwgMCwgMCwgcm0pOworICAgICAgICAgICAgbV9idWZmZXIucHV0Qnl0 ZVVuY2hlY2tlZChvcGNvZGUpOworICAgICAgICAgICAgcmVnaXN0ZXJNb2RSTShncm91cE9wLCBy bSk7CisgICAgICAgIH0KKwogICAgICAgICB2b2lkIHR3b0J5dGVPcDgoVHdvQnl0ZU9wY29kZUlE IG9wY29kZSwgUmVnaXN0ZXJJRCByZWcsIFJlZ2lzdGVySUQgcm0pCiAgICAgICAgIHsKICAgICAg ICAgICAgIG1fYnVmZmVyLmVuc3VyZVNwYWNlKG1heEluc3RydWN0aW9uU2l6ZSk7CkBAIC0xOTg2 LDYgKzIwMDIsNyBAQCBwcml2YXRlOgogICAgICAgICAvLyBObyBSRVggcHJlZml4IGJ5dGVzIG9u IDMyLWJpdCB4ODYuCiAgICAgICAgIGlubGluZSBib29sIHJlZ1JlcXVpcmVzUmV4KGludCkgeyBy ZXR1cm4gZmFsc2U7IH0KICAgICAgICAgaW5saW5lIGJvb2wgYnl0ZVJlZ1JlcXVpcmVzUmV4KGlu dCkgeyByZXR1cm4gZmFsc2U7IH0KKyAgICAgICAgaW5saW5lIHZvaWQgZW1pdFJleChib29sIHcs IGludCByLCBpbnQgeCwgaW50IGIpIHt9CiAgICAgICAgIGlubGluZSB2b2lkIGVtaXRSZXhJZihi b29sLCBpbnQsIGludCwgaW50KSB7fQogICAgICAgICBpbmxpbmUgdm9pZCBlbWl0UmV4SWZOZWVk ZWQoaW50LCBpbnQsIGludCkge30KICNlbmRpZgo= 99178 2011-06-29 16:33:17 -0700 2011-06-29 23:57:16 -0700 the patch (fix style) bytereg_patch_2.diff text/plain 3108 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTAwNTYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDYtMjkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBYODZBc3NlbWJsZXIgZG9lcyBu b3QgZW5jb2RlIGJ5dGUgcmVnaXN0ZXJzIGluIDY0LWJpdCBtb2RlIGNvcnJlY3RseS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNjY1CisKKyAgICAg ICAgKiBhc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6Olg4NkFzc2VtYmxl cjo6dGVzdGJfcnIpOgorICAgICAgICAoSlNDOjpYODZBc3NlbWJsZXI6OnRlc3RiX2k4cik6Cisg ICAgICAgIChKU0M6Olg4NkFzc2VtYmxlcjo6WDg2SW5zdHJ1Y3Rpb25Gb3JtYXR0ZXI6Om9uZUJ5 dGVPcE5lZWRSZXgpOgorICAgICAgICAoSlNDOjpYODZBc3NlbWJsZXI6Olg4Nkluc3RydWN0aW9u Rm9ybWF0dGVyOjpvbmVCeXRlT3A4TmVlZFJleCk6CisgICAgICAgIChKU0M6Olg4NkFzc2VtYmxl cjo6WDg2SW5zdHJ1Y3Rpb25Gb3JtYXR0ZXI6OmVtaXRSZXgpOgorCiAyMDExLTA2LTI5ICBGaWxp cCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2F2aW4g QmFycmFjbG91Z2guCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFz c2VtYmxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv WDg2QXNzZW1ibGVyLmgJKHJldmlzaW9uIDkwMDU1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtODc5LDcgKzg3OSw3 IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgdGVzdGJfcnIoUmVnaXN0ZXJJRCBzcmMsIFJlZ2lzdGVy SUQgZHN0KQogICAgIHsKLSAgICAgICAgbV9mb3JtYXR0ZXIub25lQnl0ZU9wKE9QX1RFU1RfRWJH Yiwgc3JjLCBkc3QpOworICAgICAgICBtX2Zvcm1hdHRlci5vbmVCeXRlT3BOZWVkUmV4KE9QX1RF U1RfRWJHYiwgc3JjLCBkc3QpOwogICAgIH0KIAogICAgIHZvaWQgdGVzdGJfaW0oaW50IGltbSwg aW50IG9mZnNldCwgUmVnaXN0ZXJJRCBiYXNlKQpAQCAtOTMzLDcgKzkzMyw3IEBAIHB1YmxpYzoK ICAgICAKICAgICB2b2lkIHRlc3RiX2k4cihpbnQgaW1tLCBSZWdpc3RlcklEIGRzdCkKICAgICB7 Ci0gICAgICAgIG1fZm9ybWF0dGVyLm9uZUJ5dGVPcDgoT1BfR1JPVVAzX0ViSWIsIEdST1VQM19P UF9URVNULCBkc3QpOworICAgICAgICBtX2Zvcm1hdHRlci5vbmVCeXRlT3A4TmVlZFJleChPUF9H Uk9VUDNfRWJJYiwgR1JPVVAzX09QX1RFU1QsIGRzdCk7CiAgICAgICAgIG1fZm9ybWF0dGVyLmlt bWVkaWF0ZTgoaW1tKTsKICAgICB9CiAKQEAgLTE2NzksNiArMTY3OSwxNCBAQCBwcml2YXRlOgog ICAgICAgICAgICAgcmVnaXN0ZXJNb2RSTShyZWcsIHJtKTsKICAgICAgICAgfQogCisgICAgICAg IHZvaWQgb25lQnl0ZU9wTmVlZFJleChPbmVCeXRlT3Bjb2RlSUQgb3Bjb2RlLCBpbnQgcmVnLCBS ZWdpc3RlcklEIHJtKQorICAgICAgICB7CisgICAgICAgICAgICBtX2J1ZmZlci5lbnN1cmVTcGFj ZShtYXhJbnN0cnVjdGlvblNpemUpOworICAgICAgICAgICAgZW1pdFJleChmYWxzZSwgcmVnLCAw LCBybSk7CisgICAgICAgICAgICBtX2J1ZmZlci5wdXRCeXRlVW5jaGVja2VkKG9wY29kZSk7Cisg ICAgICAgICAgICByZWdpc3Rlck1vZFJNKHJlZywgcm0pOworICAgICAgICB9CisKICAgICAgICAg dm9pZCBvbmVCeXRlT3AoT25lQnl0ZU9wY29kZUlEIG9wY29kZSwgaW50IHJlZywgUmVnaXN0ZXJJ RCBiYXNlLCBpbnQgb2Zmc2V0KQogICAgICAgICB7CiAgICAgICAgICAgICBtX2J1ZmZlci5lbnN1 cmVTcGFjZShtYXhJbnN0cnVjdGlvblNpemUpOwpAQCAtMTg2OCw2ICsxODc2LDE0IEBAIHByaXZh dGU6CiAgICAgICAgICAgICByZWdpc3Rlck1vZFJNKGdyb3VwT3AsIHJtKTsKICAgICAgICAgfQog CisgICAgICAgIHZvaWQgb25lQnl0ZU9wOE5lZWRSZXgoT25lQnl0ZU9wY29kZUlEIG9wY29kZSwg R3JvdXBPcGNvZGVJRCBncm91cE9wLCBSZWdpc3RlcklEIHJtKQorICAgICAgICB7CisgICAgICAg ICAgICBtX2J1ZmZlci5lbnN1cmVTcGFjZShtYXhJbnN0cnVjdGlvblNpemUpOworICAgICAgICAg ICAgZW1pdFJleChmYWxzZSwgMCwgMCwgcm0pOworICAgICAgICAgICAgbV9idWZmZXIucHV0Qnl0 ZVVuY2hlY2tlZChvcGNvZGUpOworICAgICAgICAgICAgcmVnaXN0ZXJNb2RSTShncm91cE9wLCBy bSk7CisgICAgICAgIH0KKwogICAgICAgICB2b2lkIHR3b0J5dGVPcDgoVHdvQnl0ZU9wY29kZUlE IG9wY29kZSwgUmVnaXN0ZXJJRCByZWcsIFJlZ2lzdGVySUQgcm0pCiAgICAgICAgIHsKICAgICAg ICAgICAgIG1fYnVmZmVyLmVuc3VyZVNwYWNlKG1heEluc3RydWN0aW9uU2l6ZSk7CkBAIC0xOTg2 LDYgKzIwMDIsNyBAQCBwcml2YXRlOgogICAgICAgICAvLyBObyBSRVggcHJlZml4IGJ5dGVzIG9u IDMyLWJpdCB4ODYuCiAgICAgICAgIGlubGluZSBib29sIHJlZ1JlcXVpcmVzUmV4KGludCkgeyBy ZXR1cm4gZmFsc2U7IH0KICAgICAgICAgaW5saW5lIGJvb2wgYnl0ZVJlZ1JlcXVpcmVzUmV4KGlu dCkgeyByZXR1cm4gZmFsc2U7IH0KKyAgICAgICAgaW5saW5lIHZvaWQgZW1pdFJleChib29sIHcs IGludCByLCBpbnQgeCwgaW50IGIpIHsgfQogICAgICAgICBpbmxpbmUgdm9pZCBlbWl0UmV4SWYo Ym9vbCwgaW50LCBpbnQsIGludCkge30KICAgICAgICAgaW5saW5lIHZvaWQgZW1pdFJleElmTmVl ZGVkKGludCwgaW50LCBpbnQpIHt9CiAjZW5kaWYK 99246 2011-06-29 23:57:16 -0700 2011-06-30 14:31:09 -0700 the patch (redid as per review) bytereg_patch_3.diff text/plain 1762 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTAwODgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDYtMjkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBYODZBc3NlbWJsZXIgZG9lcyBu b3QgZW5jb2RlIGJ5dGUgcmVnaXN0ZXJzIGluIDY0LWJpdCBtb2RlIGNvcnJlY3RseS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNjY1CisKKyAgICAg ICAgKiBhc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6Olg4NkFzc2VtYmxl cjo6dGVzdGJfcnIpOgorICAgICAgICAoSlNDOjpYODZBc3NlbWJsZXI6Olg4Nkluc3RydWN0aW9u Rm9ybWF0dGVyOjpvbmVCeXRlT3A4KToKKwogMjAxMS0wNi0yOSAgRmlsaXAgUGl6bG8gIDxmcGl6 bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5o CShyZXZpc2lvbiA5MDA4OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvWDg2 QXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTg3OSw3ICs4NzksNyBAQCBwdWJsaWM6CiAK ICAgICB2b2lkIHRlc3RiX3JyKFJlZ2lzdGVySUQgc3JjLCBSZWdpc3RlcklEIGRzdCkKICAgICB7 Ci0gICAgICAgIG1fZm9ybWF0dGVyLm9uZUJ5dGVPcChPUF9URVNUX0ViR2IsIHNyYywgZHN0KTsK KyAgICAgICAgbV9mb3JtYXR0ZXIub25lQnl0ZU9wOChPUF9URVNUX0ViR2IsIHNyYywgZHN0KTsK ICAgICB9CiAKICAgICB2b2lkIHRlc3RiX2ltKGludCBpbW0sIGludCBvZmZzZXQsIFJlZ2lzdGVy SUQgYmFzZSkKQEAgLTE4NjgsNiArMTg2OCwxNCBAQCBwcml2YXRlOgogICAgICAgICAgICAgcmVn aXN0ZXJNb2RSTShncm91cE9wLCBybSk7CiAgICAgICAgIH0KIAorICAgICAgICB2b2lkIG9uZUJ5 dGVPcDgoT25lQnl0ZU9wY29kZUlEIG9wY29kZSwgaW50IHJlZywgUmVnaXN0ZXJJRCBybSkKKyAg ICAgICAgeworICAgICAgICAgICAgbV9idWZmZXIuZW5zdXJlU3BhY2UobWF4SW5zdHJ1Y3Rpb25T aXplKTsKKyAgICAgICAgICAgIGVtaXRSZXhJZihieXRlUmVnUmVxdWlyZXNSZXgocmVnKSB8fCBi eXRlUmVnUmVxdWlyZXNSZXgocm0pLCByZWcsIDAsIHJtKTsKKyAgICAgICAgICAgIG1fYnVmZmVy LnB1dEJ5dGVVbmNoZWNrZWQob3Bjb2RlKTsKKyAgICAgICAgICAgIHJlZ2lzdGVyTW9kUk0ocmVn LCBybSk7CisgICAgICAgIH0KKwogICAgICAgICB2b2lkIHR3b0J5dGVPcDgoVHdvQnl0ZU9wY29k ZUlEIG9wY29kZSwgUmVnaXN0ZXJJRCByZWcsIFJlZ2lzdGVySUQgcm0pCiAgICAgICAgIHsKICAg ICAgICAgICAgIG1fYnVmZmVyLmVuc3VyZVNwYWNlKG1heEluc3RydWN0aW9uU2l6ZSk7Cg==