63660 2011-06-29 14:31:26 -0700 Only enable TestWebKitAPI on bots on win and mac-snowleopard 2011-06-30 06:00:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dslomov webkit-unassigned aroben dslomov levin webkit.review.bot oldest_to_newest 429888 0 dslomov 2011-06-29 14:31:26 -0700 WebKit2 does not support Leopard 429893 1 99153 dslomov 2011-06-29 14:39:46 -0700 Created attachment 99153 The fix 429899 2 99153 aroben 2011-06-29 14:44:25 -0700 Comment on attachment 99153 The fix View in context: https://bugs.webkit.org/attachment.cgi?id=99153&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:539 > + if configuration == "debug" and (platform == 'mac-snowleopard' or platform == 'win'): It would be nice if we didn't have to change this line of code once we have a mac-lion bot. The mixture of single- and double-quotes here is strange. I'd write the second part as: platform in ('mac-snowleopard, 'win') > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:562 > + if configuration == "debug" and (platform == 'mac-snowleopard' or platform == 'win'): Same comments as above. 430007 3 99185 dslomov 2011-06-29 17:05:57 -0700 Created attachment 99185 CR feedback 430337 4 99185 webkit.review.bot 2011-06-30 05:55:51 -0700 Comment on attachment 99185 CR feedback Clearing flags on attachment: 99185 Committed r90108: <http://trac.webkit.org/changeset/90108> 430338 5 webkit.review.bot 2011-06-30 05:55:56 -0700 All reviewed patches have been landed. Closing bug. 430340 6 aroben 2011-06-30 06:00:46 -0700 Buildbot master restarted. 99153 2011-06-29 14:39:46 -0700 2011-06-29 17:05:57 -0700 The fix 63660.patch text/plain 1909 dslomov ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDU1ZTc5NmMuLjEwNDNlNjMgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtNTM1LDYgKzUzNSw5IEBAIGNsYXNzIFRlc3RGYWN0b3J5KEZhY3RvcnkpOgog ICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuSmF2YVNjcmlwdENvcmVUZXN0cywgYnVpbGRKU0NUb29s PUZhbHNlKQogICAgICAgICBzZWxmLmFkZFN0ZXAoc2VsZi5UZXN0Q2xhc3MsIGJ1aWxkSlNDVG9v bD0ocGxhdGZvcm0gIT0gJ3dpbicpKQogCisgICAgICAgICMgRklYTUU6IE9ubHkgcnVubmluZyBp biBkZWJ1ZyBtb2RlIGR1ZSB0byBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjE4MTIKKyAgICAgICAgaWYgY29uZmlndXJhdGlvbiA9PSAiZGVidWciIGFuZCAocGxhdGZv cm0gPT0gJ21hYy1zbm93bGVvcGFyZCcgb3IgcGxhdGZvcm0gPT0gJ3dpbicpOgorICAgICAgICAg ICAgc2VsZi5hZGRTdGVwKFJ1blVuaXRUZXN0cykKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1blB5 dGhvblRlc3RzKQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuUGVybFRlc3RzKQogICAgICAgICBz ZWxmLmFkZFN0ZXAoUnVuQmluZGluZ3NUZXN0cykKQEAgLTU1Niw3ICs1NTksNyBAQCBjbGFzcyBC dWlsZEFuZFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1 bkNocm9taXVtV2ViS2l0VW5pdFRlc3RzKQogICAgICAgICBzZWxmLmFkZFN0ZXAoc2VsZi5UZXN0 Q2xhc3MpCiAgICAgICAgICMgRklYTUU6IE9ubHkgcnVubmluZyBpbiBkZWJ1ZyBtb2RlIGR1ZSB0 byBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE4MTIKLSAgICAgICAg aWYgY29uZmlndXJhdGlvbiA9PSAiZGVidWciIGFuZCAocGxhdGZvcm0gPT0gJ21hYycgb3IgcGxh dGZvcm0gPT0gJ3dpbicpOgorICAgICAgICBpZiBjb25maWd1cmF0aW9uID09ICJkZWJ1ZyIgYW5k IChwbGF0Zm9ybSA9PSAnbWFjLXNub3dsZW9wYXJkJyBvciBwbGF0Zm9ybSA9PSAnd2luJyk6CiAg ICAgICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuVW5pdFRlc3RzKQogICAgICAgICBzZWxmLmFkZFN0 ZXAoUnVuUHl0aG9uVGVzdHMpCiAgICAgICAgICMgQ2hyb21pdW0gV2luIHJ1bnMgaW4gbm9uLUN5 Z3dpbiBlbnZpcm9ubWVudCwgd2hpY2ggaXMgbm90IHlldCBmaXQKZGlmZiAtLWdpdCBhL1Rvb2xz L0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3NmE1NDRlLi45MjRhMjM2IDEwMDY0 NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTIgQEAKKzIwMTEtMDYtMjkgIERtaXRyeSBMb21vdiAgPGRzbG9tb3ZAZ29vZ2xlLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM2NjAKKyAgICAgICAgVGhpcyBlbmFibGVz IHVuaXQtdGVzdHMgc3RlcCBvbiBXaW5kb3dzIGFuZCBNYWNPUyBTbm93TGVvcGFyZC4KKworICAg ICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5j Zmc6CisKIDIwMTEtMDYtMjkgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCg== 99185 2011-06-29 17:05:57 -0700 2011-06-30 05:55:51 -0700 CR feedback 63660.patch text/plain 2330 dslomov ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IGM0YjUxZjAuLmRkMjU3NmEgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtNTIyLDYgKzUyMiwxMCBAQCBjbGFzcyBCdWlsZEZhY3RvcnkoRmFjdG9yeSk6 CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoVXBsb2FkQnVpbHRQcm9kdWN0KQogICAgICAgICAg ICAgc2VsZi5hZGRTdGVwKHRyaWdnZXIuVHJpZ2dlciwgc2NoZWR1bGVyTmFtZXM9dHJpZ2dlcnMp CiAKK2RlZiB1bml0VGVzdHNTdXBwb3J0ZWQoY29uZmlndXJhdGlvbiwgcGxhdGZvcm0pOgorICAg ICMgRklYTUU6IE9ubHkgcnVubmluZyBpbiBkZWJ1ZyBtb2RlIGR1ZSB0byBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE4MTIKKyAgICByZXR1cm4gY29uZmlndXJhdGlv biA9PSAnZGVidWcnIGFuZCAocGxhdGZvcm0gPT0gJ3dpbicgb3IgKHBsYXRmb3JtLnN0YXJ0c3dp dGgoJ21hYycpIGFuZCBwbGF0Zm9ybSAhPSAnbWFjLWxlb3BhcmQnKSkKKwogY2xhc3MgVGVzdEZh Y3RvcnkoRmFjdG9yeSk6CiAgICAgVGVzdENsYXNzID0gUnVuV2ViS2l0VGVzdHMKICAgICBFeHRy YWN0VGVzdFJlc3VsdHNDbGFzcyA9IEV4dHJhY3RUZXN0UmVzdWx0cwpAQCAtNTM2LDYgKzU0MCw4 IEBAIGNsYXNzIFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVu SmF2YVNjcmlwdENvcmVUZXN0cywgYnVpbGRKU0NUb29sPUZhbHNlKQogICAgICAgICBzZWxmLmFk ZFN0ZXAoc2VsZi5UZXN0Q2xhc3MsIGJ1aWxkSlNDVG9vbD0ocGxhdGZvcm0gIT0gJ3dpbicpKQog CisgICAgICAgIGlmIHVuaXRUZXN0c1N1cHBvcnRlZChjb25maWd1cmF0aW9uLCBwbGF0Zm9ybSk6 IAorICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1blVuaXRUZXN0cykKICAgICAgICAgc2VsZi5h ZGRTdGVwKFJ1blB5dGhvblRlc3RzKQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuUGVybFRlc3Rz KQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuQmluZGluZ3NUZXN0cykKQEAgLTU1Niw4ICs1NjIs NyBAQCBjbGFzcyBCdWlsZEFuZFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgICAgICBpZiBwbGF0 Zm9ybS5zdGFydHN3aXRoKCJjaHJvbWl1bSIpOgogICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1 bkNocm9taXVtV2ViS2l0VW5pdFRlc3RzKQogICAgICAgICBzZWxmLmFkZFN0ZXAoc2VsZi5UZXN0 Q2xhc3MpCi0gICAgICAgICMgRklYTUU6IE9ubHkgcnVubmluZyBpbiBkZWJ1ZyBtb2RlIGR1ZSB0 byBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE4MTIKLSAgICAgICAg aWYgY29uZmlndXJhdGlvbiA9PSAiZGVidWciIGFuZCAocGxhdGZvcm0gPT0gJ21hYycgb3IgcGxh dGZvcm0gPT0gJ3dpbicpOgorICAgICAgICBpZiB1bml0VGVzdHNTdXBwb3J0ZWQoY29uZmlndXJh dGlvbiwgcGxhdGZvcm0pOiAKICAgICAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5Vbml0VGVzdHMp CiAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5QeXRob25UZXN0cykKICAgICAgICAgIyBDaHJvbWl1 bSBXaW4gcnVucyBpbiBub24tQ3lnd2luIGVudmlyb25tZW50LCB3aGljaCBpcyBub3QgeWV0IGZp dApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGRm MDc2NWEuLmNhYTdkY2QgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0wNi0yOSAgRG1pdHJ5IExvbW92ICA8ZHNs b21vdkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzY2MAor ICAgICAgICBUaGlzIGVuYWJsZXMgdW5pdC10ZXN0cyBzdGVwIG9uIFdpbmRvd3MgYW5kIE1hY09T IFNub3dMZW9wYXJkLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKwogMjAxMS0wNi0yOSAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpcmsgUHJhbmtlLgo=