63642 2011-06-29 12:11:22 -0700 [Qt] Visual Studio 2010 compiler warning about TR1 support in JavascriptCore 2012-02-10 08:32:33 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P3 Normal --- 0 arosenberg webkit-unassigned bfulgham menard net147 noam robt_0 webkit.review.bot oldest_to_newest 429772 0 99123 arosenberg 2011-06-29 12:11:22 -0700 Created attachment 99123 patch to fix tr1 warning for VS2010 When building qtwebkit-2.2 branch with Visual Studio 2010, there is a warning about _HAS_TR1 being redefined. VS 2010 fully supports TR1 so the override of the define in the JavascriptCore pri file is not needed. Attached is a patch which fixes this. 440482 1 robt_0 2011-07-21 10:41:40 -0700 Same thing here. It's a really easy fix to make (7 characters), and it would be nice to get rid of all of the compiler warnings. 440537 2 noam 2011-07-21 11:50:13 -0700 Is this patch for a review? 440551 3 arosenberg 2011-07-21 11:59:17 -0700 yes, the patch should be for review 440560 4 99123 noam 2011-07-21 12:07:21 -0700 Comment on attachment 99123 patch to fix tr1 warning for VS2010 What about mingw? Shouldn't this be -win32-*:!win32-msvc2010: 440563 5 arosenberg 2011-07-21 12:11:38 -0700 I don't have a mingw setup, so I can't answer this, but win32-icc behaves the same as msvc2010. 440613 6 robt_0 2011-07-21 13:18:04 -0700 As far as I can tell, we can just delete that line and it should have no effect on any compiler. The only file that I can find using TR1 is wtf/TypeTraits.h, and lines 27 & 182 already have: #if (defined(__GLIBCXX__) && (__GLIBCXX__ >= 20070724) && defined(__GXX_EXPERIMENTAL_CXX0X__)) || (defined(_MSC_VER) && (_MSC_VER >= 1600)) Aron's ICC compiler shouldn't even be using the TR1 commands anyway. Also, if mingw doesn't have a gcc version with the cxx0x defined, then it doesn't use that code either. 441456 7 99123 noam 2011-07-24 09:22:54 -0700 Comment on attachment 99123 patch to fix tr1 warning for VS2010 OK, those multiple Windows configs are hard to test. But if it breaks a bot, prepare for a rollout :) 473982 8 robt_0 2011-09-27 09:30:06 -0700 (In reply to comment #7) > (From update of attachment 99123 [details]) > OK, those multiple Windows configs are hard to test. But if it breaks a bot, prepare for a rollout :) The only two compilers that _HAS_TR1 even affects are VS2008 with the feature pack installed and VS2010. It looks like at one time that they wanted to block VS2008 with the feature pack and someone added _HAS_TR1 = 0, but someone else accomplished the same thing by putting in _MSC_VER >= 1600 around the TR1 commands. The VS2008 implementation of TR1 is not fully conforming, so I'm assuming that's why it is avoided. Basically, we have two fixes for the problem in place, with one causing an enormous amount of obnoxious warnings (and downgrading the VS2010 compiler). gcc, icc, etc. will not be affected since _HAS_TR1 doesn't even do anything. Someone should just delete that line, or at least implement this patch, already. 503241 9 bfulgham 2011-11-15 14:03:09 -0800 Note that since VS2010 now support nullptr_t, the JavaScriptCore.def declaration for ?nullptr@@3Vnullptr_t@std@@A must be removed. 525704 10 99123 eric 2011-12-21 15:20:38 -0800 Comment on attachment 99123 patch to fix tr1 warning for VS2010 All changes require a Changelog. Sorry that's going to be so many more lines than thsi change. :) 535866 11 122476 arosenberg 2012-01-13 11:53:26 -0800 Created attachment 122476 Remove TR1 define Added changelog entry and changed patch to remove the define based on the bug feedback 536656 12 122476 menard 2012-01-16 10:33:36 -0800 Comment on attachment 122476 Remove TR1 define Well it will most likely break older version of Visual Studio no? 536658 13 arosenberg 2012-01-16 10:35:38 -0800 (In reply to comment #12) > (From update of attachment 122476 [details]) > Well it will most likely break older version of Visual Studio no? See comment #8, the effected code has already been properly ifdef with _MSC_VER checks. The define in the qt file is not needed (and not done in the non-Qt builds anyway). 554064 14 122476 hausmann 2012-02-10 07:07:45 -0800 Comment on attachment 122476 Remove TR1 define Ok, I trust you on this one :) 554088 15 122476 webkit.review.bot 2012-02-10 08:32:28 -0800 Comment on attachment 122476 Remove TR1 define Clearing flags on attachment: 122476 Committed r107404: <http://trac.webkit.org/changeset/107404> 554089 16 webkit.review.bot 2012-02-10 08:32:33 -0800 All reviewed patches have been landed. Closing bug. 99123 2011-06-29 12:11:22 -0700 2012-01-13 11:53:26 -0800 patch to fix tr1 warning for VS2010 fix_tr1_warning.diff text/plain 434 arosenberg ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpDQppbmRleCBmNmQwNjRmLi5i YmVjNGMyIDEwMDY0NA0KLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3Jl LnByaQ0KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQ0KQEAg LTUzLDcgKzUzLDcgQEAgc3ltYmlhbiB7DQogICAgIElOQ0xVREVQQVRIICo9ICQkTVdfTEFZRVJf U1lTVEVNSU5DTFVERQ0KIH0NCiANCi13aW4zMi0qOiBERUZJTkVTICs9IF9IQVNfVFIxPTANCit3 aW4zMi1tc3ZjMjAwKjogREVGSU5FUyArPSBfSEFTX1RSMT0wDQogDQogREVGSU5FUyArPSBCVUlM RElOR19KYXZhU2NyaXB0Q29yZSBCVUlMRElOR19XVEYNCiA= 122476 2012-01-13 11:53:26 -0800 2012-02-10 08:32:28 -0800 Remove TR1 define remove_tr1.diff text/plain 999 arosenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAocmV2aXNpb24gMTA0OTYxKQ0KKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICh3b3JraW5nIGNvcHkpDQpAQCAt MSwzICsxLDEyIEBADQorMjAxMi0wMS0xMyAgQXJvbiBSb3NlbmJlcmcgIDxhcm9zZW5iZXJnQGxv Z2l0ZWNoLmNvbT4NCisNCisgICAgICAgIFtRdF0gRml4IGNvbXBpbGVyIHdhcm5pbmcgaW4gVmlz dWFsIFN0dWRpbyAyMDEwIGFib3V0IFRSMQ0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYzNjQyDQorDQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4NCisNCisgICAgICAgICogSmF2YVNjcmlwdENvcmUucHJpOg0KKw0KIDIwMTItMDEt MTMgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPg0KDQogICAgICAgICBIV25kREMg aXMgYSBiZXR0ZXIgbmFtZSB0aGFuIEh3bmREQy4NCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvSmF2YVNjcmlwdENvcmUucHJpDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL0phdmFTY3JpcHRDb3JlLnByaSAgICAocmV2aXNpb24gMTA0OTUzKQ0KKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkgICAgKHdvcmtpbmcgY29weSkNCkBAIC0y OSw3ICsyOSw2IEBADQogICAgICQkSkFWQVNDUklQVENPUkVfR0VORVJBVEVEX1NPVVJDRVNfRElS DQoNCiB3aW4zMi0qIHsNCi0gICAgREVGSU5FUyArPSBfSEFTX1RSMT0wDQogICAgIExJQlMgKz0g LWx3aW5tbQ0KDQogICAgIHdpbjMyLWcrKyogew0K