63630 2011-06-29 07:55:19 -0700 [Qt][WK2] Implement the rest of WTR::PlatformWebView 2011-07-10 11:05:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified All RESOLVED FIXED P3 Normal --- 1 kbalazs kbalazs benjamin webkit.review.bot oldest_to_newest 429605 0 kbalazs 2011-06-29 07:55:19 -0700 Namely windowFrame and setWindowFrame. I don't know which tests using these and which ones can be fixed by implementing them. However it's not a big deal and we can unskip passing tests in the future. 429606 1 99090 kbalazs 2011-06-29 08:00:01 -0700 Created attachment 99090 Patch 429660 2 99090 kenneth 2011-06-29 09:16:02 -0700 Comment on attachment 99090 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99090&action=review > Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp:100 > +void PlatformWebView::setWindowFrame(WKRect wkRect) why not jsut call that rect. This wk prefix doesnt serve anything 430222 3 kbalazs 2011-06-30 00:37:29 -0700 (In reply to comment #2) > (From update of attachment 99090 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=99090&action=review > > > Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp:100 > > +void PlatformWebView::setWindowFrame(WKRect wkRect) > > why not jsut call that rect. This wk prefix doesnt serve anything Okeydokey. 430235 4 kbalazs 2011-06-30 01:00:51 -0700 Committed r90095: <http://trac.webkit.org/changeset/90095> 434574 5 benjamin 2011-07-10 10:16:38 -0700 Reopening, this was reverted by accident. 434575 6 100230 benjamin 2011-07-10 10:24:29 -0700 Created attachment 100230 Patch 434576 7 100230 benjamin 2011-07-10 10:25:04 -0700 Comment on attachment 100230 Patch Updating was taking forever, let's use the commit bot :) 434578 8 benjamin 2011-07-10 11:05:33 -0700 Committed r90693: <http://trac.webkit.org/changeset/90693> 99090 2011-06-29 08:00:01 -0700 2011-07-10 10:24:22 -0700 Patch bug-63630-20110629145959.patch text/plain 1744 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogODk5MDAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmNThmMDBlMzdjN2VmNGQ4MGY3MTY2YjQxNjczMjZjODIz YmQzODYzLi4yZGU1M2QzYWNlM2E5OGExNWQyMjgwNmY2ZDAzNjI2MjkyNGY0MjBkIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDYtMjkgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bV0syXSBJ bXBsZW1lbnQgdGhlIHJlc3Qgb2YgV1RSOjpQbGF0Zm9ybVdlYlZpZXcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNjMwCisKKyAgICAgICAgKiBXZWJL aXRUZXN0UnVubmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcDoKKyAgICAgICAgKFdUUjo6UGxh dGZvcm1XZWJWaWV3Ojp3aW5kb3dGcmFtZSk6CisgICAgICAgIChXVFI6OlBsYXRmb3JtV2ViVmll dzo6c2V0V2luZG93RnJhbWUpOgorCiAyMDExLTA2LTI3ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQg YS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcCBiL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwCmluZGV4IDZkNmYyNjJh YmZhYmJlZTFhMDU1ODQzN2ExMTg5OWY3MmFmNjljZjEuLmQ5YzRhZTk1ZDcxOTg0NjhmYTJiY2Yx ZDk3ZDAzODk3NTkzMDgxYTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQv UGxhdGZvcm1XZWJWaWV3UXQuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvUGxh dGZvcm1XZWJWaWV3UXQuY3BwCkBAIC04OCwxOSArODgsMTggQEAgdm9pZCBQbGF0Zm9ybVdlYlZp ZXc6OmZvY3VzKCkKIAogV0tSZWN0IFBsYXRmb3JtV2ViVmlldzo6d2luZG93RnJhbWUoKQogewot ICAgIC8vIEltcGxlbWVudC4KLQorICAgIFFSZWN0IHdpbmRvd1JlY3QgPSBtX3dpbmRvdy0+Z2Vv bWV0cnkoKTsKICAgICBXS1JlY3Qgd2tGcmFtZTsKLSAgICB3a0ZyYW1lLm9yaWdpbi54ID0gMDsK LSAgICB3a0ZyYW1lLm9yaWdpbi55ID0gMDsKLSAgICB3a0ZyYW1lLnNpemUud2lkdGggPSAwOwot ICAgIHdrRnJhbWUuc2l6ZS5oZWlnaHQgPSAwOworICAgIHdrRnJhbWUub3JpZ2luLnggPSB3aW5k b3dSZWN0LngoKTsKKyAgICB3a0ZyYW1lLm9yaWdpbi55ID0gd2luZG93UmVjdC55KCk7CisgICAg d2tGcmFtZS5zaXplLndpZHRoID0gd2luZG93UmVjdC5zaXplKCkud2lkdGgoKTsKKyAgICB3a0Zy YW1lLnNpemUuaGVpZ2h0ID0gd2luZG93UmVjdC5zaXplKCkuaGVpZ2h0KCk7CiAgICAgcmV0dXJu IHdrRnJhbWU7CiB9CiAKLXZvaWQgUGxhdGZvcm1XZWJWaWV3OjpzZXRXaW5kb3dGcmFtZShXS1Jl Y3QpCit2b2lkIFBsYXRmb3JtV2ViVmlldzo6c2V0V2luZG93RnJhbWUoV0tSZWN0IHdrUmVjdCkK IHsKLSAgICAvLyBJbXBsZW1lbnQuCisgICAgbV93aW5kb3ctPnNldEdlb21ldHJ5KHdrUmVjdC5v cmlnaW4ueCwgd2tSZWN0Lm9yaWdpbi55LCB3a1JlY3Quc2l6ZS53aWR0aCwgd2tSZWN0LnNpemUu aGVpZ2h0KTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV1RSCg== 100230 2011-07-10 10:24:29 -0700 2011-07-10 10:25:04 -0700 Patch bug-63630-20110710193654.patch text/plain 1800 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogOTA2OTIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1ZjFmM2E1YTYxNzAxMTcwMWI0M2MyNmM0ZjA4ZTQ3NTY4 ZTM3NjBkLi44MDc4MzIzMzI2NzM4ZjMxOGM5ZjA2MDliZWM0ZjZmZDdhMjY5OTRiIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDctMTAgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisg ICAgICAgIFtRdF1bV0syXSBJbXBsZW1lbnQgdGhlIHJlc3Qgb2YgV1RSOjpQbGF0Zm9ybVdlYlZp ZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNjMw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAg ICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcDoKKyAgICAg ICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3Ojp3aW5kb3dGcmFtZSk6CisgICAgICAgIChXVFI6OlBs YXRmb3JtV2ViVmlldzo6c2V0V2luZG93RnJhbWUpOgorCiAyMDExLTA3LTEwICBNYXJrIFJvd2Ug IDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgVGVhY2ggYnVpbGQtd2Via2l0IGhvdyB0byBm aW5kIHRoZSBsYXRlc3QgV2ViS2l0U3lzdGVtSW50ZXJmYWNlIGJpbmFyeS4KZGlmZiAtLWdpdCBh L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZpZXdRdC5jcHAKaW5kZXggZjBlMmUwYTg5 MWY1YmNhM2YxNTQ3YjRkMzNlMmNiZmQ2YzNlZTBhYi4uODdmNGE3ZjgyY2VjNmZlNTM1NGExMzEx NjcyMzA4MDdkY2RlMGFlNiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9Q bGF0Zm9ybVdlYlZpZXdRdC5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0 Zm9ybVdlYlZpZXdRdC5jcHAKQEAgLTg5LDE5ICs4OSwxOCBAQCB2b2lkIFBsYXRmb3JtV2ViVmll dzo6Zm9jdXMoKQogCiBXS1JlY3QgUGxhdGZvcm1XZWJWaWV3Ojp3aW5kb3dGcmFtZSgpCiB7Ci0g ICAgLy8gSW1wbGVtZW50LgotCisgICAgUVJlY3Qgd2luZG93UmVjdCA9IG1fd2luZG93LT5nZW9t ZXRyeSgpOwogICAgIFdLUmVjdCB3a0ZyYW1lOwotICAgIHdrRnJhbWUub3JpZ2luLnggPSAwOwot ICAgIHdrRnJhbWUub3JpZ2luLnkgPSAwOwotICAgIHdrRnJhbWUuc2l6ZS53aWR0aCA9IDA7Ci0g ICAgd2tGcmFtZS5zaXplLmhlaWdodCA9IDA7CisgICAgd2tGcmFtZS5vcmlnaW4ueCA9IHdpbmRv d1JlY3QueCgpOworICAgIHdrRnJhbWUub3JpZ2luLnkgPSB3aW5kb3dSZWN0LnkoKTsKKyAgICB3 a0ZyYW1lLnNpemUud2lkdGggPSB3aW5kb3dSZWN0LnNpemUoKS53aWR0aCgpOworICAgIHdrRnJh bWUuc2l6ZS5oZWlnaHQgPSB3aW5kb3dSZWN0LnNpemUoKS5oZWlnaHQoKTsKICAgICByZXR1cm4g d2tGcmFtZTsKIH0KIAotdm9pZCBQbGF0Zm9ybVdlYlZpZXc6OnNldFdpbmRvd0ZyYW1lKFdLUmVj dCkKK3ZvaWQgUGxhdGZvcm1XZWJWaWV3OjpzZXRXaW5kb3dGcmFtZShXS1JlY3Qgd2tSZWN0KQog ewotICAgIC8vIEltcGxlbWVudC4KKyAgICBtX3dpbmRvdy0+c2V0R2VvbWV0cnkod2tSZWN0Lm9y aWdpbi54LCB3a1JlY3Qub3JpZ2luLnksIHdrUmVjdC5zaXplLndpZHRoLCB3a1JlY3Quc2l6ZS5o ZWlnaHQpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXVFIK