63628 2011-06-29 07:40:47 -0700 generate-webkitversion.pl should not "use Switch" 2011-07-18 10:15:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leandro leandro abarth ademar benjamin hausmann webkit.review.bot oldest_to_newest 429599 0 leandro 2011-06-29 07:40:47 -0700 generate-webkitversion.pl should not "use Switch" 429600 1 99089 leandro 2011-06-29 07:42:40 -0700 Created attachment 99089 Patch 429602 2 leandro 2011-06-29 07:48:04 -0700 Switch.pm isn't available in current Perl versions, so generate-webkitversions.pl fails with this error message: Can't locate Switch.pm in @INC (@INC contains: /usr/lib/perl5/site_perl /usr/share/perl5/site_perl /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5/core_perl /usr/share/perl5/core_perl .) at /home/leandro/git/webkit/Source/WebKit/scripts/generate-webkitversion.pl line 42. Since no switch statement is used, it is safe to remove it from the script. The attached patch does that. 429604 3 leandro 2011-06-29 07:50:11 -0700 CCing Simon Hausmann and Adam Barth, who recently changed this file. 429627 4 99089 abarth 2011-06-29 08:33:30 -0700 Comment on attachment 99089 Patch I wish I knew enough about Perl to review this patch. 430221 5 99089 hausmann 2011-06-30 00:32:26 -0700 Comment on attachment 99089 Patch r=me 430224 6 99089 webkit.review.bot 2011-06-30 00:42:24 -0700 Comment on attachment 99089 Patch Clearing flags on attachment: 99089 Committed r90093: <http://trac.webkit.org/changeset/90093> 430225 7 webkit.review.bot 2011-06-30 00:42:29 -0700 All reviewed patches have been landed. Closing bug. 438543 8 ademar 2011-07-18 10:15:29 -0700 Revision r90093 cherry-picked into qtwebkit-2.2 with commit 3a4bda7 <http://gitorious.org/webkit/qtwebkit/commit/3a4bda7> 99089 2011-06-29 07:42:40 -0700 2011-06-30 00:42:24 -0700 Patch bug-63628-20110629114238.patch text/plain 1168 leandro SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA5MDAxNykKKysrIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjkgIExlYW5kcm8gUGVy ZWlyYSAgPGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgZ2VuZXJhdGUtd2Via2l0dmVyc2lvbi5wbCBzaG91bGQg bm90ICJ1c2UgU3dpdGNoIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjM2MjgKKworICAgICAgICBTd2l0Y2ggZ290IGRlcHJlY2F0ZWQgb24gcmVjZW50 IFBlcmwgdmVyc2lvbnMgYW5kIHRoZSBzY3JpcHQgd2Fzbid0CisgICAgICAgIHVzaW5nIHRoZSBz d2l0Y2ggc3RhdGVtZW50LgorICAgICAgICAKKyAgICAgICAgKiBzY3JpcHRzL2dlbmVyYXRlLXdl YmtpdHZlcnNpb24ucGw6IFJlbW92ZSAidXNlIFN3aXRjaDsiIGxpbmUuCisKIDIwMTEtMDYtMDEg IEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RXJpYyBDYXJsc29uLgpJbmRleDogU291cmNlL1dlYktpdC9zY3JpcHRzL2dlbmVyYXRlLXdlYmtp dHZlcnNpb24ucGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9zY3JpcHRzL2dlbmVyYXRl LXdlYmtpdHZlcnNpb24ucGwJKHJldmlzaW9uIDkwMDE2KQorKysgU291cmNlL1dlYktpdC9zY3Jp cHRzL2dlbmVyYXRlLXdlYmtpdHZlcnNpb24ucGwJKHdvcmtpbmcgY29weSkKQEAgLTM5LDcgKzM5 LDYgQEAgdXNlIHN0cmljdDsKIHVzZSBDb25maWc7CiB1c2UgR2V0b3B0OjpMb25nOwogdXNlIEZp bGU6OlBhdGg7Ci11c2UgU3dpdGNoOwogCiBteSAkdXNhZ2UgPSAiZ2VuZXJhdGUtd2Via2l0dmVy c2lvbiAtLWNvbmZpZyBXZWJLaXQvbWFjL0NvbmZpZ3VyYXRpb25zL1ZlcnNpb24ueGNjb25maWcg LS1vdXRwdXREaXIgPG91dHB1dGRpcj4iOwogCg==