63624 2011-06-29 06:58:59 -0700 [webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output 2011-06-29 08:32:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned abarth ossy oldest_to_newest 429574 0 pnormand 2011-06-29 06:58:59 -0700 $ ps -eo pid,comm PID COMMAND 1 init 1985 dbus-daemon 2128 dbus-daemon 2733 rsyslogd 19049 dbus-daemon 19128 dbus-daemon ^ See the leading white space? For those lines the pid won't be added to the list because: >>> " 1985 dbus-daemon".split(' ', 1) ['', '1985 dbus-daemon'] So line 308 of executive.py will raise a ValueError because pid="". I'll work on a patch for this issue. 429577 1 99085 pnormand 2011-06-29 07:03:33 -0700 Created attachment 99085 proposed patch 429578 2 pnormand 2011-06-29 07:04:15 -0700 BTW this issue showed up in GTK bots but I think it's not specific to them. 429579 3 pnormand 2011-06-29 07:05:46 -0700 The test-webkipy failure: ====================================================================== FAIL: test_running_pids (webkitpy.common.system.executive_unittest.ExecutiveTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/var/lib/buildbot/build/gtk-linux-32-release/build/Tools/Scripts/webkitpy/common/system/executive_unittest.py", line 209, in test_running_pids self.assertTrue(os.getpid() in pids) AssertionError ---------------------------------------------------------------------- 429580 4 99085 mrobinson 2011-06-29 07:10:57 -0700 Comment on attachment 99085 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=99085&action=review > Tools/Scripts/webkitpy/common/system/executive.py:306 > + # in some cases the line can contain one or more in -> In 429588 5 pnormand 2011-06-29 07:19:17 -0700 Committed r90016: <http://trac.webkit.org/changeset/90016> 429624 6 99085 abarth 2011-06-29 08:32:06 -0700 Comment on attachment 99085 proposed patch Thanks! You guys are awesome. 429626 7 abarth 2011-06-29 08:32:32 -0700 *** Bug 63619 has been marked as a duplicate of this bug. *** 99085 2011-06-29 07:03:33 -0700 2011-06-29 08:32:06 -0700 proposed patch proposed-patch.patch text/plain 1868 pnormand RnJvbSBmYWRjMjYyY2U4MGY5N2RhZThjYWNmYjk3MGMxODI3MDhjNWFlMjYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDI5IEp1biAyMDExIDE2OjA1OjI2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysKIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkgfCAgICA0ICsrKy0KIDIgZmlsZXMgY2hhbmdlZCwg MTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzU4ZjU5Zi4uMTgwNTU4NSAxMDA2NDQKLS0t IGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDExLTA2LTI5ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbd2Via2l0cHld IEV4ZWN1dGl2ZS5ydW5uaW5nX3BpZHMoKSBzb21ldGltZXMgZG9lc24ndCBjb3JyZWN0bHkgcHJv Y2VzcyAicHMiIG91dHB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjM2MjQKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3Rl bS9leGVjdXRpdmUucHk6IEluIHNvbWUgY2FzZXMgdGhlCisgICAgICAgIHBzIG91dHB1dCBsaW5l cyBjYW4gY29udGFpbiBvbmUgb3IgbW9yZSBsZWFkaW5nIHdoaXRlLXNwYWNlcywgc28KKyAgICAg ICAgc3RyaXAgaXQgYmVmb3JlIHNwbGl0dGluZyB0aGUgcGlkIGFuZCBjb21tYW5kIG5hbWUuCisK IDIwMTEtMDYtMjkgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkKaW5kZXggZjViODA4OS4uMmE2ZGE0NCAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5 CkBAIC0zMDMsNyArMzAzLDkgQEAgY2xhc3MgRXhlY3V0aXZlKG9iamVjdCk6CiAgICAgICAgIHN0 ZG91dCwgXyA9IHBzX3Byb2Nlc3MuY29tbXVuaWNhdGUoKQogICAgICAgICBmb3IgbGluZSBpbiBz dGRvdXQuc3BsaXRsaW5lcygpOgogICAgICAgICAgICAgdHJ5OgotICAgICAgICAgICAgICAgIHBp ZCwgcHJvY2Vzc19uYW1lID0gbGluZS5zcGxpdCgnICcsIDEpCisgICAgICAgICAgICAgICAgIyBp biBzb21lIGNhc2VzIHRoZSBsaW5lIGNhbiBjb250YWluIG9uZSBvciBtb3JlCisgICAgICAgICAg ICAgICAgIyBsZWFkaW5nIHdoaXRlLXNwYWNlcywgc28gc3RyaXAgaXQgYmVmb3JlIHNwbGl0Lgor ICAgICAgICAgICAgICAgIHBpZCwgcHJvY2Vzc19uYW1lID0gbGluZS5zdHJpcCgpLnNwbGl0KCcg JywgMSkKICAgICAgICAgICAgICAgICBpZiBwcm9jZXNzX25hbWVfZmlsdGVyKHByb2Nlc3NfbmFt ZSk6CiAgICAgICAgICAgICAgICAgICAgIHJ1bm5pbmdfcGlkcy5hcHBlbmQoaW50KHBpZCkpCiAg ICAgICAgICAgICBleGNlcHQgVmFsdWVFcnJvciwgZToKLS0gCjEuNy41LjQ=