63613 2011-06-29 02:03:22 -0700 [Chromium] Remove WebBindings::makeNode. 2011-06-30 23:07:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon dominicc morrita tkent webkit.review.bot oldest_to_newest 429483 0 noel.gordon 2011-06-29 02:03:22 -0700 Used by Tools/DRT on the chromium port http://webkit.org/b/56573, but dead code now. 429485 1 99057 noel.gordon 2011-06-29 02:08:14 -0700 Created attachment 99057 Patch 430079 2 tkent 2011-06-29 18:35:43 -0700 Morita-san, you're the best person to review this. 430157 3 noel.gordon 2011-06-29 21:27:06 -0700 Agree, so can we? 430978 4 99057 morrita 2011-06-30 22:16:33 -0700 Comment on attachment 99057 Patch Thanks for cleanup! 430993 5 99057 webkit.review.bot 2011-06-30 23:07:11 -0700 Comment on attachment 99057 Patch Clearing flags on attachment: 99057 Committed r90206: <http://trac.webkit.org/changeset/90206> 430994 6 webkit.review.bot 2011-06-30 23:07:15 -0700 All reviewed patches have been landed. Closing bug. 99057 2011-06-29 02:08:14 -0700 2011-06-30 23:07:11 -0700 Patch make-node.git.diff text/plain 3082 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZmExMDFlMy4uZWEzNWI1NCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wNi0yOSAgTm9lbCBHb3Jk b24gIDxub2VsLmdvcmRvbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBSZW1vdmUgV2ViQmluZGluZ3M6Om1ha2VO b2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM2 MTMKKworICAgICAgICBEZWFkIGNvZGUgZWxpbWluYXRpb24uIE5vIGNoYW5nZSBpbiBiZWhhdmlv dXIsIHNvIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHB1YmxpYy9XZWJCaW5kaW5ncy5oOgor ICAgICAgICAqIHNyYy9XZWJCaW5kaW5ncy5jcHA6CisKIDIwMTEtMDYtMjggIFJ5b3N1a2UgTml3 YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUm9sbGVkIERFUFMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJCaW5kaW5ncy5oIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQmluZGluZ3MuaAppbmRleCAxNDliZmYzLi41YWE0Yzhk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJCaW5kaW5ncy5o CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkJpbmRpbmdzLmgKQEAgLTEy OCw2ICsxMjgsOCBAQCBwdWJsaWM6CiAgICAgLy8gdW5kZWZpbmVkLiAgSWYgaVN0cmluZyBpcyBm YWxzZSwgdGhlIG9wcG9zaXRlIGlzIHRydWUuCiAgICAgV0VCS0lUX0FQSSBzdGF0aWMgdm9pZCBl eHRyYWN0SWRlbnRpZmllckRhdGEoY29uc3QgTlBJZGVudGlmaWVyJiwgY29uc3QgTlBVVEY4KiYg c3RyaW5nLCBpbnQzMl90JiBudW1iZXIsIGJvb2wmIGlzU3RyaW5nKTsKIAorICAgIC8vIER1bXBS ZW5kZXJUcmVlIHN1cHBvcnQgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQorCiAgICAgLy8gUmV0dXJuIHRydWUgKHN1Y2Nlc3MpIGlmIHRoZSBnaXZlbiBu cG9iaiBpcyBhIHJhbmdlIG9iamVjdC4KICAgICAvLyBJZiBzbywgcmV0dXJuIHRoYXQgcmFuZ2Ug YXMgYSBXZWJSYW5nZSBvYmplY3QuCiAgICAgV0VCS0lUX0FQSSBzdGF0aWMgYm9vbCBnZXRSYW5n ZShOUE9iamVjdCogcmFuZ2UsIFdlYlJhbmdlKik7CkBAIC0xMzgsNyArMTQwLDYgQEAgcHVibGlj OgogCiAgICAgV0VCS0lUX0FQSSBzdGF0aWMgTlBPYmplY3QqIG1ha2VJbnRBcnJheShjb25zdCBX ZWJWZWN0b3I8aW50PiYpOwogICAgIFdFQktJVF9BUEkgc3RhdGljIE5QT2JqZWN0KiBtYWtlU3Ry aW5nQXJyYXkoY29uc3QgV2ViVmVjdG9yPFdlYlN0cmluZz4mKTsKLSAgICBXRUJLSVRfQVBJIHN0 YXRpYyBOUE9iamVjdCogbWFrZU5vZGUoY29uc3QgV2ViTm9kZSYpOwogCiAgICAgLy8gRXhjZXB0 aW9ucyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkJp bmRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkJpbmRpbmdzLmNwcApp bmRleCBjYWY4ZWVlLi40NzQ0YTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJCaW5kaW5ncy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi QmluZGluZ3MuY3BwCkBAIC00MSw3ICs0MSw2IEBACiAjaW5jbHVkZSAiVjhET01XcmFwcGVyLmgi CiAjaW5jbHVkZSAiVjhFbGVtZW50LmgiCiAjaW5jbHVkZSAiVjhOUFV0aWxzLmgiCi0jaW5jbHVk ZSAiVjhOb2RlLmgiCiAjaW5jbHVkZSAiVjhQcm94eS5oIgogI2luY2x1ZGUgIlY4UmFuZ2UuaCIK ICNlbGlmIFVTRShKU0MpCkBAIC0yNTcsMTYgKzI1Niw2IEBAIHN0YXRpYyBOUE9iamVjdCogbWFr ZVN0cmluZ0FycmF5SW1wbChjb25zdCBXZWJWZWN0b3I8V2ViU3RyaW5nPiYgZGF0YSkKICAgICBy ZXR1cm4gbnBDcmVhdGVWOFNjcmlwdE9iamVjdCgwLCByZXN1bHQsIHdpbmRvdyk7CiB9CiAKLXN0 YXRpYyBOUE9iamVjdCogbWFrZU5vZGVJbXBsKFdlYk5vZGUgZGF0YSkKLXsKLSAgICB2ODo6SGFu ZGxlU2NvcGUgaGFuZGxlU2NvcGU7Ci0gICAgaWYgKGRhdGEuaXNOdWxsKCkpCi0gICAgICAgIHJl dHVybiAwOwotICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gcmVzdWx0ID0gVjhOb2RlOjp3cmFw KGRhdGEudW53cmFwPE5vZGU+KCkpOwotICAgIFdlYkNvcmU6OkRPTVdpbmRvdyogd2luZG93ID0g V2ViQ29yZTo6VjhQcm94eTo6cmV0cmlldmVXaW5kb3coV2ViQ29yZTo6VjhQcm94eTo6Y3VycmVu dENvbnRleHQoKSk7Ci0gICAgcmV0dXJuIG5wQ3JlYXRlVjhTY3JpcHRPYmplY3QoMCwgcmVzdWx0 LCB3aW5kb3cpOwotfQotCiAjZW5kaWYKIAogYm9vbCBXZWJCaW5kaW5nczo6Z2V0UmFuZ2UoTlBP YmplY3QqIHJhbmdlLCBXZWJSYW5nZSogd2ViUmFuZ2UpCkBAIC0zMDksMTYgKzI5OCw2IEBAIE5Q T2JqZWN0KiBXZWJCaW5kaW5nczo6bWFrZVN0cmluZ0FycmF5KGNvbnN0IFdlYlZlY3RvcjxXZWJT dHJpbmc+JiBkYXRhKQogI2VuZGlmCiB9CiAKLU5QT2JqZWN0KiBXZWJCaW5kaW5nczo6bWFrZU5v ZGUoY29uc3QgV2ViTm9kZSYgZGF0YSkKLXsKLSNpZiBVU0UoVjgpCi0gICAgcmV0dXJuIG1ha2VO b2RlSW1wbChkYXRhKTsKLSNlbHNlCi0gICAgLy8gTm90IHN1cHBvcnRlZCBvbiBvdGhlciBwb3J0 cyAoSlNDLCBldGMuKS4KLSAgICByZXR1cm4gMDsKLSNlbmRpZgotfQotCiB2b2lkIFdlYkJpbmRp bmdzOjpwdXNoRXhjZXB0aW9uSGFuZGxlcihFeGNlcHRpb25IYW5kbGVyIGhhbmRsZXIsIHZvaWQq IGRhdGEpCiB7CiAgICAgV2ViQ29yZTo6cHVzaEV4Y2VwdGlvbkhhbmRsZXIoaGFuZGxlciwgZGF0 YSk7Cg==