63604 2011-06-28 21:55:04 -0700 Store shadowPseudoId in ElementRareData. 2011-06-28 23:05:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 58584 1 dglazkov dglazkov morrita tkent webkit.review.bot oldest_to_newest 429412 0 dglazkov 2011-06-28 21:55:04 -0700 Store shadowPseudoId in ElementRareData. 429413 1 99035 dglazkov 2011-06-28 21:57:19 -0700 Created attachment 99035 Patch 429417 2 99035 tkent 2011-06-28 22:02:12 -0700 Comment on attachment 99035 Patch So, you can remove WebCore/html/shadow/ElementWithPseudoId.{cpp,h} 429419 3 dglazkov 2011-06-28 22:02:54 -0700 (In reply to comment #2) > (From update of attachment 99035 [details]) > So, you can remove WebCore/html/shadow/ElementWithPseudoId.{cpp,h} Not yet -- this patch simply adds the capability. We'll remove all virtuals as follow-up. 429420 4 99035 tkent 2011-06-28 22:04:18 -0700 Comment on attachment 99035 Patch ok. 429440 5 99035 webkit.review.bot 2011-06-28 23:05:29 -0700 Comment on attachment 99035 Patch Clearing flags on attachment: 99035 Committed r89989: <http://trac.webkit.org/changeset/89989> 429441 6 webkit.review.bot 2011-06-28 23:05:33 -0700 All reviewed patches have been landed. Closing bug. 99035 2011-06-28 21:57:19 -0700 2011-06-28 23:05:29 -0700 Patch bug-63604-20110628215718.patch text/plain 4517 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODk5ODUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzZTM4ZDVmYzY0ZjA4ZjZk ZGIxNTE1NTBmMGVjMjY3NjcyOWRmMzc0Li4yYmQ5OWU5M2Q0OTU3ZGEyYmZjN2E5YjNmZTQxYWQz MzQzNmQxZTk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDYtMjggIERpbWl0 cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdG9yZSBzaGFkb3dQc2V1ZG9JZCBpbiBFbGVt ZW50UmFyZURhdGEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02MzYwNAorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVjYXVzZSB0aGUgY29kZSBpc24n dCB5ZXQgdXNlZC4KKworICAgICAgICAqIGNzcy9DU1NTZWxlY3Rvci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDU1NTZWxlY3Rvcjo6aXNVbmtub3duUHNldWRvVHlwZSk6IEFkZGVkIGNvbnZlbmll bmNlIGhlbHBlci4KKyAgICAgICAgKiBjc3MvQ1NTU2VsZWN0b3IuaDogQWRkZWQgZGVjbC4KKyAg ICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjpzaGFk b3dQc2V1ZG9JZCk6IENoYW5nZWQgdG8gdXNlIEVsZW1lbnRSYXJlRGF0YS4KKyAgICAgICAgKFdl YkNvcmU6OkVsZW1lbnQ6OnNldFNoYWRvd1BzZXVkb0lkKTogRGl0dG8uCisgICAgICAgICogZG9t L0VsZW1lbnQuaDogQWRkZWQgZGVjbHMuCisgICAgICAgICogZG9tL0VsZW1lbnRSYXJlRGF0YS5o OiBBZGRlZCBhIG1lbWJlciB0byBrZWVwIHNoYWRvd1BzZXVkb0lkLgorCiAyMDExLTA2LTI4ICBF bWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBF cmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuY3BwCmluZGV4IDRhMzI2NmYxYjk0 ZDFjMzRiOTc2NmQ2NDQ5NzllMjlmODFhYzQ5OGUuLmNkYTQwNDU1NGRiODAzMGU0NDE5ZTViODZk MDcxYTBkMzE4MzU1NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rv ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmNwcApAQCAtMzkyLDYg KzM5MiwxMSBAQCBDU1NTZWxlY3Rvcjo6UHNldWRvVHlwZSBDU1NTZWxlY3Rvcjo6cGFyc2VQc2V1 ZG9UeXBlKGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZSkKICAgICByZXR1cm4gc2xvdCA9PSBuYW1l VG9Qc2V1ZG9UeXBlLT5lbmQoKSA/IFBzZXVkb1Vua25vd24gOiBzbG90LT5zZWNvbmQ7CiB9CiAK K2Jvb2wgQ1NTU2VsZWN0b3I6OmlzVW5rbm93blBzZXVkb1R5cGUoY29uc3QgQXRvbWljU3RyaW5n JiBuYW1lKQoreworICAgIHJldHVybiBwYXJzZVBzZXVkb1R5cGUobmFtZSkgPT0gUHNldWRvVW5r bm93bjsKK30KKwogdm9pZCBDU1NTZWxlY3Rvcjo6ZXh0cmFjdFBzZXVkb1R5cGUoKSBjb25zdAog ewogICAgIGlmIChtX21hdGNoICE9IFBzZXVkb0NsYXNzICYmIG1fbWF0Y2ggIT0gUHNldWRvRWxl bWVudCAmJiBtX21hdGNoICE9IFBhZ2VQc2V1ZG9DbGFzcykKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9y LmgKaW5kZXggYWJkMTBlNDBiNjI2NzA4NzFiMTRhY2QzMTA2ZWNjZjNlMTNjOTk0My4uYzU4OWY3 NWE3NjQ1MmRjZjYwOGU4ZWJjZTA0YzU1ZTQ4OWI5NWNiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1NlbGVjdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVj dG9yLmgKQEAgLTIxMyw2ICsyMTMsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIH0K IAogICAgICAgICBzdGF0aWMgUHNldWRvVHlwZSBwYXJzZVBzZXVkb1R5cGUoY29uc3QgQXRvbWlj U3RyaW5nJik7CisgICAgICAgIHN0YXRpYyBib29sIGlzVW5rbm93blBzZXVkb1R5cGUoY29uc3Qg QXRvbWljU3RyaW5nJik7CiAgICAgICAgIHN0YXRpYyBQc2V1ZG9JZCBwc2V1ZG9JZChQc2V1ZG9U eXBlKTsKIAogICAgICAgICAvLyBTZWxlY3RvcnMgYXJlIGtlcHQgaW4gYW4gYXJyYXkgYnkgQ1NT U2VsZWN0b3JMaXN0LiBUaGUgbmV4dCBjb21wb25lbnQgb2YgdGhlIHNlbGVjdG9yIGlzIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUv ZG9tL0VsZW1lbnQuY3BwCmluZGV4IGQxOTBlNTY3MjYwYjcwODU2OTk5MjgwNDA0MmE5NzU2YTQw ZDUxMzguLjMwMjczOTFhZWQwN2IxZDI2YTdjY2VmYzlkMTYxYjA5Nzg3YjNhY2YgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vRWxlbWVudC5jcHAKQEAgLTEyMzQsNiArMTIzNCwyNCBAQCB2b2lkIEVsZW1lbnQ6OnJlbW92 ZVNoYWRvd1Jvb3QoKQogICAgIH0KIH0KIAorY29uc3QgQXRvbWljU3RyaW5nJiBFbGVtZW50Ojpz aGFkb3dQc2V1ZG9JZCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIGhhc1JhcmVEYXRhKCkgPyByYXJl RGF0YSgpLT5tX3NoYWRvd1BzZXVkb0lkIDogbnVsbEF0b207Cit9CisKK3ZvaWQgRWxlbWVudDo6 c2V0U2hhZG93UHNldWRvSWQoY29uc3QgQXRvbWljU3RyaW5nJiBpZCwgRXhjZXB0aW9uQ29kZSYg ZWMpCit7CisgICAgaWYgKCFoYXNSYXJlRGF0YSgpICYmIGlkID09IG51bGxBdG9tKQorICAgICAg ICByZXR1cm47CisKKyAgICBpZiAoIUNTU1NlbGVjdG9yOjppc1Vua25vd25Qc2V1ZG9UeXBlKGlk KSkgeworICAgICAgICBlYyA9IFNZTlRBWF9FUlI7CisgICAgICAgIHJldHVybjsKKyAgICB9CisK KyAgICBlbnN1cmVSYXJlRGF0YSgpLT5tX3NoYWRvd1BzZXVkb0lkID0gaWQ7Cit9CisKIGJvb2wg RWxlbWVudDo6Y2hpbGRUeXBlQWxsb3dlZChOb2RlVHlwZSB0eXBlKSBjb25zdAogewogICAgIHN3 aXRjaCAodHlwZSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaCBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKaW5kZXggOTBkYWQ2NDAzNDRjZjkyNTFjOTA4 NzgxMjFjZjM2NmRjMjc4ZTAxMS4uNWEwNDg2MmMzNDFmNWIzY2Q0ZDc4MTI3Yzg4YTY2NDQ1YmRl NjVlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCkBAIC0yMzUsNiArMjM1LDcgQEAgcHVibGljOgogICAg IHZvaWQgcmVtb3ZlU2hhZG93Um9vdCgpOwogCiAgICAgdmlydHVhbCBjb25zdCBBdG9taWNTdHJp bmcmIHNoYWRvd1BzZXVkb0lkKCkgY29uc3Q7CisgICAgdm9pZCBzZXRTaGFkb3dQc2V1ZG9JZChj b25zdCBBdG9taWNTdHJpbmcmLCBFeGNlcHRpb25Db2RlJik7CiAKICAgICBSZW5kZXJTdHlsZSog Y29tcHV0ZWRTdHlsZShQc2V1ZG9JZCA9IE5PUFNFVURPKTsKIApAQCAtNTQyLDExICs1NDMsNiBA QCBpbmxpbmUgdm9pZCBFbGVtZW50OjpzZXRJZEF0dHJpYnV0ZShjb25zdCBBdG9taWNTdHJpbmcm IHZhbHVlKQogICAgIHNldEF0dHJpYnV0ZShkb2N1bWVudCgpLT5pZEF0dHJpYnV0ZU5hbWUoKSwg dmFsdWUpOwogfQogCi1pbmxpbmUgY29uc3QgQXRvbWljU3RyaW5nJiBFbGVtZW50OjpzaGFkb3dQ c2V1ZG9JZCgpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIG51bGxBdG9tOwotfQotICAgIAogaW5saW5l IEVsZW1lbnQqIGZpcnN0RWxlbWVudENoaWxkKGNvbnN0IENvbnRhaW5lck5vZGUqIGNvbnRhaW5l cikKIHsKICAgICBBU1NFUlRfQVJHKGNvbnRhaW5lciwgY29udGFpbmVyKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50UmFyZURhdGEuaCBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50UmFyZURhdGEuaAppbmRleCA1YTY1ZWRiN2UxMWM3YmRhOTA1Y2FkNjZkYTY4NjY3 MjI1ZDU1MTc4Li43Mjc3YTZmM2RkYjk1M2UzNmYxYmY2N2M2MWU4ZWM3MTQyOWY1N2Y1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudFJhcmVEYXRhLmgKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnRSYXJlRGF0YS5oCkBAIC00NSw2ICs0NSw3IEBAIHB1YmxpYzoK ICAgICBJbnRTaXplIG1fbWluaW11bVNpemVGb3JSZXNpemluZzsKICAgICBSZWZQdHI8UmVuZGVy U3R5bGU+IG1fY29tcHV0ZWRTdHlsZTsKICAgICBTaGFkb3dSb290KiBtX3NoYWRvd1Jvb3Q7Cisg ICAgQXRvbWljU3RyaW5nIG1fc2hhZG93UHNldWRvSWQ7CiAKICAgICBPd25QdHI8RGF0YXNldERP TVN0cmluZ01hcD4gbV9kYXRhc2V0RE9NU3RyaW5nTWFwOwogICAgIE93blB0cjxDbGFzc0xpc3Q+ IG1fY2xhc3NMaXN0Owo=