<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>63562</bug_id>
          
          <creation_ts>2011-06-28 14:05:27 -0700</creation_ts>
          <short_desc>[Qt] Use &lt;QtX/x.h&gt; style of headers for Qt tests which rely on it.</short_desc>
          <delta_ts>2011-06-28 14:28:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P2</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexis Menard (darktears)">menard</reporter>
          <assigned_to name="Alexis Menard (darktears)">menard</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>429125</commentid>
    <comment_count>0</comment_count>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-06-28 14:05:27 -0700</bug_when>
    <thetext>[Qt] Use &lt;QtX/x.h&gt; style of headers for Qt tests which relies on it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>429129</commentid>
    <comment_count>1</comment_count>
      <attachid>98969</attachid>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-06-28 14:09:16 -0700</bug_when>
    <thetext>Created attachment 98969
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>429130</commentid>
    <comment_count>2</comment_count>
      <attachid>98969</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2011-06-28 14:11:11 -0700</bug_when>
    <thetext>Comment on attachment 98969
Patch

Did you performance test this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>429131</commentid>
    <comment_count>3</comment_count>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-06-28 14:13:27 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 98969 [details])
&gt; Did you performance test this?

10x faster at build time :D</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>429132</commentid>
    <comment_count>4</comment_count>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-06-28 14:13:56 -0700</bug_when>
    <thetext>Committed r89958: &lt;http://trac.webkit.org/changeset/89958&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>429144</commentid>
    <comment_count>5</comment_count>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-06-28 14:28:05 -0700</bug_when>
    <thetext>Revision r89958 cherry-picked into qtwebkit-2.2 with commit 46db30c &lt;http://gitorious.org/webkit/qtwebkit/commit/46db30c&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>98969</attachid>
            <date>2011-06-28 14:09:16 -0700</date>
            <delta_ts>2011-06-28 14:11:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-63562-20110628180916.patch</filename>
            <type>text/plain</type>
            <size>1970</size>
            <attacher name="Alexis Menard (darktears)">menard</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA4OTk1NikKKysrIFNvdXJjZS9XZWJLaXQvcXQv
Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjggIEFs
ZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBVc2UgPFF0WC94Lmg+IHN0
eWxlIG9mIGhlYWRlcnMgZm9yIFF0IHRlc3RzIHdoaWNoIHJlbHkgb24gaXQuCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzU2MgorCisgICAgICAgIFNv
bWUgUXQgYXV0by10ZXN0cyByZWx5IG9uIDxRdFgveC5oPiB0eXBlcyBvZiBpbmNsdWRlcy4KKwor
ICAgICAgICAqIEFwaS9xd2Via2l0cGxhdGZvcm1wbHVnaW4uaDoKKyAgICAgICAgKiBzeW1iaWFu
L3BsYXRmb3JtcGx1Z2luL3F3ZWJraXRwbGF0Zm9ybXBsdWdpbi5oOgorCiAyMDExLTA2LTI4ICBB
bGV4aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJl
dmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCkluZGV4OiBTb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Vi
a2l0cGxhdGZvcm1wbHVnaW4uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3F0L0FwaS9x
d2Via2l0cGxhdGZvcm1wbHVnaW4uaAkocmV2aXNpb24gODk5NTYpCisrKyBTb3VyY2UvV2ViS2l0
L3F0L0FwaS9xd2Via2l0cGxhdGZvcm1wbHVnaW4uaAkod29ya2luZyBjb3B5KQpAQCAtMjYsMTEg
KzI2LDExIEBACiAgKiAgYW5kIG1heSBiZSBjaGFuZ2VkIGZyb20gdmVyc2lvbiB0byB2ZXJzaW9u
IG9yIGV2ZW4gYmUgY29tcGxldGVseSByZW1vdmVkLgogKi8KIAotI2luY2x1ZGUgPFFPYmplY3Q+
Ci0jaW5jbHVkZSA8UVVybD4KICNpZiBkZWZpbmVkKFdURl9VU0VfUVRfTVVMVElNRURJQSkgJiYg
V1RGX1VTRV9RVF9NVUxUSU1FRElBCiAjaW5jbHVkZSA8UU1lZGlhUGxheWVyPgogI2VuZGlmCisj
aW5jbHVkZSA8UXRDb3JlL1FPYmplY3Q+CisjaW5jbHVkZSA8UXRDb3JlL1FVcmw+CiAjaW5jbHVk
ZSA8UXRHdWkvUUNvbG9yPgogCiBjbGFzcyBRV2ViU2VsZWN0RGF0YSB7CkluZGV4OiBTb3VyY2Uv
V2ViS2l0L3F0L3N5bWJpYW4vcGxhdGZvcm1wbHVnaW4vcXdlYmtpdHBsYXRmb3JtcGx1Z2luLmgK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9xdC9zeW1iaWFuL3BsYXRmb3JtcGx1Z2luL3F3
ZWJraXRwbGF0Zm9ybXBsdWdpbi5oCShyZXZpc2lvbiA4OTk1NikKKysrIFNvdXJjZS9XZWJLaXQv
cXQvc3ltYmlhbi9wbGF0Zm9ybXBsdWdpbi9xd2Via2l0cGxhdGZvcm1wbHVnaW4uaAkod29ya2lu
ZyBjb3B5KQpAQCAtMjYsMTIgKzI2LDEyIEBACiAgKiAgYW5kIG1heSBiZSBjaGFuZ2VkIGZyb20g
dmVyc2lvbiB0byB2ZXJzaW9uIG9yIGV2ZW4gYmUgY29tcGxldGVseSByZW1vdmVkLgogKi8KIAot
I2luY2x1ZGUgPFFDb2xvcj4KLSNpbmNsdWRlIDxRT2JqZWN0PgotI2luY2x1ZGUgPFFVcmw+CiAj
aWYgZGVmaW5lZChXVEZfVVNFX1FUX01VTFRJTUVESUEpICYmIFdURl9VU0VfUVRfTVVMVElNRURJ
QQogI2luY2x1ZGUgPFFNZWRpYVBsYXllcj4KICNlbmRpZgorI2luY2x1ZGUgPFF0Q29yZS9RT2Jq
ZWN0PgorI2luY2x1ZGUgPFF0Q29yZS9RVXJsPgorI2luY2x1ZGUgPFF0R3VpL1FDb2xvcj4KIAog
Y2xhc3MgUVdlYlNlbGVjdERhdGEgewogcHVibGljOgo=
</data>
<flag name="review"
          id="93341"
          type_id="1"
          status="+"
          setter="kling"
    />
          </attachment>
      

    </bug>

</bugzilla>