63561 2011-06-28 13:58:33 -0700 DFG JIT - don't always assume integer in relational compare 2011-06-28 14:07:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough webkit-unassigned oldest_to_newest 429118 0 barraclough 2011-06-28 13:58:33 -0700 If neither operand is known integer, or either is in double representation, then at least use a function call (don't bail off the speculative path). 429120 1 98968 barraclough 2011-06-28 13:59:35 -0700 Created attachment 98968 The patch 429126 2 barraclough 2011-06-28 14:07:06 -0700 Fixed in r89957 98968 2011-06-28 13:59:35 -0700 2011-06-28 14:02:51 -0700 The patch 63561.patch text/plain 5207 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODk5NTYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTEtMDYtMjggIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzU2MQorICAgICAgICBERkcgSklUIC0g ZG9uJ3QgYWx3YXlzIGFzc3VtZSBpbnRlZ2VyIGluIHJlbGF0aW9uYWwgY29tcGFyZQorCisgICAg ICAgIElmIG5laXRoZXIgb3BlcmFuZCBpcyBrbm93biBpbnRlZ2VyLCBvciBlaXRoZXIgaXMgaW4g ZG91YmxlIHJlcHJlc2VudGF0aW9uLAorICAgICAgICB0aGVuIGF0IGxlYXN0IHVzZSBhIGZ1bmN0 aW9uIGNhbGwgKGRvbid0IGJhaWwgb2ZmIHRoZSBzcGVjdWxhdGl2ZSBwYXRoKS4KKworICAgICAg ICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3Vs YXRpdmVKSVQ6OmNvbXBpbGVQZWVwSG9sZUNhbGwpOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1 bGF0aXZlSklUOjpjb21waWxlKToKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuaDoK KyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6aXNEYXRhRm9ybWF0RG91YmxlKToK KyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGFyZUlzSW50ZWdlcik6CisK IDIwMTEtMDYtMjggIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCShyZXZpc2lvbiA4OTk0NikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yNjcsNyArMjY3LDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZVBlZXBI b2xlSW50ZQogICAgICAgICBhZGRCcmFuY2gobV9qaXQuanVtcCgpLCBub3RUYWtlbik7CiB9CiAK LXZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVQZWVwSG9sZUVxKE5vZGUmIG5vZGUsIE5vZGVJ bmRleCBicmFuY2hOb2RlSW5kZXgpCit2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlUGVlcEhv bGVDYWxsKE5vZGUmIG5vZGUsIE5vZGVJbmRleCBicmFuY2hOb2RlSW5kZXgsIFpfREZHT3BlcmF0 aW9uX0VKSiBvcGVyYXRpb24pCiB7CiAgICAgTm9kZSYgYnJhbmNoTm9kZSA9IG1faml0LmdyYXBo KClbYnJhbmNoTm9kZUluZGV4XTsKICAgICBCbG9ja0luZGV4IHRha2VuID0gbV9qaXQuZ3JhcGgo KS5ibG9ja0luZGV4Rm9yQnl0ZWNvZGVPZmZzZXQoYnJhbmNoTm9kZS50YWtlbkJ5dGVjb2RlT2Zm c2V0KCkpOwpAQCAtMjkwLDcgKzI5MCw3IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVQ ZWVwSG9sZUVxKE4KICAgICBmbHVzaFJlZ2lzdGVycygpOwogCiAgICAgR1BSUmVzdWx0IHJlc3Vs dCh0aGlzKTsKLSAgICBjYWxsT3BlcmF0aW9uKG9wZXJhdGlvbkNvbXBhcmVFcSwgcmVzdWx0Lmdw cigpLCBvcDFHUFIsIG9wMkdQUik7CisgICAgY2FsbE9wZXJhdGlvbihvcGVyYXRpb24sIHJlc3Vs dC5ncHIoKSwgb3AxR1BSLCBvcDJHUFIpOwogICAgIGFkZEJyYW5jaChtX2ppdC5icmFuY2hUZXN0 OChjb25kaXRpb24sIHJlc3VsdC5ncHIoKSksIHRha2VuKTsKIAogICAgIC8vIENoZWNrIGZvciBm YWxsIHRocm91Z2gsIG90aGVyd2lzZSB3ZSBuZWVkIHRvIGp1bXAuCkBAIC01NjksNyArNTY5LDEw IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUoTm9kZSYgbm9kZSkKICAgICAgICAgICAg IC8vIHNvIGNhbiBiZSBubyBpbnRlcnZlbmluZyBub2RlcyB0byBhbHNvIHJlZmVyZW5jZSB0aGUg Y29tcGFyZS4gCiAgICAgICAgICAgICBBU1NFUlQobm9kZS5hZGp1c3RlZFJlZkNvdW50KCkgPT0g MSk7CiAKLSAgICAgICAgICAgIGNvbXBpbGVQZWVwSG9sZUludGVnZXJCcmFuY2gobm9kZSwgYnJh bmNoTm9kZUluZGV4LCBKSVRDb21waWxlcjo6TGVzc1RoYW4pOworICAgICAgICAgICAgaWYgKGNv bXBhcmVJc0ludGVnZXIobm9kZS5jaGlsZDEsIG5vZGUuY2hpbGQyKSkKKyAgICAgICAgICAgICAg ICBjb21waWxlUGVlcEhvbGVJbnRlZ2VyQnJhbmNoKG5vZGUsIGJyYW5jaE5vZGVJbmRleCwgSklU Q29tcGlsZXI6Okxlc3NUaGFuKTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBj b21waWxlUGVlcEhvbGVDYWxsKG5vZGUsIGJyYW5jaE5vZGVJbmRleCwgb3BlcmF0aW9uQ29tcGFy ZUxlc3MpOwogCiAgICAgICAgICAgICB1c2Uobm9kZS5jaGlsZDEpOwogICAgICAgICAgICAgdXNl KG5vZGUuY2hpbGQyKTsKQEAgLTU5OCw3ICs2MDEsMTAgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6 Y29tcGlsZShOb2RlJiBub2RlKQogICAgICAgICAgICAgLy8gc28gY2FuIGJlIG5vIGludGVydmVu aW5nIG5vZGVzIHRvIGFsc28gcmVmZXJlbmNlIHRoZSBjb21wYXJlLiAKICAgICAgICAgICAgIEFT U0VSVChub2RlLmFkanVzdGVkUmVmQ291bnQoKSA9PSAxKTsKIAotICAgICAgICAgICAgY29tcGls ZVBlZXBIb2xlSW50ZWdlckJyYW5jaChub2RlLCBicmFuY2hOb2RlSW5kZXgsIEpJVENvbXBpbGVy OjpMZXNzVGhhbk9yRXF1YWwpOworICAgICAgICAgICAgaWYgKGNvbXBhcmVJc0ludGVnZXIobm9k ZS5jaGlsZDEsIG5vZGUuY2hpbGQyKSkKKyAgICAgICAgICAgICAgICBjb21waWxlUGVlcEhvbGVJ bnRlZ2VyQnJhbmNoKG5vZGUsIGJyYW5jaE5vZGVJbmRleCwgSklUQ29tcGlsZXI6Okxlc3NUaGFu T3JFcXVhbCk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgY29tcGlsZVBlZXBI b2xlQ2FsbChub2RlLCBicmFuY2hOb2RlSW5kZXgsIG9wZXJhdGlvbkNvbXBhcmVMZXNzRXEpOwog CiAgICAgICAgICAgICB1c2Uobm9kZS5jaGlsZDEpOwogICAgICAgICAgICAgdXNlKG5vZGUuY2hp bGQyKTsKQEAgLTYyNywxMCArNjMzLDEwIEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUo Tm9kZSYgbm9kZSkKICAgICAgICAgICAgIC8vIHNvIGNhbiBiZSBubyBpbnRlcnZlbmluZyBub2Rl cyB0byBhbHNvIHJlZmVyZW5jZSB0aGUgY29tcGFyZS4gCiAgICAgICAgICAgICBBU1NFUlQobm9k ZS5hZGp1c3RlZFJlZkNvdW50KCkgPT0gMSk7CiAKLSAgICAgICAgICAgIGlmIChpc0ludGVnZXIo bm9kZS5jaGlsZDEpIHx8IGlzSW50ZWdlcihub2RlLmNoaWxkMikpCisgICAgICAgICAgICBpZiAo Y29tcGFyZUlzSW50ZWdlcihub2RlLmNoaWxkMSwgbm9kZS5jaGlsZDIpKQogICAgICAgICAgICAg ICAgIGNvbXBpbGVQZWVwSG9sZUludGVnZXJCcmFuY2gobm9kZSwgYnJhbmNoTm9kZUluZGV4LCBK SVRDb21waWxlcjo6RXF1YWwpOwogICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgIGNv bXBpbGVQZWVwSG9sZUVxKG5vZGUsIGJyYW5jaE5vZGVJbmRleCk7CisgICAgICAgICAgICAgICAg Y29tcGlsZVBlZXBIb2xlQ2FsbChub2RlLCBicmFuY2hOb2RlSW5kZXgsIG9wZXJhdGlvbkNvbXBh cmVFcSk7CiAKICAgICAgICAgICAgIHVzZShub2RlLmNoaWxkMSk7CiAgICAgICAgICAgICB1c2Uo bm9kZS5jaGlsZDIpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxh dGl2ZUpJVC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3Bl Y3VsYXRpdmVKSVQuaAkocmV2aXNpb24gODk5NTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1NwZWN1bGF0aXZlSklULmgJKHdvcmtpbmcgY29weSkKQEAgLTE2OSw4ICsxNjksMjIg QEAgcHJpdmF0ZToKICAgICAgICAgcmV0dXJuIChpbmZvLnJlZ2lzdGVyRm9ybWF0KCkgfCBEYXRh Rm9ybWF0SlMpID09IERhdGFGb3JtYXRKU0ludGVnZXI7CiAgICAgfQogCisgICAgYm9vbCBpc0Rh dGFGb3JtYXREb3VibGUoTm9kZUluZGV4IG5vZGVJbmRleCkKKyAgICB7CisgICAgICAgIE5vZGUm IG5vZGUgPSBtX2ppdC5ncmFwaCgpW25vZGVJbmRleF07CisgICAgICAgIFZpcnR1YWxSZWdpc3Rl ciB2aXJ0dWFsUmVnaXN0ZXIgPSBub2RlLnZpcnR1YWxSZWdpc3RlcigpOworICAgICAgICBHZW5l cmF0aW9uSW5mbyYgaW5mbyA9IG1fZ2VuZXJhdGlvbkluZm9bdmlydHVhbFJlZ2lzdGVyXTsKKwor ICAgICAgICByZXR1cm4gKGluZm8ucmVnaXN0ZXJGb3JtYXQoKSB8IERhdGFGb3JtYXRKUykgPT0g RGF0YUZvcm1hdEpTRG91YmxlOworICAgIH0KKworICAgIGJvb2wgY29tcGFyZUlzSW50ZWdlcihO b2RlSW5kZXggb3AxLCBOb2RlSW5kZXggb3AyKQorICAgIHsKKyAgICAgICAgcmV0dXJuICEoaXNE YXRhRm9ybWF0RG91YmxlKG9wMSkgfHwgaXNEYXRhRm9ybWF0RG91YmxlKG9wMikpICYmIChpc0lu dGVnZXIob3AxKSB8fCBpc0ludGVnZXIob3AyKSk7CisgICAgfQorCiAgICAgdm9pZCBjb21waWxl UGVlcEhvbGVJbnRlZ2VyQnJhbmNoKE5vZGUmLCBOb2RlSW5kZXggYnJhbmNoTm9kZUluZGV4LCBK SVRDb21waWxlcjo6UmVsYXRpb25hbENvbmRpdGlvbik7Ci0gICAgdm9pZCBjb21waWxlUGVlcEhv bGVFcShOb2RlJiwgTm9kZUluZGV4IGJyYW5jaE5vZGVJbmRleCk7CisgICAgdm9pZCBjb21waWxl UGVlcEhvbGVDYWxsKE5vZGUmLCBOb2RlSW5kZXggYnJhbmNoTm9kZUluZGV4LCBaX0RGR09wZXJh dGlvbl9FSkopOwogCiAgICAgLy8gQWRkIGEgc3BlY3VsYXRpb24gY2hlY2sgd2l0aG91dCBhZGRp dGlvbmFsIHJlY292ZXJ5LgogICAgIHZvaWQgc3BlY3VsYXRpb25DaGVjayhNYWNyb0Fzc2VtYmxl cjo6SnVtcCBqdW1wVG9GYWlsKQo=