63530 2011-06-28 06:26:53 -0700 Add a test for canceling selectstart when a word is selected by right click 2011-06-28 08:10:46 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.nakedvalue.com/ P2 Normal --- 60424 1 rniwa rniwa ap sam oldest_to_newest 428838 0 rniwa 2011-06-28 06:26:53 -0700 On Safari 5, you can select a word on http://www.nakedvalue.com/ by right clicking even though the page has document.body.onselectstart = function () { return false; } On ToT WebKit this bug no longer exists. We should add a test to ensure this does not regress. 428882 1 98923 rniwa 2011-06-28 08:07:05 -0700 Created attachment 98923 adds a regression test 428883 2 98923 darin 2011-06-28 08:09:13 -0700 Comment on attachment 98923 adds a regression test View in context: https://bugs.webkit.org/attachment.cgi?id=98923&action=review > LayoutTests/fast/events/selectstart-prevent-selection-on-right-click.html:17 > + document.writeln('This test requires eventSender'); A little strange to use writeln, since it just puts in a newline that will be collapsed out. 428884 3 rniwa 2011-06-28 08:09:16 -0700 Committed r89929: <http://trac.webkit.org/changeset/89929> 428888 4 rniwa 2011-06-28 08:10:46 -0700 (In reply to comment #2) > A little strange to use writeln, since it just puts in a newline that will be collapsed out. I guess I should be doing #test.textContent = x. Will fix along and add it to the skipped list of mac-wk2. 98923 2011-06-28 08:07:05 -0700 2011-06-28 08:09:13 -0700 adds a regression test bug-63530-20110628080704.patch text/plain 3085 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg5OTI4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjggIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIGEgdGVzdCBmb3IgY2FuY2VsaW5nIHNlbGVjdHN0YXJ0IHdoZW4gYSB3b3Jk IGlzIHNlbGVjdGVkIGJ5IHJpZ2h0IGNsaWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02MzUzMAorCisgICAgICAgIEFkZCBhIHJlZ3Jlc3Npb24gbm93 IHRoYXQgdGhlIGJ1ZyBubyBsb25nZXIgcmVwcm9kdWNlcy4KKworICAgICAgICAqIGZhc3QvZXZl bnRzL3NlbGVjdHN0YXJ0LXByZXZlbnQtc2VsZWN0aW9uLW9uLXJpZ2h0LWNsaWNrLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9ldmVudHMvc2VsZWN0c3RhcnQtcHJldmVudC1z ZWxlY3Rpb24tb24tcmlnaHQtY2xpY2suaHRtbDogQWRkZWQuCisKIDIwMTEtMDYtMjggIFN0ZXBo ZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdl ZC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3NlbGVjdHN0YXJ0LXByZXZlbnQtc2Vs ZWN0aW9uLW9uLXJpZ2h0LWNsaWNrLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9zZWxlY3RzdGFydC1wcmV2ZW50LXNlbGVjdGlvbi1vbi1yaWdodC1j bGljay1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy9zZWxlY3RzdGFydC1wcmV2ZW50LXNlbGVjdGlvbi1vbi1yaWdodC1jbGljay1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorRURJVElORyBERUxFR0FURTogd2ViVmll d0RpZENoYW5nZVNlbGVjdGlvbjpXZWJWaWV3RGlkQ2hhbmdlU2VsZWN0aW9uTm90aWZpY2F0aW9u CitUaGlzIHRlc3QgZW5zdXJlcyBzZWxlY3RzdGFydCBldmVudCBmaXJlcyB3aGVuIHNlbGVjdGlu ZyBhIHdvcmQgYnkgcmlnaHQgY2xpY2sgYW5kIHNjcmlwdCBjYW4gcHJldmVudCB0aGUgc2VsZWN0 aW9uIGNoYW5nZS4KKworUEFTUwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2VsZWN0 c3RhcnQtcHJldmVudC1zZWxlY3Rpb24tb24tcmlnaHQtY2xpY2suaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zZWxlY3RzdGFydC1wcmV2ZW50LXNlbGVjdGlvbi1v bi1yaWdodC1jbGljay5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVu dHMvc2VsZWN0c3RhcnQtcHJldmVudC1zZWxlY3Rpb24tb24tcmlnaHQtY2xpY2suaHRtbAkocmV2 aXNpb24gMCkKQEAgLTAsMCArMSwzOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5 PgorPHA+VGhpcyB0ZXN0IGVuc3VyZXMgc2VsZWN0c3RhcnQgZXZlbnQgZmlyZXMgd2hlbiBzZWxl Y3RpbmcgYSB3b3JkIGJ5IHJpZ2h0IGNsaWNrIGFuZCBzY3JpcHQgY2FuIHByZXZlbnQgdGhlIHNl bGVjdGlvbiBjaGFuZ2UuPC9wPgorPGRpdiBpZD0idGVzdCI+U2VsZWN0IGEgPHNwYW4gaWQ9InRh cmdldCI+d29yZDwvc3Bhbj4gaW4gdGhpcyBwYXJhZ3JhcGggYnkgYSByaWdodC1jbGljazwvZGl2 PgorPHNjcmlwdD4KKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxh eW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wRWRpdGluZ0NhbGxiYWNrcygpOworfQorCit2YXIgaGFuZGxlcldhc0NhbGxlZCA9IGZh bHNlOworZG9jdW1lbnQuYm9keS5vbnNlbGVjdHN0YXJ0ID0gZnVuY3Rpb24gKCkgeyBoYW5kbGVy V2FzQ2FsbGVkID0gdHJ1ZTsgcmV0dXJuIGZhbHNlOyB9CisKK2lmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIgJiYgIXdpbmRvdy5ldmVudFNlbmRlcikKKyAgICBkb2N1bWVudC53cml0ZWxu KCdUaGlzIHRlc3QgcmVxdWlyZXMgZXZlbnRTZW5kZXInKTsKK2Vsc2UgeworICAgIHdpbmRvdy5n ZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlvbihkb2N1bWVudC5ib2R5LCAwKTsKKyAgICB2YXIgYmFz ZU5vZGUgPSBnZXRTZWxlY3Rpb24oKS5iYXNlTm9kZTsKKyAgICB2YXIgYmFzZU9mZnNldCA9IGdl dFNlbGVjdGlvbigpLmJhc2VPZmZzZXQ7CisKKyAgICB2YXIgdGVzdCA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCd0ZXN0Jyk7CisgICAgdmFyIHRhcmdldCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCd0YXJnZXQnKTsKKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyh0YXJnZXQub2Zmc2V0 TGVmdCArIHRhcmdldC5vZmZzZXRXaWR0aCAvIDIsIHRhcmdldC5vZmZzZXRUb3AgKyB0YXJnZXQu b2Zmc2V0SGVpZ2h0IC8gMik7CisgICAgZXZlbnRTZW5kZXIuY29udGV4dENsaWNrKCk7CisKKyAg ICBpZiAoIWhhbmRsZXJXYXNDYWxsZWQpCisgICAgICAgIHRlc3QudGV4dENvbnRlbnQgPSAnRkFJ TCAtIGhhbmRsZXIgd2FzIG5ldmVyIGNhbGxlZCc7CisgICAgZWxzZSBpZiAoIWdldFNlbGVjdGlv bigpLmlzQ29sbGFwc2VkIHx8IGdldFNlbGVjdGlvbigpLmJhc2VOb2RlICE9IGJhc2VOb2RlIHx8 IGdldFNlbGVjdGlvbigpLmJhc2VPZmZzZXQgIT0gYmFzZU9mZnNldCkKKyAgICAgICAgdGVzdC50 ZXh0Q29udGVudCA9ICdGQUlMIC0gc2VsZWN0aW9uIGNoYW5nZWQnOworICAgIGVsc2UKKyAgICAg ICAgdGVzdC50ZXh0Q29udGVudCA9ICdQQVNTJzsKK30KKworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8 L2h0bWw+Cg==