63525 2011-06-28 03:01:06 -0700 [EFL] Implement EditorClientEfl::respondToChangedSelection 2011-06-28 04:38:22 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P4 Enhancement --- 0 mpakulavelrutka webkit-unassigned antognolli+webkit gyuyoung.kim kenneth leandro lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 428774 0 mpakulavelrutka 2011-06-28 03:01:06 -0700 This patch implements EditorClientEfl::respondToChangedSelection, adds ewk_frame_editor_client_selection_changed and ewk_view_editor_client_selection_changed internal functions. 428775 1 98891 mpakulavelrutka 2011-06-28 03:08:37 -0700 Created attachment 98891 proposed patch 428789 2 98891 kenneth 2011-06-28 03:57:44 -0700 Comment on attachment 98891 proposed patch This looks ok, so I am going ahead an granding an r+ 428796 3 98891 webkit.review.bot 2011-06-28 04:38:17 -0700 Comment on attachment 98891 proposed patch Clearing flags on attachment: 98891 Committed r89920: <http://trac.webkit.org/changeset/89920> 428797 4 webkit.review.bot 2011-06-28 04:38:22 -0700 All reviewed patches have been landed. Closing bug. 98891 2011-06-28 03:08:37 -0700 2011-06-28 04:38:17 -0700 proposed patch patch2.diff text/plain 4054 mpakulavelrutka ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4YjgzN2EyLi44YzEyMzAxIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTEtMDYtMjggIE1pY2hhbCBQYWt1bGEgdmVsIFJ1dGthICA8bS5w YWt1bGFAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0VGTF0gSW1wbGVtZW50IEVkaXRvckNsaWVudEVmbDo6cmVzcG9uZFRvQ2hh bmdlZFNlbGVjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjM1MjUKKworICAgICAgICBUaGlzIHBhdGNoOgorICAgICAgICAtIGltcGxlbWVudHMg RWRpdG9yQ2xpZW50RWZsOjpyZXNwb25kVG9DaGFuZ2VkU2VsZWN0aW9uLAorICAgICAgICAtIGFk ZHMgZXdrX2ZyYW1lX2VkaXRvcl9jbGllbnRfc2VsZWN0aW9uX2NoYW5nZWQgYW5kCisgICAgICAg IC0gZXdrX3ZpZXdfZWRpdG9yX2NsaWVudF9zZWxlY3Rpb25fY2hhbmdlZAorCisgICAgICAgICog V2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50RWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVk aXRvckNsaWVudEVmbDo6cmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlvbik6CisgICAgICAgICogZXdr L2V3a19mcmFtZS5jcHA6CisgICAgICAgIChld2tfZnJhbWVfZWRpdG9yX2NsaWVudF9zZWxlY3Rp b25fY2hhbmdlZCk6CisgICAgICAgICogZXdrL2V3a19wcml2YXRlLmg6CisgICAgICAgICogZXdr L2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X2VkaXRvcl9jbGllbnRfc2VsZWN0aW9u X2NoYW5nZWQpOgorCiAyMDExLTA2LTI3ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5n LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50RWZsLmNwcCBiL1Nv dXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEVmbC5jcHAKaW5kZXgg OWJkMGNiNi4uNWMxMmZlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1 cHBvcnQvRWRpdG9yQ2xpZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3Jl U3VwcG9ydC9FZGl0b3JDbGllbnRFZmwuY3BwCkBAIC0xMjcsNyArMTI3LDIzIEBAIHZvaWQgRWRp dG9yQ2xpZW50RWZsOjpyZXNwb25kVG9DaGFuZ2VkQ29udGVudHMoKQogCiB2b2lkIEVkaXRvckNs aWVudEVmbDo6cmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlvbigpCiB7Ci0gICAgbm90SW1wbGVtZW50 ZWQoKTsKKyAgICBFdmFzX09iamVjdCogZnJhbWUgPSBld2tfdmlld19mcmFtZV9mb2N1c2VkX2dl dChtX3ZpZXcpOworCisgICAgaWYgKCFmcmFtZSkKKyAgICAgICAgZnJhbWUgPSBld2tfdmlld19m cmFtZV9tYWluX2dldChtX3ZpZXcpOworCisgICAgaWYgKCFmcmFtZSkKKyAgICAgICAgcmV0dXJu OworCisgICAgV2ViQ29yZTo6RnJhbWUqIGNvcmVGcmFtZSA9IGV3a19mcmFtZV9jb3JlX2dldChm cmFtZSk7CisKKyAgICBpZiAoIWNvcmVGcmFtZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgaWYg KGNvcmVGcmFtZS0+ZWRpdG9yKCkgJiYgY29yZUZyYW1lLT5lZGl0b3IoKS0+aWdub3JlQ29tcG9z aXRpb25TZWxlY3Rpb25DaGFuZ2UoKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgZXdrX2ZyYW1l X2VkaXRvcl9jbGllbnRfc2VsZWN0aW9uX2NoYW5nZWQoZnJhbWUpOwogfQogCiB2b2lkIEVkaXRv ckNsaWVudEVmbDo6ZGlkRW5kRWRpdGluZygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX2ZyYW1lLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3Bw CmluZGV4IDFhNDE1MGMuLjM1MzhhYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfZnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3Bw CkBAIC0xOTc1LDMgKzE5NzUsMTggQEAgV1RGOjpQYXNzUmVmUHRyPFdlYkNvcmU6OldpZGdldD4g ZXdrX2ZyYW1lX3BsdWdpbl9jcmVhdGUoRXZhc19PYmplY3QqIG8sIGNvbnN0IFcKIHsKICAgICBy ZXR1cm4gMDsKIH0KKworLyoqCisgKiBAaW50ZXJuYWwKKyAqIFJlcG9ydHMgdGhhdCBlZGl0b3Ig Y2xpZW50IHNlbGVjdGlvbiB3YXMgY2hhbmdlZC4KKyAqCisgKiBAcGFyYW0gbyBGcmFtZQorICoK KyAqIEVtaXRzIHNpZ25hbDogImVkaXRvcmNsaWVudHNlbGVjdGlvbixjaGFuZ2VkIiB3aXRoIG5v IHBhcmFtZXRlcnMuCisgKi8KK3ZvaWQgZXdrX2ZyYW1lX2VkaXRvcl9jbGllbnRfc2VsZWN0aW9u X2NoYW5nZWQoRXZhc19PYmplY3QqIG8pCit7CisgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJh Y2tfY2FsbChvLCAiZWRpdG9yY2xpZW50LHNlbGVjdGlvbixjaGFuZ2VkIiwgMCk7CisgICAgRVdL X0ZSQU1FX1NEX0dFVF9PUl9SRVRVUk4obywgc2QpOworICAgIGV3a192aWV3X2VkaXRvcl9jbGll bnRfc2VsZWN0aW9uX2NoYW5nZWQoc2QtPnZpZXcpOworfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3By aXZhdGUuaAppbmRleCAxNmRmNjc2Li4xMDc2YzY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3By aXZhdGUuaApAQCAtMTExLDYgKzExMSw4IEBAIHZvaWQgZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmli dXRlc19zZXQoRXZhc19PYmplY3QgKm8sIGNvbnN0IFdlYkNvcmU6OlZpZXdwb3J0QXJnCiAKIHZv aWQgZXdrX3ZpZXdfZG93bmxvYWRfcmVxdWVzdChFdmFzX09iamVjdCAqbywgRXdrX0Rvd25sb2Fk ICpkb3dubG9hZCk7CiAKK3ZvaWQgZXdrX3ZpZXdfZWRpdG9yX2NsaWVudF9zZWxlY3Rpb25fY2hh bmdlZChFdmFzX09iamVjdCogbyk7CisKIGludCBld2tfdXRpbF9kcGlfZ2V0KHZvaWQpOwogCiAj aWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKQEAgLTE3Nyw2ICsxNzksOCBAQCBXZWJDb3JlOjpGbG9h dFJlY3QgZXdrX3ZpZXdfcGFnZV9yZWN0X2dldChFdmFzX09iamVjdCAqbyk7CiAKIGNvbnN0IGNo YXIqIGV3a19zZXR0aW5nc19kZWZhdWx0X3VzZXJfYWdlbnRfZ2V0KHZvaWQpOwogCit2b2lkIGV3 a19mcmFtZV9lZGl0b3JfY2xpZW50X3NlbGVjdGlvbl9jaGFuZ2VkKEV2YXNfT2JqZWN0KiBvKTsK KwogI2lmZGVmIF9fY3BsdXNwbHVzCiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmlu ZGV4IDNlOTA0ZGIuLjNkYWQxOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAt NDQ5OCwzICs0NDk4LDE2IEBAIEVpbmFfQm9vbCBld2tfdmlld19uZWVkX3RvdWNoX2V2ZW50c19n ZXQoRXZhc19PYmplY3QqIG8pCiAgICAgcmV0dXJuIHByaXYtPmZsYWdzLm5lZWRfdG91Y2hfZXZl bnRzOwogfQogI2VuZGlmCisKKy8qKgorICogQGludGVybmFsCisgKiBSZXBvcnRzIHRoZSB2aWV3 IHRoYXQgZWRpdG9yIGNsaWVudCBzZWxlY3Rpb24gaGFzIGNoYW5nZWQuCisgKgorICogQHBhcmFt IG8gVmlldy4KKyAqCisgKiBFbWl0cyBzaWduYWw6ICJlZGl0b3JjbGllbnRzZWxlY3Rpb24sY2hh bmdlZCIgd2l0aCBubyBwYXJhbWV0ZXJzLgorICovCit2b2lkIGV3a192aWV3X2VkaXRvcl9jbGll bnRfc2VsZWN0aW9uX2NoYW5nZWQoRXZhc19PYmplY3QqIG8pCit7CisgICAgZXZhc19vYmplY3Rf c21hcnRfY2FsbGJhY2tfY2FsbChvLCAiZWRpdG9yY2xpZW50LHNlbGVjdGlvbixjaGFuZ2VkIiwg MCk7Cit9Cg==