63520 2011-06-28 01:59:21 -0700 [X11][WK2] X error with plugin tests 2011-06-28 04:42:50 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 1 kbalazs kbalazs webkit.review.bot oldest_to_newest 428734 0 kbalazs 2011-06-28 01:59:21 -0700 plugins/destroy-stream-twice.html and plugins/npruntime/npruntime.html take out the following error: The program '<unknown>' received an X Window System error. This probably reflects a bug in the program. The error was 'BadValue (integer parameter out of range for operation)'. (Details: serial 208 error_code 2 request_code 53 minor_code 0) (Note to programmers: normally, X errors are reported asynchronously; that is, you will receive the error a while after causing it. To debug your program, run it with the --sync command line option to change this behavior. You can then get a meaningful backtrace from your debugger if you break on the gdk_x_error() function.) Both of them has an embed tag with width:0 and height:0 attributes. It came out that the X server does not accept a pixmap with (0,0) dimensions so we need to handle this as a special case. 428739 1 kbalazs 2011-06-28 02:07:23 -0700 plugins/object-embed-plugin-scripting.html is also affected. 428751 2 98886 kbalazs 2011-06-28 02:21:19 -0700 Created attachment 98886 Patch 428792 3 98886 kenneth 2011-06-28 04:00:38 -0700 Comment on attachment 98886 Patch Nice! 428800 4 98886 webkit.review.bot 2011-06-28 04:42:46 -0700 Comment on attachment 98886 Patch Clearing flags on attachment: 98886 Committed r89921: <http://trac.webkit.org/changeset/89921> 428801 5 webkit.review.bot 2011-06-28 04:42:50 -0700 All reviewed patches have been landed. Closing bug. 98886 2011-06-28 02:21:19 -0700 2011-06-28 04:42:46 -0700 Patch bug-63520-20110628092117.patch text/plain 3291 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogODk5MDAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1MTllMDJlNWY0NDNlY2Q2ZDFjMTA0 OGM1NDNhOWJhZDAwODY0OTc0Li4wYTU2YTY1N2Q2ZWVmNzc0NjAxOTY1NDE0OGZhZGM3ZWE5NmRj ZmQyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTEtMDYtMjggIEJhbGF6cyBLZWxlbWVuICA8 a2JhbGF6c0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtYMTFdW1dLMl0gWCBlcnJvciB3aXRoIHBsdWdpbiB0ZXN0cworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM1MjAKKworICAgICAg ICAqIHBsYXRmb3JtL3F0LXdrMi9Ta2lwcGVkOgorCisyMDExLTA2LTI4ICBCYWxhenMgS2VsZW1l biAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0 cm9nb27DoWMuCiAKICAgICAgICAgV2ViS2l0VGVzdFJ1bm5lciBuZWVkcyBsYXlvdXRUZXN0Q29u dHJvbGxlci5zZXRDYWxsQ2xvc2VPbldlYlZpZXdzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9xdC13azIvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LXdrMi9Ta2lw cGVkCmluZGV4IDc4YzAyMTE4NTgyNDllYjQwZTllMmVmMzMxMmJiNDVhMDdhNGQzNDkuLjBmNTQy NjNkYjkxZmNmOWU5ZDA2MjM1M2I2ZjUxMDRlMTZiNDA4MTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3BsYXRmb3JtL3F0LXdrMi9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0 LXdrMi9Ta2lwcGVkCkBAIC0xNDk3LDkgKzE0OTcsNiBAQCBwbHVnaW5zL25ldHNjYXBlLWRvbS1h Y2Nlc3MuaHRtbAogcGx1Z2lucy9ucHAtc2V0LXdpbmRvdy1jYWxsZWQtZHVyaW5nLWRlc3RydWN0 aW9uLmh0bWwKIHBsdWdpbnMvcGx1Z2luLWphdmFzY3JpcHQtYWNjZXNzLmh0bWwKIHBsdWdpbnMv cmVsb2FkcGx1Z2lucy1hbmQtcGFnZXMuaHRtbAotcGx1Z2lucy9kZXN0cm95LXN0cmVhbS10d2lj ZS5odG1sCi1wbHVnaW5zL29iamVjdC1lbWJlZC1wbHVnaW4tc2NyaXB0aW5nLmh0bWwKLXBsdWdp bnMvbnBydW50aW1lL25wcnVudGltZS5odG1sCiAKICMgVW5leHBsYWluZWQgZmFpbHVyZXMKIGZh c3QvZG9tL2JlZm9yZWxvYWQvcmVtb3ZlLWZyYW1lLWluLWJlZm9yZWxvYWQtbGlzdGVuZXIuaHRt bApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCmluZGV4IGE2MTUzNjc5NzIyOGNmOTkwYzUwZGYzOGViYWE1NjMyNmQ3MTIwOTIu LjI5YTlmYWJjYTY3MGM0NzM3MGVkMDNjMjllYWMyYzE0Y2MwOTAwNGMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wNi0yOCAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W1gxMV1bV0syXSBYIGVycm9yIHdpdGggcGx1Z2luIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzUyMAorCisgICAgICAgICogV2ViUHJvY2Vz cy9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpblgxMS5jcHA6CisgICAgICAgIE5l dmVyIGNyZWF0ZSBhIHBpeG1hcCB3aXRoICgwLDApIGRpbWVuc2lvbnMuCisgICAgICAgIChXZWJL aXQ6Ok5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9ybUdlb21ldHJ5RGlkQ2hhbmdlKToKKyAgICAgICAg KFdlYktpdDo6TmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtUGFpbnQpOgorCiAyMDExLTA2LTI3ICBZ dXRhIEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luWDExLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQbHVnaW5YMTEu Y3BwCmluZGV4IDVmZGY3ODJkODQxNzg4MjFkNDNkNDZmYmVjNjdlYzJiMzU3OGYxM2QuLjNhMDEx MWE2YmIxNGNhYWY4MmExNzlkNmRlYjlmNjU5NTM2MjI1ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQbHVnaW5YMTEu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS94MTEv TmV0c2NhcGVQbHVnaW5YMTEuY3BwCkBAIC0yMDksNiArMjA5LDExIEBAIHZvaWQgTmV0c2NhcGVQ bHVnaW46OnBsYXRmb3JtR2VvbWV0cnlEaWRDaGFuZ2UoKQogICAgIGlmIChtX2RyYXdhYmxlKQog ICAgICAgICBYRnJlZVBpeG1hcChkaXNwbGF5LCBtX2RyYXdhYmxlKTsKIAorICAgIGlmIChtX2Zy YW1lUmVjdC5pc0VtcHR5KCkpIHsKKyAgICAgICAgbV9kcmF3YWJsZSA9IDA7CisgICAgICAgIHJl dHVybjsKKyAgICB9CisKICAgICBtX2RyYXdhYmxlID0gWENyZWF0ZVBpeG1hcChkaXNwbGF5LCBy b290V2luZG93SUQoKSwgbV9mcmFtZVJlY3Qud2lkdGgoKSwgbV9mcmFtZVJlY3QuaGVpZ2h0KCks IGRpc3BsYXlEZXB0aCgpKTsKIAogICAgIFhTeW5jKGRpc3BsYXksIGZhbHNlKTsgLy8gTWFrZSBz dXJlIHRoYXQgdGhlIHNlcnZlciBrbm93cyBhYm91dCB0aGUgRHJhd2FibGUuCkBAIC0yMzEsMTEg KzIzNiw5IEBAIHZvaWQgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtUGFpbnQoR3JhcGhpY3NDb250 ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiBkaXJ0CiAgICAgICAgIHJldHVybjsKICAgICB9 CiAKLSAgICBpZiAoY29udGV4dC0+cGFpbnRpbmdEaXNhYmxlZCgpKQorICAgIGlmIChjb250ZXh0 LT5wYWludGluZ0Rpc2FibGVkKCkgfHwgIW1fZHJhd2FibGUpCiAgICAgICAgIHJldHVybjsKIAot ICAgIEFTU0VSVChtX2RyYXdhYmxlKTsKLQogI2lmIFBMQVRGT1JNKFFUKQogICAgIFFQYWludGVy KiBwYWludGVyID0gY29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCk7CiAgICAgcGFpbnRlci0+dHJh bnNsYXRlKG1fZnJhbWVSZWN0LngoKSwgbV9mcmFtZVJlY3QueSgpKTsK