63515 2011-06-28 00:03:35 -0700 AtomicString::show() and WTFString::show() should be const. 2011-06-28 01:54:16 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Minor --- 0 shinyak webkit-unassigned tkent webkit.review.bot oldest_to_newest 428670 0 shinyak 2011-06-28 00:03:35 -0700 AtomicString::show() and WTFString::show are not const, so we have to use const_cast to call them occasionally. These methods should be const. 428673 1 98870 shinyak 2011-06-28 00:11:35 -0700 Created attachment 98870 Patch 428675 2 tkent 2011-06-28 00:14:58 -0700 (In reply to comment #0) > AtomicString::show() and WTFString::show are not const, so we have to use const_cast to call them occasionally. So you should remove such const_casts in this patch. Otherwise, the patch has no benefit. 428684 3 shinyak 2011-06-28 00:37:43 -0700 Since this is a debug feature, there is no code to call show() in Sources (maybe). However, when doing something like printf-debug, the lack of const is painful. This bug is related to https://bugs.webkit.org/show_bug.cgi?id=61149 428687 4 tkent 2011-06-28 00:40:20 -0700 (In reply to comment #3) > Since this is a debug feature, there is no code to call show() in Sources (maybe). However, when doing something like printf-debug, the lack of const is painful. Ok, I understand. Please note such reasons to ChangeLog. 428692 5 98875 shinyak 2011-06-28 00:48:31 -0700 Created attachment 98875 Patch 428693 6 98875 tkent 2011-06-28 00:50:10 -0700 Comment on attachment 98875 Patch ok. 428729 7 98875 webkit.review.bot 2011-06-28 01:54:11 -0700 Comment on attachment 98875 Patch Clearing flags on attachment: 98875 Committed r89906: <http://trac.webkit.org/changeset/89906> 428730 8 webkit.review.bot 2011-06-28 01:54:16 -0700 All reviewed patches have been landed. Closing bug. 98870 2011-06-28 00:11:35 -0700 2011-06-28 00:48:23 -0700 Patch bug-63515-20110628161133.patch text/plain 2868 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogODk4ODUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDY0 MDg3OWU0YWFjNjliZDAyMmViNjI5ZTQyN2U5YjM4YzQxMDBhNjMuLjZhZjg1OWM2NjBmMmI2MTM0 ZWRiNzVkYzcxNGRlODAwNWVhYTJkZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE3IEBACisyMDExLTA2LTI3ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRk IGNvbnN0IHRvIHNob3coKSBtZXRob2QgaW4gV1RGU3RyaW5nIGFuZCBBdG9taWNTdHJpbmcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzUxNQorCisg ICAgICAgICogd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcDoKKyAgICAgICAgKFdURjo6QXRvbWlj U3RyaW5nOjpzaG93KToKKyAgICAgICAgKiB3dGYvdGV4dC9BdG9taWNTdHJpbmcuaDoKKyAgICAg ICAgKiB3dGYvdGV4dC9XVEZTdHJpbmcuY3BwOgorICAgICAgICAoU3RyaW5nOjpzaG93KToKKyAg ICAgICAgKiB3dGYvdGV4dC9XVEZTdHJpbmcuaDoKKwogMjAxMS0wNi0yNyAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVu LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L0F0b21pY1N0cmlu Zy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcApp bmRleCA3ZWU1MzI2ZDdiODAyNGZjMzI5MjZlYjFmYWZlYzM0NjhkODljOWE1Li5jYmI4ZTljYjQz MGYxZGNlMTQ2ZTUxMDBlYmE2MmVmYjc1MmUwNzA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcApAQCAtMzY2LDcgKzM2Niw3IEBAIEF0b21p Y1N0cmluZyBBdG9taWNTdHJpbmc6OmZyb21VVEY4SW50ZXJuYWwoY29uc3QgY2hhciogY2hhcmFj dGVyc1N0YXJ0LCBjb25zdCBjCiB9CiAKICNpZm5kZWYgTkRFQlVHCi12b2lkIEF0b21pY1N0cmlu Zzo6c2hvdygpCit2b2lkIEF0b21pY1N0cmluZzo6c2hvdygpIGNvbnN0CiB7CiAgICAgbV9zdHJp bmcuc2hvdygpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0 L0F0b21pY1N0cmluZy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L0F0b21pY1N0 cmluZy5oCmluZGV4IDRlZDYxOWExYWVkZGExOGMxNWUzYTc0YTJhZGQxZTAwOWRlOTA5Y2IuLjY2 Mjc4NmVkMTEyNGFhOWUwZTk2MDVmNzdlMjBmNjRmNDEwNmUwNzYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9BdG9taWNTdHJpbmcuaAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL3RleHQvQXRvbWljU3RyaW5nLmgKQEAgLTExNCw3ICsxMTQsNyBAQCBw dWJsaWM6CiAgICAgc3RhdGljIEF0b21pY1N0cmluZyBmcm9tVVRGOChjb25zdCBjaGFyKik7CiAK ICNpZm5kZWYgTkRFQlVHCi0gICAgdm9pZCBzaG93KCk7CisgICAgdm9pZCBzaG93KCkgY29uc3Q7 CiAjZW5kaWYKIHByaXZhdGU6CiAgICAgU3RyaW5nIG1fc3RyaW5nOwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL3RleHQvV1RGU3RyaW5nLmNwcAppbmRleCA0MzM1Y2VkZmRlZGY2ZDdkYmEx NmQ5MmJiZGQ0YzM5ZjlhZGQxZThmLi4yY2U5YWExYjg2ZWY5MjE5YmY4NTJjZDlmOGViMWI0Yjhl NTY3NWEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RGU3Ry aW5nLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RGU3RyaW5nLmNw cApAQCAtOTY0LDcgKzk2NCw3IEBAIFN0cmluZyogc3RyaW5nKGNvbnN0IGNoYXIqKTsKIFZlY3Rv cjxjaGFyPiBhc2NpaURlYnVnKFN0cmluZ0ltcGwqIGltcGwpOwogVmVjdG9yPGNoYXI+IGFzY2lp RGVidWcoU3RyaW5nJiBzdHJpbmcpOwogCi12b2lkIFN0cmluZzo6c2hvdygpCit2b2lkIFN0cmlu Zzo6c2hvdygpIGNvbnN0CiB7CiAgICAgZnByaW50ZihzdGRlcnIsICIlc1xuIiwgYXNjaWlEZWJ1 ZyhpbXBsKCkpLmRhdGEoKSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL3RleHQvV1RGU3RyaW5nLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RG U3RyaW5nLmgKaW5kZXggY2U5MjM0YWQ3ODlhYzk3YjM1NTEwYWVkYzI1M2NjZWI3NzQzZWJjMS4u YTc5MGVmMzM0ODMzNmIwNzM1ZTY0MzYyYWE0MzMxZTRlN2E0NDEyYSAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5oCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS93dGYvdGV4dC9XVEZTdHJpbmcuaApAQCAtMzQ4LDcgKzM0OCw3IEBAIHB1Ymxp YzoKICAgICBXVEZfRVhQT1JUX1BSSVZBVEUgYm9vbCBpc0hhc2hUYWJsZURlbGV0ZWRWYWx1ZSgp IGNvbnN0IHsgcmV0dXJuIG1faW1wbC5pc0hhc2hUYWJsZURlbGV0ZWRWYWx1ZSgpOyB9CiAKICNp Zm5kZWYgTkRFQlVHCi0gICAgdm9pZCBzaG93KCk7CisgICAgdm9pZCBzaG93KCkgY29uc3Q7CiAj ZW5kaWYKIAogcHJpdmF0ZToK 98875 2011-06-28 00:48:31 -0700 2011-06-28 01:54:11 -0700 Patch bug-63515-20110628164829.patch text/plain 2974 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogODk4ODUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDY0 MDg3OWU0YWFjNjliZDAyMmViNjI5ZTQyN2U5YjM4YzQxMDBhNjMuLjE3YjllOWI3N2UyMDYwZGE1 M2RjOGUzZDE4Y2E3MzQyZjcwMTgxMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIwIEBACisyMDExLTA2LTI3ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRk IGNvbnN0IHRvIHNob3coKSBtZXRob2QgaW4gV1RGU3RyaW5nIGFuZCBBdG9taWNTdHJpbmcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzUxNQorCisg ICAgICAgIFRoZSBsYWNrIG9mIGNvbnN0IGluIHNob3coKSBtZXRob2QgaXMgcGFpbmZ1bCB3aGVu CisgICAgICAgIGRvaW5nIHNvbWV0aGluZyBsaWtlIHByaW50Zi1kZWJ1Zy4KKworICAgICAgICAq IHd0Zi90ZXh0L0F0b21pY1N0cmluZy5jcHA6CisgICAgICAgIChXVEY6OkF0b21pY1N0cmluZzo6 c2hvdyk6CisgICAgICAgICogd3RmL3RleHQvQXRvbWljU3RyaW5nLmg6CisgICAgICAgICogd3Rm L3RleHQvV1RGU3RyaW5nLmNwcDoKKyAgICAgICAgKFN0cmluZzo6c2hvdyk6CisgICAgICAgICog d3RmL3RleHQvV1RGU3RyaW5nLmg6CisKIDIwMTEtMDYtMjcgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5jcHAKaW5kZXggN2Vl NTMyNmQ3YjgwMjRmYzMyOTI2ZWIxZmFmZWMzNDY4ZDg5YzlhNS4uY2JiOGU5Y2I0MzBmMWRjZTE0 NmU1MTAwZWJhNjJlZmI3NTJlMDcwNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi90ZXh0L0F0b21pY1N0cmluZy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0 Zi90ZXh0L0F0b21pY1N0cmluZy5jcHAKQEAgLTM2Niw3ICszNjYsNyBAQCBBdG9taWNTdHJpbmcg QXRvbWljU3RyaW5nOjpmcm9tVVRGOEludGVybmFsKGNvbnN0IGNoYXIqIGNoYXJhY3RlcnNTdGFy dCwgY29uc3QgYwogfQogCiAjaWZuZGVmIE5ERUJVRwotdm9pZCBBdG9taWNTdHJpbmc6OnNob3co KQordm9pZCBBdG9taWNTdHJpbmc6OnNob3coKSBjb25zdAogewogICAgIG1fc3RyaW5nLnNob3co KTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9BdG9taWNT dHJpbmcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9BdG9taWNTdHJpbmcuaApp bmRleCA0ZWQ2MTlhMWFlZGRhMThjMTVlM2E3NGEyYWRkMWUwMDlkZTkwOWNiLi42NjI3ODZlZDEx MjRhYTllMGU5NjA1Zjc3ZTIwZjY0ZjQxMDZlMDc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL3RleHQvQXRvbWljU3RyaW5nLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5oCkBAIC0xMTQsNyArMTE0LDcgQEAgcHVibGljOgog ICAgIHN0YXRpYyBBdG9taWNTdHJpbmcgZnJvbVVURjgoY29uc3QgY2hhciopOwogCiAjaWZuZGVm IE5ERUJVRwotICAgIHZvaWQgc2hvdygpOworICAgIHZvaWQgc2hvdygpIGNvbnN0OwogI2VuZGlm CiBwcml2YXRlOgogICAgIFN0cmluZyBtX3N0cmluZzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS93dGYvdGV4dC9XVEZTdHJpbmcuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi90ZXh0L1dURlN0cmluZy5jcHAKaW5kZXggNDMzNWNlZGZkZWRmNmQ3ZGJhMTZkOTJiYmRk NGMzOWY5YWRkMWU4Zi4uMmNlOWFhMWI4NmVmOTIxOWJmODUyY2Q5ZjhlYjFiNGI4ZTU2NzVhMCAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5jcHAKQEAgLTk2 NCw3ICs5NjQsNyBAQCBTdHJpbmcqIHN0cmluZyhjb25zdCBjaGFyKik7CiBWZWN0b3I8Y2hhcj4g YXNjaWlEZWJ1ZyhTdHJpbmdJbXBsKiBpbXBsKTsKIFZlY3RvcjxjaGFyPiBhc2NpaURlYnVnKFN0 cmluZyYgc3RyaW5nKTsKIAotdm9pZCBTdHJpbmc6OnNob3coKQordm9pZCBTdHJpbmc6OnNob3co KSBjb25zdAogewogICAgIGZwcmludGYoc3RkZXJyLCAiJXNcbiIsIGFzY2lpRGVidWcoaW1wbCgp KS5kYXRhKCkpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0 L1dURlN0cmluZy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5o CmluZGV4IGNlOTIzNGFkNzg5YWM5N2IzNTUxMGFlZGMyNTNjY2ViNzc0M2ViYzEuLmE3OTBlZjMz NDgzMzZiMDczNWU2NDM2MmFhNDMzMWU0ZTdhNDQxMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS93dGYvdGV4dC9XVEZTdHJpbmcuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd3RmL3RleHQvV1RGU3RyaW5nLmgKQEAgLTM0OCw3ICszNDgsNyBAQCBwdWJsaWM6CiAgICAg V1RGX0VYUE9SVF9QUklWQVRFIGJvb2wgaXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKSBjb25zdCB7 IHJldHVybiBtX2ltcGwuaXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKTsgfQogCiAjaWZuZGVmIE5E RUJVRwotICAgIHZvaWQgc2hvdygpOworICAgIHZvaWQgc2hvdygpIGNvbnN0OwogI2VuZGlmCiAK IHByaXZhdGU6Cg==