63514 2011-06-28 00:02:44 -0700 Fix filesystem_unittest.FileSystemTest test_read_and_write_file() 2011-06-28 11:29:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 61772 63419 63528 1 rolandsteiner rolandsteiner dominicc dpranke tony webkit.review.bot oldest_to_newest 428668 0 rolandsteiner 2011-06-28 00:02:44 -0700 test_read_and_write_file in the FileSystemTest unit test has 3 bugs: .) any raised exception from assertEquals is swallowed by the 'except' clause .) text/binary_path is not 'None' after mktemp, but os.remove may still raise an exception if no data was actually written to the file .) write_text_file is used instead of write_binary_file to write binary contents (this again was swallowed by 'except') 428671 1 98868 rolandsteiner 2011-06-28 00:06:32 -0700 Created attachment 98868 Patch 429027 2 98868 webkit.review.bot 2011-06-28 11:29:30 -0700 Comment on attachment 98868 Patch Clearing flags on attachment: 98868 Committed r89944: <http://trac.webkit.org/changeset/89944> 429028 3 webkit.review.bot 2011-06-28 11:29:34 -0700 All reviewed patches have been landed. Closing bug. 98868 2011-06-28 00:06:32 -0700 2011-06-28 11:29:30 -0700 Patch bug-63514-20110628160631.patch text/plain 1918 rolandsteiner U3VidmVyc2lvbiBSZXZpc2lvbjogODk4ODcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwYTI2MTg0YWRkMDkwZGMwOTcwYWVjYzEzZDQwNjliODI5 ODM1MTgzLi4wMTE0Y2NiM2I2NmY3Y2I2Y2VjOWZmOTRhMDE4ODgwYTZmMmRmNjY2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDYtMjggIFJvbGFuZCBTdGVpbmVyICA8cm9sYW5kc3RlaW5lckBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IGZpbGVzeXN0ZW1fdW5pdHRlc3QuRmlsZVN5c3RlbVRlc3QgdGVzdF9yZWFkX2FuZF93cml0ZV9m aWxlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYz NTE0CisKKyAgICAgICAgLSBjaGFuZ2Ugd3JpdGVfdGV4dF9maWxlIHRvIHdyaXRlX2JpbmFyeV9m aWxlCisgICAgICAgIC0gY2hlY2sgdGhhdCB0ZXh0X3BhdGggYW5kIGJpbmFyeV9wYXRoIGFyZSBh Y3R1YWxseSBleGlzdGFudCBmaWxlcworICAgICAgICAtIGNoYW5nZSBjbGVhbnVwIGJsb2NrIGZy b20gJ2V4Y2VwdCcgdG8gJ2ZpbmFsbHknCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9zeXN0ZW0vZmlsZXN5c3RlbV91bml0dGVzdC5weToKKwogMjAxMS0wNi0yNyAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2Vp ZGVsLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2Zp bGVzeXN0ZW1fdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0 ZW0vZmlsZXN5c3RlbV91bml0dGVzdC5weQppbmRleCA4ZDRmMGNiNjM4YmRkZDQxYThlZGZlYzk5 ZThmZDc4MDFmOGJjMDM1Li5lNjEzMjYyMTA5ZTUzZDk4NzM2MGNmMjk1MjU1NjliMDkxMzI5ZjBi IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5 c3RlbV91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0 ZW0vZmlsZXN5c3RlbV91bml0dGVzdC5weQpAQCAtMTU2LDEzICsxNTYsMTMgQEAgY2xhc3MgRmls ZVN5c3RlbVRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAgICAgY29udGVudHMgPSBm cy5yZWFkX2JpbmFyeV9maWxlKHRleHRfcGF0aCkKICAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwoY29udGVudHMsIGhleF9lcXVpdmFsZW50KQogCi0gICAgICAgICAgICBmcy53cml0ZV90ZXh0 X2ZpbGUoYmluYXJ5X3BhdGgsIGhleF9lcXVpdmFsZW50KQorICAgICAgICAgICAgZnMud3JpdGVf YmluYXJ5X2ZpbGUoYmluYXJ5X3BhdGgsIGhleF9lcXVpdmFsZW50KQogICAgICAgICAgICAgdGV4 dF9jb250ZW50cyA9IGZzLnJlYWRfdGV4dF9maWxlKGJpbmFyeV9wYXRoKQogICAgICAgICAgICAg c2VsZi5hc3NlcnRFcXVhbCh0ZXh0X2NvbnRlbnRzLCB1bmljb2RlX3RleHRfc3RyaW5nKQotICAg ICAgICBleGNlcHQ6Ci0gICAgICAgICAgICBpZiB0ZXh0X3BhdGg6CisgICAgICAgIGZpbmFsbHk6 CisgICAgICAgICAgICBpZiB0ZXh0X3BhdGggYW5kIGZzLmlzZmlsZSh0ZXh0X3BhdGgpOgogICAg ICAgICAgICAgICAgIG9zLnJlbW92ZSh0ZXh0X3BhdGgpCi0gICAgICAgICAgICBpZiBiaW5hcnlf cGF0aDoKKyAgICAgICAgICAgIGlmIGJpbmFyeV9wYXRoIGFuZCBmcy5pc2ZpbGUoYmluYXJ5X3Bh dGgpOgogICAgICAgICAgICAgICAgIG9zLnJlbW92ZShiaW5hcnlfcGF0aCkKIAogICAgIGRlZiB0 ZXN0X3JlYWRfYmluYXJ5X2ZpbGVfX21pc3Npbmcoc2VsZik6Cg==