63507 2011-06-27 20:34:16 -0700 webarchive/loading/missing-data.html is failing on Mac 2011-08-03 14:53:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa andersca andersca aroben darin sam zimmermann oldest_to_newest 428583 0 rniwa 2011-06-27 20:34:16 -0700 webarchive/loading/missing-data.html has been failing since http://trac.webkit.org/log/trunk?action=stop_on_copy&mode=stop_on_copy&rev=89742&stop_rev=89736&limit=100&verbose=on according to http://build.webkit.org/TestFailures/#/Leopard Intel Release (Tests) 428584 1 rniwa 2011-06-27 20:34:41 -0700 The test was added by http://trac.webkit.org/changeset/66562. 428585 2 rniwa 2011-06-27 20:37:10 -0700 Looking at SnowLeopard Intel Leak's failures, it seems like this test was affected by other tests being added to the skipped list: http://trac.webkit.org/log/trunk?action=stop_on_copy&mode=stop_on_copy&rev=89736&stop_rev=89733&limit=100&verbose=on 431342 3 aroben 2011-07-01 12:28:03 -0700 So what's the right thing to do here? I guess we could try skipping this test, too. 431343 4 aroben 2011-07-01 12:29:22 -0700 Looks like it's only intermittently failing on Leopard: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90229%20(33702)/results.html failed http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90228%20(33701)/results.html passed http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90226%20(33700)/results.html failed 431347 5 aroben 2011-07-01 12:30:48 -0700 (In reply to comment #4) > Looks like it's only intermittently failing on Leopard: > > http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90229%20(33702)/results.html failed > http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90228%20(33701)/results.html passed > http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90226%20(33700)/results.html failed Oh, I'm wrong. Build 33701 didn't complete, but presumably the test would have failed. (I need to teach TestFailures not to get confused by that.) 446101 6 102832 andersca 2011-08-03 14:49:07 -0700 Created attachment 102832 Patch 446103 7 102832 abarth 2011-08-03 14:50:50 -0700 Comment on attachment 102832 Patch Sorry for breaking this. Moving web archives into documentloader makes infinitely more sense than dealing with them in FrameLoader. 446107 8 andersca 2011-08-03 14:53:21 -0700 Committed r92314: <http://trac.webkit.org/changeset/92314> 102832 2011-08-03 14:49:07 -0700 2011-08-03 14:50:50 -0700 Patch bug-63507-20110803144906.patch text/plain 1591 andersca SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMzEyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMDMgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICB3ZWJhcmNoaXZlL2xvYWRp bmcvbWlzc2luZy1kYXRhLmh0bWwgaXMgZmFpbGluZyBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNTA3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBsb2FkaW5nIGEgbWFpbiByZXNvdXJj ZSBmcm9tIGEgd2ViIGFyY2hpdmUsIG1ha2Ugc3VyZSB0aGF0IHRoZSB3b3JraW5nIFVSTCBpcyBh Y3R1YWxseQorICAgICAgICB0aGUgVVJMIG9mIHRoZSByZXNvdXJjZSwgYW5kIG5vdCB0aGUgVVJM IG9mIHRoZSB3ZWIgYXJjaGl2ZSBpdHNlbGYuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2Fk ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnJlY2VpdmVkRmlyc3REYXRh KToKKwogMjAxMS0wOC0wMyAgSmVmZiBNaWxsZXIgIDxqZWZmbUBhcHBsZS5jb20+CiAKICAgICAg ICAgRml4IENocm9taW11bSBhbmQgUXQgYnVpbGRzIGFmdGVyIHI5MjMwOC4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gOTIyODcpCisrKyBTb3VyY2Uv V2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NjgsNyAr NTY4LDEwIEBAIHZvaWQgRnJhbWVMb2FkZXI6OnJlY2VpdmVkRmlyc3REYXRhKCkKIHsKICAgICBL VVJMIHdvcmtpbmdVUkwgPSBhY3RpdmVEb2N1bWVudExvYWRlcigpLT5kb2N1bWVudFVSTCgpOwog I2lmIEVOQUJMRShXRUJfQVJDSElWRSkgfHwgRU5BQkxFKE1IVE1MKQotICAgIGlmIChtX2FyY2hp dmUpCisgICAgLy8gRklYTUU6IFRoZSBkb2N1bWVudCBsb2FkZXIsIG5vdCB0aGUgZnJhbWUgbG9h ZGVyLCBzaG91bGQgYmUgaW4gY2hhcmdlIG9mIGxvYWRpbmcgd2ViIGFyY2hpdmVzLgorICAgIC8v IE9uY2UgdGhpcyBpcyBkb25lLCB3ZSBjYW4ganVzdCBtYWtlIERvY3VtZW50TG9hZGVyOjpkb2N1 bWVudFVSTCgpIHJldHVybiB0aGUgcmlnaHQgVVJMCisgICAgLy8gYmFzZWQgb24gd2hldGhlciBp dCBoYXMgYSBub24tbnVsbCBhcmNoaXZlIG9yIG5vdC4KKyAgICBpZiAobV9hcmNoaXZlICYmIGFj dGl2ZURvY3VtZW50TG9hZGVyKCktPnBhcnNlZEFyY2hpdmVEYXRhKCkpCiAgICAgICAgIHdvcmtp bmdVUkwgPSBtX2FyY2hpdmUtPm1haW5SZXNvdXJjZSgpLT51cmwoKTsKICNlbmRpZgogCg==