63496 2011-06-27 17:16:46 -0700 [Qt] DRT support for setInteractiveFormValidationEnabled 2011-06-29 05:32:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 1 diegohcg diegohcg ossy tonikitoo oldest_to_newest 428462 0 diegohcg 2011-06-27 17:16:46 -0700 Make possible to enable setInteractiveFormValidationEnabled on Qt DRT Unskipped: fast/forms/interactive-validation-prevented.html fast/forms/interactive-validation-attach-assertion.html fast/forms/interactive-validation-assertion-by-validate-twice.html fast/forms/interactive-validation-select-crash.html fast/forms/interactive-validation-crash-by-style-override.html 428467 1 98821 diegohcg 2011-06-27 17:20:46 -0700 Created attachment 98821 Patch 428725 2 98821 kenneth 2011-06-28 01:43:54 -0700 Comment on attachment 98821 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98821&action=review > Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:1012 > +void DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled(QWebPage* page, bool flag) flag is a pretty bad name for a bool. what about 'bool enable' 429538 3 diegohcg 2011-06-29 05:32:29 -0700 commited at r89972 98821 2011-06-27 17:20:46 -0700 2011-06-28 01:43:54 -0700 Patch 0001-Qt-DRT-support-for-setInteractiveFormValidationEnabl.patch text/plain 6383 diegohcg RnJvbSAxMjY2OWY0MmM0MzFjNTlmYzFmNjdjMDcwMDU3MjIzZDNjMGJmMTZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBHb256YWxleiA8ZGllZ29oY2dAd2Via2l0Lm9yZz4K RGF0ZTogTW9uLCAyNyBKdW4gMjAxMSAyMDoxNjoyMiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR dF0gRFJUIHN1cHBvcnQgZm9yIHNldEludGVyYWN0aXZlRm9ybVZhbGlkYXRpb25FbmFibGVkCiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM0OTYKClJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgoKU291cmNlL1dlYktpdC9xdDoKClVuc2tpcHBlZDoKICAgIGZhc3Qv Zm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1wcmV2ZW50ZWQuaHRtbAogICAgZmFzdC9mb3Jt cy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWF0dGFjaC1hc3NlcnRpb24uaHRtbAogICAgZmFzdC9m b3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWFzc2VydGlvbi1ieS12YWxpZGF0ZS10d2ljZS5o dG1sCiAgICBmYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24tc2VsZWN0LWNyYXNoLmh0 bWwKICAgIGZhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1jcmFzaC1ieS1zdHlsZS1v dmVycmlkZS5odG1sCgoqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNw cDoKKER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpzZXRJbnRlcmFjdGl2ZUZvcm1WYWxpZGF0aW9u RW5hYmxlZCk6CiogV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaDoKClRv b2xzOgoKKiBEdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcDoKKFdlYkNvcmU6 OkR1bXBSZW5kZXJUcmVlOjpEdW1wUmVuZGVyVHJlZSk6CgpMYXlvdXRUZXN0czoKCiogcGxhdGZv cm0vcXQvU2tpcHBlZDoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgIDkgKysrKysrKysrCiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9T a2lwcGVkICAgICAgICAgICAgICAgICAgICB8ICAgIDYgLS0tLS0tCiBTb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTggKysrKysrKysrKysrKysr KysrCiAuLi4vcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwICB8 ICAgIDcgKysrKysrKwogLi4uL3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9y dFF0LmggICAgfCAgICAyICsrCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTAgKysrKysrKysrKwogVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQv RHVtcFJlbmRlclRyZWVRdC5jcHAgICAgICAgfCAgICAxICsKIDcgZmlsZXMgY2hhbmdlZCwgNDcg aW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNmVmNTBhOS4uYWM5MjUyMiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTA2LTI3ICBEaWVnbyBHb256YWxleiAgPGRpZWdv aGNnQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBEUlQgc3VwcG9ydCBmb3Igc2V0SW50ZXJhY3RpdmVGb3JtVmFsaWRhdGlv bkVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTYzNDk2CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDExLTA2LTI3ICBM ZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4IGJkNjIwNDUuLjViMTVm NjEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApAQCAtMjAwNSwxMiArMjAwNSw2IEBAIGh0dHAv dGVzdHMvbWlzYy93ZWJ0aW1pbmctc2xvdy1sb2FkLnBocAogaHR0cC90ZXN0cy9zZWN1cml0eS80 MDEtbG9nb3V0LzQwMS1sb2dvdXQucGhwCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3JlbWVt YmVyLWJhZC1wYXNzd29yZC5odG1sCiAKLSMgTmVlZCB0byBjYWxsIFNldHRpbmdzOjpzZXRJbnRl cmFjdGl2ZUZvcm1WYWxpZGF0aW9uRW5hYmxlZCh0cnVlKS4KLWZhc3QvZm9ybXMvaW50ZXJhY3Rp dmUtdmFsaWRhdGlvbi1wcmV2ZW50ZWQuaHRtbAotZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxp ZGF0aW9uLWF0dGFjaC1hc3NlcnRpb24uaHRtbAotZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxp ZGF0aW9uLWFzc2VydGlvbi1ieS12YWxpZGF0ZS10d2ljZS5odG1sCi1mYXN0L2Zvcm1zL2ludGVy YWN0aXZlLXZhbGlkYXRpb24tc2VsZWN0LWNyYXNoLmh0bWwKLWZhc3QvZm9ybXMvaW50ZXJhY3Rp dmUtdmFsaWRhdGlvbi1jcmFzaC1ieS1zdHlsZS1vdmVycmlkZS5odG1sCiAjIE5lZWQgdG8gY2Fs bCBTZXR0aW5nczo6c2V0VmFsaWRhdGlvbk1lc3NhZ2VUaW1lck1hZ25pZmljYXRpb24oLTEpIGlu IERSVC4KIGZhc3QvZm9ybXMvdmFsaWRhdGlvbi1tZXNzYWdlLWFwcGVhcmFuY2UuaHRtbAogZmFz dC9mb3Jtcy92YWxpZGF0aW9uLW1lc3NhZ2Utb24tY2hlY2tib3guaHRtbApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwpp bmRleCA0ZTM0ZmYwLi5kZDY2NGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisy MDExLTA2LTI3ICBEaWVnbyBHb256YWxleiAgPGRpZWdvaGNnQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBEUlQgc3VwcG9y dCBmb3Igc2V0SW50ZXJhY3RpdmVGb3JtVmFsaWRhdGlvbkVuYWJsZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNDk2CisKKyAgICAgICAgVW5za2lw cGVkOgorICAgICAgICAgICAgZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLXByZXZl bnRlZC5odG1sCisgICAgICAgICAgICBmYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24t YXR0YWNoLWFzc2VydGlvbi5odG1sCisgICAgICAgICAgICBmYXN0L2Zvcm1zL2ludGVyYWN0aXZl LXZhbGlkYXRpb24tYXNzZXJ0aW9uLWJ5LXZhbGlkYXRlLXR3aWNlLmh0bWwKKyAgICAgICAgICAg IGZhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1zZWxlY3QtY3Jhc2guaHRtbAorICAg ICAgICAgICAgZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWNyYXNoLWJ5LXN0eWxl LW92ZXJyaWRlLmh0bWwKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVl U3VwcG9ydFF0LmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpzZXRJbnRl cmFjdGl2ZUZvcm1WYWxpZGF0aW9uRW5hYmxlZCk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQv RHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaDoKKwogMjAxMS0wNi0yNyAgQWxleGlzIE1lbmFyZCAg PGFsZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJp biBBZGxlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVt cFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9y dC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAKaW5kZXggMWRjYmE1NC4uODY2YTViMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1 cHBvcnRRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVu ZGVyVHJlZVN1cHBvcnRRdC5jcHAKQEAgLTEwMDksNiArMTAwOSwxMyBAQCB2b2lkIER1bXBSZW5k ZXJUcmVlU3VwcG9ydFF0OjphZGRVUkxUb1JlZGlyZWN0KGNvbnN0IFFTdHJpbmcmIG9yaWdpbiwg Y29uc3QgUVN0cgogICAgIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OlVSTHNUb1JlZGlyZWN0W29yaWdp bl0gPSBkZXN0aW5hdGlvbjsKIH0KIAordm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6c2V0 SW50ZXJhY3RpdmVGb3JtVmFsaWRhdGlvbkVuYWJsZWQoUVdlYlBhZ2UqIHBhZ2UsIGJvb2wgZmxh ZykKK3sKKyAgICBQYWdlKiBjb3JlUGFnZSA9IFFXZWJQYWdlUHJpdmF0ZTo6Y29yZShwYWdlKTsK KyAgICBpZiAoY29yZVBhZ2UpCisgICAgICAgIGNvcmVQYWdlLT5zZXR0aW5ncygpLT5zZXRJbnRl cmFjdGl2ZUZvcm1WYWxpZGF0aW9uRW5hYmxlZChmbGFnKTsKK30KKwogc3RhdGljIFFTdHJpbmdM aXN0IGl0ZXJhdGVDb250ZXh0TWVudShRTWVudSogbWVudSkKIHsKICAgICBpZiAoIW1lbnUpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVl U3VwcG9ydFF0LmggYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJU cmVlU3VwcG9ydFF0LmgKaW5kZXggODk0YWRiMC4uYTU5YmQ2ZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5oCisrKyBi L1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQu aApAQCAtMjEyLDYgKzIxMiw4IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUVN0cmluZyBsYXllclRy ZWVBc1RleHQoUVdlYkZyYW1lKik7CiAKICAgICBzdGF0aWMgdm9pZCBpbmplY3RJbnRlcm5hbHNP YmplY3QoUVdlYkZyYW1lKik7CisKKyAgICBzdGF0aWMgdm9pZCBzZXRJbnRlcmFjdGl2ZUZvcm1W YWxpZGF0aW9uRW5hYmxlZChRV2ViUGFnZSosIGJvb2wpOwogfTsKIAogI2VuZGlmCmRpZmYgLS1n aXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDJkYTI1Yi4uODBh YzNmOCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDExLTA2LTI3ICBEaWVnbyBHb256YWxleiAgPGRpZWdvaGNnQHdl YmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBEUlQgc3VwcG9ydCBmb3Igc2V0SW50ZXJhY3RpdmVGb3JtVmFsaWRhdGlvbkVuYWJs ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNDk2 CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkR1bXBSZW5kZXJUcmVlOjpEdW1wUmVuZGVyVHJlZSk6CisKIDIwMTEt MDYtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEaXJrIFByYW5rZS4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1 bXBSZW5kZXJUcmVlUXQuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRy ZWVRdC5jcHAKaW5kZXggMWNlZTNjNi4uMjM0NjQxMyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRy ZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKQEAgLTQ2Niw2ICs0NjYsNyBAQCBEdW1wUmVuZGVy VHJlZTo6RHVtcFJlbmRlclRyZWUoKQogICAgIFFPYmplY3Q6OmNvbm5lY3QodGhpcywgU0lHTkFM KHF1aXQoKSksIHFBcHAsIFNMT1QocXVpdCgpKSwgUXQ6OlF1ZXVlZENvbm5lY3Rpb24pOwogCiAg ICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OnNldER1bXBSZW5kZXJUcmVlTW9kZUVuYWJsZWQo dHJ1ZSk7CisgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OnNldEludGVyYWN0aXZlRm9ybVZh bGlkYXRpb25FbmFibGVkKHdlYlBhZ2UoKSwgdHJ1ZSk7CiAgICAgUUZvY3VzRXZlbnQgZXZlbnQo UUV2ZW50OjpGb2N1c0luLCBRdDo6QWN0aXZlV2luZG93Rm9jdXNSZWFzb24pOwogICAgIFFBcHBs aWNhdGlvbjo6c2VuZEV2ZW50KG1fbWFpblZpZXcsICZldmVudCk7CiB9Ci0tIAoxLjcuNC4xCgo=